)]}'
{"playbooks/defaults/distro_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"65f7daadb25a2943f499d1f6118509ec1193cbcc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"blazar_install_method: distro"},{"line_number":25,"context_line":"ceilometer_install_method: distro"},{"line_number":26,"context_line":"cinder_install_method: distro"},{"line_number":27,"context_line":"cinder_bin: /usr/bin"},{"line_number":28,"context_line":"cloudkitty_install_method: distro"},{"line_number":29,"context_line":"congress_install_method: distro"},{"line_number":30,"context_line":"designate_install_method: distro"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_a2ca0e43","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":20},"updated":"2018-07-17 15:20:42.000000000","message":"do we really need this? Isn\u0027t that handled by the roles? Could you add a comment with the reason why it\u0027s needed?","commit_id":"78bc78344ba39cc8d22377340aed984a6f65acca"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"8c38c539a71496bd63ae8a7abdae98bf189b1131","unresolved":false,"context_lines":[{"line_number":24,"context_line":"blazar_install_method: distro"},{"line_number":25,"context_line":"ceilometer_install_method: distro"},{"line_number":26,"context_line":"cinder_install_method: distro"},{"line_number":27,"context_line":"cinder_bin: /usr/bin"},{"line_number":28,"context_line":"cloudkitty_install_method: distro"},{"line_number":29,"context_line":"congress_install_method: distro"},{"line_number":30,"context_line":"designate_install_method: distro"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_6d406733","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":20},"in_reply_to":"5f7c97a3_a2ca0e43","updated":"2018-07-17 15:32:19.000000000","message":"some playbooks in this repo are making use of $service_bin variables (most notably keystone_bin and nova_bin) so I decided to add all of them here just to be safe.","commit_id":"78bc78344ba39cc8d22377340aed984a6f65acca"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"23a95f5d385df4ceb2e7a6a829b4db4b7d982c3e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# some playbooks in this repository are explicitly using them to perform"},{"line_number":23,"context_line":"# post deployment actions such as the playbooks/os-{cinder,keystone,nova}-install.yml"},{"line_number":24,"context_line":"# playbooks."},{"line_number":25,"context_line":"# "},{"line_number":26,"context_line":"almanach_install_method: distro"},{"line_number":27,"context_line":"aodh_install_method: distro"},{"line_number":28,"context_line":"barbican_install_method: distro"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f7c97a3_60a7c00a","line":25,"range":{"start_line":25,"start_character":1,"end_line":25,"end_character":2},"updated":"2018-07-20 07:13:24.000000000","message":"nit: whitespace.","commit_id":"d17e4c15bb4eae2d42588eeec5119ba376381174"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"23a95f5d385df4ceb2e7a6a829b4db4b7d982c3e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"zun_install_method: distro"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# default variables for PIP since we are not using the repo server"},{"line_number":71,"context_line":"pip_upstream_url: \"https://bootstrap.pypa.io/3.2/get-pip.py\""},{"line_number":72,"context_line":"pip_default_index: \"https://pypi.python.org/simple\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"tempest_venv_download: false"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f7c97a3_40ac04ed","line":71,"range":{"start_line":71,"start_character":45,"end_line":71,"end_character":48},"updated":"2018-07-20 07:13:24.000000000","message":"probably worth setting to 3.3","commit_id":"d17e4c15bb4eae2d42588eeec5119ba376381174"}],"playbooks/defaults/source_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"65f7daadb25a2943f499d1f6118509ec1193cbcc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# locations for fetching the default files from the git source"},{"line_number":43,"context_line":"tacker_git_config_lookup_location: \"{{ openstack_repo_url }}/openstackgit/tacker\""},{"line_number":44,"context_line":"# locations for fetching the default files from the git source"},{"line_number":45,"context_line":"keystone_git_config_lookup_location: \"{{openstack_repo_url }}/openstackgit/keystone\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_e2fd666d","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":41},"updated":"2018-07-17 15:20:42.000000000","message":"I know it was already like that, but you could add a space, it wouldn\u0027t hurt visually : p","commit_id":"78bc78344ba39cc8d22377340aed984a6f65acca"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"6e13879ce7629e1e01a4b8e3ad69caae364ac4c2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# locations for fetching the default files from the git source"},{"line_number":43,"context_line":"tacker_git_config_lookup_location: \"{{ openstack_repo_url }}/openstackgit/tacker\""},{"line_number":44,"context_line":"# locations for fetching the default files from the git source"},{"line_number":45,"context_line":"keystone_git_config_lookup_location: \"{{openstack_repo_url }}/openstackgit/keystone\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_289d7dba","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":41},"in_reply_to":"5f7c97a3_2d782f8d","updated":"2018-07-17 16:13:36.000000000","message":"haha it\u0027s not important. It\u0027s just if you are changing this patch, and adding some comments/change the code, it would be nice if you could do this.","commit_id":"78bc78344ba39cc8d22377340aed984a6f65acca"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"8c38c539a71496bd63ae8a7abdae98bf189b1131","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# locations for fetching the default files from the git source"},{"line_number":43,"context_line":"tacker_git_config_lookup_location: \"{{ openstack_repo_url }}/openstackgit/tacker\""},{"line_number":44,"context_line":"# locations for fetching the default files from the git source"},{"line_number":45,"context_line":"keystone_git_config_lookup_location: \"{{openstack_repo_url }}/openstackgit/keystone\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_2d782f8d","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":41},"in_reply_to":"5f7c97a3_e2fd666d","updated":"2018-07-17 15:32:19.000000000","message":"yep will do","commit_id":"78bc78344ba39cc8d22377340aed984a6f65acca"}],"scripts/gate-check-commit.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"96df0666ee2d9b5c01009380008c44dadc3dc531","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # Prepare the infrastructure"},{"line_number":197,"context_line":"    export ANSIBLE_LOG_PATH\u003d\"${ANSIBLE_LOG_DIR}/setup-infrastructure.log\""},{"line_number":198,"context_line":"    openstack-ansible setup-infrastructure.yml -e osa_gather_facts\u003dFalse ${INSTALL_METHOD_VARS}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # Log some data about the instance and the rest of the system"},{"line_number":201,"context_line":"    log_instance_info"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    # Setup OpenStack"},{"line_number":204,"context_line":"    export ANSIBLE_LOG_PATH\u003d\"${ANSIBLE_LOG_DIR}/setup-openstack.log\""},{"line_number":205,"context_line":"    openstack-ansible setup-openstack.yml -e osa_gather_facts\u003dFalse ${INSTALL_METHOD_VARS}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    # Log some data about the instance and the rest of the system"},{"line_number":208,"context_line":"    log_instance_info"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_33b2db4b","line":205,"range":{"start_line":198,"start_character":0,"end_line":205,"end_character":90},"updated":"2018-07-04 12:22:51.000000000","message":"I\u0027d rather see no change there, and implement a scenario that sets the var install_method to distro if necessary.","commit_id":"331504f5a4339357a30b9591c733253654fdb221"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"047f1ccae095ebe29657b58af916ca1d5aa31495","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # Prepare the infrastructure"},{"line_number":197,"context_line":"    export ANSIBLE_LOG_PATH\u003d\"${ANSIBLE_LOG_DIR}/setup-infrastructure.log\""},{"line_number":198,"context_line":"    openstack-ansible setup-infrastructure.yml -e osa_gather_facts\u003dFalse ${INSTALL_METHOD_VARS}"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # Log some data about the instance and the rest of the system"},{"line_number":201,"context_line":"    log_instance_info"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    # Setup OpenStack"},{"line_number":204,"context_line":"    export ANSIBLE_LOG_PATH\u003d\"${ANSIBLE_LOG_DIR}/setup-openstack.log\""},{"line_number":205,"context_line":"    openstack-ansible setup-openstack.yml -e osa_gather_facts\u003dFalse ${INSTALL_METHOD_VARS}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    # Log some data about the instance and the rest of the system"},{"line_number":208,"context_line":"    log_instance_info"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_33709b09","line":205,"range":{"start_line":198,"start_character":0,"end_line":205,"end_character":90},"in_reply_to":"5f7c97a3_33b2db4b","updated":"2018-07-04 12:45:02.000000000","message":"and how would you suggest to do that?","commit_id":"331504f5a4339357a30b9591c733253654fdb221"}]}