)]}'
{"inventory/env.d/neutron.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a0e6a9785cd6462aa167326b427dfe4a32e1097d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    belongs_to:"},{"line_number":79,"context_line":"      - network_containers"},{"line_number":80,"context_line":"    contains:"},{"line_number":81,"context_line":"      - neutron_ovn_northd  "},{"line_number":82,"context_line":"  neutron_server_container:"},{"line_number":83,"context_line":"    belongs_to:"},{"line_number":84,"context_line":"      - network_containers"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_43d05bf8","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":28},"updated":"2018-08-06 12:27:58.000000000","message":"please remove the trailing whitespace here.","commit_id":"a22b30f5403d40f76ab566a79180dd8029fbdb7b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a0e6a9785cd6462aa167326b427dfe4a32e1097d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      - neutron_all"},{"line_number":41,"context_line":"  neutron_metadata_agent:"},{"line_number":42,"context_line":"    belongs_to:"},{"line_number":43,"context_line":"      - neutron_all"},{"line_number":44,"context_line":"  neutron_ovn_controller:"},{"line_number":45,"context_line":"    belongs_to:"},{"line_number":46,"context_line":"      - neutron_all"},{"line_number":47,"context_line":"  neutron_ovn_northd:"},{"line_number":48,"context_line":"    belongs_to:"},{"line_number":49,"context_line":"      - neutron_all"},{"line_number":50,"context_line":"  neutron_sriov_nic_agent:"},{"line_number":51,"context_line":"    belongs_to:"},{"line_number":52,"context_line":"      - neutron_all"},{"line_number":53,"context_line":"  neutron_server:"},{"line_number":54,"context_line":"    belongs_to:"},{"line_number":55,"context_line":"      - neutron_all"},{"line_number":56,"context_line":"  opendaylight:"},{"line_number":57,"context_line":"    belongs_to:"},{"line_number":58,"context_line":"      - neutron_all"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"container_skel:"},{"line_number":61,"context_line":"  neutron_agents_container:"},{"line_number":62,"context_line":"    belongs_to:"},{"line_number":63,"context_line":"      - network_containers"},{"line_number":64,"context_line":"    contains:"},{"line_number":65,"context_line":"      - neutron_agent"},{"line_number":66,"context_line":"      - neutron_bgp_dragent"},{"line_number":67,"context_line":"      - neutron_dhcp_agent"},{"line_number":68,"context_line":"      - neutron_l3_agent"},{"line_number":69,"context_line":"      - neutron_lbaas_agent"},{"line_number":70,"context_line":"      - neutron_linuxbridge_agent"},{"line_number":71,"context_line":"      - neutron_metadata_agent"},{"line_number":72,"context_line":"      - neutron_metering_agent"},{"line_number":73,"context_line":"      - neutron_openvswitch_agent"},{"line_number":74,"context_line":"      - neutron_sriov_nic_agent"},{"line_number":75,"context_line":"    properties:"},{"line_number":76,"context_line":"      is_metal: true"},{"line_number":77,"context_line":"  neutron_ovn_northd_container:"},{"line_number":78,"context_line":"    belongs_to:"},{"line_number":79,"context_line":"      - network_containers"},{"line_number":80,"context_line":"    contains:"},{"line_number":81,"context_line":"      - neutron_ovn_northd  "},{"line_number":82,"context_line":"  neutron_server_container:"},{"line_number":83,"context_line":"    belongs_to:"},{"line_number":84,"context_line":"      - network_containers"},{"line_number":85,"context_line":"    contains:"},{"line_number":86,"context_line":"      - neutron_server"},{"line_number":87,"context_line":"      - opendaylight"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_c3ef8b85","line":84,"range":{"start_line":43,"start_character":0,"end_line":84,"end_character":23},"updated":"2018-08-06 12:27:58.000000000","message":"nit: you don\u0027t really need to set those if you provide the change in the inventory.ini, but that suppose deployers will know how to add containers in their inventory in a static way.","commit_id":"a22b30f5403d40f76ab566a79180dd8029fbdb7b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8684bce27c79ed1e518f36c7475d9308a7c6b88d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    belongs_to:"},{"line_number":79,"context_line":"      - network_containers"},{"line_number":80,"context_line":"    contains:"},{"line_number":81,"context_line":"      - neutron_ovn_northd  "},{"line_number":82,"context_line":"  neutron_server_container:"},{"line_number":83,"context_line":"    belongs_to:"},{"line_number":84,"context_line":"      - network_containers"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_48ed488c","line":81,"updated":"2018-10-01 12:41:23.000000000","message":"Remove the trailing whitespace.","commit_id":"5b8f54e0abcee0bacd0795788c9da7fab20f40f4"}],"inventory/group_vars/haproxy/haproxy.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a0e6a9785cd6462aa167326b427dfe4a32e1097d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"      haproxy_timeout_client: 90m"},{"line_number":369,"context_line":"      haproxy_timeout_server: 90m"},{"line_number":370,"context_line":"      haproxy_backend_options:"},{"line_number":371,"context_line":"        - tcpka"},{"line_number":372,"context_line":"      haproxy_service_enabled: \"{{ groups[\u0027neutron_ovn_northd\u0027] is defined and groups[\u0027neutron_ovn_northd\u0027] | length \u003e 0 }}\""},{"line_number":373,"context_line":"  - service:"},{"line_number":374,"context_line":"      haproxy_service_name: neutron_ovn_northd_southbound"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_8382f3c7","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":15},"updated":"2018-08-06 12:27:58.000000000","message":"could you explain why the tcp keepalives are needed, in the commit message, or as a comment here?\n\nIt would help us understand, further in the future if some configuration changes, if client or server keepalives are important.\n\nCan you explain also why is there no healthcheck, at least tcp?","commit_id":"a22b30f5403d40f76ab566a79180dd8029fbdb7b"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"631de8cabff84090b763228f850679822d1401ec","unresolved":false,"context_lines":[{"line_number":368,"context_line":"      haproxy_timeout_client: 90m"},{"line_number":369,"context_line":"      haproxy_timeout_server: 90m"},{"line_number":370,"context_line":"      haproxy_backend_options:"},{"line_number":371,"context_line":"        - tcpka"},{"line_number":372,"context_line":"      haproxy_service_enabled: \"{{ groups[\u0027neutron_ovn_northd\u0027] is defined and groups[\u0027neutron_ovn_northd\u0027] | length \u003e 0 }}\""},{"line_number":373,"context_line":"  - service:"},{"line_number":374,"context_line":"      haproxy_service_name: neutron_ovn_northd_southbound"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_529edf54","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":15},"in_reply_to":"3f79a3b5_0a3b41eb","updated":"2018-08-17 14:48:06.000000000","message":"my bad it should be good then.","commit_id":"a22b30f5403d40f76ab566a79180dd8029fbdb7b"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"a9ff07336483b958fe358386c636d24f4eced568","unresolved":false,"context_lines":[{"line_number":368,"context_line":"      haproxy_timeout_client: 90m"},{"line_number":369,"context_line":"      haproxy_timeout_server: 90m"},{"line_number":370,"context_line":"      haproxy_backend_options:"},{"line_number":371,"context_line":"        - tcpka"},{"line_number":372,"context_line":"      haproxy_service_enabled: \"{{ groups[\u0027neutron_ovn_northd\u0027] is defined and groups[\u0027neutron_ovn_northd\u0027] | length \u003e 0 }}\""},{"line_number":373,"context_line":"  - service:"},{"line_number":374,"context_line":"      haproxy_service_name: neutron_ovn_northd_southbound"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0a3b41eb","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":15},"in_reply_to":"3f79a3b5_8382f3c7","updated":"2018-08-07 11:25:21.000000000","message":"TCP keepalives were needed to keep neutron-server and the metadata agent from constantly reconnecting in an idle environment. Disconnects/reconnects were occurring roughly every 50 seconds.\n\nAs for the healthcheck, I was under the impression the default tcp check was in place. Resulting config has \u0027check port 6641 inter 12000\u0027. Is \u0027tcp-check\u0027 not implied?","commit_id":"a22b30f5403d40f76ab566a79180dd8029fbdb7b"}]}