)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1a42499336b4e759c4e58f0f5a547099c8552267","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Thode \u003cmthode@mthode.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-22 10:42:07 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" bind mount glance cache directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" By default glance has ~10GB available to cache images on within it\u0027s"},{"line_number":10,"context_line":" container.  Some images exceed that size causing image uploads to fail."},{"line_number":11,"context_line":" To work around this we can mount the image cache directory on the host."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This has the same danger as bind mounting the image directory (filling"},{"line_number":14,"context_line":"up the host disk), so it\u0027s not a new danger, just one to be called out."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_5cb5c67c","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":72},"updated":"2018-08-27 21:16:17.000000000","message":"Is there a reason for the space prefix? It\u0027s a little weird. :p","commit_id":"0e19ec16e75842db982a5f240f8026c359a7db40"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"13e6faa12a2f314c9d9f42f2e090e52e6182521e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Thode \u003cmthode@mthode.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-22 10:42:07 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" bind mount glance cache directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" By default glance has ~10GB available to cache images on within it\u0027s"},{"line_number":10,"context_line":" container.  Some images exceed that size causing image uploads to fail."},{"line_number":11,"context_line":" To work around this we can mount the image cache directory on the host."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This has the same danger as bind mounting the image directory (filling"},{"line_number":14,"context_line":"up the host disk), so it\u0027s not a new danger, just one to be called out."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_e54756a2","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":72},"in_reply_to":"3f79a3b5_5cb5c67c","updated":"2018-08-27 22:59:52.000000000","message":"Nope, I think I copypasta\u0027d wrong","commit_id":"0e19ec16e75842db982a5f240f8026c359a7db40"}],"inventory/group_vars/glance_all.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1a42499336b4e759c4e58f0f5a547099c8552267","unresolved":false,"context_lines":[{"line_number":33,"context_line":"glance_container_bind_mounts:"},{"line_number":34,"context_line":"  - bind_dir_path: \"/var/lib/glance/images\""},{"line_number":35,"context_line":"    mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":36,"context_line":"  - bind_dir_path: \"/var/lib/glance/cache\""},{"line_number":37,"context_line":"    mount_path: \"/openstack/{{ inventory_hostname }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_9c64be23","line":36,"updated":"2018-08-27 21:16:17.000000000","message":"Given that this is changing a default behaviour, and will force the restart of the container, a release note describing the change for upgrades would be a good thing to add.","commit_id":"0e19ec16e75842db982a5f240f8026c359a7db40"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"13e6faa12a2f314c9d9f42f2e090e52e6182521e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"glance_container_bind_mounts:"},{"line_number":34,"context_line":"  - bind_dir_path: \"/var/lib/glance/images\""},{"line_number":35,"context_line":"    mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":36,"context_line":"  - bind_dir_path: \"/var/lib/glance/cache\""},{"line_number":37,"context_line":"    mount_path: \"/openstack/{{ inventory_hostname }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_65b82674","line":36,"in_reply_to":"3f79a3b5_9c64be23","updated":"2018-08-27 22:59:52.000000000","message":"Sure, going to put it in feature for now.","commit_id":"0e19ec16e75842db982a5f240f8026c359a7db40"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b4536a7941a758df66424b5e4cf4e5e116ee17f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  - bind_dir_path: \"/var/lib/glance/images\""},{"line_number":35,"context_line":"    mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":36,"context_line":"  - bind_dir_path: \"/var/lib/glance/cache\""},{"line_number":37,"context_line":"    mount_path: \"/openstack/{{ inventory_hostname }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_68579d02","line":37,"range":{"start_line":37,"start_character":17,"end_line":37,"end_character":52},"updated":"2018-08-27 23:15:37.000000000","message":"Can they share the same space without any collision concerns?","commit_id":"a06c45cc2fa5abf03de64daad9f6dd580fbaead5"}],"releasenotes/notes/glance-cache-4d5f8036c5e8f5b1.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b4536a7941a758df66424b5e4cf4e5e116ee17f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Glance containers will now bind mount the default glance cache directory"},{"line_number":5,"context_line":"    from the host when glance_default_store is set to file.  This allows"},{"line_number":6,"context_line":"    utilization of glance cache when uploading large images to glance instead"},{"line_number":7,"context_line":"    of crashing."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_c847d14b","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":61},"updated":"2018-08-27 23:15:37.000000000","message":"double-space","commit_id":"a06c45cc2fa5abf03de64daad9f6dd580fbaead5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b4536a7941a758df66424b5e4cf4e5e116ee17f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Glance containers will now bind mount the default glance cache directory"},{"line_number":5,"context_line":"    from the host when glance_default_store is set to file.  This allows"},{"line_number":6,"context_line":"    utilization of glance cache when uploading large images to glance instead"},{"line_number":7,"context_line":"    of crashing."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_687ebd6a","line":7,"range":{"start_line":5,"start_character":61,"end_line":7,"end_character":16},"updated":"2018-08-27 23:15:37.000000000","message":"This is ambiguous, and also makes it seems like there\u0027s a problem where there may be none for some installations. Suggestion:\n\nWith this change, the glance file cache size is no longer restricted to the size of the container file system.","commit_id":"a06c45cc2fa5abf03de64daad9f6dd580fbaead5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b4536a7941a758df66424b5e4cf4e5e116ee17f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f79a3b5_c8e35133","line":8,"updated":"2018-08-27 23:15:37.000000000","message":"Given that this will cause an upgrade to reboot the container, there should be in \u0027upgrade\u0027 note to highlight this.","commit_id":"a06c45cc2fa5abf03de64daad9f6dd580fbaead5"}]}