)]}'
{"id":"openstack%2Fopenstack-ansible~631957","triplet_id":"openstack%2Fopenstack-ansible~master~I8d9b7809901e045c3ecd538270833a6e80d1a3a1","project":"openstack/openstack-ansible","branch":"master","topic":"bug/1812540","hashtags":[],"change_id":"I8d9b7809901e045c3ecd538270833a6e80d1a3a1","subject":"Add missing \u0027os-infra_hosts\u0027 to prod-ceph example","status":"ABANDONED","created":"2019-01-20 07:57:33.000000000","updated":"2020-01-10 21:52:45.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"40f72bb665d1ef0a119702857d5e5a49feef8678","_number":631957,"virtual_id_number":631957,"owner":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-01-08 12:32:58.000000000","_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":1,"date":"2019-01-20 08:09:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-01-04 22:02:38.000000000","_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"date":"2019-01-20 09:17:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-01-20 08:09:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-01-20 09:17:51.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2020-01-08 12:32:58.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"3a8e46674fef0beb489fc499ce6d54e643a7764d","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2019-01-20 07:57:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"88ffdc77b9feba587d1859e0f75cb92a4cae16ce","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-20 08:09:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/57/631957/1/check/openstack-ansible-linters/911f51b/ : SUCCESS in 9m 32s\n- openstack-tox-docs http://logs.openstack.org/57/631957/1/check/openstack-tox-docs/153428a/html/ : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":1},{"id":"0d41cb3dcbb0c028c4d0e6fa7cf4d42b224d1da1","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-01-20 09:17:51.000000000","message":"Patch Set 1: Code-Review-1\n\nBug 1812540 references the \"Pike\" release documentation, and I see the os-infra_hosts group referred to elsewhere as \u0027legacy\u0027. (See https://github.com/openstack/openstack-ansible-ops/blob/master/multi-node-aio/playbooks/osa/openstack_user_config.yml#L236-L238)\n\nThis probably means there is a different error with the ceph example.","accounts_in_message":[],"_revision_number":1},{"id":"0f5ead1d05d4338fe0f96ac7099142cf47c25dc8","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2019-01-20 12:07:40.000000000","message":"Patch Set 1:\n\nIMHO there are two things:\n\n1. Inconsistent usage of os-infra_hosts\n\nFrom current openstack-ansible master:\n\n    $ git log -n 1 etc/openstack_deploy/openstack_user_config.yml.example\n    commit 8d9c0336ecc2b8469c78c7798e5b1871264b8087\n    Author: James Denton \u003cjames.denton@rackspace.com\u003e\n    Date:   Tue Jan 15 12:47:07 2019 +0000\n\n    Make container_interface optional for provider network\n    \n    As Neutron agents move to bare metal by default, the container_interface\n    attribute for a Neutron provider network (e.g. br-vlan, br-vxlan, etc) is\n    unnecessary and confusing. This patch aims to change it from a required\n    attribute to an optional one.\n    \n    Change-Id: I52692f5a36e7064c3a6ac6ccafc2420549685a66\n\n    $ grep -A 4 os-infra_hosts etc/openstack_deploy/openstack_user_config.yml.example\n    # Level: os-infra_hosts (required)\n    # List of target hosts on which to deploy the glance API, nova API, heat API,\n    # and horizon. Recommend three minimum target hosts for these services.\n    # Typically contains the same target hosts as \u0027shared-infra_hosts\u0027 level.\n    #\n\n2. (Maybe) deprecated use of \u0027os-infra_hosts\u0027 in openstack-ansible.\n\nThis patch is for handling 1. - not 2.\n\nAdding the \u0027os-infra_hosts\u0027 to the config fixed the problem that openstack-ansible stops with an error and it is consistent within openstack-ansible. So IMHO this is a step forward.\n\nDeprecating / removing the \u0027os-infra_hosts\u0027 from openstack-ansible should be handled in a dedicated patch.","accounts_in_message":[],"_revision_number":1},{"id":"0beb02c50298bf22a57bea266210c4d024754447","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-01-03 09:46:42.000000000","message":"Patch Set 1:\n\nI think that shared-infra_hosts should be used instead of os-infra hosts. According to their env.d files [1] [2] - they are kinda the same. And shared-infra_hosts is already used here and assigned to infrastructure_hosts.\n\n\n[1] https://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/env.d/shared-infra.yml\n[2] https://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/env.d/os-infra.yml","accounts_in_message":[],"_revision_number":1},{"id":"d38bd64b36a7076c0257133aad13340c474450ef","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2020-01-04 22:02:38.000000000","message":"Patch Set 1:\n\nOk - when I understand you correctly, instead of os-infra_hosts the var shared-infra_hosts should be used.\n\nThe problem is, that this does currently not work in OSA 20.0.0. Re-run this on a complete fresh installation today to check.\n\nWhen only setting shared-infra_hosts and not os-infra_hosts os-nova stops with:\n\n    TASK [os_nova : Set the delegated task facts] **********************************\n    task path: /etc/ansible/roles/os_nova/tasks/nova_db_post_setup.yml:16\n    \u003ccompute0\u003e Task is delegated to {{ nova_conductor_setup_host }}.\n    \u003ccompute0\u003e The \"physical_host\" variable of \"compute0\" has been found to have a corresponding host entry in inventory.\n    \u003ccompute0\u003e The \"physical_host\" variable of \"compute0\" terminates at \"10.0.5.104\" using the host variable \"ansible_host\".\n    \u003ccompute0\u003e Because this is a task using \"delegate_to\" pipelining has been disabled. but will be restored upon completion of this task.\n    fatal: [compute0]: FAILED! \u003d\u003e {\"msg\": \"list object has no element 0\"}\n\nThe patch is currently based on this experience.  If you think, this is a bug, I\u0027d prefer to report and get this fixed first.  I don\u0027t want to introduce a documentation that does not work ;-)","accounts_in_message":[],"_revision_number":1},{"id":"8e52355ed8cfd78438be3b7535eea0c1ee268772","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-01-05 09:30:28.000000000","message":"Patch Set 1:\n\nYep, I mean, that I never used os-infra_hosts and it\u0027s actually not really used in CI as well http://codesearch.openstack.org/?q\u003dos-infra_hosts\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nCan you join our IRC #openstack-ansible at freenode for further conversation?","accounts_in_message":[],"_revision_number":1},{"id":"3d06dcb444c4ca156e216b1ec0c49ac84ed04659","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-01-08 12:32:58.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nYeah, sorry, you was right about os-infra_hosts - it\u0027s really required and is different from shared-infra - shared is for memchached, rabbidmq, etc while os-infra is for openstack core set [1].\n\n[1] http://codesearch.openstack.org/?q\u003dos-infra_containers\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dopenstack/openstack-ansible","accounts_in_message":[],"_revision_number":1},{"id":"39693828d324e7408a6178407770243d5134c00c","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-01-09 10:13:28.000000000","message":"Removed Code-Review-1 by Jonathan Rosser \u003cjonathan.rosser@rd.bbc.co.uk\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"f4afb8ffd8446b85328b002bac5155cff67761a2","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-01-10 21:52:45.000000000","message":"Abandoned\n\nreplaced by 701548","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6485ea332edc84a53dcf5d4c5477ca11cd454220","revisions":{"6485ea332edc84a53dcf5d4c5477ca11cd454220":{"kind":"REWORK","_number":1,"created":"2019-01-20 07:57:33.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/57/631957/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/57/631957/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/57/631957/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/57/631957/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/57/631957/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/57/631957/1"}}},"commit":{"parents":[{"commit":"f623de3846f60dd13bbe0746932772514facd5cc","subject":"Merge \"Remove tempest service enable vars\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/f623de3846f60dd13bbe0746932772514facd5cc"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2019-01-20 07:41:39.000000000","tz":60},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2019-01-20 07:50:43.000000000","tz":60},"subject":"Add missing \u0027os-infra_hosts\u0027 to prod-ceph example","message":"Add missing \u0027os-infra_hosts\u0027 to prod-ceph example\n\nThe example configuration file for ceph production\nis missing the configuration entry for \u0027os-infra_hosts\u0027\n- which is mandatory.\n\nChange-Id: I8d9b7809901e045c3ecd538270833a6e80d1a3a1\nCloses-Bug: 1812540\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6485ea332edc84a53dcf5d4c5477ca11cd454220"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6485ea332edc84a53dcf5d4c5477ca11cd454220"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}