)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"294cd5d636d2f68b820f663510e1801e6a1e718c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert the nova playbook to use newer ansible syntax"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova plabook has been converted from using \"include\" with playbooks"},{"line_number":10,"context_line":"as this funciton has ben deprecated and is set to be removed. The"},{"line_number":11,"context_line":"serialization of the nova playbook has been impacted by the removal"},{"line_number":12,"context_line":"of this function and will need to be reworked should we discover issues"},{"line_number":13,"context_line":"with the installation process using the new layout."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_27e91ce2","line":11,"range":{"start_line":10,"start_character":62,"end_line":11,"end_character":52},"updated":"2019-02-27 09:57:46.000000000","message":"By \u0027impacted\u0027, you mean \u0027removed\u0027. This is a fairly large impact. We can probably keep the serialization if we convert this all to imported tasks. It does mean a lot more repetition, but keeps the serialization.","commit_id":"afa0e0a6da6991eadb7e5b6533308a639baf74f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7ad1dcd0e8af12be3fefa509430c90d46d937145","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert the nova playbook to use newer ansible syntax"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova plabook has been converted from using \"include\" with playbooks"},{"line_number":10,"context_line":"as this funciton has ben deprecated and is set to be removed. The"},{"line_number":11,"context_line":"serialization of the nova playbook has been impacted by the removal"},{"line_number":12,"context_line":"of this function and will need to be reworked should we discover issues"},{"line_number":13,"context_line":"with the installation process using the new layout."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_8f5c9a7d","line":11,"range":{"start_line":10,"start_character":62,"end_line":11,"end_character":52},"in_reply_to":"9fdfeff1_27e91ce2","updated":"2019-02-27 13:51:37.000000000","message":"I actually think we can remove it in the conversion task (here), and re-add it in a way that falls within the new ansible task framework, I\u0027m thinking of using dynamic groups and include tasks, however, I\u0027ve not really sat down and worked out the nuances just yet. In the conversion work I was trying to do the absolute minimum to resolve the deprecation warnings without re-implementing everything is a massive patch [I Know, not my normal approach :)]. Assuming we can work out a suitable pattern to reintroduce the serialization, this is something we should be able to apply to all of the OpenStack and Infrastructure services giving us a much better upgrade story across the board.","commit_id":"afa0e0a6da6991eadb7e5b6533308a639baf74f9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"af24bbff562b6eef987fdd030519a1cc53cef27e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert the nova playbook to use newer ansible syntax"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova plabook has been converted from using \"include\" with playbooks"},{"line_number":10,"context_line":"as this funciton has ben deprecated and is set to be removed. The"},{"line_number":11,"context_line":"serialization of the nova playbook has been impacted by the removal"},{"line_number":12,"context_line":"of this function and will need to be reworked should we discover issues"},{"line_number":13,"context_line":"with the installation process using the new layout."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_47946044","line":11,"range":{"start_line":10,"start_character":62,"end_line":11,"end_character":52},"in_reply_to":"9fdfeff1_27e91ce2","updated":"2019-02-27 09:59:18.000000000","message":"If everyone is happy to do this, then that\u0027s all well and good - but I\u0027d like us to discuss this as a community, rather than let this fly by without a broad enough consensus.","commit_id":"afa0e0a6da6991eadb7e5b6533308a639baf74f9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7ad1dcd0e8af12be3fefa509430c90d46d937145","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert the nova playbook to use newer ansible syntax"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova plabook has been converted from using \"include\" with playbooks"},{"line_number":10,"context_line":"as this funciton has ben deprecated and is set to be removed. The"},{"line_number":11,"context_line":"serialization of the nova playbook has been impacted by the removal"},{"line_number":12,"context_line":"of this function and will need to be reworked should we discover issues"},{"line_number":13,"context_line":"with the installation process using the new layout."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_6f57f65b","line":11,"range":{"start_line":10,"start_character":62,"end_line":11,"end_character":52},"in_reply_to":"9fdfeff1_47946044","updated":"2019-02-27 13:51:37.000000000","message":"100% I\u0027ll be sure to bring this up in the next meeting.","commit_id":"afa0e0a6da6991eadb7e5b6533308a639baf74f9"}]}
