)]}'
{"scripts/run-upgrade.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"95c7eed71b6fd0dec8d04290d325b7a6c13ab4e7","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    \"${SCRIPTS_PATH}/bootstrap-ansible.sh\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":170,"context_line":"        if [ -v SKIP_CUSTOM_ENVD_CHECK ]; then"},{"line_number":171,"context_line":"           RUN_TASKS+\u003d(\"${SCRIPTS_PATH}/upgrade-utilities/deploy-config-changes.yml --skip-tags custom-envd-file-check\")"},{"line_number":172,"context_line":"        else"},{"line_number":173,"context_line":"           RUN_TASKS+\u003d(\"${SCRIPTS_PATH}/upgrade-utilities/deploy-config-changes.yml\")"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffb9cba7_acbc87dc","line":170,"range":{"start_line":170,"start_character":13,"end_line":170,"end_character":15},"updated":"2019-04-24 10:07:35.000000000","message":"What does this condition mean? I\u0027ve not seen it before and my google-fu is failing me.","commit_id":"7effebd5260d17264a7fa902f6b3fccd34b3a4a9"}],"scripts/upgrade-utilities/deploy-config-changes.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b65164931d873897317a128333f1423d431a445","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          layout in {{ repo_root_dir }}/inventory/env.d. The difference between these files"},{"line_number":57,"context_line":"          should be carefully reviewed to understand whether the changes are still necessary"},{"line_number":58,"context_line":"          and applicable to the environment. If all the user-space env.d files are necessary,"},{"line_number":59,"context_line":"          then please export SKIP_CUSTOM_ENVD_CHECK\u003dtrue and re-run the the run-upgrade.sh"},{"line_number":60,"context_line":"          script."},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - _envd_dir_contents.matched \u003e 0"},{"line_number":63,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_99aea496","line":60,"range":{"start_line":59,"start_character":22,"end_line":60,"end_character":17},"updated":"2019-04-24 11:33:09.000000000","message":"This assumes that the run-upgrade script was used in the first place, which may not be true given that we also provide a guide to doing all the run-upgrade steps manually. To work around this, the wording can stay the same, but the condition below can be changed to something like:\n\n      when:\n        - _envd_dir_contents.matched \u003e 0\n        - not(lookup(\u0027env\u0027, \u0027SKIP_CUSTOM_ENVD_CHECK\u0027) | bool)","commit_id":"7effebd5260d17264a7fa902f6b3fccd34b3a4a9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8dadf6817b3d5bb56dc3455df96e99c9fe6f2a78","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          layout in {{ repo_root_dir }}/inventory/env.d. The difference between these files"},{"line_number":57,"context_line":"          should be carefully reviewed to understand whether the changes are still necessary"},{"line_number":58,"context_line":"          and applicable to the environment. If all the user-space env.d files are necessary,"},{"line_number":59,"context_line":"          then please export SKIP_CUSTOM_ENVD_CHECK\u003dtrue and re-run the the run-upgrade.sh"},{"line_number":60,"context_line":"          script."},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - _envd_dir_contents.matched \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_fe21befc","line":59,"range":{"start_line":59,"start_character":68,"end_line":59,"end_character":75},"updated":"2019-04-24 16:11:05.000000000","message":"the the - repetition","commit_id":"6e49ebb15aa06267c1af755ad148cfb1ed768460"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8dadf6817b3d5bb56dc3455df96e99c9fe6f2a78","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          layout in {{ repo_root_dir }}/inventory/env.d. The difference between these files"},{"line_number":57,"context_line":"          should be carefully reviewed to understand whether the changes are still necessary"},{"line_number":58,"context_line":"          and applicable to the environment. If all the user-space env.d files are necessary,"},{"line_number":59,"context_line":"          then please export SKIP_CUSTOM_ENVD_CHECK\u003dtrue and re-run the the run-upgrade.sh"},{"line_number":60,"context_line":"          script."},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - _envd_dir_contents.matched \u003e 0"},{"line_number":63,"context_line":"        - not(lookup(\u0027env\u0027, \u0027SKIP_CUSTOM_ENVD_CHECK\u0027) | bool)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_5e680a20","line":60,"range":{"start_line":59,"start_character":76,"end_line":60,"end_character":16},"updated":"2019-04-24 16:11:05.000000000","message":"I\u0027d suggest making this \u0027re-run the playbook or run-upgrade script.\u0027","commit_id":"6e49ebb15aa06267c1af755ad148cfb1ed768460"}]}