)]}'
{"playbooks/infra-journal-remote.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5bc3c2e43a7eb3e868189ba6d158f9f3d1cf2278","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - (ansible_host \u003d\u003d systemd_journal_remote_target)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   - name: Create journal directory"},{"line_number":53,"context_line":"      file:"},{"line_number":54,"context_line":"        path: \"/var/log/journal\""},{"line_number":55,"context_line":"        state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_bdea14d5","line":52,"updated":"2019-04-30 11:53:12.000000000","message":"Wrong indent","commit_id":"33a5228e22e64cf20c270e10068c5ae0b43d15b9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a1de80d2b50d5a2dd8f093558ff7235fb5028fd9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      systemd_TasksAccounting: true"},{"line_number":96,"context_line":"      systemd_services:"},{"line_number":97,"context_line":"        - service_name: \"systemd-journal-remote\""},{"line_number":98,"context_line":"          enabled: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027no\u0027, \u0027yes\u0027) }}\""},{"line_number":99,"context_line":"          state: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027stopped\u0027, \u0027started\u0027) }}\""},{"line_number":100,"context_line":"          execstarts: \u003e-"},{"line_number":101,"context_line":"            {{ systemd_utils_prefix }}/systemd-journal-remote"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_bdfc54b5","line":98,"updated":"2019-04-30 11:43:06.000000000","message":"doesn\u0027t it do the same thing?","commit_id":"33a5228e22e64cf20c270e10068c5ae0b43d15b9"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"7a2717421e337c3f80f48899274607268fb84138","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      systemd_TasksAccounting: true"},{"line_number":96,"context_line":"      systemd_services:"},{"line_number":97,"context_line":"        - service_name: \"systemd-journal-remote\""},{"line_number":98,"context_line":"          enabled: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027no\u0027, \u0027yes\u0027) }}\""},{"line_number":99,"context_line":"          state: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027stopped\u0027, \u0027started\u0027) }}\""},{"line_number":100,"context_line":"          execstarts: \u003e-"},{"line_number":101,"context_line":"            {{ systemd_utils_prefix }}/systemd-journal-remote"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_b3448348","line":98,"in_reply_to":"ffb9cba7_9d18701e","updated":"2019-04-30 14:26:38.000000000","message":"i didn\u0027t use systemd_serivce because the service unit file seems to be present from the distro, its just not enabled or started. Could change this though if we want to replace the unit file with one of our own?","commit_id":"33a5228e22e64cf20c270e10068c5ae0b43d15b9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2da1060178e3911f0617e1eb24e1d2f4acf2d7c7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      systemd_TasksAccounting: true"},{"line_number":96,"context_line":"      systemd_services:"},{"line_number":97,"context_line":"        - service_name: \"systemd-journal-remote\""},{"line_number":98,"context_line":"          enabled: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027no\u0027, \u0027yes\u0027) }}\""},{"line_number":99,"context_line":"          state: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027stopped\u0027, \u0027started\u0027) }}\""},{"line_number":100,"context_line":"          execstarts: \u003e-"},{"line_number":101,"context_line":"            {{ systemd_utils_prefix }}/systemd-journal-remote"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_b3e00328","line":98,"in_reply_to":"ffb9cba7_b3448348","updated":"2019-04-30 14:36:36.000000000","message":"Ah, ok, I see. I\u0027d suggested to move this to handlers, but once you say that it\u0027s already present - we won\u0027t be able to trigger it then...","commit_id":"33a5228e22e64cf20c270e10068c5ae0b43d15b9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6f4e3cfb19341f239506c1b37f2dc24d5ce5ef46","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      systemd_TasksAccounting: true"},{"line_number":96,"context_line":"      systemd_services:"},{"line_number":97,"context_line":"        - service_name: \"systemd-journal-remote\""},{"line_number":98,"context_line":"          enabled: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027no\u0027, \u0027yes\u0027) }}\""},{"line_number":99,"context_line":"          state: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027stopped\u0027, \u0027started\u0027) }}\""},{"line_number":100,"context_line":"          execstarts: \u003e-"},{"line_number":101,"context_line":"            {{ systemd_utils_prefix }}/systemd-journal-remote"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_9d18701e","line":98,"in_reply_to":"ffb9cba7_bdfc54b5","updated":"2019-04-30 11:45:43.000000000","message":"If it\u0027s about socket, than probably we can extend systemd_service role functionality instead?","commit_id":"33a5228e22e64cf20c270e10068c5ae0b43d15b9"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"7a2717421e337c3f80f48899274607268fb84138","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      systemd_TasksAccounting: true"},{"line_number":96,"context_line":"      systemd_services:"},{"line_number":97,"context_line":"        - service_name: \"systemd-journal-remote\""},{"line_number":98,"context_line":"          enabled: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027no\u0027, \u0027yes\u0027) }}\""},{"line_number":99,"context_line":"          state: \"{{ (ansible_host !\u003d systemd_journal_remote_target) | ternary(\u0027stopped\u0027, \u0027started\u0027) }}\""},{"line_number":100,"context_line":"          execstarts: \u003e-"},{"line_number":101,"context_line":"            {{ systemd_utils_prefix }}/systemd-journal-remote"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_93605fd1","line":98,"in_reply_to":"ffb9cba7_bdfc54b5","updated":"2019-04-30 14:26:38.000000000","message":"there are two services, systemd-journal-remote and systemd-journal-remote.socket","commit_id":"33a5228e22e64cf20c270e10068c5ae0b43d15b9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2da1060178e3911f0617e1eb24e1d2f4acf2d7c7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        name: systemd-journal-remote.socket"},{"line_number":47,"context_line":"        enabled: yes"},{"line_number":48,"context_line":"        state: started"},{"line_number":49,"context_line":"        when:"},{"line_number":50,"context_line":"          - (ansible_host \u003d\u003d systemd_journal_remote_target)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   - name: Create journal directory"},{"line_number":53,"context_line":"      file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_d3c6d79a","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":59},"updated":"2019-04-30 14:36:36.000000000","message":"indent problem not here","commit_id":"e5d4179375c376a143bd9c6e9135922683a11d1a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7a73bab90d7da343ef8a59a81785499cb4472e7c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        name: systemd-journal-remote.socket"},{"line_number":47,"context_line":"        enabled: yes"},{"line_number":48,"context_line":"        state: started"},{"line_number":49,"context_line":"        when:"},{"line_number":50,"context_line":"          - (ansible_host \u003d\u003d systemd_journal_remote_target)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   - name: Create journal directory"},{"line_number":53,"context_line":"      file:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_936a9f7e","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":59},"in_reply_to":"ffb9cba7_d3c6d79a","updated":"2019-04-30 14:43:16.000000000","message":"I mean it was not here until patch 2, but now it\u0027s here as well:)","commit_id":"e5d4179375c376a143bd9c6e9135922683a11d1a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2da1060178e3911f0617e1eb24e1d2f4acf2d7c7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        when:"},{"line_number":50,"context_line":"          - (ansible_host \u003d\u003d systemd_journal_remote_target)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   - name: Create journal directory"},{"line_number":53,"context_line":"      file:"},{"line_number":54,"context_line":"        path: \"/var/log/journal\""},{"line_number":55,"context_line":"        state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffb9cba7_f3c3db87","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":35},"updated":"2019-04-30 14:36:36.000000000","message":"But here","commit_id":"e5d4179375c376a143bd9c6e9135922683a11d1a"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"5c8cc23a29c48ad6ef5f3382334efe71bdf6d8ad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name: \"{{ systemd_journal_remote_distro_package[ansible_pkg_mgr] }}\""},{"line_number":42,"context_line":"        state: \"{{ package_state }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    - name: Ensure systemd-journal-remote socket is enabled on receiving host"},{"line_number":45,"context_line":"      systemd:"},{"line_number":46,"context_line":"        name: systemd-journal-remote.socket"},{"line_number":47,"context_line":"        enabled: yes"},{"line_number":48,"context_line":"        state: started"},{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - (ansible_host \u003d\u003d systemd_journal_remote_target)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    - name: Create journal directory"},{"line_number":53,"context_line":"      file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_37cb2d54","line":50,"range":{"start_line":44,"start_character":0,"end_line":50,"end_character":57},"updated":"2019-05-18 11:18:28.000000000","message":"any reason why we don\u0027t just delegate_to: \"{{ systemd_journal_remote_target }}\" and run_once: true ?","commit_id":"590c86bc1010eae78a5df7ede26eb8dca0bf20a5"}]}