)]}'
{"id":"openstack%2Fopenstack-ansible~672704","triplet_id":"openstack%2Fopenstack-ansible~master~I689c7cf749f6611ae3dfcb1804a700d5e456947e","project":"openstack/openstack-ansible","branch":"master","hashtags":[],"change_id":"I689c7cf749f6611ae3dfcb1804a700d5e456947e","subject":"Allow user overrides for ansible-role-requirements","status":"MERGED","created":"2019-07-25 11:49:39.000000000","updated":"2019-10-04 11:54:03.000000000","submitted":"2019-07-30 19:53:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672704-1564516405477-66f2565c","meta_rev_id":"5d62aa7f6a61db861edf4de7b9ac38de68751a00","_number":672704,"virtual_id_number":672704,"owner":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":2,"date":"2019-07-30 19:53:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"all":[{"value":2,"date":"2019-07-25 20:22:32.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":2,"date":"2019-07-30 17:19:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"all":[{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":1,"date":"2019-07-30 17:19:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-25 20:22:32.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2019-07-30 17:19:07.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2019-07-30 19:53:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3570b8e01e2cddac56e889789b2ce84427f790fa","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-07-25 11:49:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eecfaa76248e00bb49f9285a984d9c5b2afbe74e","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-07-25 12:16:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a3018b266237da9a5f5422ea5b68faf40aeb9306","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 14:43:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/04/672704/2/check/openstack-ansible-linters/57cdd18/ : SUCCESS in 9m 27s\n- openstack-ansible-varstest-aio http://logs.openstack.org/04/672704/2/check/openstack-ansible-varstest-aio/1943401/ : SUCCESS in 9m 20s\n- openstack-tox-docs http://logs.openstack.org/04/672704/2/check/openstack-tox-docs/f91cd05/html/ : SUCCESS in 8m 00s\n- openstack-ansible-deploy-aio_lxc-centos-7 http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_lxc-centos-7/8a3bdca/ : SUCCESS in 2h 14m 31s\n- openstack-ansible-deploy-aio_lxc-debian-stable http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_lxc-debian-stable/436e6ab/ : SUCCESS in 1h 50m 09s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_lxc-ubuntu-bionic/78e527d/ : SUCCESS in 1h 40m 39s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_metal-debian-stable/873c893/ : SUCCESS in 1h 13m 22s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_metal-centos-7/1be37f7/ : SUCCESS in 1h 24m 34s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_metal-opensuse-15/72b2f90/ : SUCCESS in 1h 12m 55s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/3aecccc/ : SUCCESS in 1h 06m 14s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_distro_metal-centos-7/8fd2f09/ : SUCCESS in 59m 22s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/a145484/ : FAILURE in 44m 25s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/47ccb4f/ : SUCCESS in 50m 01s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_ceph-ubuntu-bionic/ff955c9/ : SUCCESS in 1h 47m 50s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic http://logs.openstack.org/04/672704/2/check/openstack-ansible-deploy-aio_proxy-ubuntu-bionic/093b09f/ : SUCCESS in 1h 33m 18s\n- build-openstack-releasenotes http://logs.openstack.org/04/672704/2/check/build-openstack-releasenotes/106944b/html/ : SUCCESS in 7m 39s","accounts_in_message":[],"_revision_number":2},{"id":"bb3cf9cf6508baf689d82411c85c0f95a4df37bb","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-07-25 20:22:32.000000000","message":"Patch Set 2: Code-Review+2\n\nI like this.\n\nI think this could be used to cleanup our way to deal with depends-on though (generating the user role overrides from zuul vars), but that could be done later.","accounts_in_message":[],"_revision_number":2},{"id":"8d1318684cd220fe57e07fe8c236d28aafa36bb2","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-30 17:19:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9922ef5a5a0e459325e775831bf07151dea5f4fd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 17:19:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9637eed959e38d06ab04190d78fafba9d994bb78","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 19:53:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters http://logs.openstack.org/04/672704/2/gate/openstack-ansible-linters/7845d04/ : SUCCESS in 9m 02s\n- openstack-ansible-varstest-aio http://logs.openstack.org/04/672704/2/gate/openstack-ansible-varstest-aio/2700a8a/ : SUCCESS in 8m 28s\n- openstack-tox-docs http://logs.openstack.org/04/672704/2/gate/openstack-tox-docs/3f01b8d/html/ : SUCCESS in 9m 40s\n- openstack-ansible-deploy-aio_lxc-centos-7 http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_lxc-centos-7/0455fbc/ : SUCCESS in 2h 23m 17s\n- openstack-ansible-deploy-aio_lxc-debian-stable http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_lxc-debian-stable/045a4b6/ : SUCCESS in 1h 55m 30s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_lxc-ubuntu-bionic/0ed4e31/ : SUCCESS in 1h 37m 22s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_metal-debian-stable/6610ab2/ : SUCCESS in 1h 11m 56s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_metal-centos-7/a33c92c/ : SUCCESS in 1h 27m 54s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_metal-opensuse-15/f0b089c/ : SUCCESS in 1h 16m 13s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_metal-ubuntu-bionic/5a60ef5/ : SUCCESS in 55m 42s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_distro_metal-centos-7/c479a3f/ : SUCCESS in 59m 46s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/0107d68/ : SUCCESS in 45m 28s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_ceph-ubuntu-bionic/9cc0467/ : SUCCESS in 2h 08m 15s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic http://logs.openstack.org/04/672704/2/gate/openstack-ansible-deploy-aio_proxy-ubuntu-bionic/27aeaf7/ : SUCCESS in 1h 50m 13s\n- build-openstack-releasenotes http://logs.openstack.org/04/672704/2/gate/build-openstack-releasenotes/e0d31a9/html/ : SUCCESS in 7m 02s","accounts_in_message":[],"_revision_number":2},{"id":"685f563857cba9f6c58910a929562b6ffb380768","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 19:53:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5d62aa7f6a61db861edf4de7b9ac38de68751a00","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-10-04 11:54:03.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 1c871f0edf53e255078889faba8ab3c8e061d9ea","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e9f323c6540713d7facf515957af4b2705a1ad1e","revisions":{"6b7ccc06fc713080bb39d5dc12f0bbb0b41f6882":{"kind":"REWORK","_number":1,"created":"2019-07-25 11:49:39.000000000","uploader":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"ref":"refs/changes/04/672704/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/04/672704/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/1"}}},"commit":{"parents":[{"commit":"048e197ef475159406ca128ef9ec173ead6ce06e","subject":"Merge \"Update Ansible to 2.8.2, Ceph-Ansible to 4.0, Ceph to Nautilus\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/048e197ef475159406ca128ef9ec173ead6ce06e"}]}],"author":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2019-07-25 11:32:16.000000000","tz":60},"committer":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2019-07-25 11:32:16.000000000","tz":60},"subject":"Allow user overrides for ansible-role-requirements","message":"Allow user overrides for ansible-role-requirements\n\nCurrently it is only possible to override the contents of the\nansible-role-requirements file as a whole.\n\nThis patch allows a user-role-requirements.yml file to be\nlocated in the /etc/openstack_deploy directory (or the directory defined\nby OSA_CONFIG_DIR). It is only necessary to list specific overridden\nrepos in the user role file. The boostrap-ansible.sh script is modified to\ngive preference to any repos named in user-role-requirements over those\nin the standard ansible-role-requirements.\n\nThis gives the following benefits:\n\n* When a deployer needs to use a locally patched version of an ansible\nrole, the configuration can be held under source code control in\n/etc/openstack_deploy along with the rest of the environment\nconfiguration\n\n* Manual adjustments to ansible-role-requirements.yml are no longer lost\nwhen running bootstrap-ansible.sh, the modifications can be kept in\nuserspace.\n\n* If any additional ansible roles are required by the deployer above the\nstandard set these can be listed in user-role-requirements.yml\n\n* It is very clear which roles have been overidden as they are the only\nones listed in user-role-requirements.yml\n\nChange-Id: I689c7cf749f6611ae3dfcb1804a700d5e456947e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6b7ccc06fc713080bb39d5dc12f0bbb0b41f6882"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6b7ccc06fc713080bb39d5dc12f0bbb0b41f6882"}]},"branch":"refs/heads/master"},"e9f323c6540713d7facf515957af4b2705a1ad1e":{"kind":"REWORK","_number":2,"created":"2019-07-25 12:16:59.000000000","uploader":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"ref":"refs/changes/04/672704/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/04/672704/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/04/672704/2"}}},"commit":{"parents":[{"commit":"048e197ef475159406ca128ef9ec173ead6ce06e","subject":"Merge \"Update Ansible to 2.8.2, Ceph-Ansible to 4.0, Ceph to Nautilus\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/048e197ef475159406ca128ef9ec173ead6ce06e"}]}],"author":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2019-07-25 11:32:16.000000000","tz":60},"committer":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2019-07-25 12:16:44.000000000","tz":60},"subject":"Allow user overrides for ansible-role-requirements","message":"Allow user overrides for ansible-role-requirements\n\nCurrently it is only possible to override the contents of the\nansible-role-requirements file as a whole.\n\nThis patch allows a user-role-requirements.yml file to be\nlocated in the /etc/openstack_deploy directory (or the directory defined\nby OSA_CONFIG_DIR). It is only necessary to list specific overridden\nrepos in the user role file. The boostrap-ansible.sh script is modified to\ngive preference to any repos named in user-role-requirements over those\nin the standard ansible-role-requirements.\n\nThis gives the following benefits:\n\n* When a deployer needs to use a locally patched version of an ansible\nrole, the configuration can be held under source code control in\n/etc/openstack_deploy along with the rest of the environment\nconfiguration\n\n* Manual adjustments to ansible-role-requirements.yml are no longer lost\nwhen running bootstrap-ansible.sh, the modifications can be kept in\nuserspace.\n\n* If any additional ansible roles are required by the deployer above the\nstandard set these can be listed in user-role-requirements.yml\n\n* It is very clear which roles have been overidden as they are the only\nones listed in user-role-requirements.yml\n\nChange-Id: I689c7cf749f6611ae3dfcb1804a700d5e456947e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/e9f323c6540713d7facf515957af4b2705a1ad1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/e9f323c6540713d7facf515957af4b2705a1ad1e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}