)]}'
{"id":"openstack%2Fopenstack-ansible~672835","triplet_id":"openstack%2Fopenstack-ansible~master~I141cb426939929f8db361cdabe12134c1e1bb791","project":"openstack/openstack-ansible","branch":"master","topic":"fix-ceph","hashtags":[],"change_id":"I141cb426939929f8db361cdabe12134c1e1bb791","subject":"rbd: define nova_cinder_rbd_inuse properly","status":"ABANDONED","created":"2019-07-25 22:29:08.000000000","updated":"2019-07-30 16:30:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"37c7530fdafd468b356e4b113f4421c27087a1ef","_number":672835,"virtual_id_number":672835,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"date":"2019-07-30 16:05:56.000000000","_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":-1,"date":"2019-07-26 00:01:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"date":"2019-07-26 13:17:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-07-26 10:10:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-26 00:01:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-26 10:10:09.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-07-26 13:17:25.000000000","updated_by":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"reviewer":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"state":"REVIEWER"},{"updated":"2019-07-30 16:05:56.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"d6fb99d3616608067e066f6a1f287f0fa05ee471","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-25 22:29:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68aa4c564a395a3200db17bbc977c74bda7f0da8","author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"date":"2019-07-25 22:29:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"313e419276408f5f447b0aeda46503d1cb2328b0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 00:01:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-ansible-linters http://logs.openstack.org/35/672835/1/check/openstack-ansible-linters/17d2ffa/ : SUCCESS in 10m 46s\n- openstack-ansible-varstest-aio http://logs.openstack.org/35/672835/1/check/openstack-ansible-varstest-aio/21dddd3/ : SUCCESS in 11m 37s\n- openstack-tox-docs http://logs.openstack.org/35/672835/1/check/openstack-tox-docs/1290e4f/html/ : SUCCESS in 5m 53s\n- openstack-ansible-deploy-aio_lxc-centos-7 http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_lxc-centos-7/0dab577/ : FAILURE in 1h 21m 21s\n- openstack-ansible-deploy-aio_lxc-debian-stable http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_lxc-debian-stable/b554a8d/ : FAILURE in 1h 11m 57s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_lxc-ubuntu-bionic/2b76ec9/ : FAILURE in 1h 05m 17s\n- openstack-ansible-deploy-aio_metal-debian-stable http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_metal-debian-stable/30dfc8a/ : FAILURE in 41m 57s\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_metal-centos-7/fbc12a5/ : FAILURE in 50m 05s\n- openstack-ansible-deploy-aio_metal-opensuse-15 http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_metal-opensuse-15/3f39763/ : FAILURE in 49m 17s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/a61e93a/ : FAILURE in 46m 03s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_distro_metal-centos-7/8d5c483/ : FAILURE in 39m 49s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_distro_metal-opensuse-15/0db3c2c/ : FAILURE in 40m 00s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic/1ea0b2c/ : FAILURE in 31m 11s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_ceph-ubuntu-bionic/df1a9bf/ : FAILURE in 1h 26m 05s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic http://logs.openstack.org/35/672835/1/check/openstack-ansible-deploy-aio_proxy-ubuntu-bionic/9c22992/ : FAILURE in 1h 05m 38s","accounts_in_message":[],"_revision_number":1},{"id":"c09a40de63bb153e5ee8db7dc0e0ebea2b090fce","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-07-26 10:10:09.000000000","message":"Patch Set 1: Code-Review-1\n\nI see special handling for this var here to make it be defined in the os_nova role https://opendev.org/openstack/openstack-ansible/src/branch/master/playbooks/common-playbooks/nova.yml#L145\n\n  11:31 PM \u003clogan-\u003e it is only meant to be set locally\n  11:32 PM \u003clogan-\u003e that way we aren\u0027t running the same logic across * hosts\n  11:32 PM \u003clogan-\u003e because map/extract acorss inventory is very slow\n\nSo is this an error with the way the var is passed into os_nova, or that it is required somewhere other than os_nova? Either way the commit message doesn\u0027t help me understand, particularly if the map/extract is an expensive operation.","accounts_in_message":[],"_revision_number":1},{"id":"d0f8198bb2c6b9045e685fe06f1a9ab7622a806b","author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"date":"2019-07-26 13:17:25.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"69a3fbc42782e235d6e8f45de7ab9b108251b56e","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-07-30 16:05:56.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7b035b18122a519796bdfbc7e3d8aeb1e52a2ca9","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-30 16:30:15.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88638861d7ca7dc4a23e9738d15bef1f39d4bf5b","revisions":{"88638861d7ca7dc4a23e9738d15bef1f39d4bf5b":{"kind":"REWORK","_number":1,"created":"2019-07-25 22:29:08.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/35/672835/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/35/672835/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/35/672835/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/35/672835/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/35/672835/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/35/672835/1"}}},"commit":{"parents":[{"commit":"f1aa51b20e04def439f6a37983e7ba099fc50d84","subject":"Install placement osc plugin on utility machines","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/f1aa51b20e04def439f6a37983e7ba099fc50d84"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-25 22:27:29.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-25 22:27:29.000000000","tz":-240},"subject":"rbd: define nova_cinder_rbd_inuse properly","message":"rbd: define nova_cinder_rbd_inuse properly\n\nPreviously, the logic that determines nova_cinder_rbd_inuse ran\non the localhost and set the fact only on the localhost.\n\nDue to this, the variable `nova_cinder_rbd_inuse` was always set\nto false on the hosts when they ran.\n\nThis moves it into the vars section so it runs globally against\nall hosts.\n\nChange-Id: I141cb426939929f8db361cdabe12134c1e1bb791\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/88638861d7ca7dc4a23e9738d15bef1f39d4bf5b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/88638861d7ca7dc4a23e9738d15bef1f39d4bf5b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}