)]}'
{"id":"openstack%2Fopenstack-ansible~673713","triplet_id":"openstack%2Fopenstack-ansible~stable%2Frocky~I77b7e090aa4331e6a9547e0526a0f291f06a57c0","project":"openstack/openstack-ansible","branch":"stable/rocky","topic":"nova_console_httpchk-stable/rocky","hashtags":[],"change_id":"I77b7e090aa4331e6a9547e0526a0f291f06a57c0","subject":"Change haproxy http-check expect for nova_console","status":"ABANDONED","created":"2019-07-30 23:59:30.000000000","updated":"2020-10-13 20:30:32.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1f509ba0074cca9e189ac90d3ec97eb8364ddc6f","_number":673713,"virtual_id_number":673713,"owner":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":1,"date":"2019-07-31 02:27:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":-1,"date":"2019-07-31 03:56:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"all":[{"value":-1,"date":"2019-07-31 22:42:15.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-31 02:27:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-31 03:56:53.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"2819febe405132c14f55fafa4b4b73d37f1deaf1","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2019-07-30 23:59:30.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"b56157b7eba2e47e0e00797fbceb8ce9c3f76d98","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 02:27:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/13/673713/1/check/build-openstack-sphinx-docs/1ce20ac/html/ : SUCCESS in 4m 17s\n- openstack-ansible-linters http://logs.openstack.org/13/673713/1/check/openstack-ansible-linters/2b0c953/ : SUCCESS in 10m 24s\n- openstack-ansible-varstest-aio http://logs.openstack.org/13/673713/1/check/openstack-ansible-varstest-aio/0cb5e43/ : SUCCESS in 11m 54s\n- openstack-ansible-deploy-aio_lxc-centos-7 http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_lxc-centos-7/b6a2601/ : SUCCESS in 2h 02m 15s\n- openstack-ansible-deploy-aio_lxc-opensuse-150 http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_lxc-opensuse-150/e059892/ : FAILURE in 6m 38s (non-voting)\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_lxc-ubuntu-bionic/0b080c8/ : SUCCESS in 1h 25m 57s\n- openstack-ansible-deploy-aio_lxc-ubuntu-xenial http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_lxc-ubuntu-xenial/e4e688b/ : SUCCESS in 1h 42m 28s\n- openstack-ansible-deploy-aio_distro_lxc-centos-7 http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_distro_lxc-centos-7/4862a79/ : SUCCESS in 1h 17m 32s (non-voting)\n- openstack-ansible-deploy-aio_distro_lxc-opensuse-150 http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_distro_lxc-opensuse-150/4af777d/ : FAILURE in 6m 06s (non-voting)\n- openstack-ansible-deploy-aio_distro_lxc-ubuntu-bionic http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_distro_lxc-ubuntu-bionic/fd6b75c/ : FAILURE in 1h 19m 32s (non-voting)\n- openstack-ansible-deploy-aio_metal-centos-7 http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_metal-centos-7/e539df6/ : SUCCESS in 1h 06m 09s\n- openstack-ansible-deploy-aio_metal-opensuse-150 http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_metal-opensuse-150/aa42424/ : FAILURE in 6m 14s (non-voting)\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/a1fa5e2/ : SUCCESS in 54m 37s\n- openstack-ansible-deploy-aio_metal-ubuntu-xenial http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_metal-ubuntu-xenial/1d79ec9/ : SUCCESS in 1h 01m 06s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_ceph-ubuntu-bionic/dc794b4/ : SUCCESS in 1h 47m 56s (non-voting)\n- openstack-ansible-deploy-aio_ceph-ubuntu-xenial http://logs.openstack.org/13/673713/1/check/openstack-ansible-deploy-aio_ceph-ubuntu-xenial/989c09b/ : SUCCESS in 1h 33m 54s","accounts_in_message":[],"_revision_number":1},{"id":"9320c0a912e381330bea1ab5b0095acb14e04c59","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2019-07-31 03:56:53.000000000","message":"Patch Set 1: Code-Review-1\n\nAre you sure that it works for VNC as well? Since for me it doesn\u0027t:\nIt\u0027s curl output for console url http://paste.openstack.org/show/755153/\n\nAnd it\u0027s output of haproxy right after your change http://paste.openstack.org/show/755155/","accounts_in_message":[],"_revision_number":1},{"id":"9ec34dfebff5a68086a3ee265c5d7e983980e2f0","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2019-07-31 17:30:46.000000000","message":"Patch Set 1:\n\nAre you seeing that specifically on rocky?\n\nI originally tested both spice and novnc against master, the logged errors stopped and checks continued to go through but don\u0027t remember seeing haproxy mark the backend as down.\n\nThe curl looks correct and should pass the check, I can do some more testing locally to try to reproduce though.","accounts_in_message":[],"_revision_number":1},{"id":"0de5d528163fe3bdf15fb1757de80466ca5f5235","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2019-07-31 22:42:15.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"a3d4b58bd41779c395eebe5fb9772596c336c244","author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"date":"2019-08-01 00:03:34.000000000","message":"Patch Set 1:\n\nThanks for catching this Dmitriy.\n\nReverting in master here:\nhttps://review.opendev.org/#/c/673929/\n\nIt\u0027s actually an empty response body so the check was marking the backends down.","accounts_in_message":[],"_revision_number":1},{"id":"31b6db0801c064729c937ec5b7b3b9d16bb594a1","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-10-13 20:30:32.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d7d2645eec2d88af246adb4b611bf0c29fa32cdb","revisions":{"d7d2645eec2d88af246adb4b611bf0c29fa32cdb":{"kind":"REWORK","_number":1,"created":"2019-07-30 23:59:30.000000000","uploader":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"ref":"refs/changes/13/673713/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/13/673713/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/673713/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/673713/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/673713/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/13/673713/1"}}},"commit":{"parents":[{"commit":"1205d19b314a54fcf3793016b7859d94b2bc52dc","subject":"Merge \"Set nodepool mirror PIP_OPTS consistently\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/1205d19b314a54fcf3793016b7859d94b2bc52dc"}]}],"author":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2019-07-23 07:41:07.000000000","tz":-300},"committer":{"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","date":"2019-07-30 23:59:30.000000000","tz":0},"subject":"Change haproxy http-check expect for nova_console","message":"Change haproxy http-check expect for nova_console\n\nChange the haproxy_backend_httpcheck_options to expect an \u0027OK\u0027 string\nrather than a 200 response to avoid constant logging of broken pipe\nerrors in the console proxy services\u0027 logs.\n\nChange-Id: I77b7e090aa4331e6a9547e0526a0f291f06a57c0\n(cherry picked from commit dc409a98e3d8b3c28cc884442776bd9b525cc851)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/d7d2645eec2d88af246adb4b611bf0c29fa32cdb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/d7d2645eec2d88af246adb4b611bf0c29fa32cdb"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}