)]}'
{"id":"openstack%2Fopenstack-ansible~676444","triplet_id":"openstack%2Fopenstack-ansible~master~I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8","project":"openstack/openstack-ansible","branch":"master","topic":"haproxy-ceph-rgw","hashtags":[],"change_id":"I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8","subject":"Ceph-RGW HAProxy config skipped when shouldnt","status":"MERGED","created":"2019-08-14 15:34:55.000000000","updated":"2019-08-19 09:14:04.000000000","submitted":"2019-08-16 15:18:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676444-1565968694881-ed945153","meta_rev_id":"97fc3d8063cd675463c59ed3191cb17c62d33826","_number":676444,"virtual_id_number":676444,"owner":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"date":"2019-08-15 00:29:08.000000000","_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":2,"date":"2019-08-16 15:18:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"all":[{"value":2,"date":"2019-08-16 12:25:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-15 12:26:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"all":[{"value":1,"date":"2019-08-16 12:25:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-15 00:29:08.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2019-08-15 12:26:14.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-08-16 12:25:31.000000000","updated_by":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"reviewer":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"state":"REVIEWER"},{"updated":"2019-08-16 15:18:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3ca64abae97e8516f4729ea758386fb7eda7af9c","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-08-14 15:34:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a94e43a2b4fac96117e6eac32cce2882129c0f87","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 18:06:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/f9f70966ed1c4c8bbb7c0ab8ec6d54ff : SUCCESS in 8m 20s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/700bde2c8db24c5f8f62f1ba3fe6b258 : SUCCESS in 8m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/328d582a1f0247c786a0bf07119cbe28 : SUCCESS in 8m 58s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/2c27c84b8bb54714959a945ed6ee15de : SUCCESS in 2h 15m 06s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/86482375312e4ad5add7bd70de7fd6ac : POST_FAILURE in 2h 09m 01s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/58edee783024427caceb758fc0e84644 : SUCCESS in 1h 51m 36s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/515903ce6ccd459c9c02ce4c48bf72f7 : SUCCESS in 1h 08m 43s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/f3c405f49e0a42658e7eff9060811e12 : SUCCESS in 1h 30m 29s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/b36b340abc964a2d922b8e6f438a3e3b : SUCCESS in 1h 19m 12s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3004ab2e1aee4fde87ea3871826ddf4d : SUCCESS in 1h 13m 35s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/7778a28965d54e79a7813272605d6b61 : SUCCESS in 1h 00m 42s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/5b2d95755ea94346a9f67608e2bd58e2 : SUCCESS in 51m 44s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/19a6231050654af997f0b06e8ebaadbd : SUCCESS in 51m 06s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c8f13ea1c4954e17b3e0c44565b7da9e : SUCCESS in 2h 11m 19s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3adfcfeff0c74a17a7c105607c5f052e : SUCCESS in 2h 17m 11s","accounts_in_message":[],"_revision_number":1},{"id":"670fd9104acb74a96022cfa58870cce253486593","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-08-15 00:29:08.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0524416592e30b7e0c2384b01b730d1109b59776","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 03:07:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/e72370ea640f43a190481b8b91c524ae : SUCCESS in 10m 08s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/e564adcb1b7349aab5d3b26827fe6237 : SUCCESS in 9m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca1f69a58ade47a5978b5bfd3e344567 : SUCCESS in 6m 11s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/710d7f9e1f5c4e9e99698bd1e4994d4a : SUCCESS in 2h 17m 27s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/01599149f40a44d3b16beb6718f7a145 : SUCCESS in 1h 49m 24s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e2064e2c0c534e5cbb5e176389c9f217 : SUCCESS in 1h 37m 26s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/0aa03827b7334969b02ccd883f4db890 : SUCCESS in 1h 00m 43s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/ff1a0220e2544b8bbb84e0877bd84639 : SUCCESS in 1h 15m 17s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/237574e7446e4442bdebc18957ac61f4 : SUCCESS in 1h 10m 39s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/382e7a66fd854d82b887e38598b16cfa : SUCCESS in 56m 29s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/7a8c5941b20d4abdbbb1579e58c8af54 : SUCCESS in 59m 50s\n- openstack-ansible-deploy-aio_distro_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/f054bac441bd4635a4dcb7c0a26edd18 : SUCCESS in 50m 57s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/846e5ce449054a45851e9190439182cf : SUCCESS in 45m 24s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/216e4ab2d75341bf8b9b9fe817379a9e : SUCCESS in 2h 25m 50s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9e4abdc0fe0543a5aa1ba6a8e54bb8ae : SUCCESS in 1h 31m 23s","accounts_in_message":[],"_revision_number":1},{"id":"666eb82dfe07393c740b32d5c1f45ff1351d2986","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-08-15 12:26:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5e99059ffa85c6c7e0a6dd05ba6252056a890e5f","author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"date":"2019-08-16 12:25:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4d40b8583416f0e4e35e46f6968eb3206c4098df","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 12:25:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7f2fcecfa58b2de963953a6279a969ac60f81be3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 15:18:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/d7fa143b608c4d75b0bcba2dfabec23c : SUCCESS in 10m 07s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/916dc6732acc4b93952f84f9bdccf32e : SUCCESS in 9m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/67c1a706e86942a9a2f8914ab8d1dddb : SUCCESS in 9m 11s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/462ee4d48fff479d84a2c6213a6b873f : SUCCESS in 2h 47m 00s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/8d12af0cf6194d89a576e041eef13177 : SUCCESS in 1h 54m 28s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2885897c2fd44b81adf6f25d1d0f015c : SUCCESS in 1h 51m 48s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/da853dcf790d4d37af922e2ae01e4913 : SUCCESS in 1h 18m 13s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/83a27885ede945bd9d7de9b0a0121a58 : SUCCESS in 1h 38m 04s\n- openstack-ansible-deploy-aio_metal-opensuse-15 https://zuul.opendev.org/t/openstack/build/7d5974fd4cd14305b703ba2dc145e97b : SUCCESS in 1h 21m 49s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d8f47c2fd8734a82962605e2b06d17f1 : SUCCESS in 1h 07m 52s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/5b7fcfa18c5249a195d02bed3ccf84ec : SUCCESS in 1h 20m 32s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c286c0e47a354636bf9c4a9be074abc2 : SUCCESS in 1h 12m 07s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/667fa01341574bdabc2d1be315957627 : SUCCESS in 2h 00m 00s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6556eed3c66341b292d063ec688336d1 : SUCCESS in 1h 55m 21s","accounts_in_message":[],"_revision_number":1},{"id":"dfcc561971c59fbc33b6d82c9fd6bab797907c41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 15:18:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"016b1121e9d98cd749e5f8989b2f83c3507a075e","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-08-19 09:14:04.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit b59f688673d929e37cb6390d42affa466f663ee8","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"00417b6856a4dd6363e85df95af67202d95c1529","revisions":{"00417b6856a4dd6363e85df95af67202d95c1529":{"kind":"REWORK","_number":1,"created":"2019-08-14 15:34:55.000000000","uploader":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"ref":"refs/changes/44/676444/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/44/676444/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/44/676444/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/44/676444/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/44/676444/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/44/676444/1"}}},"commit":{"parents":[{"commit":"95d4b5b04aa8c9be5d8d48ebd7b0a4b8a5abd20c","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/95d4b5b04aa8c9be5d8d48ebd7b0a4b8a5abd20c"}]}],"author":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-08-14 15:16:21.000000000","tz":60},"committer":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-08-14 15:16:21.000000000","tz":60},"subject":"Ceph-RGW HAProxy config skipped when shouldnt","message":"Ceph-RGW HAProxy config skipped when shouldnt\n\nNow that group ceph-rgw is in the default inventory (commit c700fdba)\nthe logic for haproxy_backend_nodes would always select the group\n\u0027ceph-rgw\u0027 as it will always be defined, regardless of length.\n\nIf using the ceph_rgws variable instead of the ceph-rgws group it\nmeant that the haproxy_backend_nodes equated to an empty group.\nSo the \u0027when\u0027 criteria in haproxy_service_config.yml did not get met\nand the services config was not provisioned.\n\nThis fix checks the length of the ceph-rgws group.\nIf its not greater than zero, haproxy_backend_nodes is defaulted\nback to ceph_rgws.\n\nChange-Id: I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/00417b6856a4dd6363e85df95af67202d95c1529"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/00417b6856a4dd6363e85df95af67202d95c1529"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}