)]}'
{"id":"openstack%2Fopenstack-ansible~677153","triplet_id":"openstack%2Fopenstack-ansible~stable%2Fstein~I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8","project":"openstack/openstack-ansible","branch":"stable/stein","topic":"haproxy-ceph-rgw-stable/stein","hashtags":[],"change_id":"I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8","subject":"Ceph-RGW HAProxy config skipped when shouldnt","status":"MERGED","created":"2019-08-19 09:14:04.000000000","updated":"2019-08-20 05:09:02.000000000","submitted":"2019-08-20 05:09:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677153-1566277742716-ac68746e","meta_rev_id":"e2e14c94a84c3100dd7fc1125b110b3956fb8485","_number":677153,"virtual_id_number":677153,"owner":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":2,"date":"2019-08-20 05:09:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"all":[{"value":2,"date":"2019-08-20 02:41:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-19 11:15:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"all":[{"value":1,"date":"2019-08-20 02:41:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-19 11:15:52.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2019-08-20 02:41:53.000000000","updated_by":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"reviewer":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"state":"REVIEWER"},{"updated":"2019-08-20 05:09:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f7bc33d780288bc084c876eeafdfc373e440869f","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2019-08-19 09:14:04.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"7239f0166ff931ac5ff243c427e842b4e2547d71","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 11:13:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/6b4d6fc140ed4b0aa86b26f8ea19f8b0 : SUCCESS in 8m 42s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/831016cb306c4eb098998708cc4fdcae : SUCCESS in 8m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/288b503fd3334150be93b8ea21c9dc11 : SUCCESS in 5m 30s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/b8947b3cfddb4c158a307e65ace5851f : SUCCESS in 1h 58m 04s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/578319bdd00e4b6598b17ff38766a7a6 : SUCCESS in 1h 51m 36s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a04f3cb23cc848839f78a904d1f38c4d : SUCCESS in 1h 27m 53s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/d750647abad84bcea7b7939785e44690 : SUCCESS in 1h 20m 02s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/847374f6be2b4f7cb9f294788a13b7c2 : SUCCESS in 1h 08m 45s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9840091d1a824e9294e31b1f60ae57c8 : SUCCESS in 58m 43s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/ea86cdd47f484d5eadb2006cc4029ef1 : SUCCESS in 58m 01s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c304d2888155479ba9237b6176ff5128 : SUCCESS in 59m 18s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7302a636d09b40ecaf00648ec5bef13b : SUCCESS in 1h 49m 16s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f48b2569c88f4cf2af0968a6b680c460 : SUCCESS in 1h 50m 32s","accounts_in_message":[],"_revision_number":1},{"id":"2e8dab93717852c6c18771abaa9ddacdc9d159ab","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2019-08-19 11:15:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cc73245fc499f301c880f163757d40cd65761d43","author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"date":"2019-08-20 02:41:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8f42ed7afeb8638f1922a91724858280a083f084","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 02:42:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8674033fe68b7cd4e38090e5fbfec4bd9008f7f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 05:09:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/68f1be47c2b04ad08e0b335a1ec8872d : SUCCESS in 13m 49s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/b9baed6855e04c478aee38fb4293c9b4 : SUCCESS in 7m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7eff1dc772cf46e0bcc9c0affc91046f : SUCCESS in 6m 13s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/faa14ce3e91946f38a17e65e64cefc40 : SUCCESS in 2h 25m 30s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/8c790f2ca89f42a69ea8bb406c24f31c : SUCCESS in 1h 39m 57s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e99102bca5db47a0a295a974da17e181 : SUCCESS in 1h 41m 57s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/c392b70a092c40baadb059cfcd1212e9 : SUCCESS in 1h 00m 00s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/eb3741f90c26474b870fc789812055fd : SUCCESS in 1h 13m 13s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f65e120957004383bf468216add80e22 : SUCCESS in 1h 01m 25s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/41477e9104f64db880451776ab23c104 : SUCCESS in 54m 19s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6c011d689a6c4df282970efe173b85bb : SUCCESS in 47m 55s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/65b8f13f11734db1962700e89edb8b03 : SUCCESS in 1h 52m 49s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a39c2d7d88a3436dad0beae7661c8f44 : SUCCESS in 1h 41m 55s","accounts_in_message":[],"_revision_number":1},{"id":"914f62f29d3092b6fb1453c7ae7849ff8321bfcb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 05:09:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b59f688673d929e37cb6390d42affa466f663ee8","revisions":{"b59f688673d929e37cb6390d42affa466f663ee8":{"kind":"REWORK","_number":1,"created":"2019-08-19 09:14:04.000000000","uploader":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"ref":"refs/changes/53/677153/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/53/677153/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/53/677153/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/53/677153/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/53/677153/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/53/677153/1"}}},"commit":{"parents":[{"commit":"2466e0dfcddb829b3fdb8f1252e04277db89f4ed","subject":"Merge \"Fix systemd-journal-remote socket dependency\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/2466e0dfcddb829b3fdb8f1252e04277db89f4ed"}]}],"author":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-08-14 15:16:21.000000000","tz":60},"committer":{"name":"Georgina Shippey","email":"georgina.shippey@bbc.co.uk","date":"2019-08-19 09:14:04.000000000","tz":0},"subject":"Ceph-RGW HAProxy config skipped when shouldnt","message":"Ceph-RGW HAProxy config skipped when shouldnt\n\nNow that group ceph-rgw is in the default inventory (commit c700fdba)\nthe logic for haproxy_backend_nodes would always select the group\n\u0027ceph-rgw\u0027 as it will always be defined, regardless of length.\n\nIf using the ceph_rgws variable instead of the ceph-rgws group it\nmeant that the haproxy_backend_nodes equated to an empty group.\nSo the \u0027when\u0027 criteria in haproxy_service_config.yml did not get met\nand the services config was not provisioned.\n\nThis fix checks the length of the ceph-rgws group.\nIf its not greater than zero, haproxy_backend_nodes is defaulted\nback to ceph_rgws.\n\nChange-Id: I7ac3e3ba9e64b38ec22704394fcd5f402dd9d7f8\n(cherry picked from commit 00417b6856a4dd6363e85df95af67202d95c1529)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/b59f688673d929e37cb6390d42affa466f663ee8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/b59f688673d929e37cb6390d42affa466f663ee8"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
