)]}'
{"playbooks/common-tasks/tempest-resources.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5da9024aafe612190a06e4003ba5f3a92ea44025","unresolved":true,"context_lines":[{"line_number":53,"context_line":"      delay: 5"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Upload tempest images to glance"},{"line_number":56,"context_line":"      os_image:"},{"line_number":57,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":58,"context_line":"        interface: \"{{ tempest_interface_name }}\""},{"line_number":59,"context_line":"        validate_certs: \"{{ not (tempest_keystone_interface_insecure | bool) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e6235e78_fa4fd047","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":14},"updated":"2020-11-25 16:53:12.000000000","message":"I think we should use openstack.cloud.image","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b0e3e1271c4b441e1790e2b8d2240f336bdfb3bd","unresolved":true,"context_lines":[{"line_number":53,"context_line":"      delay: 5"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Upload tempest images to glance"},{"line_number":56,"context_line":"      os_image:"},{"line_number":57,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":58,"context_line":"        interface: \"{{ tempest_interface_name }}\""},{"line_number":59,"context_line":"        validate_certs: \"{{ not (tempest_keystone_interface_insecure | bool) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ed8a6f92_c103bc2f","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":14},"in_reply_to":"e6235e78_fa4fd047","updated":"2021-03-17 14:01:12.000000000","message":"agreed.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5da9024aafe612190a06e4003ba5f3a92ea44025","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        tempest_glance_image_id_2: \"{{ tempest_service_available_glance | ternary(tempest_image_create[\u0027results\u0027][-1][\u0027id\u0027], \u0027\u0027) }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    - name: Add tempest projects"},{"line_number":82,"context_line":"      os_project:"},{"line_number":83,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":84,"context_line":"        state: present"},{"line_number":85,"context_line":"        name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a4e32fcf_bcd1f616","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":16},"updated":"2020-11-25 16:53:12.000000000","message":"openstack.cloud.project","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b0e3e1271c4b441e1790e2b8d2240f336bdfb3bd","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        tempest_glance_image_id_2: \"{{ tempest_service_available_glance | ternary(tempest_image_create[\u0027results\u0027][-1][\u0027id\u0027], \u0027\u0027) }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    - name: Add tempest projects"},{"line_number":82,"context_line":"      os_project:"},{"line_number":83,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":84,"context_line":"        state: present"},{"line_number":85,"context_line":"        name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dd1271ee_ca991b01","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":16},"in_reply_to":"a4e32fcf_bcd1f616","updated":"2021-03-17 14:01:12.000000000","message":"agreed.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5da9024aafe612190a06e4003ba5f3a92ea44025","unresolved":true,"context_lines":[{"line_number":94,"context_line":"      with_items: \"{{ tempest_projects }}\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    - name: Add tempest users"},{"line_number":97,"context_line":"      os_user:"},{"line_number":98,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":99,"context_line":"        state: present"},{"line_number":100,"context_line":"        name: \"{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c858f00d_0005cb00","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":13},"updated":"2020-11-25 16:53:12.000000000","message":"openstack.cloud.user","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b0e3e1271c4b441e1790e2b8d2240f336bdfb3bd","unresolved":true,"context_lines":[{"line_number":94,"context_line":"      with_items: \"{{ tempest_projects }}\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    - name: Add tempest users"},{"line_number":97,"context_line":"      os_user:"},{"line_number":98,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":99,"context_line":"        state: present"},{"line_number":100,"context_line":"        name: \"{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"995d4759_30b8aa7e","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":13},"in_reply_to":"c858f00d_0005cb00","updated":"2021-03-17 14:01:12.000000000","message":"agreed.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5da9024aafe612190a06e4003ba5f3a92ea44025","unresolved":true,"context_lines":[{"line_number":111,"context_line":"      no_log: True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    - name: Add tempest roles"},{"line_number":114,"context_line":"      os_keystone_role:"},{"line_number":115,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":116,"context_line":"        interface: \"{{ tempest_interface_name }}\""},{"line_number":117,"context_line":"        validate_certs: \"{{ not (tempest_keystone_interface_insecure | bool) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa817c7f_919b85ec","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":22},"updated":"2020-11-25 16:53:12.000000000","message":"ditto","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b0e3e1271c4b441e1790e2b8d2240f336bdfb3bd","unresolved":true,"context_lines":[{"line_number":111,"context_line":"      no_log: True"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    - name: Add tempest roles"},{"line_number":114,"context_line":"      os_keystone_role:"},{"line_number":115,"context_line":"        cloud: \"{{ tempest_cloud_name }}\""},{"line_number":116,"context_line":"        interface: \"{{ tempest_interface_name }}\""},{"line_number":117,"context_line":"        validate_certs: \"{{ not (tempest_keystone_interface_insecure | bool) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1d3f32bb_5c2c993e","line":114,"range":{"start_line":114,"start_character":6,"end_line":114,"end_character":22},"in_reply_to":"fa817c7f_919b85ec","updated":"2021-03-17 14:01:12.000000000","message":"agreed.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"}],"playbooks/os-tempest-install.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5da9024aafe612190a06e4003ba5f3a92ea44025","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    - \"defaults/repo_packages/openstack_testing.yml\""},{"line_number":29,"context_line":"    - \"defaults/{{ install_method }}_install.yml\""},{"line_number":30,"context_line":"  pre_tasks:"},{"line_number":31,"context_line":"    - include_tasks: \"common-tasks/tempest-resources.yml\""},{"line_number":32,"context_line":"    - name: End playbook"},{"line_number":33,"context_line":"      meta: end_play"},{"line_number":34,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c9328e06_b990dfa3","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":19},"updated":"2020-11-25 16:53:12.000000000","message":"I\u0027d do it only conditionally as we again forget about usecase where you don;t want to create resources.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1bff0279864c2aa4d1b98f46356cf858b00715b2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    - \"defaults/repo_packages/openstack_testing.yml\""},{"line_number":29,"context_line":"    - \"defaults/{{ install_method }}_install.yml\""},{"line_number":30,"context_line":"  pre_tasks:"},{"line_number":31,"context_line":"    - include_tasks: \"common-tasks/tempest-resources.yml\""},{"line_number":32,"context_line":"    - name: End playbook"},{"line_number":33,"context_line":"      meta: end_play"},{"line_number":34,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"05264d1f_92ad3dc3","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":19},"in_reply_to":"be8c84ba_73d4b400","updated":"2021-03-17 14:08:29.000000000","message":"What I meant is that we need to add `when` condition here for including resources creation, to be able to avoid resources creation even here, in case deployer provides all required stuff for tempest conf","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b0e3e1271c4b441e1790e2b8d2240f336bdfb3bd","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    - \"defaults/repo_packages/openstack_testing.yml\""},{"line_number":29,"context_line":"    - \"defaults/{{ install_method }}_install.yml\""},{"line_number":30,"context_line":"  pre_tasks:"},{"line_number":31,"context_line":"    - include_tasks: \"common-tasks/tempest-resources.yml\""},{"line_number":32,"context_line":"    - name: End playbook"},{"line_number":33,"context_line":"      meta: end_play"},{"line_number":34,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"be8c84ba_73d4b400","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":19},"in_reply_to":"c9328e06_b990dfa3","updated":"2021-03-17 14:01:12.000000000","message":"So, set this up as a separate task prior to this one? And make it conditional (default to no)?\n\nThe resource tasks currently live in os_tempest and are deployed by default. The intention here IIRC was to not change existing behavior, but rather introduce the option to not deploy default resources and let the deployer (or OSA) have a unique set of resources vs other users of os_tempest (i.e. Red Hat) and reduce the number of resources created in os_tempest that wouldn\u0027t apply to everyone.\n\nRelated: https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/733892","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"}],"tests/roles/bootstrap-host/templates/user_variables.aio.yml.j2":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5da9024aafe612190a06e4003ba5f3a92ea44025","unresolved":true,"context_lines":[{"line_number":221,"context_line":"tempest_install: yes"},{"line_number":222,"context_line":"tempest_run: yes"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"## Implement OSA tempest resources rather than role defaults"},{"line_number":225,"context_line":"tempest_default_role_resources: no"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"# Do a gateway ping test once the tempest role creates it"},{"line_number":228,"context_line":"tempest_network_ping_gateway: yes"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"802d395d_5af7a79f","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":34},"updated":"2020-11-25 16:53:12.000000000","message":"I\u0027d rather set it to group_vars so by default when user deploys tempest it won\u0027t get them unless specificly asked.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"b0e3e1271c4b441e1790e2b8d2240f336bdfb3bd","unresolved":true,"context_lines":[{"line_number":221,"context_line":"tempest_install: yes"},{"line_number":222,"context_line":"tempest_run: yes"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"## Implement OSA tempest resources rather than role defaults"},{"line_number":225,"context_line":"tempest_default_role_resources: no"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"# Do a gateway ping test once the tempest role creates it"},{"line_number":228,"context_line":"tempest_network_ping_gateway: yes"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"a9d26296_3becff63","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":34},"in_reply_to":"802d395d_5af7a79f","updated":"2021-03-17 14:01:12.000000000","message":"Not quite sure I understand this...","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1bff0279864c2aa4d1b98f46356cf858b00715b2","unresolved":true,"context_lines":[{"line_number":221,"context_line":"tempest_install: yes"},{"line_number":222,"context_line":"tempest_run: yes"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"## Implement OSA tempest resources rather than role defaults"},{"line_number":225,"context_line":"tempest_default_role_resources: no"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"# Do a gateway ping test once the tempest role creates it"},{"line_number":228,"context_line":"tempest_network_ping_gateway: yes"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ffc8fe4c_1d1d424d","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":34},"in_reply_to":"a9d26296_3becff63","updated":"2021-03-17 14:08:29.000000000","message":"I mean put it somewhere here https://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/group_vars/utility_all.yml#L80\n\nas this scope is only valid for CI and AIO but not for real deployments.","commit_id":"9c60eebbe2d72cd5c0ba207a832d8692845a5122"}]}