)]}'
{"id":"openstack%2Fopenstack-ansible~740343","triplet_id":"openstack%2Fopenstack-ansible~master~Ic1acfea71f27f94e277aa443f0a53ef16b4eb417","project":"openstack/openstack-ansible","branch":"master","topic":"fix-keyerror-osa_toolkit-generate","hashtags":[],"change_id":"Ic1acfea71f27f94e277aa443f0a53ef16b4eb417","subject":"Fix KeyError raised when max hostname length exceeded","status":"MERGED","created":"2020-07-09 18:01:31.000000000","updated":"2020-07-10 10:45:59.000000000","submitted":"2020-07-10 09:58:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"740343-1594375122687-9763ba5f","meta_rev_id":"82156f5de5c0e0efc3102cd9389f68fd191e01f1","_number":740343,"virtual_id_number":740343,"owner":{"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-07-09 18:01:46.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-10 09:58:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":2,"date":"2020-07-09 20:09:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-10 07:34:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-07-10 07:34:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-09 18:01:46.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2020-07-09 20:09:37.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"},{"updated":"2020-07-10 07:34:33.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2020-07-10 09:58:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3ef0e57626378c78a8a075addd0ff073723eedd7","author":{"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},"date":"2020-07-09 18:01:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f5e040f794eee6820afdad4f68eb2cc190ddc43","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2020-07-09 18:01:46.000000000","message":"Patch Set 1:\n\nCongratulations, you\u0027ve proposed your first change in OpenDev.\n\nYour submission will now be tested automatically by Zuul, our gatekeeper,\nand reviewed by other friendly developers. They will give you feedback and\nmay require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches often take days (and sometimes weeks) to get reviewed, so be\npatient. Don\u0027t hesitate to ask for help, and answer questions about your\nwork promptly if you can. The more you get to know reviewers and get to be\nknown by them, the smoother the review and approval process will become. The\nfastest way to accomplish this is by reviewing other proposed changes\nyourself: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for participating in OpenDev, we look forward to seeing you\naround.\n\nWorkflow Guide: https://docs.openstack.org/infra/manual/developers.html","accounts_in_message":[],"_revision_number":1},{"id":"6178d37db76c6e3fe5821322abef866bce7676a7","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-07-09 20:09:37.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"e28616d7babd9b05d4d72a0840f55c3abed3cbbd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-09 20:34:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/52e5122586d4435f8bdee44371612f10 : SUCCESS in 12m 36s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/2c0cf118fe7a4b13bde1574507cf88c3 : SUCCESS in 14m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/014e4c5f9ddb4c2793a3f267c1ef29fc : SUCCESS in 12m 28s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/8c6306e236c7459892ebfc50b1d82fe9 : SUCCESS in 2h 14m 06s\n- openstack-ansible-deploy-aio_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/51ed7b518f37464eac561a8b3effa924 : SUCCESS in 2h 23m 04s\n- openstack-ansible-deploy-aio_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/0850a6706dbd43009df0c001c0a01f19 : SUCCESS in 1h 51m 02s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/411b658c3f6f47daa35ab1945d2b25cf : SUCCESS in 1h 33m 40s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bfdf5e0b42504ea2b021956360f85696 : SUCCESS in 1h 13m 56s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/1d7b6f621e8e4fc4b1a6da153602e3ec : SUCCESS in 1h 28m 37s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/11b1841cfd3f4bc1aa5b83509782fe36 : SUCCESS in 55m 19s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/873a7ace17644f00b11022468ce6f23a : SUCCESS in 1h 38m 11s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4243d6d0cf32444f8c18394787b18fc7 : SUCCESS in 1h 13m 39s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b75294a0b598467fb1810bec180d3c51 : SUCCESS in 2h 11m 55s\n- openstack-ansible-upgrade-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/733d738ddf9b42baa42c1076fef53a76 : SUCCESS in 2h 05m 41s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/82694813783541979a3ee533769b6c41 : SUCCESS in 1h 49m 16s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/699773ac74be4cfc8c89cc9b5d782ed6 : SUCCESS in 1h 05m 01s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/70cf79eb8ff14e98bef46016bef6db6e : SUCCESS in 1h 07m 53s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6e4464c50d294a18a2fd8e6478b9181d : SUCCESS in 56m 31s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/72a88b616d5140edb794c9fc998e3e91 : SUCCESS in 2h 18m 21s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/45a42dec16d04eb68f494a4d8a0d029d : FAILURE in 44m 26s (non-voting)\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/331ce3653b3243f7bc270d80fcd5c28a : SUCCESS in 2h 22m 56s","accounts_in_message":[],"_revision_number":1},{"id":"7776f4b19900e83f09ea993a5abd082835bd7ec6","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-07-10 07:34:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"19cbee15bbe0c0ea2d9551695e4450ac165822f5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 07:34:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3d36d91bcd1fb85245dbb16c65ffaa236a8c2705","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 09:58:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/33f48f8838254a9682e44bc8bae87aab : SUCCESS in 11m 27s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/33fcdd5aa3084c8e9034d416eb7ce193 : SUCCESS in 13m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab397ebb9f0f465d87c2d7bbfbf27756 : SUCCESS in 12m 02s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/fac4ef019a0844568850116b5c76d7de : SUCCESS in 2h 13m 26s\n- openstack-ansible-deploy-aio_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/53806a2473614ee58d7dedba802a3dc3 : SUCCESS in 2h 04m 53s\n- openstack-ansible-deploy-aio_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/c1236d3a8caf4805a51ae263f7c2805f : SUCCESS in 1h 46m 29s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b8d627a79e4d43d3a8285d41de98bc19 : SUCCESS in 1h 52m 19s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/aa231e72d9434b3fab8ef7fa8a6a8074 : SUCCESS in 1h 39m 07s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/d501dda67d924aaaa42d949a32ba24c0 : SUCCESS in 1h 11m 32s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/17a4574350144667b9040fdd25049d8e : SUCCESS in 1h 22m 35s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/17b14ec673774cd0b660ccb4544fecc0 : SUCCESS in 1h 13m 41s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e1416835860e4c9f9bca2eb6c290c67d : SUCCESS in 1h 38m 08s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/9f07e9b3aec741a5969a5d6a3b2212fa : SUCCESS in 1h 02m 53s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/e5fd2977e40345d0bdab6313cbe09df8 : SUCCESS in 1h 03m 16s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d80a735ad1e743db940b9ae8bdbd61f8 : SUCCESS in 1h 03m 33s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/094caba616dd43d0824264e9754d7e25 : SUCCESS in 2h 21m 48s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2814d0e27bdf497f9b3ccd1f39f2bc01 : SUCCESS in 1h 40m 59s","accounts_in_message":[],"_revision_number":1},{"id":"871f165b3181479c17460894cdb18d9041068588","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 09:58:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1e5a416457a3a14455e5a2cbaa6c241b4ae52d1f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 10:01:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8feca487e274452bc3d9531a2e2eb9c : SUCCESS in 2m 36s","accounts_in_message":[],"_revision_number":1},{"id":"7061d7476daff3d9d2fc6b20039eb02dc998f400","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-07-10 10:45:17.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit 59deac41ea535d66d98cad28f85cdf57572c1acb","accounts_in_message":[],"_revision_number":1},{"id":"22303962105aa3620516542698662253b65a27e6","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-07-10 10:45:42.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit 664d9457f842b3c2b1e0cf6f90fffd727ea6011f","accounts_in_message":[],"_revision_number":1},{"id":"1371446aff1666546e9ad964a585fb1128098931","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-07-10 10:45:59.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit f59ee5bdb6dc8c0acda8cef4a70e38b7f19e9060","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d2657174ceaf289ad60ba7291a8a9eed10c26687","revisions":{"d2657174ceaf289ad60ba7291a8a9eed10c26687":{"kind":"REWORK","_number":1,"created":"2020-07-09 18:01:31.000000000","uploader":{"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},"ref":"refs/changes/43/740343/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/43/740343/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740343/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740343/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740343/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740343/1"}}},"commit":{"parents":[{"commit":"8760541cedd7bda736449007accf235f2b5fea23","subject":"Merge \"Fix tmpfiles-setup wait handler\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/8760541cedd7bda736449007accf235f2b5fea23"}]}],"author":{"name":"Ryan Drew","email":"learnitall0@gmail.com","date":"2020-07-09 18:01:00.000000000","tz":-360},"committer":{"name":"Ryan Drew","email":"learnitall0@gmail.com","date":"2020-07-09 18:01:00.000000000","tz":-360},"subject":"Fix KeyError raised when max hostname length exceeded","message":"Fix KeyError raised when max hostname length exceeded\n\nThe function osa_toolkit.generate._add_container_hosts contains a bug in\nthe code used to check if provided hostnames have exceeded their max\nallowed length. The logic used to perform this check depends on the\n`is_metal` flag within each container\u0027s properties. Unfortunately the\n`is_metal` flag is accessed within the `properties` dictionary using\nbracket notation rather than the safer `dict.get` method, causing a\n`KeyError` to be raised when a host\u0027s properties dictionary does not\ncontain the `is_metal` flag.\n\nIt is not expected that a `KeyError` would be raised in the function if\nhostnames have exceeded their max length. It is instead expected that a\n`SystemExit` exception would be raised warning the user of their invalid\nhostname(s).\n\nThis bug will impacts deployments where hostnames actually do exceed the\nmax allowed length due to the short circuit logic used in the if-elif\ntree.\n\nCloses-Bug: #1886905\n\nChange-Id: Ic1acfea71f27f94e277aa443f0a53ef16b4eb417\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/d2657174ceaf289ad60ba7291a8a9eed10c26687"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/d2657174ceaf289ad60ba7291a8a9eed10c26687"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}