)]}'
{"id":"openstack%2Fopenstack-ansible~740443","triplet_id":"openstack%2Fopenstack-ansible~stable%2Fstein~Ic1acfea71f27f94e277aa443f0a53ef16b4eb417","project":"openstack/openstack-ansible","branch":"stable/stein","topic":"fix-keyerror-osa_toolkit-generate-stable/stein","hashtags":[],"change_id":"Ic1acfea71f27f94e277aa443f0a53ef16b4eb417","subject":"Fix KeyError raised when max hostname length exceeded","status":"MERGED","created":"2020-07-10 10:45:59.000000000","updated":"2020-07-13 18:34:45.000000000","submitted":"2020-07-13 18:32:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"740443-1594665177378-2400accf","meta_rev_id":"a73b0ab0e1b42dca54ea857379f24f9106a1a005","_number":740443,"virtual_id_number":740443,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},{"value":0,"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-13 18:32:57.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"all":[{"value":0,"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},{"value":2,"date":"2020-07-13 14:12:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-11 14:08:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"all":[{"value":0,"date":"2020-07-10 10:45:59.000000000","_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},{"value":1,"date":"2020-07-13 14:12:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},{"value":0,"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},{"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-10 10:45:59.000000000","updated_by":{"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},"reviewer":{"_account_id":32176,"name":"Ryan Drew","email":"learnitall0@gmail.com","username":"learnitall"},"state":"REVIEWER"},{"updated":"2020-07-11 14:08:19.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2020-07-13 14:12:38.000000000","updated_by":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"reviewer":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"state":"REVIEWER"},{"updated":"2020-07-13 18:32:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed5d42c40cee1508b22406bdee2e100ecb731594","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-07-10 10:45:59.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"57ee42c7cc52cb8ed591bd704f9ed2fff6e66a89","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 13:00:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/10b9bb27ab4f4da09b5ce06d87c81d8d : SUCCESS in 12m 40s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/9639147bf0e6419ea88d38e6790e35f3 : SUCCESS in 9m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/650d474e22e648f5882d342c65acd3e7 : SUCCESS in 6m 23s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/67fcc67d851e48dcb9eeb4f95893dda0 : SUCCESS in 2h 09m 20s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/fb5745abc2df434c8d4faea11b78076c : SUCCESS in 1h 40m 15s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a8d4a3537f344f13a6463b9194ebde9e : SUCCESS in 1h 15m 41s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/03fc62b8a9ae46a8b82aaab0e9773bec : SUCCESS in 45m 18s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/c2715541c3f04c30a3374771caeae9db : SUCCESS in 1h 17m 43s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c620e92a8ff64278a3cc999d6bd61fe7 : SUCCESS in 57m 33s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/ac9b0a2bff2a43779ac3f2b41c21088a : SUCCESS in 1h 00m 31s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0c41b33a3dcb4dc3a30990c51aba6f25 : SUCCESS in 44m 21s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4da08f1bc2f0405597dff558298b62a0 : SUCCESS in 1h 46m 40s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ad49d19d2dc64e4e8de4b162b2c4b231 : SUCCESS in 1h 43m 32s","accounts_in_message":[],"_revision_number":1},{"id":"26f2bcc65aeee6ac39acf9bb3cfeed5bfd218349","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-07-11 14:08:19.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"15e6b5906a281b5dd0857388aeeb2fdb53a3578b","author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"date":"2020-07-13 14:12:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e45f9acf7094743b5bfd659a55f637664df726b3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 14:12:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"98527a5d155a3c7ccda10439afb0525fc2611a06","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 18:32:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"41d38b5ab0905eb166d9d65c13fb459d87ef3225","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 18:32:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/33a763926a364f399b94cdcb878cd2df : SUCCESS in 10m 27s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/fb373e0fc58b459eb7c2300343e6f6d6 : SUCCESS in 13m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a29d3eb10d843168d8b99d17eeed462 : SUCCESS in 10m 28s\n- openstack-ansible-deploy-aio_lxc-centos-7 https://zuul.opendev.org/t/openstack/build/47e670db14e241ab803c386d8d22bd70 : SUCCESS in 2h 19m 11s\n- openstack-ansible-deploy-aio_lxc-debian-stable https://zuul.opendev.org/t/openstack/build/8111028574f04bd88ccf44f9dcec5261 : SUCCESS in 1h 34m 32s\n- openstack-ansible-deploy-aio_lxc-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/531fefd7432c4fd9a785abced0143d22 : SUCCESS in 1h 31m 33s\n- openstack-ansible-deploy-aio_metal-debian-stable https://zuul.opendev.org/t/openstack/build/ce482fce417e4b18bcdadbee8aab9759 : SUCCESS in 1h 06m 08s\n- openstack-ansible-deploy-aio_metal-centos-7 https://zuul.opendev.org/t/openstack/build/cbf9c3e808ae4f63a8bb01214532f216 : SUCCESS in 1h 21m 01s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bc7b336251834ad8b02ab189c28601c1 : SUCCESS in 1h 46m 03s\n- openstack-ansible-deploy-aio_distro_metal-centos-7 https://zuul.opendev.org/t/openstack/build/1525c3c204b14fa7a5f26469ca9536a2 : SUCCESS in 1h 08m 10s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d6486f2dcb8049ca863bf5a9d6c96c1e : SUCCESS in 45m 06s\n- openstack-ansible-deploy-aio_ceph-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6cbffa9e040f45afac9224dbeeca8664 : SUCCESS in 2h 07m 49s\n- openstack-ansible-deploy-aio_proxy-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/01321ab04b4d4d078592c646eefa5644 : SUCCESS in 1h 33m 15s","accounts_in_message":[],"_revision_number":1},{"id":"2b47749fd1f59258acd8508d73c915f21c2cbb44","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 18:34:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1daaed112f6b4269836414002300fc5d : SUCCESS in 1m 26s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f59ee5bdb6dc8c0acda8cef4a70e38b7f19e9060","revisions":{"f59ee5bdb6dc8c0acda8cef4a70e38b7f19e9060":{"kind":"REWORK","_number":1,"created":"2020-07-10 10:45:59.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/43/740443/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/43/740443/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740443/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740443/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740443/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/43/740443/1"}}},"commit":{"parents":[{"commit":"9a73b8d49501246d3dbb21c0469a7ec9e4ae9562","subject":"Bump SHAs for stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/9a73b8d49501246d3dbb21c0469a7ec9e4ae9562"}]}],"author":{"name":"Ryan Drew","email":"learnitall0@gmail.com","date":"2020-07-09 18:01:00.000000000","tz":-360},"committer":{"name":"Dmitriy Rabotyagov (noonedeadpunk)","email":"noonedeadpunk@ya.ru","date":"2020-07-10 10:45:59.000000000","tz":0},"subject":"Fix KeyError raised when max hostname length exceeded","message":"Fix KeyError raised when max hostname length exceeded\n\nThe function osa_toolkit.generate._add_container_hosts contains a bug in\nthe code used to check if provided hostnames have exceeded their max\nallowed length. The logic used to perform this check depends on the\n`is_metal` flag within each container\u0027s properties. Unfortunately the\n`is_metal` flag is accessed within the `properties` dictionary using\nbracket notation rather than the safer `dict.get` method, causing a\n`KeyError` to be raised when a host\u0027s properties dictionary does not\ncontain the `is_metal` flag.\n\nIt is not expected that a `KeyError` would be raised in the function if\nhostnames have exceeded their max length. It is instead expected that a\n`SystemExit` exception would be raised warning the user of their invalid\nhostname(s).\n\nThis bug will impacts deployments where hostnames actually do exceed the\nmax allowed length due to the short circuit logic used in the if-elif\ntree.\n\nCloses-Bug: #1886905\n\nChange-Id: Ic1acfea71f27f94e277aa443f0a53ef16b4eb417\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/f59ee5bdb6dc8c0acda8cef4a70e38b7f19e9060"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/f59ee5bdb6dc8c0acda8cef4a70e38b7f19e9060"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}