)]}'
{"id":"openstack%2Fopenstack-ansible~767513","triplet_id":"openstack%2Fopenstack-ansible~master~I3c57c3aab3cacfd5732b9bf5e251a7a8b654d4f5","project":"openstack/openstack-ansible","branch":"master","topic":"1908510","hashtags":[],"change_id":"I3c57c3aab3cacfd5732b9bf5e251a7a8b654d4f5","subject":"Fix keystone IDP setup","status":"MERGED","created":"2020-12-17 11:08:50.000000000","updated":"2021-01-04 12:26:02.000000000","submitted":"2021-01-04 12:23:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"767513-1908510","meta_rev_id":"e92fd2cc2e469f223cf9f7672c79d33262c07944","_number":767513,"virtual_id_number":767513,"owner":{"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-04 12:23:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"all":[{"value":2,"date":"2021-01-04 09:19:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":1,"date":"2020-12-17 18:08:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-12-17 22:41:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"all":[{"value":1,"date":"2021-01-04 09:19:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-17 14:51:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-17 22:41:00.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"},{"updated":"2021-01-04 09:19:13.000000000","updated_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"reviewer":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"state":"REVIEWER"}],"messages":[{"id":"6d8240d860aab1950a7cfc24391989ceb1ecbceb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},"date":"2020-12-17 11:08:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad2b796d3d9924a79aa618d0f3f3bb9082853eac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-12-17 11:58:05.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"f4eb8cfb9dd9ec210de8e1f215ab1eb7a5b31232","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 14:51:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/e1c73404f86c459da703942b08e8be7d : SUCCESS in 10m 32s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/236030c1c6eb4ea7a8206e4f3ca5e348 : SUCCESS in 12m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3cc88f9339254c8a8dc28e9e05db6632 : SUCCESS in 10m 47s\n- openstack-ansible-deploy-aio_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/291b6854cbc74595b0b37328dcba02b4 : SUCCESS in 2h 08m 26s\n- openstack-ansible-deploy-aio_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/620dfb20a1ff42d1aa56f9828e3a3bfa : SUCCESS in 1h 50m 05s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2b7b09038f684a0fb57df5a8f487a6f8 : SUCCESS in 1h 36m 33s\n- openstack-ansible-deploy-aio_ovn_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9913cd041d0a4da0b0084c4a5b11fa79 : SUCCESS in 1h 43m 48s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/7c859083a8964b2c9c1a0632b8218319 : SUCCESS in 1h 09m 46s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/ea2d411ec65f4e4a967bd71da383054a : SUCCESS in 1h 24m 41s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/75549e0a9c63473b97599f00780c4d8a : SUCCESS in 1h 32m 14s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/539575e9e737458bb3d2c3ed682789c1 : SUCCESS in 1h 18m 51s\n- openstack-ansible-upgrade-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/fbde23cb97d647688a587fcdc4cb1c93 : FAILURE in 17m 03s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f2fde55b9a2441cfa9e3596862be9535 : SUCCESS in 1h 33m 59s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/6398661bb069498996310ea064cc0a6e : SUCCESS in 1h 00m 34s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6f745a1574854fcb82acc76f5e9da673 : SUCCESS in 59m 42s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ebce3b7aae084a27abe2cc9a35a12d12 : SUCCESS in 2h 39m 09s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b0f1630c91f5476c97353bfa0c926eaf : SUCCESS in 2h 06m 51s","accounts_in_message":[],"_revision_number":2},{"id":"0358c15803e8da721333f5e6a5f69a272faf5136","author":{"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},"date":"2020-12-17 18:08:19.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ac19fc7226f01c603d551a268f7c0544650d70ec","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2020-12-17 22:41:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"72127809dd572135621f640b9d0e8eebcb1807a3","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2021-01-04 09:19:13.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"762c18e6d1c27ae12805bf69d0f5dbb34e68c9aa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-04 09:19:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c570a20830eff91e0c3fb9cdc21546cd250e64f2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-04 12:23:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters https://zuul.opendev.org/t/openstack/build/e00a782b96cd43b6b520cab3a542551a : SUCCESS in 11m 24s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/fe404d1b9ee049c8a5a48c0b4d660a91 : SUCCESS in 11m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/838a9de941f546cab271b054db74227a : SUCCESS in 12m 48s\n- openstack-ansible-deploy-aio_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/2aa8889182ae43688e681615dfabe40e : SUCCESS in 1h 50m 39s\n- openstack-ansible-deploy-aio_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/b76bc172b4a94a939ebfaa24dc6ebaab : SUCCESS in 1h 43m 56s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d67099f46dc647bb9a16d941e66345d4 : SUCCESS in 1h 33m 13s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/d796eba3af69438fad310e4f0ce9d4cf : SUCCESS in 1h 10m 33s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/1411e2af5bff40fbbbf4405647e2f465 : SUCCESS in 1h 22m 20s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/65818b948cc0450cb0c3d4819330674f : SUCCESS in 1h 14m 23s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0aeaeb1f1e9d4065bad68697906dedfd : SUCCESS in 1h 05m 59s\n- openstack-ansible-deploy-aio_distro_metal-centos-8 https://zuul.opendev.org/t/openstack/build/49412e6e8af64cbe95d085a39f074532 : SUCCESS in 1h 06m 22s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fe908b6b7b1e42fca3a5d743aa25eeca : SUCCESS in 57m 41s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fd250f4c3bc74e8fa0c3d4564f3d4d75 : SUCCESS in 1h 53m 47s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/211ed69132624f75877841b3d916294e : SUCCESS in 1h 35m 04s","accounts_in_message":[],"_revision_number":2},{"id":"4c319ecff89800905bd07bfd83e60f51b6af2e4d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-04 12:23:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"e92fd2cc2e469f223cf9f7672c79d33262c07944","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-04 12:26:02.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48cb3fbb50484c4297d4741d0dd7cdff : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2bb60193028fc848e87cdc7f416019482b8cf2cb","revisions":{"0b6b44d68f802e8b6a2d6eddc6aee23074a16bdc":{"kind":"REWORK","_number":1,"created":"2020-12-17 11:08:50.000000000","uploader":{"_account_id":27915,"name":"PerToft","email":"per@minfejl.dk","username":"PTO"},"ref":"refs/changes/13/767513/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/13/767513/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/1"}}},"commit":{"parents":[{"commit":"ba8b6af1740aa98ec930178a206f1ac248b026fc","subject":"Merge \"Add security.txt to haproxy frontend\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/ba8b6af1740aa98ec930178a206f1ac248b026fc"}]}],"author":{"name":"Per Abildgaard Toft","email":"per@minfejl.dk","date":"2020-12-17 11:06:12.000000000","tz":60},"committer":{"name":"Per Abildgaard Toft","email":"per@minfejl.dk","date":"2020-12-17 11:06:12.000000000","tz":60},"subject":"The current version does not include the os_keystone role correct, as it will run the role again, ignoring the tasks_from: main_keystone_federation_sp_idp_setup.yml part. This fix has been tested and now it corectly configures the SP/IDP config. Paste of a test: https://pastebin.com/DnEc86HR","message":"The current version does not include the os_keystone role correct, as it will run the role again, ignoring the tasks_from: main_keystone_federation_sp_idp_setup.yml part.\nThis fix has been tested and now it corectly configures the SP/IDP config.\nPaste of a test: https://pastebin.com/DnEc86HR\n\nChange-Id: I3c57c3aab3cacfd5732b9bf5e251a7a8b654d4f5\nCloses-Bug: 1908510\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/0b6b44d68f802e8b6a2d6eddc6aee23074a16bdc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/0b6b44d68f802e8b6a2d6eddc6aee23074a16bdc"}]},"branch":"refs/heads/master"},"2bb60193028fc848e87cdc7f416019482b8cf2cb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-12-17 11:58:05.000000000","uploader":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"ref":"refs/changes/13/767513/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/13/767513/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/13/767513/2"}}},"commit":{"parents":[{"commit":"ba8b6af1740aa98ec930178a206f1ac248b026fc","subject":"Merge \"Add security.txt to haproxy frontend\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/ba8b6af1740aa98ec930178a206f1ac248b026fc"}]}],"author":{"name":"Per Abildgaard Toft","email":"per@minfejl.dk","date":"2020-12-17 11:06:12.000000000","tz":60},"committer":{"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","date":"2020-12-17 11:58:05.000000000","tz":0},"subject":"Fix keystone IDP setup","message":"Fix keystone IDP setup\n\nThe current version does not include the os_keystone role correctly,\nas it runs the whole os_keystone role again and ignores the\ntasks_from: parameter.\n\nThis fix has been tested and now it correctly configures the SP/IDP\nconfiguration.\n\nChange-Id: I3c57c3aab3cacfd5732b9bf5e251a7a8b654d4f5\nCloses-Bug: 1908510\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/2bb60193028fc848e87cdc7f416019482b8cf2cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/2bb60193028fc848e87cdc7f416019482b8cf2cb"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}