)]}'
{"inventory/group_vars/haproxy/keepalived.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a3cdf92d6fd86c3213b71009b040c3f8033461f0","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    check_script: \"/etc/keepalived/pingable_check.sh {{ keepalived_ping_count }} {{ keepalived_external_ping_address }}\""},{"line_number":36,"context_line":"    dest_check_script: \"/etc/keepalived/pingable_check.sh\""},{"line_number":37,"context_line":"    src_check_script: \"{{ playbook_dir }}/../scripts/keepalived_pingable_check.sh\""},{"line_number":38,"context_line":"    interval: \"{{ keepalived_ping_interval }}\""},{"line_number":39,"context_line":"    fall: 2"},{"line_number":40,"context_line":"    rise: 4"},{"line_number":41,"context_line":"  pingable_check_script_internal:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"04316345_23654845","line":38,"updated":"2021-04-02 08:00:28.000000000","message":"can we add here extra key, like\ninstance: external ?","commit_id":"0764c96b8e6fcb258338a96862b097d7569321fe"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a3cdf92d6fd86c3213b71009b040c3f8033461f0","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    check_script: \"/etc/keepalived/pingable_check.sh {{ keepalived_ping_count }} {{ keepalived_internal_ping_address }}\""},{"line_number":43,"context_line":"    dest_check_script: \"/etc/keepalived/pingable_check.sh\""},{"line_number":44,"context_line":"    src_check_script: \"{{ playbook_dir }}/../scripts/keepalived_pingable_check.sh\""},{"line_number":45,"context_line":"    interval: \"{{ keepalived_ping_interval }}\""},{"line_number":46,"context_line":"    fall: 2"},{"line_number":47,"context_line":"    rise: 4"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3ae7178d_5de28b5c","line":45,"updated":"2021-04-02 08:00:28.000000000","message":"and\n\ninstance: internal","commit_id":"0764c96b8e6fcb258338a96862b097d7569321fe"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a3cdf92d6fd86c3213b71009b040c3f8033461f0","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    authentication_password: \"{{ haproxy_keepalived_authentication_password }}\""},{"line_number":61,"context_line":"    vips:"},{"line_number":62,"context_line":"      - \"{{ haproxy_keepalived_external_vip_cidr | default(\u0027169.254.1.1/24\u0027)  }} dev {{ haproxy_keepalived_external_interface | default(management_bridge) }}\""},{"line_number":63,"context_line":"    track_scripts:"},{"line_number":64,"context_line":"      - haproxy_check_script"},{"line_number":65,"context_line":"      - pingable_check_script_external"},{"line_number":66,"context_line":"  internal:"},{"line_number":67,"context_line":"    interface: \"{{ haproxy_keepalived_internal_interface | default(management_bridge) }}\""},{"line_number":68,"context_line":"    state: \"{{ (groups[\u0027haproxy\u0027].index(inventory_hostname) \u003d\u003d 0) | ternary(\u0027MASTER\u0027, \u0027BACKUP\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8d172ce7_0d965078","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":38},"updated":"2021-04-02 08:00:28.000000000","message":"I don\u0027t like changed behaviour here, in case there were extra scripts defined in keepalived_scripts.\n\nI think we can play around with selectattr/rejectattr to choose scripts which eiother don\u0027t have `instance` as key, or it\u0027s set as external.\nOr we should make that key a requirement and add this to reno - not sure how hard would it be to implement","commit_id":"0764c96b8e6fcb258338a96862b097d7569321fe"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0c0faaa3cded2618fd74e52ec3ca2ea1c06ce517","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    authentication_password: \"{{ haproxy_keepalived_authentication_password }}\""},{"line_number":61,"context_line":"    vips:"},{"line_number":62,"context_line":"      - \"{{ haproxy_keepalived_external_vip_cidr | default(\u0027169.254.1.1/24\u0027)  }} dev {{ haproxy_keepalived_external_interface | default(management_bridge) }}\""},{"line_number":63,"context_line":"    track_scripts:"},{"line_number":64,"context_line":"      - haproxy_check_script"},{"line_number":65,"context_line":"      - pingable_check_script_external"},{"line_number":66,"context_line":"  internal:"},{"line_number":67,"context_line":"    interface: \"{{ haproxy_keepalived_internal_interface | default(management_bridge) }}\""},{"line_number":68,"context_line":"    state: \"{{ (groups[\u0027haproxy\u0027].index(inventory_hostname) \u003d\u003d 0) | ternary(\u0027MASTER\u0027, \u0027BACKUP\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d3a339b9_164f9a8e","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":38},"in_reply_to":"3e947a7e_2ac3f119","updated":"2021-05-06 17:37:43.000000000","message":"Well, I kind of found the way 😄 Feel free to revert if you feel it\u0027s also too untidy (as it kind of is)","commit_id":"0764c96b8e6fcb258338a96862b097d7569321fe"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"6030c7e9ceeeabca937a5f6d56cc13a35df5cb84","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    authentication_password: \"{{ haproxy_keepalived_authentication_password }}\""},{"line_number":61,"context_line":"    vips:"},{"line_number":62,"context_line":"      - \"{{ haproxy_keepalived_external_vip_cidr | default(\u0027169.254.1.1/24\u0027)  }} dev {{ haproxy_keepalived_external_interface | default(management_bridge) }}\""},{"line_number":63,"context_line":"    track_scripts:"},{"line_number":64,"context_line":"      - haproxy_check_script"},{"line_number":65,"context_line":"      - pingable_check_script_external"},{"line_number":66,"context_line":"  internal:"},{"line_number":67,"context_line":"    interface: \"{{ haproxy_keepalived_internal_interface | default(management_bridge) }}\""},{"line_number":68,"context_line":"    state: \"{{ (groups[\u0027haproxy\u0027].index(inventory_hostname) \u003d\u003d 0) | ternary(\u0027MASTER\u0027, \u0027BACKUP\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3e947a7e_2ac3f119","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":38},"in_reply_to":"8d172ce7_0d965078","updated":"2021-04-07 14:15:15.000000000","message":"I\u0027ve had a go at this. The issue I\u0027m seeing with selectattr/rejectattr is that they won\u0027t recursively test within the dict, so using \u0027keepalived_scripts | selectattr(\u0027instance\u0027, \u0027external)\u0027 for example won\u0027t work. I could break out into a jinja loop, but this seems quite untidy.","commit_id":"0764c96b8e6fcb258338a96862b097d7569321fe"}]}