)]}'
{"playbooks/certificate-generate.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"26a2ea1dc25c84e69a9798a733adc13c9757add2","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        name: pki"},{"line_number":24,"context_line":"        tasks_from: main_certs.yml"},{"line_number":25,"context_line":"      vars:"},{"line_number":26,"context_line":"        pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":27,"context_line":"        pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":28,"context_line":"        cert_dir: \"{{ pki_dir }}/certs\""},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - pki_create_certificates | default(true)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50203747_aecfeb91","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":39},"updated":"2021-11-03 15:03:22.000000000","message":"Shouldn\u0027t we provide smth like pki_certificates here and add some variable for it?","commit_id":"5512c49c9bc01cb579cf04a1fee1d4f75d626db5"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"4d8b7727ba2286ff6ad6f28e2f39dc016ec23e4b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        name: pki"},{"line_number":24,"context_line":"        tasks_from: main_certs.yml"},{"line_number":25,"context_line":"      vars:"},{"line_number":26,"context_line":"        pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":27,"context_line":"        pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":28,"context_line":"        cert_dir: \"{{ pki_dir }}/certs\""},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - pki_create_certificates | default(true)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"51c0dbb5_02179e41","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"50203747_aecfeb91","updated":"2021-11-04 08:09:30.000000000","message":"I don\u0027t believe so in the role when it runs it will look for `pki_cert_defs` which is dynamically generated by the role. \nhttps://github.com/openstack/ansible-role-pki/blob/master/vars/main.yml","commit_id":"5512c49c9bc01cb579cf04a1fee1d4f75d626db5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d064f1478bcca74593cc6a9f82a5defce7b0d01e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        name: pki"},{"line_number":24,"context_line":"        tasks_from: main_certs.yml"},{"line_number":25,"context_line":"      vars:"},{"line_number":26,"context_line":"        pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":27,"context_line":"        pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":28,"context_line":"        cert_dir: \"{{ pki_dir }}/certs\""},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - pki_create_certificates | default(true)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fda54f01_bf988c66","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"51c0dbb5_02179e41","updated":"2021-11-08 09:52:38.000000000","message":"So, um, we rely on this?\nhttps://github.com/openstack/ansible-role-pki/blob/master/vars/main.yml#L34\n\nWell I think explicit is better then implicit? But even if we leave it implicit, that is totally worth documenting, since even for me it\u0027s not obvious how to make this playbook work.","commit_id":"5512c49c9bc01cb579cf04a1fee1d4f75d626db5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"028c8dfd428a4b194ab58f919e76f2371595557b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        name: pki"},{"line_number":24,"context_line":"        tasks_from: main_certs.yml"},{"line_number":25,"context_line":"      vars:"},{"line_number":26,"context_line":"        pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":27,"context_line":"        pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":28,"context_line":"        cert_dir: \"{{ pki_dir }}/certs\""},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - pki_create_certificates | default(true)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"31bbc242_09a22514","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"629ade33_ef62941f","updated":"2021-11-12 09:28:57.000000000","message":"I was actually thinking more about passing:\n\n  pki_certificates: \"{{ user_custom_pki_certificates | default(False) }}\"\n\nand use when: pki_certificates | length\n\nBut again, given decent documntation it might be fine this way as well","commit_id":"5512c49c9bc01cb579cf04a1fee1d4f75d626db5"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"37f8dfecf54a6f1ced4e289ddaf1f057e1c8c41b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        name: pki"},{"line_number":24,"context_line":"        tasks_from: main_certs.yml"},{"line_number":25,"context_line":"      vars:"},{"line_number":26,"context_line":"        pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":27,"context_line":"        pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":28,"context_line":"        cert_dir: \"{{ pki_dir }}/certs\""},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - pki_create_certificates | default(true)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"629ade33_ef62941f","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"bf29b93c_07229659","updated":"2021-11-08 14:10:19.000000000","message":"Is the latest patch the kind of thing you were thinking of?","commit_id":"5512c49c9bc01cb579cf04a1fee1d4f75d626db5"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"d0e7e0640c8f36fe3a0826cb6c4c805f805e5f36","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        name: pki"},{"line_number":24,"context_line":"        tasks_from: main_certs.yml"},{"line_number":25,"context_line":"      vars:"},{"line_number":26,"context_line":"        pki_setup_host: \"{{ openstack_pki_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":27,"context_line":"        pki_dir: \"{{ openstack_pki_dir }}\""},{"line_number":28,"context_line":"        cert_dir: \"{{ pki_dir }}/certs\""},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - pki_create_certificates | default(true)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf29b93c_07229659","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"fda54f01_bf988c66","updated":"2021-11-08 10:21:46.000000000","message":"I think it would be good to use a variable name which makes it explicitly \u0027user_....\" so that it\u0027s totally clear that these are a set of user supplied certificate definitions.\n\nThe variable will be defined in user_variables.yml by most people so will be in scope for all hosts in the deployment, when we really only want the certs to be generated in one specific playbook, and only with the deploy host as a target. Perhaps this allows it to be both specific and extensible?\n\npki_certificates_pattern: \"user_pki_certificates\"","commit_id":"5512c49c9bc01cb579cf04a1fee1d4f75d626db5"}]}