)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"712b55331ac1555235e1f21a6765ba5431c9103a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add support for TLS to Glance backends"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the ability to configure TLS for the galnce haproxy"},{"line_number":10,"context_line":"backends, by setting the variable"},{"line_number":11,"context_line":"`openstack_backend_service_https: true`."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5482a6c5_95ac3773","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":48},"updated":"2021-12-15 14:47:49.000000000","message":"glance","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"84fa7c6d515ad516ef525ac5efecf527c3e128ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add support for TLS to Glance backends"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the ability to configure TLS for the galnce haproxy"},{"line_number":10,"context_line":"backends, by setting the variable"},{"line_number":11,"context_line":"`openstack_backend_service_https: true`."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e8b1830b_141a6a9e","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":48},"in_reply_to":"5482a6c5_95ac3773","updated":"2021-12-23 14:15:15.000000000","message":"Done","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8b9c26e63c1decb85616e8edc88356ad561b6ed0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     James Gibson \u003cjames.gibson@bbc.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-23 14:15:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add support for TLS to Glance backends"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the ability to configure TLS for the glance haproxy"},{"line_number":10,"context_line":"backends, by setting the variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"61d8cf40_5e634e56","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2021-12-23 14:38:57.000000000","message":"This should be removed if ready for being merged","commit_id":"c262212240d61afa1a70e43a62c7344f6c9948d6"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"34d81f71d7f397dc35c38d0fe8f0b3592ca024af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     James Gibson \u003cjames.gibson@bbc.co.uk\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-23 14:15:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add support for TLS to Glance backends"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds the ability to configure TLS for the glance haproxy"},{"line_number":10,"context_line":"backends, by setting the variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b35dacca_80c764e5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"61d8cf40_5e634e56","updated":"2022-02-18 14:50:57.000000000","message":"Done","commit_id":"c262212240d61afa1a70e43a62c7344f6c9948d6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"f44b15271e4869c9ec693087e4a2033519854439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b0c9c8d_7f6dd551","updated":"2021-12-09 10:22:14.000000000","message":"recheck","commit_id":"5c240d7fc841a956170a966c1ed18e57c852740f"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"2acaa03bd300cdc2c359cb9073bd7e0a5e73d249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"670523e2_c3480fbe","updated":"2021-12-20 08:12:12.000000000","message":"recheck","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a78ba96f1971b4696a9335a184cb8d0f4f45e9fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f9d10a5c_cc6ec6c0","updated":"2022-02-21 11:36:58.000000000","message":"I\u0027d say it\u0027s also WIP as worth merging for all services at once.","commit_id":"ca319c86148d0c2bc2c7ca457dc6b23237bee877"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"6762833ea60ac95465ad5ed1b7e5d5924626a2a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ebfbdf7_04d23995","updated":"2022-02-18 18:57:11.000000000","message":"recheck","commit_id":"ca319c86148d0c2bc2c7ca457dc6b23237bee877"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"62ae69dd14cac98a2aea743e0d201ee4dce1744c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"493a3db8_ab159ce2","updated":"2022-11-16 21:41:25.000000000","message":"Just FYI:\n\nIt\u0027s a quite small change in openstack-ansible repository.\nThat\u0027s why I decided not to implement separate changes for all openstack services but gather them all here.\n\nEven if we merge this change before these services will have TLS support on their end, it shouldn\u0027t break anything.","commit_id":"ce2d4abf34e9f16f267a80f61acb26abcbdf0ed1"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"98c179fd20520e1b4839f115e13201600e3ae623","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3b512588_758608b2","updated":"2022-11-17 17:43:57.000000000","message":"recheck - tempest test(tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_volume_boot_pattern) failed","commit_id":"ce2d4abf34e9f16f267a80f61acb26abcbdf0ed1"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"e870c46b662273e792d38d700215cacd66726e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e5db3ea6_ad526ee6","updated":"2022-11-17 10:40:01.000000000","message":"recheck - urlopen error timed out","commit_id":"ce2d4abf34e9f16f267a80f61acb26abcbdf0ed1"}],"inventory/group_vars/haproxy/haproxy.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6f7ba66f1397c4a571f38e9b63a0f8a48987a539","unresolved":true,"context_lines":[{"line_number":157,"context_line":"  haproxy_balance_alg: source"},{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ haproxy_glance_backend_service_https is defined | ternary(haproxy_glance_backend_service_https, (openstack_backend_service_https | default(False))) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(\u0027/etc/ssl/certs/ca-certificates.crt\u0027) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e735fe6f_a4c664f3","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":174},"updated":"2021-12-10 12:40:54.000000000","message":"can\u0027t this be simplified to\n\nhaproxy_glance_backend_service_https | default(openstack_backend_service_https | default(False)) ?\n\nOr even drop default at all and get openstack_backend_service_https just defined somewhere in https://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/group_vars/all/ssl.yml\n\n\nWhy we also introduce haproxy_glance_backend_service_https? Shouldn\u0027t we just re-use `glance_https` (or whatever name we pick for it)?","commit_id":"5c240d7fc841a956170a966c1ed18e57c852740f"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"e871514edb2b9e58373b2181f35cc7ba73c786c6","unresolved":true,"context_lines":[{"line_number":157,"context_line":"  haproxy_balance_alg: source"},{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ haproxy_glance_backend_service_https is defined | ternary(haproxy_glance_backend_service_https, (openstack_backend_service_https | default(False))) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(\u0027/etc/ssl/certs/ca-certificates.crt\u0027) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"523792b3_52046f87","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":174},"in_reply_to":"e735fe6f_a4c664f3","updated":"2021-12-15 09:34:03.000000000","message":"The reason for creating a new variable `haproxy_glance_backend_service_https` is that  `glance_https` (or whatever name we pick for it) is defined in the glance role defaults, so if in the future the default is changed and we don\u0027t define it in user_variables, then the logic would fail. \n\nHappy not to define a new variable for haproxy and use `glance_https` or make just have `openstack_backend_service_https` so all serives use http or https backends?","commit_id":"5c240d7fc841a956170a966c1ed18e57c852740f"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"712b55331ac1555235e1f21a6765ba5431c9103a","unresolved":true,"context_lines":[{"line_number":157,"context_line":"  haproxy_balance_alg: source"},{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ glance_backend_https | default(openstack_backend_service_https | default(False)) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(true) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4e4d8147_e0b4d087","line":160,"range":{"start_line":160,"start_character":27,"end_line":160,"end_character":47},"updated":"2021-12-15 14:47:49.000000000","message":"are you trying to use the value from defaults/main.yml in the glance role? that will only be in scope when the glance role is running so perhaps confusingly this only refers to a variable of the same name defined in host/group/user_variables vars","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"84fa7c6d515ad516ef525ac5efecf527c3e128ff","unresolved":true,"context_lines":[{"line_number":157,"context_line":"  haproxy_balance_alg: source"},{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ glance_backend_https | default(openstack_backend_service_https | default(False)) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(true) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b95457e7_b5f52967","line":160,"range":{"start_line":160,"start_character":27,"end_line":160,"end_character":47},"in_reply_to":"4e4d8147_e0b4d087","updated":"2021-12-23 14:15:15.000000000","message":"So i could create an extra variable such as `openstack_glance_backend_https` to allow you to override the config in glance and haproxy on a per service basis.\nBut Andrew pointed out that explicitly overriding a variable from a different role\u0027s defaults is a pattern that is already used in the glance role which uses a galera variable `glance_galera_use_ssl: \"{{ galera_use_ssl | default(False) }}\"` \nhttps://opendev.org/openstack/openstack-ansible-os_glance/src/branch/master/defaults/main.yml#L130\n\nI am happy with either if there is a consensus for the best option create a new variable or re-use variable from defaults/main.yml?\n\nWhich ever option is picked, it will be documented in the security docs on how to enable/diable on  a per service basis.","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"62ae69dd14cac98a2aea743e0d201ee4dce1744c","unresolved":true,"context_lines":[{"line_number":157,"context_line":"  haproxy_balance_alg: source"},{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ glance_backend_https | default(openstack_backend_service_https | default(False)) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(true) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d6be85da_0d1fe378","line":160,"range":{"start_line":160,"start_character":27,"end_line":160,"end_character":47},"in_reply_to":"b95457e7_b5f52967","updated":"2022-11-16 21:41:25.000000000","message":"so looks like there\u0027s no perfect solution.\nI\u0027m fine with the current way.","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"712b55331ac1555235e1f21a6765ba5431c9103a","unresolved":true,"context_lines":[{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ glance_backend_https | default(openstack_backend_service_https | default(False)) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(true) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"haproxy_gnocchi_service:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ee8d7722_b8123c15","line":161,"range":{"start_line":161,"start_character":26,"end_line":161,"end_character":44},"updated":"2021-12-15 14:47:49.000000000","message":"this looks confusing, as haproxy_backend_ca looks like a role default variable for the haproxy role - except that it isnt.","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"},{"author":{"_account_id":31749,"name":"James Gibson","email":"james.gibson@bbc.co.uk","username":"jamesgibo"},"change_message_id":"84fa7c6d515ad516ef525ac5efecf527c3e128ff","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  haproxy_backend_options:"},{"line_number":159,"context_line":"    - \"httpchk GET / HTTP/1.0\\\\r\\\\nUser-agent:\\\\ osa-haproxy-healthcheck\""},{"line_number":160,"context_line":"  haproxy_backend_ssl: \"{{ glance_backend_https | default(openstack_backend_service_https | default(False)) }}\""},{"line_number":161,"context_line":"  haproxy_backend_ca: \"{{ haproxy_backend_ca | default(true) }}\""},{"line_number":162,"context_line":"  haproxy_service_enabled: \"{{ groups[\u0027glance_api\u0027] is defined and groups[\u0027glance_api\u0027] | length \u003e 0 }}\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"haproxy_gnocchi_service:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ebb81913_d39b715b","line":161,"range":{"start_line":161,"start_character":26,"end_line":161,"end_character":44},"in_reply_to":"ee8d7722_b8123c15","updated":"2021-12-23 14:15:15.000000000","message":"Done","commit_id":"597ec773fd26d3ed033d5ef3074b25888ad97f18"}]}