)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"8f6b38475bf24a095a90493f993080e75acd0809","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa59feec_5957be3b","updated":"2021-12-08 17:18:08.000000000","message":"This maybe doesn\u0027t quite cover all cases\n\n* The repo is cloned with git from the prepared zuul location retrieving a specific refspec\n* The zuul location is set up with any patches as a result of depends-on\n* When there is a depends on, is the zuul repo left with the branch moved forward to the applied patch, or is it \"detached-head\" state? i.e does master or stable/blah refer to the original branch head, or the depends-on state.\n\n* openstack-ansible-plugins probably wants to be treated like a normal OSA role, installed from master on master branch and a pinned SHA on stable branches, while respecting depends-on in CI\n\n* Upstream collections will only use released version numbers like x.y.z which we bump manually\n\n* ansible-collections-openstack sits in between, were we want to use released versions but might need to depends-on in CI, particularly on master branch.\n\nSo:\n\nAlways use x.y.z version numbers for upstream roles\n\nWhere a zuul copy exists: take \u0027head of the current branch\u0027? Does this work for depends-on?\n\nIn an upgrade job, do we always use the target (N-1) or (N) branch as the zuul state will be correct even for depends-on? Rememeber that with the source set to git+https:// ansible-galaxy does a git clone from the zuul copy. ","commit_id":"2a4c270523317cd83105a13eec5fbb8b25fb03be"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"3a69ea238e6cf3a211dea8ac2485735f197e29a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61cdb281_87eed1bc","updated":"2021-12-09 07:49:30.000000000","message":"recheck GPG error: https://packages.erlang-solutions.com/ubuntu focal Release","commit_id":"2a4c270523317cd83105a13eec5fbb8b25fb03be"}],"scripts/get-ansible-collection-requirements.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"20f812c5c12fdc57b82419fcdc15b8f4439954a0","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        state: directory"},{"line_number":26,"context_line":"      with_items:"},{"line_number":27,"context_line":"        - \"{{ collection_path_default }}\""},{"line_number":28,"context_line":"        - \"{{ collection_path_default }}/ansible_collections\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    - name: Read the list of user collections"},{"line_number":31,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e369554f_15ce7a93","line":28,"range":{"start_line":28,"start_character":11,"end_line":28,"end_character":60},"updated":"2022-01-11 13:20:39.000000000","message":"should we just leave \"{{ collection_path_default }}/ansible_collections\" as it\u0027s a recurse action anyway?","commit_id":"2514e97192be251c5dfc4eaadd4f4e865a14baf8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"20f812c5c12fdc57b82419fcdc15b8f4439954a0","unresolved":true,"context_lines":[{"line_number":65,"context_line":"          version: \"{{ item.item.version }}\""},{"line_number":66,"context_line":"          type: \"{{ item.item.type | default(\u0027\u0027) }}\""},{"line_number":67,"context_line":"      set_fact:"},{"line_number":68,"context_line":"        galaxy_collections_list_ci: \"{{ galaxy_collections_list_ci + [ (item.stat.exists | ternary(zuul_item, item.item)) ] }}\""},{"line_number":69,"context_line":"      with_items: \"{{ zuul_collections.results }}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    - name: Create temporary file for galaxy collection requirements"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f6ec9243_60b88d8c","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":127},"updated":"2022-01-11 13:20:39.000000000","message":"I\u0027m not sure I see what we\u0027re doing here? As `galaxy_collections_list_ci` is not used anywhere?\n\nShould we `set_fact: galaxy_collections` here instead?","commit_id":"2514e97192be251c5dfc4eaadd4f4e865a14baf8"}]}