)]}'
{"id":"openstack%2Fopenstack-ansible~823437","triplet_id":"openstack%2Fopenstack-ansible~master~Icd2f9142f1717023a323da23452c6ea27291840c","project":"openstack/openstack-ansible","branch":"master","attention_set":{},"removed_from_attention_set":{"31542":{"account":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"last_update":"2022-01-07 13:10:10.000000000","reason":"Change was abandoned"},"32666":{"account":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"last_update":"2022-01-07 13:10:04.000000000","reason":"Damian Dąbrowski replied on the change"}},"hashtags":[],"change_id":"Icd2f9142f1717023a323da23452c6ea27291840c","subject":"Explicitly make gather_subset a list instead of a string","status":"ABANDONED","created":"2022-01-04 23:21:00.000000000","updated":"2022-01-07 13:10:10.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bd3802a942b2deef75b886c11b9ad8bd43576439","_number":823437,"virtual_id_number":823437,"owner":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-01-05 01:44:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-05 01:44:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-06 10:32:00.000000000","updated_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"reviewer":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"state":"CC"}],"messages":[{"id":"80d28bf0e02c2e04909f7adb442f8b20eacb05fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"date":"2022-01-04 23:21:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ec4d208a84c81bf037c2353c8daab643439ca3eb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-01-05 01:44:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/4e2583c5b87c4f95998ed564df13862c : SUCCESS in 14m 51s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/9d2b526e0b9f49dc8b3b6f71e975291b : SUCCESS in 24m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9bd04ea44e334e638fc2827c03473268 : SUCCESS in 13m 56s\n- openstack-ansible-deploy-aio_lxc-centos-8 https://zuul.opendev.org/t/openstack/build/5354bacafafe48e0bcedde3f01d83503 : SUCCESS in 2h 15m 25s\n- openstack-ansible-deploy-aio_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/8f0ccf9d5b3e4aab800578a33b229df0 : SUCCESS in 1h 58m 24s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/2a92ebd39a0241d2aad4a5087ac1fa7c : SUCCESS in 1h 54m 57s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e98d0f0b6bd94fe987250569551ec746 : SUCCESS in 2h 03m 35s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/291ce88c8a3949ceb6ffc181417b8336 : SUCCESS in 1h 15m 10s\n- openstack-ansible-deploy-aio_metal-centos-8 https://zuul.opendev.org/t/openstack/build/0958c8cf8cd94bda875ea0eb27f1c4aa : SUCCESS in 1h 25m 59s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/e1fabd2d8e54430a8070e3a72c473956 : SUCCESS in 1h 25m 55s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/eab90ff20f0f42ada0de3e9cb95a912a : SUCCESS in 1h 27m 56s\n- openstack-ansible-upgrade-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/68182cf1fa6443f888d0375d14c56eef : SUCCESS in 2h 02m 08s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e7f2ffc4b41e4bec878188f8b6b582f4 : SUCCESS in 2h 10m 31s\n- openstack-ansible-deploy-aio_distro_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/1afa8a6d04d9488784fb33b59cd096cd : FAILURE in 33m 16s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7264a877e8514ab5bb3ee4cbc4b8f2d1 : SUCCESS in 57m 41s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/14e7f7ec19c94a7dac1a17600d3b45fa : SUCCESS in 2h 13m 50s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b9c3e8afd3e541bfb57700b66a23f755 : SUCCESS in 2h 03m 20s","accounts_in_message":[],"_revision_number":1},{"id":"8b186550f8df87daf48ae4f71269b20ef61d8cb9","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2022-01-06 10:32:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73e51eac65932c986344d28a384392b5245a32eb","author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"date":"2022-01-07 13:10:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bd3802a942b2deef75b886c11b9ad8bd43576439","tag":"autogenerated:gerrit:abandon","author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"date":"2022-01-07 13:10:10.000000000","message":"Abandoned\n\nhttps://review.opendev.org/c/openstack/openstack-ansible/+/823796","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e136832d882ca5a5950f39ec9c9083c086a52c93","revisions":{"e136832d882ca5a5950f39ec9c9083c086a52c93":{"kind":"REWORK","_number":1,"created":"2022-01-04 23:21:00.000000000","uploader":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"ref":"refs/changes/37/823437/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/37/823437/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/37/823437/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/37/823437/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/37/823437/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/37/823437/1"}}},"commit":{"parents":[{"commit":"464d7e5d36396c7360d4f357500784d61a3fb13a","subject":"Bump collection versions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/464d7e5d36396c7360d4f357500784d61a3fb13a"}]}],"author":{"name":"Damian Dabrowski","email":"damian@dabrowski.cloud","date":"2022-01-04 23:16:47.000000000","tz":60},"committer":{"name":"Damian Dabrowski","email":"damian@dabrowski.cloud","date":"2022-01-04 23:17:34.000000000","tz":60},"subject":"Explicitly make gather_subset a list instead of a string","message":"Explicitly make gather_subset a list instead of a string\n\nAs of Ansible 2.11, the type of \u0027filter\u0027 in setup module has changed from string to list and the default has became an empty list. A simple string is still accepted and works as a single pattern[1].\nHowever, there are some corner cases when a simple string misbehaves and it happened in our ceph-install.yml[2] where ansible tries to create a list when it\u0027s not necessary:\n\n```\n\"invocation\": {\n  \"module_args\": {\n    \"gather_subset\": [\"!all\", \"network\"],\n    \"filter\": [\"ansible_all_ipv[4\", \"6]_addresses\"],\n    \"gather_timeout\": 10,\n    \"fact_path\": \"/etc/ansible/facts.d\"\n  }\n}\n```\n\n[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/setup_module.html#parameter-filter\n[2] https://opendev.org/openstack/openstack-ansible/src/commit/954567346e24c46a07d1f6d018ffb9e80ea7960d/playbooks/ceph-install.yml#L33\n\nChange-Id: Icd2f9142f1717023a323da23452c6ea27291840c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/e136832d882ca5a5950f39ec9c9083c086a52c93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/e136832d882ca5a5950f39ec9c9083c086a52c93"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}