)]}'
{"id":"openstack%2Fopenstack-ansible~828392","triplet_id":"openstack%2Fopenstack-ansible~stable%2Fxena~I263315b13669a0b9b2fe318f86fe8d0cf1e3fafd","project":"openstack/openstack-ansible","branch":"stable/xena","attention_set":{},"removed_from_attention_set":{"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2022-02-09 11:10:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I263315b13669a0b9b2fe318f86fe8d0cf1e3fafd","subject":"Fix additional facts gathering in ceph-install.yml","status":"MERGED","created":"2022-02-08 19:13:18.000000000","updated":"2022-02-09 11:13:11.000000000","submitted":"2022-02-09 11:10:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"828392","cherry_pick_of_change":823796,"cherry_pick_of_patch_set":1,"meta_rev_id":"cfb1dd9ac1d8796c335f66715d2bd19a48d8d0f9","_number":828392,"virtual_id_number":828392,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-02-09 11:10:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"all":[{"value":2,"date":"2022-02-09 08:39:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":1,"date":"2022-02-08 21:33:33.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":2,"date":"2022-02-09 03:39:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"all":[{"value":1,"date":"2022-02-09 08:39:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"value":0,"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-08 19:13:18.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"state":"CC"},{"updated":"2022-02-08 21:33:33.000000000","updated_by":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"reviewer":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"state":"REVIEWER"},{"updated":"2022-02-08 23:34:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-09 08:39:08.000000000","updated_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"reviewer":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"state":"REVIEWER"}],"messages":[{"id":"da2bb82866764b7a70c4e5456a9f00f6b06ff645","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2022-02-08 19:13:18.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"fc8f825fe10bb676e91c19cc48198aea71cd1901","author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"date":"2022-02-08 21:33:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e4dbda52709cb2dd61e86c9fc203774dcfd005ca","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-08 23:34:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/87108347c2af4d21a7ebdd983b8fcf7a : SUCCESS in 16m 47s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/9331f3c86a7a44ee91f1106c892464bc : SUCCESS in 21m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f4834f062d154d11879ee3dee3987b26 : SUCCESS in 14m 53s\n- openstack-ansible-deploy-aio_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/0b7109aec3b14b5aae0251338cda3181 : SUCCESS in 2h 07m 58s\n- openstack-ansible-deploy-aio_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/5efabc027cd64f9db014fd71a39f5f41 : SUCCESS in 2h 18m 57s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/71228c5266694e69b708581e5a58f67b : SUCCESS in 1h 40m 31s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/51daf209d6984f168d0a96f6181a229d : SUCCESS in 2h 07m 33s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/0bb26aeb3a8147d2a08fda946a72dbb0 : SUCCESS in 1h 35m 16s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/a0c7735362cc4a3f83d2a3df9d36f0d8 : SUCCESS in 1h 12m 36s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/e1a76dd0035b4d709b3f510b93dae1a0 : SUCCESS in 1h 31m 44s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ad1194363efa4be2abde73742a358117 : SUCCESS in 1h 39m 53s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/083eeac5af874b33ac61f752b8f5f285 : SUCCESS in 1h 29m 24s\n- openstack-ansible-upgrade-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/215396c005744fb29cbd3f361956129d : FAILURE in 23m 14s (non-voting)\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f2716fabaee54773b86350975c50fa66 : SUCCESS in 1h 56m 30s\n- openstack-ansible-deploy-aio_distro_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/75f7837ddfef482886ff5e8365c255ea : FAILURE in 36m 57s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e4c5326a326e4d59ad87ec281bb1bedc : SUCCESS in 1h 18m 17s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9dac5a90cbd240b5b5c6e0f8e23b5768 : SUCCESS in 2h 05m 41s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fdae1851ba7240d5954c6e1b681169e4 : SUCCESS in 2h 02m 25s","accounts_in_message":[],"_revision_number":1},{"id":"b3b1f726243de57e6896dcde8cfc498b8fce7a94","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2022-02-09 03:39:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b59788fe400e149bba96e84ff785b7b7065b5828","author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"date":"2022-02-09 08:39:08.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1d98009e6222ee820a035e156ef5d48a6533f1aa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-09 08:44:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f53440fd3878bbf44f017b27696cc1d2b1eda7d3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-09 11:10:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/376a37409a5142009a9027f22411b846 : SUCCESS in 17m 34s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/564e56b055c646dfa9919ad9186b9035 : SUCCESS in 16m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d9b74d842f2b42e3a743a874612774ff : SUCCESS in 11m 22s\n- openstack-ansible-deploy-aio_lxc-centos-8-stream https://zuul.opendev.org/t/openstack/build/39896ec6661b4d2a8da17d12f959ac25 : SUCCESS in 2h 10m 39s\n- openstack-ansible-deploy-aio_lxc-debian-buster https://zuul.opendev.org/t/openstack/build/d8b98bf7fbf6469399478db0832c03a2 : SUCCESS in 2h 22m 00s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/85309e02ef784fa09211b429c611538b : SUCCESS in 2h 01m 15s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dd9a9f4682e1415c9676075b9a838214 : SUCCESS in 2h 20m 39s\n- openstack-ansible-deploy-aio_metal-debian-buster https://zuul.opendev.org/t/openstack/build/f0571a6b923444f0a2180e18e9c6901c : SUCCESS in 1h 44m 21s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/79b29d6c4dfd4f03b8c551605ae1683e : SUCCESS in 1h 03m 30s\n- openstack-ansible-deploy-aio_metal-centos-8-stream https://zuul.opendev.org/t/openstack/build/78dda90c02ee462fa4cf23c15fe7f004 : SUCCESS in 1h 45m 28s\n- openstack-ansible-deploy-aio_metal-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8897bee27b954cec80c538279a261bbe : SUCCESS in 1h 31m 03s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6ea5459944234ae2b43f6b5483e55194 : SUCCESS in 1h 30m 55s\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d6ef556d062f47ad879d7342708121d7 : SUCCESS in 58m 49s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ab0209b1ddcf430ca64705cd93138e2c : SUCCESS in 2h 18m 49s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6eb7a419fbd44afbb05041dc6a01728d : SUCCESS in 1h 58m 57s","accounts_in_message":[],"_revision_number":1},{"id":"b853002182908770073e125193a8302ef63b95d0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-09 11:10:15.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"cfb1dd9ac1d8796c335f66715d2bd19a48d8d0f9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-09 11:13:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/534cfc816ebd4ba68d1ea8c8901f3dd8 : SUCCESS in 1m 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"403b068f16315ec993c8444b25fefff1ac3e1fa4","revisions":{"403b068f16315ec993c8444b25fefff1ac3e1fa4":{"kind":"REWORK","_number":1,"created":"2022-02-08 19:13:18.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/92/828392/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/92/828392/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/92/828392/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/92/828392/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/92/828392/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/92/828392/1"}}},"commit":{"parents":[{"commit":"7aa256779d134d19e14a1ffc86612ae82fd32074","subject":"Clarify major upgrade documentation for updating internal CA","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/7aa256779d134d19e14a1ffc86612ae82fd32074"}]}],"author":{"name":"Damian Dabrowski","email":"damian@dabrowski.cloud","date":"2022-01-07 12:54:42.000000000","tz":60},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@ya.ru","date":"2022-02-08 19:13:18.000000000","tz":0},"subject":"Fix additional facts gathering in ceph-install.yml","message":"Fix additional facts gathering in ceph-install.yml\n\nAs of Ansible 2.11, the type of \u0027filter\u0027 in setup module has changed from string to list and the default has became an empty list. A simple string is still accepted and works as a single pattern[1].\nHowever, there are some corner cases when a simple string misbehaves and it happened here where ansible tries to create a list when it\u0027s not necessary:\n\n\"invocation\": {\n  \"module_args\": {\n    \"gather_subset\": [\"!all\", \"network\"],\n    \"filter\": [\"ansible_all_ipv[4\", \"6]_addresses\"],\n    \"gather_timeout\": 10,\n    \"fact_path\": \"/etc/ansible/facts.d\"\n  }\n}\n\nPreviously I tried to fix it differently in Change #823437 but Andrew Bonney proposed a better way of handling this issue.\n\n[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/setup_module.html#parameter-filter\n\nCo-authored-by: Andrew Bonney \u003candrew.bonney@bbc.co.uk\u003e\nChange-Id: I263315b13669a0b9b2fe318f86fe8d0cf1e3fafd\n(cherry picked from commit 61c550d0835449f08f00172fa2bfd6bab24ccce2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/403b068f16315ec993c8444b25fefff1ac3e1fa4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/403b068f16315ec993c8444b25fefff1ac3e1fa4"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}