)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"732f80e3514f7d7b1307353a93dacbaa33a1b41e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd4f7585_5beca891","updated":"2022-05-28 07:05:22.000000000","message":"Let\u0027s wait for dependant patch to pass upgrade jobs first","commit_id":"23b81d0ac54b96e120c88633fa3dac69e04186d4"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"d0aed1617199079904e040f9c6d8724b72497fc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fde23b10_d6c1edda","updated":"2022-06-01 14:32:16.000000000","message":"Note that setting \u0027octavia_client_cert\u0027 to the existing PEM results in the private key occurring twice in the PEM which is ultimately deployed to the octavia container. I suspect this isn\u0027t a problem, but still need to confirm.","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1838fb54fa22acb5282a598af1dbb5f0f30fc5b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"02c60458_975015f7","updated":"2022-06-05 16:21:53.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ecbeb35cd1df5780e035d3cd7fa239c069070c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"439eac56_c174a622","updated":"2022-06-05 06:05:12.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"85f068619f4138071b5f57d71beea39deecf5a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6dc796c4_abe67479","updated":"2022-06-07 06:55:20.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d114a63a8ff29c2de74bcde9e2dfc70a97a76d04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"702b326b_dc32418b","updated":"2022-06-06 09:03:12.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d98f4632c685f215bcbbfeb3572f81d580e3f93b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"766a41e0_2a36fd0e","updated":"2022-06-04 06:43:54.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4ad6cdd4a52ddeb84f350e93e95f7b53ebdb22b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"85238425_973a0559","updated":"2022-06-03 16:48:45.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b12cb7e73e0f092ea8293441a757c4f23f6c64c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a3204bc2_3ebdee3a","updated":"2022-06-04 10:11:19.000000000","message":"recheck post failure","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"55e548dc85f1710a541155e5de5b25292d951e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e56108e5_6964145a","updated":"2022-06-03 20:18:21.000000000","message":"recheck post failures","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e2a0f72e208242631c175dc4809af50ab074329c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf07fc42_6ec92323","in_reply_to":"fde23b10_d6c1edda","updated":"2022-06-02 08:28:13.000000000","message":"from what I saw what we did to octavia certs was quite weird and inconsistent. It was hard to understand why we did certain things, so I did some assumptions for upgrade script, that it should be fine this way....\n\nSO yes, worth double-checking","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"}],"scripts/upgrade-utilities/define-octavia-certificate-vars.yml":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"4efa790b908e7e1c0120a882b7592f7da0cb4e33","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    generated_octavia_cert_setup_host: \"{{ octavia_cert_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":22,"context_line":"    generated_octavia_cert_vars:"},{"line_number":23,"context_line":"      octavia_client_ca: \"{{ octavia_client_ca | default(generated_octavia_cert_dir ~ \u0027/ca_01.pem\u0027) }}\""},{"line_number":24,"context_line":"      octavia_client_cert: \"{{ octavia_client_cert | default(generated_octavia_cert_dir ~ \u0027/client.pem\u0027) }}\""},{"line_number":25,"context_line":"      octavia_client_key: \"{{ octavia_client_key | default(generated_octavia_cert_dir ~ \u0027/client.key\u0027) }}\""},{"line_number":26,"context_line":"      octavia_ca_certificate: \"{{ octavia_ca_certificate | default(generated_octavia_cert_dir ~ \u0027/ca_server_01.pem\u0027) }}\""},{"line_number":27,"context_line":"      octavia_ca_private_key: \"{{ octavia_ca_private_key | default(generated_octavia_cert_dir ~ \u0027/private/cakey.pem\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b9db462a_ba02620b","line":24,"updated":"2022-06-06 12:41:27.000000000","message":"If I\u0027m reading the old tasks correctly I suspect this should use \u0027client-.pem\u0027 rather than \u0027client.pem\u0027. The former contains just the cert and not the key, which should result in the key appearing just once in the file when concatenated.","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a79dc1dcbabd47ba19829972124a9213640fb17b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    generated_octavia_cert_setup_host: \"{{ octavia_cert_setup_host | default(\u0027localhost\u0027) }}\""},{"line_number":22,"context_line":"    generated_octavia_cert_vars:"},{"line_number":23,"context_line":"      octavia_client_ca: \"{{ octavia_client_ca | default(generated_octavia_cert_dir ~ \u0027/ca_01.pem\u0027) }}\""},{"line_number":24,"context_line":"      octavia_client_cert: \"{{ octavia_client_cert | default(generated_octavia_cert_dir ~ \u0027/client.pem\u0027) }}\""},{"line_number":25,"context_line":"      octavia_client_key: \"{{ octavia_client_key | default(generated_octavia_cert_dir ~ \u0027/client.key\u0027) }}\""},{"line_number":26,"context_line":"      octavia_ca_certificate: \"{{ octavia_ca_certificate | default(generated_octavia_cert_dir ~ \u0027/ca_server_01.pem\u0027) }}\""},{"line_number":27,"context_line":"      octavia_ca_private_key: \"{{ octavia_ca_private_key | default(generated_octavia_cert_dir ~ \u0027/private/cakey.pem\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f00ec7f6_50ec52cc","line":24,"in_reply_to":"b9db462a_ba02620b","updated":"2022-06-06 18:19:25.000000000","message":"well yes, but octavia_client_cert is smth we were distributing? I\u0027m not sure how correct that was though, but for compatability likely worth leaving it...","commit_id":"92555fc1887d1b6ecc8ea029551b2d9ee6d5b770"}]}