)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d318ef36f498fabf3bbef0d4c9042c014b15c451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"24ca5648_ee0ad7fe","updated":"2022-11-17 17:51:49.000000000","message":"recheck - redirect has been dropped by infra","commit_id":"e48ed7e2f7f110daf5df1110348f67c9a5c86333"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d73dd541d6995f7a55779ef86c5c31697cd9d61b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1c610a89_68f2c9fb","updated":"2022-11-18 09:08:57.000000000","message":"recheck ceph tempest run failed with 503","commit_id":"329010487931da5e16e41e12d31f7075d36d04bf"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"d905739b4632ef72cbe260195a27798d05fd163d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"663b520d_61e999c3","updated":"2022-11-26 19:44:58.000000000","message":"I think here i\u0027m not sure if we are saying zookeeper may be installed or not installed at the choice of the deployer - do the changes to cinder/designate roles allow it to be optional?","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"55687ed0597c269f05d8e17ebd8fd9906d886eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e2473c42_f382f534","updated":"2022-11-28 20:44:40.000000000","message":"Will a followup patch add zookeeper to bootstrap_host_scenarios_expanded for any job names containing \u0027infra\u0027? Currently the host group is empty and the healthchecks are not run in the \"infra_validate\" job.","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"7f079102c73223657da95949f8f582120e4ed116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"2f92404d_f1f9365c","updated":"2022-12-01 13:43:22.000000000","message":"looks good but I\u0027m not sure if i should +W before [1] and [2] are merged\n\n[1] https://review.opendev.org/c/openstack/ansible-role-zookeeper/+/864752\n[2] https://review.opendev.org/c/openstack/ansible-role-zookeeper/+/865449","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b684e314acebf2d5a80414c600ace11896427bff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"95bfd7eb_27f46b83","updated":"2022-11-25 16:30:53.000000000","message":"recheck centos stream","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"30b65401f983b7546477126d35dc3e70e884c3e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"17ec01fb_f72b4c2c","in_reply_to":"2f92404d_f1f9365c","updated":"2022-12-01 13:45:43.000000000","message":"these both patches depend on this one. So they can\u0027t be merged without it.","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d9e316254728cbdc6a0cfd8620aebb4453a21aec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"b680f207_abff5dc4","in_reply_to":"663b520d_61e999c3","updated":"2022-11-28 11:29:30.000000000","message":"Yes, intention is that coordination is optional and up to deployer to decide if they want it or not.","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2c1499c83b7c07748cfca4db019ca7f19f349e6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c24a1be2_417939ed","in_reply_to":"e2473c42_f382f534","updated":"2022-11-29 11:41:09.000000000","message":"Helthchecks are run for zookeeper role itself as it appears in scenario:\n\nhttps://zuul.opendev.org/t/openstack/build/d8c0fd68706b42b492a668624c474348/log/job-output.txt#13056\n\nWe can add more in the future, but likely it\u0027s good enough for beginning?","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"}],"etc/openstack_deploy/openstack_user_config.yml.aio.j2":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"86d4440c948d0490b35598d35e2fd1ec05af15a0","unresolved":true,"context_lines":[{"line_number":249,"context_line":"    ip: 172.29.236.100"},{"line_number":250,"context_line":"{% if \u0027infra\u0027 in bootstrap_host_scenarios_expanded %}"},{"line_number":251,"context_line":"    affinity:"},{"line_number":252,"context_line":"      repo_container: 3"},{"line_number":253,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"80dca28b_c49bc687","line":252,"range":{"start_line":252,"start_character":6,"end_line":252,"end_character":20},"updated":"2022-11-16 17:43:37.000000000","message":"copy/paste error?","commit_id":"b7ecbd378f6ab06faabd9944526a0c8c933aeaa0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d1da3a32376b98ad27051b5c4e645f92917326ba","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    ip: 172.29.236.100"},{"line_number":250,"context_line":"{% if \u0027infra\u0027 in bootstrap_host_scenarios_expanded %}"},{"line_number":251,"context_line":"    affinity:"},{"line_number":252,"context_line":"      repo_container: 3"},{"line_number":253,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c24b779e_41d8086a","line":252,"range":{"start_line":252,"start_character":6,"end_line":252,"end_character":20},"in_reply_to":"80dca28b_c49bc687","updated":"2022-11-16 20:34:37.000000000","message":"yeah, thanks!","commit_id":"b7ecbd378f6ab06faabd9944526a0c8c933aeaa0"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"d905739b4632ef72cbe260195a27798d05fd163d","unresolved":true,"context_lines":[{"line_number":243,"context_line":"{% endif %}"},{"line_number":244,"context_line":"    ip: 172.29.236.100"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"{% if \u0027zookeeper\u0027 in bootstrap_host_scenarios_expanded %}"},{"line_number":247,"context_line":"coordination_hosts:"},{"line_number":248,"context_line":"  aio1:"},{"line_number":249,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"1b740c74_6b5176df","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":57},"updated":"2022-11-26 19:44:58.000000000","message":"Won\u0027t only defining coordination hosts with this conditional make it be not present for cinder/designate jobs?\n\nDo you think that we should be adding this by default to shared_infra group if we are saying that a coordination service is now always required for services such as cinder/designate?","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d9e316254728cbdc6a0cfd8620aebb4453a21aec","unresolved":true,"context_lines":[{"line_number":243,"context_line":"{% endif %}"},{"line_number":244,"context_line":"    ip: 172.29.236.100"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"{% if \u0027zookeeper\u0027 in bootstrap_host_scenarios_expanded %}"},{"line_number":247,"context_line":"coordination_hosts:"},{"line_number":248,"context_line":"  aio1:"},{"line_number":249,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3d1efeec_7fd2de7b","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":57},"in_reply_to":"1b740c74_6b5176df","updated":"2022-11-28 11:29:30.000000000","message":"Eventually, it should. Well, for cinder I intentionally didn\u0027t add coordination as we don\u0027t have spare ram in jobs for Java.\nAlso it\u0027s needed for cinder only in case of using active/active mode. And quite limited set of drivers does support active/active. So imo - it\u0027s quite optional.\n\nBut I would expect that having zookeeper in extended scenarios and adding zookeeper for designate here https://review.opendev.org/c/openstack/openstack-ansible/+/864750/19/tests/roles/bootstrap-host/vars/main.yml should be enough to get it added. Though I\u0027m not sure if depends-on will work here or not.","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"6b0d557a6e68e322a51b463c15b8fa624b56cf03","unresolved":false,"context_lines":[{"line_number":243,"context_line":"{% endif %}"},{"line_number":244,"context_line":"    ip: 172.29.236.100"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"{% if \u0027zookeeper\u0027 in bootstrap_host_scenarios_expanded %}"},{"line_number":247,"context_line":"coordination_hosts:"},{"line_number":248,"context_line":"  aio1:"},{"line_number":249,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"a38c1226_1aba0e15","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":57},"in_reply_to":"3d1efeec_7fd2de7b","updated":"2022-11-29 14:29:19.000000000","message":"Done","commit_id":"65ce2753fa50585cd5866ff4b9113983b78d56a5"}]}