)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"ab0100a2c8290e765de8ccc93615b9f52991345f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc83e6bd_bc7bc282","updated":"2023-03-08 18:05:19.000000000","message":"recheck - adjusted handler order in dependant patch","commit_id":"28db99e7bbb2932f5444a378cee199fa6ef7cc2a"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e4d026ad08fe4bd5481a41df7e00605a53ee8b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a74c85d1_5e547283","updated":"2023-03-14 09:04:22.000000000","message":"recheck - ceph focal job failed tempest","commit_id":"af0b0f6bd62447d58b18ee8f55842ce016e80713"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"33536ebb6590192fa74caee9b6ecd7b1d6ebea49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4d3da7c1_b8ad6503","updated":"2023-03-13 11:06:46.000000000","message":"recheck - dependant patch updated","commit_id":"af0b0f6bd62447d58b18ee8f55842ce016e80713"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"8bd4e04266751081684a1646db653e7b8fd3025a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31766757_993bd988","updated":"2023-03-13 14:45:29.000000000","message":"recheck - rocky linux ansible MODULE FAILURE","commit_id":"af0b0f6bd62447d58b18ee8f55842ce016e80713"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"09ef5eb6d4049314c112c1336a770852d93083f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1210c794_6535dce5","updated":"2023-03-28 09:53:51.000000000","message":"876749 is merged","commit_id":"499f3fff2a4cbf22223b8e3ed5d67e68269553d2"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0f806bf43e6ea5c480ddc97e4950f3306c0c1ec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"51faac03_201b94d1","updated":"2023-03-16 11:12:40.000000000","message":"Not placing +W in order to wait for dependent patch to land first.","commit_id":"499f3fff2a4cbf22223b8e3ed5d67e68269553d2"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"a06028d5a1f9be269f3fa44b1f592c0725128dee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"48b95b20_7bb5bd9f","updated":"2023-03-21 15:27:41.000000000","message":"recheck - focal upgrade failed see if this is transient or not","commit_id":"499f3fff2a4cbf22223b8e3ed5d67e68269553d2"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"28f32042818830b6d5c9fea3f9b391f57b7bf068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5d67b2c9_0ed771b5","updated":"2023-04-03 20:23:07.000000000","message":"recheck - gating should be unblocked now","commit_id":"75edc133072fb9fcd436846423638651eb990d36"}],"inventory/group_vars/haproxy/haproxy.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"fa91f65bd158898aaa2b9e7d4f1c26e3ccbeb97c","unresolved":true,"context_lines":[{"line_number":89,"context_line":"  haproxy_redirect_scheme: \"{{ (haproxy_ssl_letsencrypt_enable | bool and haproxy_ssl | bool) | ternary(\u0027https if !{ ssl_fc } !{ path_beg /.well-known/acme-challenge/ }\u0027, \u0027https if !{ ssl_fc }\u0027) }}\""},{"line_number":90,"context_line":"  haproxy_frontend_acls: \"{{ (haproxy_ssl_letsencrypt_enable | bool and haproxy_ssl | bool) | ternary(haproxy_ssl_letsencrypt_acl, {}) }}\""},{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) + [\u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027] }}\""},{"line_number":93,"context_line":"  maps:"},{"line_number":94,"context_line":"    - name: regex"},{"line_number":95,"context_line":"      entries:"},{"line_number":96,"context_line":"        - \"#Regular expression map file - this comment is defined in the base frontend config\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"haproxy_adjutant_api_service:"},{"line_number":99,"context_line":"  haproxy_service_name: adjutant_api"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"62f909f7_8f6a9303","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":94},"updated":"2023-03-08 13:01:43.000000000","message":"this needs improving, it\u0027s not good to just have to add more maps to use to haproxy_frontend_raw, there should be a key specifically for them to be listed against","commit_id":"3053d85f8794018f7cd270f912fc2cdbef5612a8"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"d04b17caaa652eb8d919e8b7e3566aabea3c51dd","unresolved":true,"context_lines":[{"line_number":89,"context_line":"  haproxy_redirect_scheme: \"{{ (haproxy_ssl_letsencrypt_enable | bool and haproxy_ssl | bool) | ternary(\u0027https if !{ ssl_fc } !{ path_beg /.well-known/acme-challenge/ }\u0027, \u0027https if !{ ssl_fc }\u0027) }}\""},{"line_number":90,"context_line":"  haproxy_frontend_acls: \"{{ (haproxy_ssl_letsencrypt_enable | bool and haproxy_ssl | bool) | ternary(haproxy_ssl_letsencrypt_acl, {}) }}\""},{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) + [\u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027] }}\""},{"line_number":93,"context_line":"  maps:"},{"line_number":94,"context_line":"    - name: regex"},{"line_number":95,"context_line":"      entries:"},{"line_number":96,"context_line":"        - \"#Regular expression map file - this comment is defined in the base frontend config\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"haproxy_adjutant_api_service:"},{"line_number":99,"context_line":"  haproxy_service_name: adjutant_api"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"937a2966_e3b53295","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":94},"in_reply_to":"62f909f7_8f6a9303","updated":"2023-03-08 13:14:22.000000000","message":"perhaps better to rename things a bit\n\nhaproxy_maps -\u003e maps in use on this frontend\nhaproxy_map_entries -\u003e map fragments defined in this service\n\n  haproxy_maps:\n    - \u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027\n  haproxy_map_entries:\n    - name: regex\n      entries:\n        - \u0027#Regular expression map file\u0027","commit_id":"3053d85f8794018f7cd270f912fc2cdbef5612a8"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"dad8ef40ff467cd5ba80560956409ccd14f2a48f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  haproxy_redirect_scheme: \"{{ (haproxy_ssl_letsencrypt_enable | bool and haproxy_ssl | bool) | ternary(\u0027https if !{ ssl_fc } !{ path_beg /.well-known/acme-challenge/ }\u0027, \u0027https if !{ ssl_fc }\u0027) }}\""},{"line_number":90,"context_line":"  haproxy_frontend_acls: \"{{ (haproxy_ssl_letsencrypt_enable | bool and haproxy_ssl | bool) | ternary(haproxy_ssl_letsencrypt_acl, {}) }}\""},{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) + [\u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027] }}\""},{"line_number":93,"context_line":"  maps:"},{"line_number":94,"context_line":"    - name: regex"},{"line_number":95,"context_line":"      entries:"},{"line_number":96,"context_line":"        - \"#Regular expression map file - this comment is defined in the base frontend config\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"haproxy_adjutant_api_service:"},{"line_number":99,"context_line":"  haproxy_service_name: adjutant_api"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a62c9914_200d695c","line":96,"range":{"start_line":92,"start_character":0,"end_line":96,"end_character":94},"in_reply_to":"937a2966_e3b53295","updated":"2023-03-13 08:58:10.000000000","message":"Done","commit_id":"3053d85f8794018f7cd270f912fc2cdbef5612a8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4215203f6392ef366bf3f018f3c909a9000ea58c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) }}\""},{"line_number":93,"context_line":"  haproxy_maps:"},{"line_number":94,"context_line":"    - \u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027"},{"line_number":95,"context_line":"  haproxy_map_entries:"},{"line_number":96,"context_line":"    - name: regex"},{"line_number":97,"context_line":"      entries:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f47208ec_80628272","line":94,"updated":"2023-03-15 16:14:05.000000000","message":"don\u0027t you think that \u0027regex\u0027 name is a bit unfortunate? especially if someone defines maps for multiple frontends?\n\nMaybe it would be more obvious if we change \u0027regex\u0027 to just \u0027base\u0027 or \u0027base-regex\u0027? Would do you think?","commit_id":"5e556b670d137cedf7c0350abf830e3d3e065a9b"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"098370ff18ea7259fb491955189fc2386a3f36e0","unresolved":true,"context_lines":[{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) }}\""},{"line_number":93,"context_line":"  haproxy_maps:"},{"line_number":94,"context_line":"    - \u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027"},{"line_number":95,"context_line":"  haproxy_map_entries:"},{"line_number":96,"context_line":"    - name: regex"},{"line_number":97,"context_line":"      entries:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c565866a_4050cdea","line":94,"in_reply_to":"833cf62f_acbaf7ed","updated":"2023-03-16 09:03:50.000000000","message":"yes good idea - i\u0027ve updated that so that the map name includes the frontend where it is applied.","commit_id":"5e556b670d137cedf7c0350abf830e3d3e065a9b"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"0c6c33bb7547aed48c6e6fd79f1c09635263313a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) }}\""},{"line_number":93,"context_line":"  haproxy_maps:"},{"line_number":94,"context_line":"    - \u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027"},{"line_number":95,"context_line":"  haproxy_map_entries:"},{"line_number":96,"context_line":"    - name: regex"},{"line_number":97,"context_line":"      entries:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f9e3ae08_94760cb4","line":94,"in_reply_to":"c565866a_4050cdea","updated":"2023-03-16 09:38:51.000000000","message":"Done","commit_id":"5e556b670d137cedf7c0350abf830e3d3e065a9b"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"a7cf5d23a46333624688990154da6d8fa9f62686","unresolved":true,"context_lines":[{"line_number":91,"context_line":"  haproxy_acls: \"{{ keystone_security_txt_content is defined | ternary(haproxy_security_txt_acl, {}) }}\""},{"line_number":92,"context_line":"  haproxy_frontend_raw: \"{{ (haproxy_ssl | bool and haproxy_security_headers is defined) | ternary( haproxy_security_headers + [ haproxy_horizon_csp | default(haproxy_security_headers_csp)], []) }}\""},{"line_number":93,"context_line":"  haproxy_maps:"},{"line_number":94,"context_line":"    - \u0027use_backend %[path,map_reg(/etc/haproxy/regex.map)]\u0027"},{"line_number":95,"context_line":"  haproxy_map_entries:"},{"line_number":96,"context_line":"    - name: regex"},{"line_number":97,"context_line":"      entries:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"833cf62f_acbaf7ed","line":94,"in_reply_to":"f47208ec_80628272","updated":"2023-03-15 21:51:54.000000000","message":"what do you think?*","commit_id":"5e556b670d137cedf7c0350abf830e3d3e065a9b"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"5d8e01bf73e49a008517f5e54985eb29cc9b9881","unresolved":true,"context_lines":[{"line_number":384,"context_line":"  haproxy_backend_nodes: \"{{ groups[\u0027nova_api_metadata\u0027] | default([]) }}\""},{"line_number":385,"context_line":"  haproxy_bind: \"{{ [internal_lb_vip_address] }}\""},{"line_number":386,"context_line":"  haproxy_port: 8775"},{"line_number":387,"context_line":"  haproxy_ssl: \"{{ (neutron_plugin_type | default(\u0027ml2.ovn\u0027) \u003d\u003d \u0027ml2.calico\u0027) | ternary(False, haproxy_ssl_all_vips) }}\""},{"line_number":388,"context_line":"  haproxy_ssl_all_vips: \"{{ (neutron_plugin_type | default(\u0027ml2.ovn\u0027) \u003d\u003d \u0027ml2.calico\u0027) | ternary(False, haproxy_ssl_all_vips) }}\""},{"line_number":389,"context_line":"  haproxy_balance_type: http"},{"line_number":390,"context_line":"  haproxy_backend_options:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"aa52e068_c5f7e5e2","line":387,"updated":"2023-03-16 09:38:30.000000000","message":"umm what is that? did you add it intentionally?","commit_id":"71ea270d0154fe530da9e2366b06b4adbf2af082"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"bab1eaacc88e338ffc0cb5e23f18b7526cd764b9","unresolved":false,"context_lines":[{"line_number":384,"context_line":"  haproxy_backend_nodes: \"{{ groups[\u0027nova_api_metadata\u0027] | default([]) }}\""},{"line_number":385,"context_line":"  haproxy_bind: \"{{ [internal_lb_vip_address] }}\""},{"line_number":386,"context_line":"  haproxy_port: 8775"},{"line_number":387,"context_line":"  haproxy_ssl: \"{{ (neutron_plugin_type | default(\u0027ml2.ovn\u0027) \u003d\u003d \u0027ml2.calico\u0027) | ternary(False, haproxy_ssl_all_vips) }}\""},{"line_number":388,"context_line":"  haproxy_ssl_all_vips: \"{{ (neutron_plugin_type | default(\u0027ml2.ovn\u0027) \u003d\u003d \u0027ml2.calico\u0027) | ternary(False, haproxy_ssl_all_vips) }}\""},{"line_number":389,"context_line":"  haproxy_balance_type: http"},{"line_number":390,"context_line":"  haproxy_backend_options:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4af45dfb_8cb6cea3","line":387,"in_reply_to":"aa52e068_c5f7e5e2","updated":"2023-03-16 10:26:55.000000000","message":"looks like this patch is crossed paths with https://review.opendev.org/c/openstack/openstack-ansible/+/866119 merging in the meantime.","commit_id":"71ea270d0154fe530da9e2366b06b4adbf2af082"}]}