)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"fed04595cb38772a19a4963072de8c5d95a77603","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Rename openstack_haproxy_horizon_stick_table variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"`openstack_haproxy_horizon_stick_table` is a horizon\u0027s variable(it\u0027s"},{"line_number":10,"context_line":"defined in horizon\u0027s group_vars) so `openstack_` prefix is a bit"},{"line_number":11,"context_line":"misleading. It makes sense to have `_horizon` prefix for this variable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f356cf2673a4e0d40c9dcb04000980fce250c10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8fa9414c_611f05db","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":31},"updated":"2023-04-08 06:20:41.000000000","message":"imho this change is also misleading, as it\u0027s actually a variable to do with haproxy not horizon. variables in role defaults are prefixed, generally, with their role name.... so a var starting horizon_ would be expected to be overriding something in the horizon role.\n\nopenstack_ variables are generally of global scope which somehow wire together settings across different roles or components.\n\nIt is also only defined in the horizon group_vars because it has been moved there as part of the separated service config. it could equally be in the haproxy group vars.","commit_id":"6970ca8330248ec48e990c65169197f348d7a66b"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"a8a1aef87654b8d8434bff62d4c97f8be76ab7c2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Rename openstack_haproxy_horizon_stick_table variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"`openstack_haproxy_horizon_stick_table` is a horizon\u0027s variable(it\u0027s"},{"line_number":10,"context_line":"defined in horizon\u0027s group_vars) so `openstack_` prefix is a bit"},{"line_number":11,"context_line":"misleading. It makes sense to have `_horizon` prefix for this variable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f356cf2673a4e0d40c9dcb04000980fce250c10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b7a28985_f9f67b09","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"8fa9414c_611f05db","updated":"2023-04-11 14:59:10.000000000","message":"so maybe `haproxy_horizon_stick_table` in inventory/group_vars/horizon_all.yml?\n\nwe already have `haproxy_horizon_service` so for me it makes sense.","commit_id":"6970ca8330248ec48e990c65169197f348d7a66b"}]}