)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"4a69c3b6998a7adfbb61a2b9537f7cf316c1a50d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d84b3c26_c044d64d","updated":"2023-06-05 14:03:47.000000000","message":"recheck - ovn failed for openstack-ansible-upgrade_yoga-aio_metal-ubuntu-focal","commit_id":"501a93854f1da6635a6df45ca50b1bba19be42cb"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a98805c1993af85403e9183ff05c2f93b4a09b12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c9e3b61b_36aedab3","updated":"2023-06-08 15:31:58.000000000","message":"TO be frank, I\u0027m not really sure about this one. As I think idea of upgrade test, is to be able to perform required upgrade steps to make config from version N-1 usable for N. Otherwise, if we\u0027re simply re-applying config, what are we testing in upgrade jobs and how they would be different from just regular ones, except will run twice as much?","commit_id":"27401a98082a40fd8c797292daebc0997bfc720d"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"93900b67f5d56a328844698c9356fe9241a69f9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9cb8c539_32be71b5","in_reply_to":"5e96d6b0_d1452637","updated":"2023-06-22 07:25:26.000000000","message":"i\u0027ve changed the behavior to update AIO config only for scenarios from `SCENARIOS_WITH_CONFIG_UPDATE` list","commit_id":"27401a98082a40fd8c797292daebc0997bfc720d"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"2fc547090cb87f06c0a21ce6ce48e085fd266847","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e96d6b0_d1452637","in_reply_to":"c3533d19_d0188146","updated":"2023-06-08 17:53:11.000000000","message":"you may be right, what other solution do you suggest?\n\njust to have it said: this change is needed to perform an openstack upgrade where tls is disabled on source release and enabled on target release: https://review.opendev.org/c/openstack/openstack-ansible/+/885194\n\nmaybe we can run it only for tls-transition scenario but i\u0027m open for other ideas","commit_id":"27401a98082a40fd8c797292daebc0997bfc720d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"04c216f1171fb4126b7c142b23a6a5a82b0302f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c3533d19_d0188146","in_reply_to":"c9e3b61b_36aedab3","updated":"2023-06-08 15:32:26.000000000","message":"I\u0027d propose to discuss that during our session next week","commit_id":"27401a98082a40fd8c797292daebc0997bfc720d"}],"scripts/gate-check-commit.sh":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e73984a7c20abe849bfb8bd0b89b4bb729d7de68","unresolved":true,"context_lines":[{"line_number":50,"context_line":"export SETUP_ARA\u003d${SETUP_ARA:-true}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# List of scenarios that update configuration files prior to the upgrade"},{"line_number":53,"context_line":"export SCENARIOS_WITH_CONFIG_UPDATE\u003d(\"tls-transition\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"## Change branch for Upgrades ------------------------------------------------"},{"line_number":56,"context_line":"# If the action is to upgrade, then store the current SHA,"}],"source_content_type":"text/x-sh","patch_set":8,"id":"80d316f4_69d73ca1","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":52},"updated":"2023-07-06 14:51:14.000000000","message":"As I\u0027ve mentioned in [1], such scenario name is not correct.\n\n[1] https://review.opendev.org/c/openstack/openstack-ansible/+/885194","commit_id":"4006571e4b0ca83a8d2cf162dac1c0e959334551"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"24ade263d90e2da09c800c7d0bd38b6372c530b2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"export SETUP_ARA\u003d${SETUP_ARA:-true}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# List of scenarios that update configuration files prior to the upgrade"},{"line_number":53,"context_line":"export SCENARIOS_WITH_CONFIG_UPDATE\u003d(\"tls-transition\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"## Change branch for Upgrades ------------------------------------------------"},{"line_number":56,"context_line":"# If the action is to upgrade, then store the current SHA,"}],"source_content_type":"text/x-sh","patch_set":8,"id":"75f8df33_9d256bd7","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":52},"in_reply_to":"80d316f4_69d73ca1","updated":"2023-07-06 16:44:56.000000000","message":"fixed","commit_id":"4006571e4b0ca83a8d2cf162dac1c0e959334551"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e73984a7c20abe849bfb8bd0b89b4bb729d7de68","unresolved":true,"context_lines":[{"line_number":269,"context_line":"    for item in \"${SCENARIOS_WITH_CONFIG_UPDATE[@]}\"; do"},{"line_number":270,"context_line":"      if [[ \"${SCENARIO}\" \u003d~ \"${item}\" ]]; then"},{"line_number":271,"context_line":"        export BOOTSTRAP_EXTRA_PARAMS\u003d\"${BOOTSTRAP_EXTRA_PARAMS:-} -t prepare-aio-config\""},{"line_number":272,"context_line":"        \"${OSA_CLONE_DIR}/scripts/bootstrap-aio.sh\""},{"line_number":273,"context_line":"        break"},{"line_number":274,"context_line":"      fi"},{"line_number":275,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"a41426c8_693b7065","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":51},"updated":"2023-07-06 14:51:14.000000000","message":"why would we run bootstrap-aio multiple times with the same tag? Shouldn\u0027t that be done outside of the cycle?\n\nAlso, I\u0027m not sure that `for` is even needed here...","commit_id":"4006571e4b0ca83a8d2cf162dac1c0e959334551"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"24ade263d90e2da09c800c7d0bd38b6372c530b2","unresolved":true,"context_lines":[{"line_number":269,"context_line":"    for item in \"${SCENARIOS_WITH_CONFIG_UPDATE[@]}\"; do"},{"line_number":270,"context_line":"      if [[ \"${SCENARIO}\" \u003d~ \"${item}\" ]]; then"},{"line_number":271,"context_line":"        export BOOTSTRAP_EXTRA_PARAMS\u003d\"${BOOTSTRAP_EXTRA_PARAMS:-} -t prepare-aio-config\""},{"line_number":272,"context_line":"        \"${OSA_CLONE_DIR}/scripts/bootstrap-aio.sh\""},{"line_number":273,"context_line":"        break"},{"line_number":274,"context_line":"      fi"},{"line_number":275,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"a8927009_cff56c78","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":51},"in_reply_to":"a41426c8_693b7065","updated":"2023-07-06 16:44:56.000000000","message":"we don\u0027t run bootstrap-aio multiple times, you probably missed `break` statement\n\n`for` is needed because I assume that in the future `SCENARIOS_WITH_CONFIG_UPDATE` may have more elements and bash is not very handy when it comes to working with arrays\n\nI really tried to make it simpler but that\u0027s the best I could do","commit_id":"4006571e4b0ca83a8d2cf162dac1c0e959334551"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0b21e3298cc2e5c3de3bd67938c75d60ebae54f9","unresolved":true,"context_lines":[{"line_number":269,"context_line":"    for item in \"${SCENARIOS_WITH_CONFIG_UPDATE[@]}\"; do"},{"line_number":270,"context_line":"      if [[ \"${SCENARIO}\" \u003d~ \"${item}\" ]]; then"},{"line_number":271,"context_line":"        export BOOTSTRAP_EXTRA_PARAMS\u003d\"${BOOTSTRAP_EXTRA_PARAMS:-} -t prepare-aio-config\""},{"line_number":272,"context_line":"        \"${OSA_CLONE_DIR}/scripts/bootstrap-aio.sh\""},{"line_number":273,"context_line":"        break"},{"line_number":274,"context_line":"      fi"},{"line_number":275,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba85cadc_86190076","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":51},"in_reply_to":"a8927009_cff56c78","updated":"2023-07-07 16:46:40.000000000","message":"Ah, true, I missed `break` indeed. Ok then","commit_id":"4006571e4b0ca83a8d2cf162dac1c0e959334551"}]}