)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3657f05b511408048325ec1bd8042ddbcb9097cc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027tls-transition\u0027 scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since TLS is enabled on both haproxy VIPs and backends by default,"},{"line_number":10,"context_line":"the transition from non-TLS to TLS should be properly tested."},{"line_number":11,"context_line":"This patch changes a \u0027tls\u0027 scenario to \u0027tls-transition\u0027 scenario."},{"line_number":12,"context_line":"\u0027tls-transition\u0027 scenario is responsible for performing an openstack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"72a1b870_afed210c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":65},"updated":"2023-07-06 14:30:13.000000000","message":"it\u0027s disabled by default? It\u0027s true only for `tls` scenario?","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"2637581ac048f232274c17d414672f7c491f16f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027tls-transition\u0027 scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since TLS is enabled on both haproxy VIPs and backends by default,"},{"line_number":10,"context_line":"the transition from non-TLS to TLS should be properly tested."},{"line_number":11,"context_line":"This patch changes a \u0027tls\u0027 scenario to \u0027tls-transition\u0027 scenario."},{"line_number":12,"context_line":"\u0027tls-transition\u0027 scenario is responsible for performing an openstack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7e775c08_936c13e9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":65},"in_reply_to":"72a1b870_afed210c","updated":"2023-07-06 17:35:31.000000000","message":"when i was writing this change i was thinking that we are going to enable tls everywhere by default and this change was based on the previous one responsible for enabling tls by default.\n\nI forgot to update commit msg after we decided not to enable tls by default.\n\nfixed","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3657f05b511408048325ec1bd8042ddbcb9097cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"470950da_000f5492","updated":"2023-07-06 14:30:13.000000000","message":"Do we really need to rename the scenario? Can\u0027t we just leave it as TLS, but use upgrade ACTION instead?\n\nAs current name is not parsed properly, so CI doesn\u0027t do what you expect it would.","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"996868f13535783ab0a20298fd45d30f63819891","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"059245cc_fbcdc0fc","updated":"2023-06-29 08:20:12.000000000","message":"recheck - \nopenstack-ansible-upgrade-aio_metal_tls-transition-rockylinux-9 timeout","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"6010ca64007138e9bfe29614ed2f2f6e94f7bf49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6c79a924_6c031dd0","updated":"2023-06-30 09:20:09.000000000","message":"recheck - a lot of tasks failed for no reason, it didn\u0027t happen during previous rechecks O.o","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"9ecda06b9314117ed79df609434df588542afe5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d02d700b_c933fe8b","updated":"2023-06-29 16:09:49.000000000","message":"recheck - a lot of timeouts/failures(probably something was off on INFRA side)","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"1ea316699647163090df32456291120a7b05f70f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"72374582_8bbfaccd","updated":"2023-06-29 12:38:01.000000000","message":"recheck - openstack-ansible-deploy-aio_stepca-ubuntu-jammy failed","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"9bb1584983d8ff72e6aa30d2c11335873c16a9c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"10d83516_7d2933c1","updated":"2023-06-28 06:36:52.000000000","message":"recheck - tempest failed for openstack-ansible-deploy-aio_ceph-ubuntu-focal","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"20d634c685f112fe9377de1f311c43492dacf9fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"742b9291_5bfb11da","updated":"2023-06-28 19:31:54.000000000","message":"recheck - tempest failed for openstack-ansible-deploy-aio_lxc-ubuntu-focal","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"2637581ac048f232274c17d414672f7c491f16f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"00236fd1_f0e7a62c","in_reply_to":"470950da_000f5492","updated":"2023-07-06 17:35:31.000000000","message":"hmm..i think you are right\n\nwhen i was writing this change i was thinking that we are going to enable tls everywhere by default. It would mean that we won\u0027t need \u0027tls\u0027 scenario anymore and \u0027tls-transition\u0027 will better describe the purpose of these tests.\n\nBut now, after we decided to keep tls-backend disabled by default, it actually makes sense to have single scenario named just \u0027tls\u0027","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"488e66f7ccea932ec8f4989b8fbdf6cc5ba19c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d85d31c8_0f918fe2","updated":"2023-07-07 16:49:26.000000000","message":"At glance looks like this is working. user_variables_tls at least has proper content now.","commit_id":"41d2dcaa47e6f9c9cfffa472e5877cdb586bdab6"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"a6432287b0444faa9f062fe7d460fcc4820eb5cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3bbef4a8_3e869982","updated":"2023-07-06 21:12:56.000000000","message":"recheck - openstack-ansible-upgrade-aio_metal-rockylinux-9 timeout","commit_id":"41d2dcaa47e6f9c9cfffa472e5877cdb586bdab6"}],"tests/roles/bootstrap-host/templates/user_variables_tls.yml.j2":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"cf71c2f61b34edb7c1b2eea6cb13b00cf1dc566f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if lookup(\u0027env\u0027, \u0027UPGRADE_TARGET_BRANCH\u0027) \u003d\u003d \u0027\u0027 %}"},{"line_number":15,"context_line":"# Make sure that TLS is fully enabled on target release."},{"line_number":16,"context_line":"openstack_service_publicuri_proto: https"},{"line_number":17,"context_line":"openstack_service_adminuri_proto: https"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"1b5f4e05_29b5afe3","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"updated":"2023-07-13 11:44:04.000000000","message":"what happens here if i run a regular AIO with `tls` in SCENARIO? will it be enabled?","commit_id":"41d2dcaa47e6f9c9cfffa472e5877cdb586bdab6"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"35cdd64062adadac5539e6cf6feec94fa747c850","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if lookup(\u0027env\u0027, \u0027UPGRADE_TARGET_BRANCH\u0027) \u003d\u003d \u0027\u0027 %}"},{"line_number":15,"context_line":"# Make sure that TLS is fully enabled on target release."},{"line_number":16,"context_line":"openstack_service_publicuri_proto: https"},{"line_number":17,"context_line":"openstack_service_adminuri_proto: https"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5fe3f25a_ae02178a","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"in_reply_to":"1b5f4e05_29b5afe3","updated":"2023-07-13 15:14:07.000000000","message":"yes: https://zuul.opendev.org/t/openstack/build/505501535c6e434bbdb06bd985dcd386/log/logs/etc/host/openstack_deploy/user_variables_tls.yml.txt","commit_id":"41d2dcaa47e6f9c9cfffa472e5877cdb586bdab6"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3657f05b511408048325ec1bd8042ddbcb9097cc","unresolved":true,"context_lines":[{"line_number":427,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"- job:"},{"line_number":430,"context_line":"    name: openstack-ansible-upgrade-aio_metal_tls-transition-ubuntu-jammy"},{"line_number":431,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":432,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c848e818_a2c653f1","line":430,"range":{"start_line":430,"start_character":46,"end_line":430,"end_character":61},"updated":"2023-07-06 14:30:13.000000000","message":"I think this scenario is going to be parsed [1] wrongly, as `-` delimiter is used to distinguish where scenario ends.\n\nSo scenario will be just `aio_metal_tls`: https://zuul.opendev.org/t/openstack/build/20ea38c6502046e0b84de646d68aa04d/log/job-output.txt#5320\n\n[1] https://opendev.org/openstack/openstack-ansible/src/branch/master/zuul.d/playbooks/pre-gate-scenario.yml#L34","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"2637581ac048f232274c17d414672f7c491f16f9","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"- job:"},{"line_number":430,"context_line":"    name: openstack-ansible-upgrade-aio_metal_tls-transition-ubuntu-jammy"},{"line_number":431,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":432,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4c29e198_74165f6a","line":430,"range":{"start_line":430,"start_character":46,"end_line":430,"end_character":61},"in_reply_to":"aff33329_f6bd895c","updated":"2023-07-06 17:35:31.000000000","message":"that\u0027s a valid point...i wonder why it worked fine on my AIO\n\nfixed","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"643555789d963393b105cd9e54a943a6ee98bf52","unresolved":true,"context_lines":[{"line_number":427,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"- job:"},{"line_number":430,"context_line":"    name: openstack-ansible-upgrade-aio_metal_tls-transition-ubuntu-jammy"},{"line_number":431,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":432,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"aff33329_f6bd895c","line":430,"range":{"start_line":430,"start_character":46,"end_line":430,"end_character":61},"in_reply_to":"c848e818_a2c653f1","updated":"2023-07-06 14:31:42.000000000","message":"As with just `tls` it should be perfectly fine. If it\u0027s deploy - it will be all TLS, as UPGRADE_TARGET_BRANCH is not defined. If it\u0027s upgrade - it would work as transition?","commit_id":"052ec60d3caf16b1119cd49dba6278d744a92af8"}]}