)]}'
{"id":"openstack%2Fopenstack-ansible~888660","triplet_id":"openstack%2Fopenstack-ansible~stable%2Fzed~Iaf81f778ffd9fcf6572e03e8ce73ffef46bd98aa","project":"openstack/openstack-ansible","branch":"stable/zed","topic":"osa/core-2.15-stable/zed","attention_set":{},"removed_from_attention_set":{"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-07-25 16:59:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iaf81f778ffd9fcf6572e03e8ce73ffef46bd98aa","subject":"Use include_role in task to avoid lack of access to vars","status":"MERGED","created":"2023-07-20 09:20:07.000000000","updated":"2023-07-25 17:01:50.000000000","submitted":"2023-07-25 16:59:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"888660-osa/core-2.15-stable/zed","cherry_pick_of_change":887082,"cherry_pick_of_patch_set":3,"meta_rev_id":"1a2572a0c5328a702f2c6baf9d20f9f2e14f5e63","_number":888660,"virtual_id_number":888660,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-07-25 16:59:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":2,"date":"2023-07-25 13:30:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-07-25 14:15:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-07-25 14:15:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-20 12:27:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-25 14:15:33.000000000","updated_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"reviewer":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"state":"REVIEWER"}],"messages":[{"id":"fc8ad54a4534205cae65f7ccfe5d64311c4c5e1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-07-20 09:20:07.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"82f6550c056765fdf5c177d269deae4aa94235a6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-20 12:27:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/182243001d854686ab8ec70ad3f0ac91\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/49373ce8810348048aec2d9f5f0cb1f6 : SUCCESS in 16m 37s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/f128552b3475425d8b6333c385046d15 : SUCCESS in 14m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/50c5eae1ddbb41b1b71cbac7c50db7f0 : SUCCESS in 10m 45s\n- openstack-ansible-deploy-aio_lxc-centos-9-stream https://zuul.opendev.org/t/openstack/build/5b67a943c2eb4ce885f4398abd382613 : FAILURE in 38m 46s (non-voting)\n- openstack-ansible-deploy-aio_lxc-rockylinux-9 https://zuul.opendev.org/t/openstack/build/05267af2c3674100a5bc573bec3b5e63 : FAILURE in 2h 02m 54s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/85f5c755d6d24d0d84bb002829270d9f : FAILURE in 2h 04m 55s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/de50f68725e344b0aeac3fe1899195d7 : FAILURE in 2h 53m 06s\n- openstack-ansible-deploy-aio_lxc-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/46cd90b142c346bd98639a5ec83d40ac : FAILURE in 2h 13m 10s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/ea1b76e39a954176bb2710438200cd7a : FAILURE in 1h 21m 10s\n- openstack-ansible-deploy-aio_metal-centos-9-stream https://zuul.opendev.org/t/openstack/build/87155916e8414077a8494c14680e88a4 : FAILURE in 1h 00m 11s (non-voting)\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/3dd3524e63924311a776279727999da0 : FAILURE in 1h 28m 48s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c8b8bebfd2504ec5a783d4b6df24c1fb : FAILURE in 1h 39m 29s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/828c6b69dfb34a8ebe123e5aab9d096d : FAILURE in 1h 21m 56s\n- openstack-ansible-upgrade-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/f0fe5d9434fc42b4a33c0499acf8a2f6 : FAILURE in 2h 33m 15s\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/921ad4c1e51242d09dc4583c7d578aa8 : FAILURE in 2h 08m 34s\n- openstack-ansible-deploy-aio_distro_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/64b03c4b9ad04adc80b61914613e2014 : FAILURE in 45m 15s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/a70592bdc9d9401f8b49f93032ef75b4 : FAILURE in 1h 08m 10s (non-voting)\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/694454a735414339b18c8ea9ff3fa152 : FAILURE in 2h 27m 33s\n- openstack-ansible-deploy-aio_ceph-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/8f179a367e5d47bf9a5e28ab6434f1a0 : FAILURE in 2h 16m 28s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3edb924dbfff4a5683c84c8723bf0d09 : FAILURE in 2h 32m 15s","accounts_in_message":[],"_revision_number":1},{"id":"4d3de5c0c9dc1117c33097b8b2d08f59d3932955","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-07-24 07:38:48.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"fd12e3d660952330ff9c8a022225b95039a80ab6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-24 10:01:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6db4477faf3e428f8e4705f002a0776b\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/788815e06a064cc6ae7d77985b7641ab : SUCCESS in 10m 28s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/64d05fdc037c452eb6e004110785b39f : SUCCESS in 12m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/885ca2982bdc49b690d7830e5c29f1a3 : SUCCESS in 9m 19s\n- openstack-ansible-deploy-aio_lxc-centos-9-stream https://zuul.opendev.org/t/openstack/build/4cc60da5590a4627b2633cf3ae7f0966 : FAILURE in 35m 49s (non-voting)\n- openstack-ansible-deploy-aio_lxc-rockylinux-9 https://zuul.opendev.org/t/openstack/build/65259c843ad0404fb06b4ad7caf03255 : SUCCESS in 1h 57m 45s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/f4e02c217a0e47d4b09ee4744f4e936e : SUCCESS in 1h 34m 04s\n- openstack-ansible-deploy-aio_lxc-ubuntu-focal https://zuul.opendev.org/t/openstack/build/879b05c88a7546f58a3ba843f1a49337 : SUCCESS in 2h 12m 21s\n- openstack-ansible-deploy-aio_lxc-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/059600cdf9924e1d94b23f5a60f6b224 : SUCCESS in 1h 35m 58s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/7c99bac81e6c4a4eae61d93667bbe468 : SUCCESS in 1h 21m 43s\n- openstack-ansible-deploy-aio_metal-centos-9-stream https://zuul.opendev.org/t/openstack/build/d39ed7ca0afa4cff885dc93802dfae06 : FAILURE in 58m 10s (non-voting)\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/35cc1cc130fa458e82e9d92ba2ff77d7 : SUCCESS in 1h 33m 58s\n- openstack-ansible-deploy-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ab3038b6e3f04632b7a51d6d0ae51ee7 : SUCCESS in 1h 21m 19s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/acdeef9cb0514e28a0eb0c6b3b5b7526 : SUCCESS in 1h 18m 38s\n- openstack-ansible-upgrade-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/db8c8d4f1e5248a18caa72748f5c4a70 : SUCCESS in 2h 15m 04s\n- openstack-ansible-upgrade-aio_metal-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ea24482b9e064e699c8a5f4e722e5a42 : SUCCESS in 1h 58m 47s\n- openstack-ansible-deploy-aio_distro_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/a38410d069e24fd6a9db9822505d8bd7 : FAILURE in 39m 08s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/284d6e100e27402b993d8aad0be8c9df : SUCCESS in 1h 06m 56s (non-voting)\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/99d9d8dcafb542ca8f6cee6a412a00fa : SUCCESS in 2h 07m 43s\n- openstack-ansible-deploy-aio_ceph-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/b1ab3ff02ace4a7ca4e28e50a0e0759c : SUCCESS in 2h 08m 16s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a5ad0b63aa3143e18e9c91b960feab2f : SUCCESS in 2h 09m 23s","accounts_in_message":[],"_revision_number":2},{"id":"ca2f5fae042559e1b76f3eb60c4eb9368c52f7de","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-07-25 13:30:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b78eb27d23a3249a83f06a75774b2d99e28991d6","author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"date":"2023-07-25 14:15:33.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"64ffe7c533501a9542c42a51df21594f5131940e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 14:17:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b18b0d3dc8d310e15a9a611c65041c10fd984aad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 16:59:22.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/01158f07f0bb4dddb6a5bd81452100ed\n\n- openstack-ansible-linters-ubuntu-focal https://zuul.opendev.org/t/openstack/build/214667d3ea224a7eb03002833253999d : SUCCESS in 13m 39s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/03a3ff1cb1fc449c9734195d19547bb1 : SUCCESS in 16m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f83bfabb5f17477fa3333702d55434ff : SUCCESS in 10m 03s\n- openstack-ansible-deploy-aio_lxc-rockylinux-9 https://zuul.opendev.org/t/openstack/build/c92a6df9eca74a6383c70c9c31d4f9f3 : SUCCESS in 2h 29m 17s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/ef96e724fa834508ad0271a483c7d1e2 : SUCCESS in 2h 14m 14s\n- openstack-ansible-deploy-aio_lxc-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/1a71d15a374a44a2a7b25891b5b0b6b0 : SUCCESS in 2h 10m 04s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/18343ecf40bd4a3b8bd37de3c4809d6c : SUCCESS in 1h 19m 09s\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/6dd9081f4d0149f680dcd2259f8fcb19 : SUCCESS in 1h 29m 43s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/7291145047e54a18808554e266643d1a : SUCCESS in 1h 22m 42s\n- openstack-ansible-deploy-aio_ceph-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d782d17fd0c64e0780026a8fe6fae68a : SUCCESS in 2h 34m 43s\n- openstack-ansible-deploy-aio_proxy-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0d3eea23f2d3465c809aafce6da1a13a : SUCCESS in 2h 14m 36s","accounts_in_message":[],"_revision_number":2},{"id":"9f86e8a45e190a158481a7d12d093f649e211f6a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 16:59:23.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"1a2572a0c5328a702f2c6baf9d20f9f2e14f5e63","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-25 17:01:50.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2e729f31ae4c4db0afe820143f4bfb12\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a4a0e257e09b45149061af4cfbc0c2d0 : SUCCESS in 2m 06s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"63641540a63260081e18b076011d96a4ff65fd47","revisions":{"0f12220b8e666f88eae934496ff3a249cd4d9486":{"kind":"REWORK","_number":1,"created":"2023-07-20 09:20:07.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/60/888660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/60/888660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/1"}}},"commit":{"parents":[{"commit":"fc482c9e49640bb80820d5f648c11e18baa32b89","subject":"Drop `else` condition in the container_skel_load loop","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/fc482c9e49640bb80820d5f648c11e18baa32b89"}]}],"author":{"name":"root","email":"root@aio1.openstack.local","date":"2023-06-27 16:18:44.000000000","tz":0},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","date":"2023-07-20 09:20:07.000000000","tz":0},"subject":"Use include_role in task to avoid lack of access to vars","message":"Use include_role in task to avoid lack of access to vars\n\nThis patch updates the security hardening playbook to use include_role\nwithin a task versus using \u0027roles\u0027 directly to fix cases where\napply_security_hardening is set to False. Some change to Ansible\nappears to limit access to vars when the role is skipped, resulting\nin failures. The side effect of this change is the role is skipped\nentirely (when applicable) versus the individual tasks being skipped,\nwhich speeds up deployment times.\n\nChange-Id: Iaf81f778ffd9fcf6572e03e8ce73ffef46bd98aa\n(cherry picked from commit 9690b34193430d99c201e3ac2e85258e6aba011e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/0f12220b8e666f88eae934496ff3a249cd4d9486"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/0f12220b8e666f88eae934496ff3a249cd4d9486"}]},"branch":"refs/heads/stable/zed"},"63641540a63260081e18b076011d96a4ff65fd47":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-07-24 07:38:48.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/60/888660/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/60/888660/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/60/888660/2"}}},"commit":{"parents":[{"commit":"17abe18d8b45b4585734adcdddd4caeba7de3e40","subject":"Re-enable CI jobs after rally is fixed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/17abe18d8b45b4585734adcdddd4caeba7de3e40"}]}],"author":{"name":"root","email":"root@aio1.openstack.local","date":"2023-06-27 16:18:44.000000000","tz":0},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","date":"2023-07-24 07:38:48.000000000","tz":0},"subject":"Use include_role in task to avoid lack of access to vars","message":"Use include_role in task to avoid lack of access to vars\n\nThis patch updates the security hardening playbook to use include_role\nwithin a task versus using \u0027roles\u0027 directly to fix cases where\napply_security_hardening is set to False. Some change to Ansible\nappears to limit access to vars when the role is skipped, resulting\nin failures. The side effect of this change is the role is skipped\nentirely (when applicable) versus the individual tasks being skipped,\nwhich speeds up deployment times.\n\nChange-Id: Iaf81f778ffd9fcf6572e03e8ce73ffef46bd98aa\n(cherry picked from commit 9690b34193430d99c201e3ac2e85258e6aba011e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/63641540a63260081e18b076011d96a4ff65fd47"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/63641540a63260081e18b076011d96a4ff65fd47"}]},"branch":"refs/heads/stable/zed","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}