)]}'
{"id":"openstack%2Fopenstack-ansible~891575","triplet_id":"openstack%2Fopenstack-ansible~master~I88ab8819979509ffd1582f06be85d127e93ac47f","project":"openstack/openstack-ansible","branch":"master","topic":"osa/h2","attention_set":{},"removed_from_attention_set":{"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-08-23 13:21:41.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I88ab8819979509ffd1582f06be85d127e93ac47f","subject":"Enable HTTP/2 for TLS-covered frontends","status":"ABANDONED","created":"2023-08-16 09:31:45.000000000","updated":"2023-08-23 13:21:41.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b3319a75ee4b8c924d3e5782d9d57cfbe556eb25","_number":891575,"virtual_id_number":891575,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-08-22 16:54:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-16 12:07:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5e474bf629fe67b050b66458772d4f8e3994f94c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-16 09:31:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"50ff0e1427d621a48950d40f6a529befa00dd30f","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-16 09:34:04.000000000","message":"Topic set to osa/h2","accounts_in_message":[],"_revision_number":1},{"id":"24b849a6c93ac3b46b76525737d129ecff234b59","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-16 12:07:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/32100f78a2214efbbafb8952ab20ac7a\n\n- openstack-ansible-linters-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/e02c88d74c13439c8d6e1a258d2ef1b9 : SUCCESS in 14m 13s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/bc0ba1a59a64471189f7a7f123751f4d : SUCCESS in 18m 28s\n- openstack-ansible-tox-inventory https://zuul.opendev.org/t/openstack/build/3ad28e5d86f1431ba0197dfccea4b6d4 : SUCCESS in 3m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2f4b140a70dc4772925202fe1ec466c9 : SUCCESS in 9m 41s\n- openstack-ansible-deploy-aio_lxc-centos-9-stream https://zuul.opendev.org/t/openstack/build/b551c3ea03ce42d98d74308c6cb8120b : SUCCESS in 2h 17m 00s (non-voting)\n- openstack-ansible-deploy-aio_lxc-rockylinux-9 https://zuul.opendev.org/t/openstack/build/5c03b7cb797b49828b1e001bca5025eb : SUCCESS in 2h 30m 47s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/5580f97a408943cbaafbcde7f3c1508b : SUCCESS in 1h 56m 01s\n- openstack-ansible-deploy-aio_lxc-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/981e3bb3d09041728c9e0185e9a3c611 : SUCCESS in 2h 07m 56s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/e614226f9ec449c3bbe99a10f2b3e612 : SUCCESS in 1h 34m 59s\n- openstack-ansible-deploy-aio_metal-centos-9-stream https://zuul.opendev.org/t/openstack/build/5fec1d22c8e74ef3931d63bc992744f3 : SUCCESS in 1h 44m 50s (non-voting)\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/08d70617772241be8be86841efb8ddb1 : SUCCESS in 1h 44m 09s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/f20b7cfd35fc41aab0ad699d7c36163c : SUCCESS in 1h 38m 24s\n- openstack-ansible-deploy-aio_metal_tls-rockylinux-9 https://zuul.opendev.org/t/openstack/build/6a8ed8d72ef5425e8c0ad6760dcbdc37 : SUCCESS in 1h 54m 48s\n- openstack-ansible-deploy-aio_metal_tls-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/dfc1576e698940a284da96f011428189 : SUCCESS in 1h 38m 35s\n- openstack-ansible-upgrade-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/b2ac3f21e3bf4b0daef39f41707480f9 : SUCCESS in 2h 22m 17s\n- openstack-ansible-upgrade-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/d0ee1ebdf4884c46806783d81169ccf8 : SUCCESS in 2h 28m 05s\n- openstack-ansible-deploy-aio_distro_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/9ed9aa98b91a4c839be97bfa1c4d4837 : SUCCESS in 1h 08m 41s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/5bd5b2d957cd4e0f8fe40acafae2261e : SUCCESS in 1h 09m 32s (non-voting)\n- openstack-ansible-deploy-aio_ceph-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/ea27cdc661b94b0185dcce4f89370527 : SUCCESS in 2h 00m 01s\n- openstack-ansible-deploy-aio_proxy-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/47e868a12db541bc8c0682ae95ee38ee : SUCCESS in 1h 52m 39s\n- openstack-ansible-deploy-aio_stepca-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/5b50b8b50ae343e29b8ac3a39bdf83dc : SUCCESS in 2h 09m 58s\n- openstack-ansible-deploy-aio_metal_stepca-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/c8ddf86dcbb74c61b965351b8c94b8b7 : SUCCESS in 1h 28m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/269df62b681c4e618e500ff581d5c10c : SUCCESS in 6m 40s","accounts_in_message":[],"_revision_number":1},{"id":"008869dec2079710af8e075bd0632c9ec2be366d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-22 13:46:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"12eb7f08b28afda856013f380ba159eb858846af","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-22 16:54:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/6b592f3c509e4bf08fd7746a62fcb648\n\n- openstack-ansible-linters-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/1b022315fd8940ab946bea69cef00141 : SUCCESS in 15m 32s\n- openstack-ansible-varstest-aio https://zuul.opendev.org/t/openstack/build/1134879c7ed64fe48802f7e98c734108 : SUCCESS in 15m 18s\n- openstack-ansible-tox-inventory https://zuul.opendev.org/t/openstack/build/43edc4ee895e48988b5aba0b180b0037 : SUCCESS in 4m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5be707a166974ed4835178d3addbe4fb : SUCCESS in 10m 34s\n- openstack-ansible-deploy-aio_lxc-centos-9-stream https://zuul.opendev.org/t/openstack/build/42acf321d1ae458593027715b2f1e076 : SUCCESS in 2h 17m 04s (non-voting)\n- openstack-ansible-deploy-aio_lxc-rockylinux-9 https://zuul.opendev.org/t/openstack/build/c24c6f034e074e4181e009d20b79adf6 : SUCCESS in 2h 08m 28s\n- openstack-ansible-deploy-aio_lxc-debian-bullseye https://zuul.opendev.org/t/openstack/build/4ef0eaf91b064b26a3ff08f314550500 : SUCCESS in 1h 55m 55s\n- openstack-ansible-deploy-aio_lxc-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/c864bd25b95b43788a9bd5ba8dc4e990 : FAILURE in 1h 48m 37s\n- openstack-ansible-deploy-aio_metal-debian-bullseye https://zuul.opendev.org/t/openstack/build/cd1415a9a53c4dc7b4b35555a9d7eec9 : SUCCESS in 1h 43m 43s\n- openstack-ansible-deploy-aio_metal-centos-9-stream https://zuul.opendev.org/t/openstack/build/250174fd23c34799b2696714e06b97d9 : SUCCESS in 1h 57m 00s (non-voting)\n- openstack-ansible-deploy-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/834b2cc091fb46deb4be788c886f6833 : SUCCESS in 1h 35m 15s\n- openstack-ansible-deploy-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/3d674b67d67d4e09ba62a25840fb8379 : SUCCESS in 1h 21m 21s\n- openstack-ansible-deploy-aio_metal_tls-rockylinux-9 https://zuul.opendev.org/t/openstack/build/cc865aec600b47b3b43caf02619bfa1b : SUCCESS in 1h 49m 42s\n- openstack-ansible-deploy-aio_metal_tls-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/0332107a3d9b4fb1b45cc6558b9e4caa : SUCCESS in 1h 39m 34s\n- openstack-ansible-upgrade-aio_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/915cea37895442869133d3c7f4f3d9ba : SUCCESS in 2h 28m 57s\n- openstack-ansible-upgrade-aio_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/9bfe40cbfb7e4eb489abaaec8c350a4c : SUCCESS in 2h 15m 32s\n- openstack-ansible-deploy-aio_distro_metal-rockylinux-9 https://zuul.opendev.org/t/openstack/build/86349d39ca094a4290b7d1ad08ac7a09 : SUCCESS in 1h 04m 58s (non-voting)\n- openstack-ansible-deploy-aio_distro_metal-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/1074e44bb15c4520831214bb4b9d58cb : SUCCESS in 1h 11m 57s (non-voting)\n- openstack-ansible-deploy-aio_ceph-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/0869729721a04f60ac47865d443b9d3e : SUCCESS in 2h 02m 49s\n- openstack-ansible-deploy-aio_proxy-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/1ab714b5636b4b4783d17731a553263e : SUCCESS in 1h 48m 11s\n- openstack-ansible-deploy-aio_stepca-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/8c6ecacc519e4d1da3aa83333e27e0f8 : SUCCESS in 1h 50m 36s\n- openstack-ansible-deploy-aio_metal_stepca-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/950fd69d16e04ddb996a172828f3a8ff : SUCCESS in 1h 25m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e2d7487bf3634f0d93e952a08dfae503 : SUCCESS in 7m 26s","accounts_in_message":[],"_revision_number":2},{"id":"b3319a75ee4b8c924d3e5782d9d57cfbe556eb25","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-23 13:21:41.000000000","message":"Abandoned\n\nAs this patch is not needed, since we\u0027ve agreed not to allow to configure HTTP/2 for non-TLS frontends.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9778f08f64330fc80b219127dc060edc5e9040f5","revisions":{"7938614fbe44ba43fcbea9a4ac3fd952304b3d51":{"kind":"REWORK","_number":1,"created":"2023-08-16 09:31:45.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/75/891575/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/75/891575/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/1"}}},"commit":{"parents":[{"commit":"589a869ee51407f16d03d872b0e7e053bc41366b","subject":"Merge \"haproxy: fix health checks for serialconsole in http mode\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/589a869ee51407f16d03d872b0e7e053bc41366b"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-16 09:31:36.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-16 09:31:36.000000000","tz":120},"subject":"Enable HTTP/2 for TLS-covered frontends","message":"Enable HTTP/2 for TLS-covered frontends\n\nIn case all frontend VIPs are covered with TLS, it makes total\nsense to enable HTTP/2 to speedup services, as according to the [1],\nTLS adds significant overhead to HAProxy that can be solved by\nenabling HTTP/2 on frontends.\n\nWe don\u0027t enable HTTP/2 in other cases, since with non-TLS covered\nfrontends it is not possible to support multiple versions of HTTP\nsimultaneously [2]\n\n[1] https://etherpad.opendev.org/p/openstack-ansible-tls-performance-impact\n[2] https://www.haproxy.com/documentation/hapee/latest/load-balancing/protocols/http-2/\n\nDepends-On: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/891572\nChange-Id: I88ab8819979509ffd1582f06be85d127e93ac47f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/7938614fbe44ba43fcbea9a4ac3fd952304b3d51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/7938614fbe44ba43fcbea9a4ac3fd952304b3d51"}]},"branch":"refs/heads/master"},"9778f08f64330fc80b219127dc060edc5e9040f5":{"kind":"REWORK","_number":2,"created":"2023-08-22 13:46:50.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/75/891575/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/75/891575/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/75/891575/2"}}},"commit":{"parents":[{"commit":"e88ba9b917a217a1a65133be1df592b869f0d8d4","subject":"Merge \"Respect haproxy_bind_internal_lb_vip_* variables\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/e88ba9b917a217a1a65133be1df592b869f0d8d4"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-16 09:31:36.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-22 13:46:39.000000000","tz":120},"subject":"Enable HTTP/2 for TLS-covered frontends","message":"Enable HTTP/2 for TLS-covered frontends\n\nIn case all frontend VIPs are covered with TLS, it makes total\nsense to enable HTTP/2 to speedup services, as according to the [1],\nTLS adds significant overhead to HAProxy that can be solved by\nenabling HTTP/2 on frontends.\n\nWe don\u0027t enable HTTP/2 in other cases, since with non-TLS covered\nfrontends it is not possible to support multiple versions of HTTP\nsimultaneously [2]\n\n[1] https://etherpad.opendev.org/p/openstack-ansible-tls-performance-impact\n[2] https://www.haproxy.com/documentation/hapee/latest/load-balancing/protocols/http-2/\n\nDepends-On: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/891572\nChange-Id: I88ab8819979509ffd1582f06be85d127e93ac47f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/9778f08f64330fc80b219127dc060edc5e9040f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/9778f08f64330fc80b219127dc060edc5e9040f5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}