)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"68f80cbec0fb5907007e4a5cfaa28627b38b6ad1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a6d3f59_86475993","updated":"2023-10-12 13:38:46.000000000","message":"Corner case of hyperconverged / metal AIO makes the code look unusual, but it\u0027s right.","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"2c51aa2ca2dacd5a70b9959265c80d1fd2fa5948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a73503ba_1716e4ec","updated":"2023-10-11 10:41:36.000000000","message":"Some interesting logic here for nova_cinder_rbd_inuse - is it needed to template nova.conf on the controllers?","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"eb27ba47b401b3db5a04c0e2e4c1fdc35aa35406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd0fd0da_9a4c2937","updated":"2023-10-10 17:34:39.000000000","message":"recheck debian version missmatch should be fixed now","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"09c371392ad51a0c90e6423d3c7087bcdfd8f5e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99659e5c_913145d6","updated":"2023-10-16 12:14:08.000000000","message":"recheck master should be unblocked now","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f89c1c848269b44992cd0c7830ef32cf63a68b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9cda8da4_acd370a7","updated":"2023-10-16 12:14:21.000000000","message":"recheck master should be unblocked now","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"1cc2c891bd21aaa70dae39fd02d02b182d69b96b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c74054a7_016ea0d1","updated":"2023-10-11 08:10:00.000000000","message":"recheck rocky timeout","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"}],"playbooks/os-nova-install.yml":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"2c51aa2ca2dacd5a70b9959265c80d1fd2fa5948","unresolved":true,"context_lines":[{"line_number":65,"context_line":"      delegate_to: localhost"},{"line_number":66,"context_line":"      delegate_facts: True"},{"line_number":67,"context_line":"      when:"},{"line_number":68,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":69,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":70,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":71,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1541297d_037ca819","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":41},"updated":"2023-10-11 10:41:36.000000000","message":"i\u0027m not sure this is ever true for the hosts: pattern for this play, except for perhaps a metal AIO where the control plane and compute services are co-located?","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f43954dda8702c8cd7cd2347fdc4c9447fd2d9c1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"      delegate_to: localhost"},{"line_number":66,"context_line":"      delegate_facts: True"},{"line_number":67,"context_line":"      when:"},{"line_number":68,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":69,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":70,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":71,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8251a044_ef3546a1","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":41},"in_reply_to":"05ee01b2_c699fc4a","updated":"2023-10-11 13:49:39.000000000","message":"Yes, that is example usecase of metal hyperconverged deployment (or simply AIO) actually. Since next run `Install nova compute services` it won\u0027t target the nova-compute, as hosts are part of nova-scheduler and they will be ignored.\n\nThus rbd vars can be needed here depending if these hosts are by co-incidence are computes as well.","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"905a4b21ca4865a3c7a2efdfd98748f5a9e5c093","unresolved":true,"context_lines":[{"line_number":65,"context_line":"      delegate_to: localhost"},{"line_number":66,"context_line":"      delegate_facts: True"},{"line_number":67,"context_line":"      when:"},{"line_number":68,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":69,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":70,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":71,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"05ee01b2_c699fc4a","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":41},"in_reply_to":"1541297d_037ca819","updated":"2023-10-11 10:45:16.000000000","message":"looks like the rbd vars are not actually needed on the controllers","commit_id":"61ea7a82073ea5886ad7f27f9dbcf6456233ab67"}]}