)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb291214beeb2b7dacdde3a4fa1269ed3c73b3ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"90aadf5c_f884e8b3","updated":"2025-05-06 09:58:18.000000000","message":"some more issues spotted","commit_id":"8b2d096e82afaf74541c8cb7d76f0e6d21c0729b"}],"doc/source/reference/architecture/manifesto.rst":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a1d43aa9f5cfd104166f801af851d32aa9b4feff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"OpenStack-Ansible Manifesto"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This project will be a **Batteries included** project. Which"},{"line_number":5,"context_line":"means deployer can expect that deploying from any of the named"},{"line_number":6,"context_line":"feature branches or tags should provide an OpenStack cloud"},{"line_number":7,"context_line":"built for production which will be available at the successful"},{"line_number":8,"context_line":"completion of the deployment."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Project scope"},{"line_number":11,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b146f572_fd4d4ba7","side":"PARENT","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":29},"updated":"2025-05-05 12:24:21.000000000","message":"That is not minor fix nor minor edit. Please justify why you think this should be removed","commit_id":"c816bf2fc0dd2225b30126573728b22b3958e967"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb291214beeb2b7dacdde3a4fa1269ed3c73b3ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack-Ansible Manifesto"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This project will be a **Batteries included** project. Which"},{"line_number":5,"context_line":"means deployer can expect that deploying from any of the named"},{"line_number":6,"context_line":"feature branches or tags should provide an OpenStack cloud"},{"line_number":7,"context_line":"built for production which will be available at the successful"},{"line_number":8,"context_line":"completion of the deployment."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Project scope"},{"line_number":11,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c4134560_702d7117","side":"PARENT","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":29},"in_reply_to":"995cbe69_70e51c36","updated":"2025-05-06 09:58:18.000000000","message":"ah, right, ok. no need then, I missed that it\u0027s already present down the line.\n\nI\u0027d still highly encourage to be more explicit in commit messages, as they are really too generic to understand what is happening.\n\nAnd we encourage to have commit message that is answering the question what and why, so you can fully understand what is going on even before you start checking the code changes.","commit_id":"c816bf2fc0dd2225b30126573728b22b3958e967"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"80c71a8311fff4e8c41074a8792df54500c1b3c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack-Ansible Manifesto"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This project will be a **Batteries included** project. Which"},{"line_number":5,"context_line":"means deployer can expect that deploying from any of the named"},{"line_number":6,"context_line":"feature branches or tags should provide an OpenStack cloud"},{"line_number":7,"context_line":"built for production which will be available at the successful"},{"line_number":8,"context_line":"completion of the deployment."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Project scope"},{"line_number":11,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"995cbe69_70e51c36","side":"PARENT","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":29},"in_reply_to":"b146f572_fd4d4ba7","updated":"2025-05-05 13:30:54.000000000","message":"@noonedeadpunk@gmail.com Hi, I\u0027m not removing this part, it has just duplicate in \"Project Scope\" section. Should I make a separate change?","commit_id":"c816bf2fc0dd2225b30126573728b22b3958e967"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"43c271f97a6ebc7c5defabe4e9e017f7dcaf8ddb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack-Ansible Manifesto"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This project will be a **Batteries included** project. Which"},{"line_number":5,"context_line":"means deployer can expect that deploying from any of the named"},{"line_number":6,"context_line":"feature branches or tags should provide an OpenStack cloud"},{"line_number":7,"context_line":"built for production which will be available at the successful"},{"line_number":8,"context_line":"completion of the deployment."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Project scope"},{"line_number":11,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"457b490e_48253e21","side":"PARENT","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":29},"in_reply_to":"c4134560_702d7117","updated":"2025-05-06 10:47:21.000000000","message":"Thanks for opinion, added some more accurate description in commit message, may be it\u0027s better to make separate changes in future.","commit_id":"c816bf2fc0dd2225b30126573728b22b3958e967"}],"doc/source/reference/configuration/extending-osa.rst":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a1d43aa9f5cfd104166f801af851d32aa9b4feff","unresolved":true,"context_lines":[{"line_number":74,"context_line":"specifying which roles to download and install."},{"line_number":75,"context_line":"The default value for this is ``ansible-role-requirements.yml``."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To completely override the ``ansible-role-requirement`` file you can define"},{"line_number":78,"context_line":"the environment variable ``ANSIBLE_ROLE_FILE`` before running the"},{"line_number":79,"context_line":"``bootstrap-ansible.sh`` script. With this approach it is now the"},{"line_number":80,"context_line":"responsibility of the deployer to maintain appropriate versions pins"}],"source_content_type":"text/x-rst","patch_set":2,"id":"12e55d7e_531edaad","line":77,"range":{"start_line":77,"start_character":29,"end_line":77,"end_character":54},"updated":"2025-05-05 12:24:21.000000000","message":"```suggestion\nTo completely override the ``ansible-role-requirement.yml`` file you can define\n```","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"80c71a8311fff4e8c41074a8792df54500c1b3c2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"specifying which roles to download and install."},{"line_number":75,"context_line":"The default value for this is ``ansible-role-requirements.yml``."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To completely override the ``ansible-role-requirement`` file you can define"},{"line_number":78,"context_line":"the environment variable ``ANSIBLE_ROLE_FILE`` before running the"},{"line_number":79,"context_line":"``bootstrap-ansible.sh`` script. With this approach it is now the"},{"line_number":80,"context_line":"responsibility of the deployer to maintain appropriate versions pins"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d7e30646_6490c3e8","line":77,"range":{"start_line":77,"start_character":29,"end_line":77,"end_character":54},"in_reply_to":"12e55d7e_531edaad","updated":"2025-05-05 13:30:54.000000000","message":"Done","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb291214beeb2b7dacdde3a4fa1269ed3c73b3ef","unresolved":false,"context_lines":[{"line_number":74,"context_line":"specifying which roles to download and install."},{"line_number":75,"context_line":"The default value for this is ``ansible-role-requirements.yml``."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To completely override the ``ansible-role-requirement`` file you can define"},{"line_number":78,"context_line":"the environment variable ``ANSIBLE_ROLE_FILE`` before running the"},{"line_number":79,"context_line":"``bootstrap-ansible.sh`` script. With this approach it is now the"},{"line_number":80,"context_line":"responsibility of the deployer to maintain appropriate versions pins"}],"source_content_type":"text/x-rst","patch_set":2,"id":"946036cf_1b76f95e","line":77,"range":{"start_line":77,"start_character":29,"end_line":77,"end_character":54},"in_reply_to":"d7e30646_6490c3e8","updated":"2025-05-06 09:58:18.000000000","message":"Seems you","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a1d43aa9f5cfd104166f801af851d32aa9b4feff","unresolved":true,"context_lines":[{"line_number":142,"context_line":" * ``pre_setup_openstack_hook``"},{"line_number":143,"context_line":" * ``post_setup_openstack_hook``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The hook variables should be configured in a suitable ``user_variables``"},{"line_number":146,"context_line":"file. An example calling a playbook from a collection (installed"},{"line_number":147,"context_line":"using ``user-collection-requirements.yml``) :"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"eb4a8d3c_3b613913","line":145,"range":{"start_line":145,"start_character":56,"end_line":145,"end_character":70},"updated":"2025-05-05 12:24:21.000000000","message":"```suggestion\nThe hook variables should be configured in a suitable ``user_variables.yml``\n```","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"80c71a8311fff4e8c41074a8792df54500c1b3c2","unresolved":false,"context_lines":[{"line_number":142,"context_line":" * ``pre_setup_openstack_hook``"},{"line_number":143,"context_line":" * ``post_setup_openstack_hook``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The hook variables should be configured in a suitable ``user_variables``"},{"line_number":146,"context_line":"file. An example calling a playbook from a collection (installed"},{"line_number":147,"context_line":"using ``user-collection-requirements.yml``) :"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d9502e4c_cae4fd8f","line":145,"range":{"start_line":145,"start_character":56,"end_line":145,"end_character":70},"in_reply_to":"eb4a8d3c_3b613913","updated":"2025-05-05 13:30:54.000000000","message":"Done","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"f7f4214c8ae3900a91525a1ba19aaff9d5a54aa2","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"The hook variables should be configured in a suitable ``user_variables.yml``"},{"line_number":148,"context_line":"file. An example calling a playbook from a collection (installed"},{"line_number":149,"context_line":"using ``user-collection-requirements.yml``) :"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. code-block:: bash"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"e1e2bfbc_840f3ddb","line":149,"updated":"2025-05-06 10:57:26.000000000","message":"Please remove space before :","commit_id":"46fa8af80ba6c9c6c50244312f9b50e57f61cd47"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"9ad8dbbff387a8f95b68a12bdabeff1a0711c81e","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"The hook variables should be configured in a suitable ``user_variables.yml``"},{"line_number":148,"context_line":"file. An example calling a playbook from a collection (installed"},{"line_number":149,"context_line":"using ``user-collection-requirements.yml``) :"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. code-block:: bash"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"6a104de8_3e6f11fe","line":149,"in_reply_to":"e1e2bfbc_840f3ddb","updated":"2025-05-06 11:39:33.000000000","message":"Thx, done.","commit_id":"46fa8af80ba6c9c6c50244312f9b50e57f61cd47"}],"doc/source/reference/configuration/using-overrides.rst":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a1d43aa9f5cfd104166f801af851d32aa9b4feff","unresolved":true,"context_lines":[{"line_number":28,"context_line":"``/etc/openstack_deploy/host_vars respectively``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"If you want to change the location of the override folder, you"},{"line_number":31,"context_line":"can adapt your ``openstack-ansible.rc file``, or export"},{"line_number":32,"context_line":"``GROUP_VARS_PATH`` and ``HOST_VARS_PATH`` during your shell session."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Role vars"}],"source_content_type":"text/x-rst","patch_set":2,"id":"29cf4928_5c5a0e63","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":44},"updated":"2025-05-05 12:24:21.000000000","message":"Probably worth referring to ``user.rc`` file and potentially with a link to https://docs.openstack.org/openstack-ansible/latest/reference/configuration/extending-osa.html#defining-environment-variables-for-deployment for more details","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"80c71a8311fff4e8c41074a8792df54500c1b3c2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"``/etc/openstack_deploy/host_vars respectively``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"If you want to change the location of the override folder, you"},{"line_number":31,"context_line":"can adapt your ``openstack-ansible.rc file``, or export"},{"line_number":32,"context_line":"``GROUP_VARS_PATH`` and ``HOST_VARS_PATH`` during your shell session."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Role vars"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bd153e1a_71debce1","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":44},"in_reply_to":"29cf4928_5c5a0e63","updated":"2025-05-05 13:30:54.000000000","message":"Done","commit_id":"c7fddc191c849d667942734c8df40ffef32d859c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb291214beeb2b7dacdde3a4fa1269ed3c73b3ef","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"You can override the existing group vars (and host vars) by creating"},{"line_number":27,"context_line":"your own folder in ``/etc/openstack_deploy/group_vars`` (and"},{"line_number":28,"context_line":"``/etc/openstack_deploy/host_vars respectively``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"If you want to change the location of the override folder, you"},{"line_number":31,"context_line":"can adapt your ``user.rc file`` (see details in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"93a673da_ef88a2fe","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":34},"updated":"2025-05-06 09:58:18.000000000","message":"```suggestion\n``/etc/openstack_deploy/host_vars`` respectively).\n```","commit_id":"8b2d096e82afaf74541c8cb7d76f0e6d21c0729b"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"43c271f97a6ebc7c5defabe4e9e017f7dcaf8ddb","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"You can override the existing group vars (and host vars) by creating"},{"line_number":27,"context_line":"your own folder in ``/etc/openstack_deploy/group_vars`` (and"},{"line_number":28,"context_line":"``/etc/openstack_deploy/host_vars respectively``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"If you want to change the location of the override folder, you"},{"line_number":31,"context_line":"can adapt your ``user.rc file`` (see details in"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a23884d2_5745bcfe","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":34},"in_reply_to":"93a673da_ef88a2fe","updated":"2025-05-06 10:47:21.000000000","message":"Done","commit_id":"8b2d096e82afaf74541c8cb7d76f0e6d21c0729b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bb291214beeb2b7dacdde3a4fa1269ed3c73b3ef","unresolved":true,"context_lines":[{"line_number":28,"context_line":"``/etc/openstack_deploy/host_vars respectively``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"If you want to change the location of the override folder, you"},{"line_number":31,"context_line":"can adapt your ``user.rc file`` (see details in"},{"line_number":32,"context_line":":dev_docs:`Extending OSA with additional Ansible content \u003creference/configuration/extending-osa.html#defining-environment-variables-for-deployment\u003e`),"},{"line_number":33,"context_line":"or export"},{"line_number":34,"context_line":"``GROUP_VARS_PATH`` and ``HOST_VARS_PATH`` during your shell session."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ef4f857_32b478d4","line":31,"updated":"2025-05-06 09:58:18.000000000","message":"```suggestion\ncan adapt your ``user.rc`` file (see details in\n```","commit_id":"8b2d096e82afaf74541c8cb7d76f0e6d21c0729b"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"43c271f97a6ebc7c5defabe4e9e017f7dcaf8ddb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"``/etc/openstack_deploy/host_vars respectively``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"If you want to change the location of the override folder, you"},{"line_number":31,"context_line":"can adapt your ``user.rc file`` (see details in"},{"line_number":32,"context_line":":dev_docs:`Extending OSA with additional Ansible content \u003creference/configuration/extending-osa.html#defining-environment-variables-for-deployment\u003e`),"},{"line_number":33,"context_line":"or export"},{"line_number":34,"context_line":"``GROUP_VARS_PATH`` and ``HOST_VARS_PATH`` during your shell session."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bea3d152_9bb5779a","line":31,"in_reply_to":"3ef4f857_32b478d4","updated":"2025-05-06 10:47:21.000000000","message":"Thanks, didn\u0027t notice that(","commit_id":"8b2d096e82afaf74541c8cb7d76f0e6d21c0729b"}]}