)]}'
{"roles/os-ops-database.json":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"76a816ac56b57ed9efd4dba4d8dffef3519eae1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"json_class\": \"Chef::Role\","},{"line_number":5,"context_line":"  \"default_attributes\": {"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"override_attributes\": {"},{"line_number":8,"context_line":"    \"openstack\": {"},{"line_number":9,"context_line":"      \"mysql\": {"},{"line_number":10,"context_line":"        \"max_connections\": \"1024\""}],"source_content_type":"application/json","patch_set":2,"id":"da20952f_b806b91e","line":7,"updated":"2015-08-27 06:31:19.000000000","message":"this attribute has been overrided in https://review.openstack.org/#/c/138537/3/recipes/mysql-server.rb , \n\nwhy to do again here ?","commit_id":"a5ed650e40351e0c76c1cf99a7f291a9a5e0b81e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"9c20f8e4592782b56db82dd375ad6622959380e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"json_class\": \"Chef::Role\","},{"line_number":5,"context_line":"  \"default_attributes\": {"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"override_attributes\": {"},{"line_number":8,"context_line":"    \"openstack\": {"},{"line_number":9,"context_line":"      \"mysql\": {"},{"line_number":10,"context_line":"        \"max_connections\": \"1024\""}],"source_content_type":"application/json","patch_set":2,"id":"da20952f_4a6e9bca","line":7,"in_reply_to":"da20952f_0f275513","updated":"2015-08-27 08:36:51.000000000","message":"is it a internal requirement ? I think it is better to override it in env file.","commit_id":"a5ed650e40351e0c76c1cf99a7f291a9a5e0b81e"},{"author":{"_account_id":15765,"name":"Mark Gloshen","email":"mark@gloshen.com","username":"mark.gloshen"},"change_message_id":"4bc287b6baaf1465d9afe26e47204473637729fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"json_class\": \"Chef::Role\","},{"line_number":5,"context_line":"  \"default_attributes\": {"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"override_attributes\": {"},{"line_number":8,"context_line":"    \"openstack\": {"},{"line_number":9,"context_line":"      \"mysql\": {"},{"line_number":10,"context_line":"        \"max_connections\": \"1024\""}],"source_content_type":"application/json","patch_set":2,"id":"da20952f_6f034743","line":7,"in_reply_to":"da20952f_1e822801","updated":"2015-08-27 21:38:22.000000000","message":"We can\u0027t predict what values are going to be best for each user\u0027s implementation. 1024 might work for you, but not someone else.  Therefore, rather than play that game at all, the default mysql values are used.  You should override in your own environment or role to meet your own particular requirements.","commit_id":"a5ed650e40351e0c76c1cf99a7f291a9a5e0b81e"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"cbdf1c76cdb194c0e4f70dbb80eadb0f2a91ccb2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"json_class\": \"Chef::Role\","},{"line_number":5,"context_line":"  \"default_attributes\": {"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"override_attributes\": {"},{"line_number":8,"context_line":"    \"openstack\": {"},{"line_number":9,"context_line":"      \"mysql\": {"},{"line_number":10,"context_line":"        \"max_connections\": \"1024\""}],"source_content_type":"application/json","patch_set":2,"id":"da20952f_5e9bc0c9","line":7,"in_reply_to":"da20952f_4a6e9bca","updated":"2015-08-27 09:00:45.000000000","message":"Thanks for your quick comments. It seems a common issue for openstack, so it is suggested changing it in community.  Which environment file do you suggest ?","commit_id":"a5ed650e40351e0c76c1cf99a7f291a9a5e0b81e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"c11519400ae4e08c4e27ce8da373a20a3240ba92","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"json_class\": \"Chef::Role\","},{"line_number":5,"context_line":"  \"default_attributes\": {"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"override_attributes\": {"},{"line_number":8,"context_line":"    \"openstack\": {"},{"line_number":9,"context_line":"      \"mysql\": {"},{"line_number":10,"context_line":"        \"max_connections\": \"1024\""}],"source_content_type":"application/json","patch_set":2,"id":"da20952f_1e822801","line":7,"in_reply_to":"da20952f_5e9bc0c9","updated":"2015-08-27 09:07:59.000000000","message":"if it is a common issue for openstack,  should change the default attribute value in cookbook-openstack-ops-database.\n\nNow the value is changed from 1024 to 151 in community, so for your internal requirement, please change it in your internal project. This is the right way to integrate the community project.","commit_id":"a5ed650e40351e0c76c1cf99a7f291a9a5e0b81e"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"9bab12e13930a1ad149905625eaa2c346ddeb5c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"json_class\": \"Chef::Role\","},{"line_number":5,"context_line":"  \"default_attributes\": {"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"override_attributes\": {"},{"line_number":8,"context_line":"    \"openstack\": {"},{"line_number":9,"context_line":"      \"mysql\": {"},{"line_number":10,"context_line":"        \"max_connections\": \"1024\""}],"source_content_type":"application/json","patch_set":2,"id":"da20952f_0f275513","line":7,"in_reply_to":"da20952f_b806b91e","updated":"2015-08-27 08:28:35.000000000","message":"It did.  But the overridden value was removed in https://review.openstack.org/#/c/167843/,  that patch was intended to keep consistent with mysql doc as the default value. But it is apparent it is not sufficient for openstack,  people were aware of it before.  We need to override it somewhere, database role maybe a better place.","commit_id":"a5ed650e40351e0c76c1cf99a7f291a9a5e0b81e"}]}