)]}'
{"Rakefile":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"28b712cf537f687dd203fbb791364fe3d15dea3e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  %w(nova neutron keystone cinder glance heat).each do |project|"},{"line_number":156,"context_line":"    paths \u003c\u003c \"-r \\\"\\\" /etc/#{project}/*\""},{"line_number":157,"context_line":"    paths \u003c\u003c \"-r \\\"\\\" /var/log/#{project}/*\""},{"line_number":158,"context_line":"    paths \u003c\u003c \"-r \\\"\\\" /var/log/httpd/*\""},{"line_number":159,"context_line":"  end"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  _run_commands(\u0027Dump Logs\u0027, {"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"1af94dfe_d06a7c80","line":158,"updated":"2016-03-18 08:25:42.000000000","message":"This would implicitly revert my log-publisher patch, please rebase properly instead.","commit_id":"0959f9e72cbfe0f88cc8440331bd436030ebef9a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"28b712cf537f687dd203fbb791364fe3d15dea3e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  for i in 1..3"},{"line_number":181,"context_line":"    puts \"####### Pass #{i}\""},{"line_number":182,"context_line":"    # Kick off chef client in local mode, will converge OpenStack right on the gate job \"in place\""},{"line_number":183,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-#{platform} -r \u0027role[allinone]\u0027;systemctl status httpd.service;tail -n500 /var/log/httpd/error.log)"},{"line_number":184,"context_line":"    _setup_tempest(client_opts)"},{"line_number":185,"context_line":"    _dump_logs"},{"line_number":186,"context_line":"    _setup_local_network if i \u003d\u003d 1"}],"source_content_type":"application/octet-stream","patch_set":23,"id":"1af94dfe_701f2808","line":183,"updated":"2016-03-18 08:25:42.000000000","message":"systemctl and /var/log/httpd do not exist on Trusty, see http://logs.openstack.org/39/291939/23/check/gate-ubuntu-trusty-openstack-chef-repo-chef-rake-integration-nv/16f4306/console.html#_2016-03-18_01_31_05_171","commit_id":"0959f9e72cbfe0f88cc8440331bd436030ebef9a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0c4473963a65ad7cb000ed4e62aef8ccf0e08913","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  begin"},{"line_number":175,"context_line":"  # This is a workaround for allowing chef-client to run in local mode"},{"line_number":176,"context_line":"  sh %(sudo mkdir /etc/chef \u0026\u0026 sudo cp .chef/encrypted_data_bag_secret /etc/chef/openstack_data_bag_secret)"},{"line_number":177,"context_line":"  #_run_env_queries"},{"line_number":178,"context_line":"  #"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  # Three passes to make sure of cookbooks idempotency"}],"source_content_type":"application/octet-stream","patch_set":34,"id":"1af94dfe_08be54fe","line":177,"updated":"2016-03-18 20:30:41.000000000","message":"why comments out?  some don\u0027t work on centos7?   I think they provide valuable info.","commit_id":"1c09c1753d1d40bf298f1d8a193c6fe8cbde95d7"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"8ce8b6d4ab210bfd36917c81d9bcd7cf4c0e0430","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  begin"},{"line_number":175,"context_line":"  # This is a workaround for allowing chef-client to run in local mode"},{"line_number":176,"context_line":"  sh %(sudo mkdir /etc/chef \u0026\u0026 sudo cp .chef/encrypted_data_bag_secret /etc/chef/openstack_data_bag_secret)"},{"line_number":177,"context_line":"  #_run_env_queries"},{"line_number":178,"context_line":"  #"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  # Three passes to make sure of cookbooks idempotency"}],"source_content_type":"application/octet-stream","patch_set":34,"id":"1af94dfe_a87ac021","line":177,"in_reply_to":"1af94dfe_08be54fe","updated":"2016-03-18 20:34:59.000000000","message":"C7 has PATH issues and it didn\u0027t seem worth fighting with the environment more than is already necessary here","commit_id":"1c09c1753d1d40bf298f1d8a193c6fe8cbde95d7"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0c4473963a65ad7cb000ed4e62aef8ccf0e08913","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    _setup_cinder_volume"},{"line_number":190,"context_line":"    _run_nova_tests"},{"line_number":191,"context_line":"  end"},{"line_number":192,"context_line":"  rescue"},{"line_number":193,"context_line":"  # TODO (jklare) utilise tempest to run tests against openstack"},{"line_number":194,"context_line":"  # TODO (MRV) gather logs"},{"line_number":195,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":34,"id":"1af94dfe_c8e0ec2b","line":192,"updated":"2016-03-18 20:30:41.000000000","message":"what was this rescue for?","commit_id":"1c09c1753d1d40bf298f1d8a193c6fe8cbde95d7"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"8ce8b6d4ab210bfd36917c81d9bcd7cf4c0e0430","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    _setup_cinder_volume"},{"line_number":190,"context_line":"    _run_nova_tests"},{"line_number":191,"context_line":"  end"},{"line_number":192,"context_line":"  rescue"},{"line_number":193,"context_line":"  # TODO (jklare) utilise tempest to run tests against openstack"},{"line_number":194,"context_line":"  # TODO (MRV) gather logs"},{"line_number":195,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":34,"id":"1af94dfe_08f134cd","line":192,"in_reply_to":"1af94dfe_c8e0ec2b","updated":"2016-03-18 20:34:59.000000000","message":"rescue is useful for fishing information out of the build instances if the rake job fails","commit_id":"1c09c1753d1d40bf298f1d8a193c6fe8cbde95d7"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"ccb3b3fd8c746bc35cc7cf92552700185ce3a308","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  # This is a workaround for allowing chef-client to run in local mode"},{"line_number":172,"context_line":"  sh %(sudo mkdir /etc/chef \u0026\u0026 sudo cp .chef/encrypted_data_bag_secret /etc/chef/openstack_data_bag_secret)"},{"line_number":173,"context_line":"  "},{"line_number":174,"context_line":"  # disable env helper due to PATH issues with CentOS 7"},{"line_number":175,"context_line":"  #_run_env_queries"},{"line_number":176,"context_line":"  #"},{"line_number":177,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":39,"id":"fa0719c6_927f65df","line":174,"updated":"2016-03-23 18:38:42.000000000","message":"Since you have the platform, why not check that to leave this enabled in the ubuntu case?    Or add a separate centos specific version of this?","commit_id":"0e215d3559c9a37b46d683c6448f33903cff6598"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"353e48009d2004664807f749053f83158976c126","unresolved":false,"context_lines":[{"line_number":85,"context_line":"def _run_env_queries # rubocop:disable Metrics/MethodLength"},{"line_number":86,"context_line":"  if File.exist?(\u0027/etc/debian_version\u0027)"},{"line_number":87,"context_line":"    _run_commands(\u0027basic env queries\u0027, {"},{"line_number":88,"context_line":"      \u0027uname\u0027 \u003d\u003e [\u0027-a\u0027],"},{"line_number":89,"context_line":"      \u0027pwd\u0027 \u003d\u003e [\u0027\u0027],"},{"line_number":90,"context_line":"      \u0027env\u0027 \u003d\u003e [\u0027\u0027],"},{"line_number":91,"context_line":"      \u0027ifconfig\u0027 \u003d\u003e [\u0027\u0027],"}],"source_content_type":"application/octet-stream","patch_set":51,"id":"ba0121b8_1e5b0d56","line":88,"updated":"2016-03-28 16:12:56.000000000","message":"Not a big deal, but for DRY, you could pull out the first 3 common ones into a \"basic common env queries\"","commit_id":"6ae565cbf41278fa728ae9e5db02f55696588b5f"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"353e48009d2004664807f749053f83158976c126","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Helper for setting up basic query tests"},{"line_number":108,"context_line":"def _run_basic_queries # rubocop:disable Metrics/MethodLength"},{"line_number":109,"context_line":"  if File.exist?(\u0027/etc/debian_version\u0027)"},{"line_number":110,"context_line":"    _run_commands(\u0027basic test queries\u0027, {"},{"line_number":111,"context_line":"      \u0027curl\u0027 \u003d\u003e [\u0027-v http://localhost\u0027, \u0027-kv https://localhost\u0027],"},{"line_number":112,"context_line":"      \u0027sudo netstat\u0027 \u003d\u003e [\u0027-nlp\u0027],"}],"source_content_type":"application/octet-stream","patch_set":51,"id":"ba0121b8_5e03c50f","line":109,"updated":"2016-03-28 16:12:56.000000000","message":"Again, for DRY, could pull out common ones, and just leave the ones that really need differences in the IF logic.","commit_id":"6ae565cbf41278fa728ae9e5db02f55696588b5f"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"353e48009d2004664807f749053f83158976c126","unresolved":false,"context_lines":[{"line_number":180,"context_line":"# itself is not yet used for integration tests."},{"line_number":181,"context_line":"def _setup_tempest(client_opts)"},{"line_number":182,"context_line":"  if File.exist?(\u0027/etc/debian_version\u0027)"},{"line_number":183,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-ubuntu14 -r \u0027recipe[openstack-integration-test::setup]\u0027 || true)"},{"line_number":184,"context_line":"  elsif File.exist?(\u0027/etc/redhat-release\u0027)"},{"line_number":185,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-centos7 -r \u0027recipe[openstack-integration-test::setup]\u0027 || true)"},{"line_number":186,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":51,"id":"ba0121b8_c12538af","line":183,"updated":"2016-03-28 16:12:56.000000000","message":"Again for DRY, keep command on one line and add in a #{env} to replace the env as appropriate.   Like is done on #198 below","commit_id":"6ae565cbf41278fa728ae9e5db02f55696588b5f"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3c72e53e857fc9ee9c618a41c5574fc652791a1b","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# use the correct environment depending on platform"},{"line_number":168,"context_line":"if File.exist?(\u0027/etc/debian_version\u0027)"},{"line_number":169,"context_line":"  platform \u003d \u0027ubuntu14\u0027"},{"line_number":170,"context_line":"elsif File.exist?(\u0027/etc/redhat-release\u0027)"},{"line_number":171,"context_line":"  platform \u003d \u0027centos7\u0027"},{"line_number":172,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":61,"id":"ba0121b8_0ba31bb3","line":169,"updated":"2016-03-31 14:04:29.000000000","message":"For a bit more DRY, would be good to move this up and then just use the platform for the run_basic_queries and run_env_queries","commit_id":"4cd47664584a61a222cc43fbff93e411ab80ba0a"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"84044723261720eeb1ecd487e4295281f9b302e9","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# use the correct environment depending on platform"},{"line_number":168,"context_line":"if File.exist?(\u0027/etc/debian_version\u0027)"},{"line_number":169,"context_line":"  platform \u003d \u0027ubuntu14\u0027"},{"line_number":170,"context_line":"elsif File.exist?(\u0027/etc/redhat-release\u0027)"},{"line_number":171,"context_line":"  platform \u003d \u0027centos7\u0027"},{"line_number":172,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":61,"id":"ba0121b8_e228659c","line":169,"in_reply_to":"ba0121b8_0ba31bb3","updated":"2016-04-01 04:45:45.000000000","message":"Done","commit_id":"4cd47664584a61a222cc43fbff93e411ab80ba0a"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"134b9e8a410bc0d62648c161acbaf047fa31774a","unresolved":false,"context_lines":[{"line_number":214,"context_line":"      _save_logs(\"pass#{i}\", log_dir)"},{"line_number":215,"context_line":"    end"},{"line_number":216,"context_line":"  end"},{"line_number":217,"context_line":"  sh %(sudo chown -R $USER #{log_dir})"},{"line_number":218,"context_line":"  # TODO (jklare) utilise tempest to run tests against openstack"},{"line_number":219,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":81,"id":"9a061dce_9fc7f244","line":217,"updated":"2016-04-04 20:21:12.000000000","message":"Should this be part of the ensure step above to make sure it gets done on failure?","commit_id":"e4ff303a9cfd704f844bc6e561fd48dd25c31ee4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"758cc94f5fc2470c4e40a7ef66779aaea9db681d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"      sh %(sudo chown -R $USER #{log_dir})"},{"line_number":216,"context_line":"    end"},{"line_number":217,"context_line":"  end"},{"line_number":218,"context_line":"  return e"},{"line_number":219,"context_line":"  # TODO (jklare) utilise tempest to run tests against openstack"},{"line_number":220,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":84,"id":"9a061dce_00107a00","line":218,"updated":"2016-04-05 14:39:46.000000000","message":"Humm I don\u0027t understand his part, in the success case, this will fail with undefined \"e\".\n\nI was thinking that all we need to do here is to change that rescue puts to a raise:\n\n\nrescue \u003d\u003e e\n      raise \"####### Pass #{i} failed with #{e.message}\"","commit_id":"fc14e3885de3beecdeb6adad9e070614baa354fe"}],"roles/allinone.json":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"259670d7140fb471ac2c98a0739b355f5ef881e3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"recipe[openstack-image::api]\","},{"line_number":23,"context_line":"    \"recipe[openstack-image::registry]\","},{"line_number":24,"context_line":"    \"recipe[openstack-image::identity_registration]\","},{"line_number":25,"context_line":"    \"recipe[openstack-image::image_upload]\","},{"line_number":26,"context_line":"    \"recipe[openstack-network::identity_registration]\","},{"line_number":27,"context_line":"    \"recipe[openstack-network::ml2_core_plugin]\","},{"line_number":28,"context_line":"    \"recipe[openstack-network::ml2_openvswitch]\","}],"source_content_type":"application/json","patch_set":85,"id":"9a061dce_03079a18","line":25,"updated":"2016-04-06 17:15:12.000000000","message":"Might better to move this toward the end, it will let the other services settle down a bit before trying to use them.","commit_id":"d996282e2578bb52c85cf62a2bd255b062475a05"}]}