)]}'
{"Rakefile":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"17184cd2285e886237c2e806fb8687bf3e9fc3cd","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def _save_logs(prefix)"},{"line_number":157,"context_line":"  sh %(sleep 25)"},{"line_number":158,"context_line":"  %w(nova neutron keystone cinder glance heat).each do |project|"},{"line_number":159,"context_line":"    sh %(mkdir -p logs/#{prefix}/#{project})"},{"line_number":160,"context_line":"    sh %(sudo cp -r /etc/#{project} logs/#{prefix}/#{project}/etc)"},{"line_number":161,"context_line":"    sh %(sudo cp -r /var/log/#{project} logs/#{prefix}/#{project}/log)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1af94dfe_2132dd10","line":158,"updated":"2016-03-16 15:24:10.000000000","message":"What about apache/horizon logs?","commit_id":"fd89282660680ae34317aad335560ddf5b926a46"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"f9d37ceead24338059e0ce16904d6ed7ac888b7a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def _save_logs(prefix)"},{"line_number":157,"context_line":"  sh %(sleep 25)"},{"line_number":158,"context_line":"  %w(nova neutron keystone cinder glance heat).each do |project|"},{"line_number":159,"context_line":"    sh %(mkdir -p logs/#{prefix}/#{project})"},{"line_number":160,"context_line":"    sh %(sudo cp -r /etc/#{project} logs/#{prefix}/#{project}/etc)"},{"line_number":161,"context_line":"    sh %(sudo cp -r /var/log/#{project} logs/#{prefix}/#{project}/log)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1af94dfe_2873dde8","line":158,"in_reply_to":"1af94dfe_2132dd10","updated":"2016-03-16 15:48:27.000000000","message":"they should be included, but this patch should be done in master first and then cherry-picked like this one","commit_id":"fd89282660680ae34317aad335560ddf5b926a46"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"17184cd2285e886237c2e806fb8687bf3e9fc3cd","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  for i in 1..3"},{"line_number":173,"context_line":"    puts \"####### Pass #{i}\""},{"line_number":174,"context_line":"    # Kick off chef client in local mode, will converge OpenStack right on the gate job \"in place\""},{"line_number":175,"context_line":"    sh %(sudo chef-client #{client_opts} -E integration-aio-neutron -r \u0027role[allinone-compute]\u0027,\u0027role[os-image-upload]\u0027,\u0027recipe[openstack-integration-test::setup]\u0027 || true)"},{"line_number":176,"context_line":"    _save_logs(\"pass#{i}\")"},{"line_number":177,"context_line":"    _setup_local_network if i \u003d\u003d 1"},{"line_number":178,"context_line":"    _run_basic_queries"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1af94dfe_0130819d","line":175,"updated":"2016-03-16 15:24:10.000000000","message":"If this fails on first pass, do we really want it doing pass 2 and 3?\n\nWhat about capturing the output of each chef-client run and putting that into the \"pass#{i}\" dir such that the main log is cleaner?","commit_id":"fd89282660680ae34317aad335560ddf5b926a46"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"da7486ba1222464140ea20c3870b8e6805f6fe26","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  for i in 1..3"},{"line_number":173,"context_line":"    puts \"####### Pass #{i}\""},{"line_number":174,"context_line":"    # Kick off chef client in local mode, will converge OpenStack right on the gate job \"in place\""},{"line_number":175,"context_line":"    sh %(sudo chef-client #{client_opts} -E integration-aio-neutron -r \u0027role[allinone-compute]\u0027,\u0027role[os-image-upload]\u0027,\u0027recipe[openstack-integration-test::setup]\u0027 || true)"},{"line_number":176,"context_line":"    _save_logs(\"pass#{i}\")"},{"line_number":177,"context_line":"    _setup_local_network if i \u003d\u003d 1"},{"line_number":178,"context_line":"    _run_basic_queries"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1af94dfe_3b0c613a","line":175,"in_reply_to":"1af94dfe_0130819d","updated":"2016-03-18 08:41:07.000000000","message":"There are situations where the first chef run fails, but the second one succeeds, so there is some value in at least trying twice. Also, the main point here is to make sure that the rake jobs will continue to execute through to the save_logs part. One could think about including some try/except clause in the main code instead, but as Jan noted, that should be done in a new patch and not in a cherry-pick.\n\nI also thought about redirecting the output of the chef-client run itself, the reason why I decided against that for now, was that then it will no longer be possible to watch it live on the jenkins console.","commit_id":"fd89282660680ae34317aad335560ddf5b926a46"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"f9d37ceead24338059e0ce16904d6ed7ac888b7a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  for i in 1..3"},{"line_number":173,"context_line":"    puts \"####### Pass #{i}\""},{"line_number":174,"context_line":"    # Kick off chef client in local mode, will converge OpenStack right on the gate job \"in place\""},{"line_number":175,"context_line":"    sh %(sudo chef-client #{client_opts} -E integration-aio-neutron -r \u0027role[allinone-compute]\u0027,\u0027role[os-image-upload]\u0027,\u0027recipe[openstack-integration-test::setup]\u0027 || true)"},{"line_number":176,"context_line":"    _save_logs(\"pass#{i}\")"},{"line_number":177,"context_line":"    _setup_local_network if i \u003d\u003d 1"},{"line_number":178,"context_line":"    _run_basic_queries"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1af94dfe_8b1e6b61","line":175,"in_reply_to":"1af94dfe_0130819d","updated":"2016-03-16 15:48:27.000000000","message":"should also be done in master first and not in a cherry-pick","commit_id":"fd89282660680ae34317aad335560ddf5b926a46"}]}