)]}'
{"Rakefile":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a14941c9fbf77972a1ccaabf7cc4aa3f09a9a6dc","unresolved":false,"context_lines":[{"line_number":192,"context_line":"end"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Helper for setting up tempest and upload the default cirros image. Tempest"},{"line_number":195,"context_line":"# itself is not yet used for integration tests."},{"line_number":196,"context_line":"def _setup_tempest(client_opts)"},{"line_number":197,"context_line":"  sh %(sudo chef-client #{client_opts} -E allinone-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":198,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3a1ff146_945137db","side":"PARENT","line":195,"updated":"2017-03-16 11:16:11.000000000","message":"Tempest is being used now, so you can drop this sentence.","commit_id":"5a22e2dcc07d69368ec4b33e73c9366b5e62e805"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"cbb60c7394ef3031f53b1dbdaa04ca8e86f04602","unresolved":false,"context_lines":[{"line_number":192,"context_line":"end"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Helper for setting up tempest and upload the default cirros image. Tempest"},{"line_number":195,"context_line":"# itself is not yet used for integration tests."},{"line_number":196,"context_line":"def _setup_tempest(client_opts)"},{"line_number":197,"context_line":"  sh %(sudo chef-client #{client_opts} -E allinone-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":198,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a1ced50_8617ac53","side":"PARENT","line":195,"in_reply_to":"3a1ff146_945137db","updated":"2017-03-16 17:06:23.000000000","message":"Done","commit_id":"5a22e2dcc07d69368ec4b33e73c9366b5e62e805"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a14941c9fbf77972a1ccaabf7cc4aa3f09a9a6dc","unresolved":false,"context_lines":[{"line_number":194,"context_line":"# Helper for setting up tempest and upload the default cirros image. Tempest"},{"line_number":195,"context_line":"# itself is not yet used for integration tests."},{"line_number":196,"context_line":"def _setup_tempest(client_opts)"},{"line_number":197,"context_line":"  if ENV[\u0027CHEF_ENV\u0027] \u003d\u003d \u0027multi-node\u0027"},{"line_number":198,"context_line":"    sh %(sudo chef-client #{client_opts} -E multi-node-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":199,"context_line":"  elsif"},{"line_number":200,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3a1ff146_b45e33e7","line":197,"updated":"2017-03-16 11:16:11.000000000","message":"multinode","commit_id":"fb90291d4864555161c758faab8ec266a3b3aa65"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"cbb60c7394ef3031f53b1dbdaa04ca8e86f04602","unresolved":false,"context_lines":[{"line_number":194,"context_line":"# Helper for setting up tempest and upload the default cirros image. Tempest"},{"line_number":195,"context_line":"# itself is not yet used for integration tests."},{"line_number":196,"context_line":"def _setup_tempest(client_opts)"},{"line_number":197,"context_line":"  if ENV[\u0027CHEF_ENV\u0027] \u003d\u003d \u0027multi-node\u0027"},{"line_number":198,"context_line":"    sh %(sudo chef-client #{client_opts} -E multi-node-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":199,"context_line":"  elsif"},{"line_number":200,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a1ced50_a61ca878","line":197,"in_reply_to":"3a1ff146_b45e33e7","updated":"2017-03-16 17:06:23.000000000","message":"Done","commit_id":"fb90291d4864555161c758faab8ec266a3b3aa65"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a14941c9fbf77972a1ccaabf7cc4aa3f09a9a6dc","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# itself is not yet used for integration tests."},{"line_number":196,"context_line":"def _setup_tempest(client_opts)"},{"line_number":197,"context_line":"  if ENV[\u0027CHEF_ENV\u0027] \u003d\u003d \u0027multi-node\u0027"},{"line_number":198,"context_line":"    sh %(sudo chef-client #{client_opts} -E multi-node-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":199,"context_line":"  elsif"},{"line_number":200,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":201,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3a1ff146_d461efa9","line":198,"updated":"2017-03-16 11:16:11.000000000","message":"dito","commit_id":"fb90291d4864555161c758faab8ec266a3b3aa65"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"cbb60c7394ef3031f53b1dbdaa04ca8e86f04602","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# itself is not yet used for integration tests."},{"line_number":196,"context_line":"def _setup_tempest(client_opts)"},{"line_number":197,"context_line":"  if ENV[\u0027CHEF_ENV\u0027] \u003d\u003d \u0027multi-node\u0027"},{"line_number":198,"context_line":"    sh %(sudo chef-client #{client_opts} -E multi-node-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":199,"context_line":"  elsif"},{"line_number":200,"context_line":"    sh %(sudo chef-client #{client_opts} -E allinone-#{@platform} -r \u0027recipe[openstack-integration-test::setup]\u0027)"},{"line_number":201,"context_line":"  end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a1ced50_46069421","line":198,"in_reply_to":"3a1ff146_d461efa9","updated":"2017-03-16 17:06:23.000000000","message":"Done","commit_id":"fb90291d4864555161c758faab8ec266a3b3aa65"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a14941c9fbf77972a1ccaabf7cc4aa3f09a9a6dc","unresolved":false,"context_lines":[{"line_number":211,"context_line":"end"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"desc \"Multi-node integration test on Infra\""},{"line_number":214,"context_line":"task :int_multi \u003d\u003e [:create_key, :berks_vendor] do"},{"line_number":215,"context_line":"  log_dir \u003d ENV[\u0027WORKSPACE\u0027]+\u0027/logs\u0027"},{"line_number":216,"context_line":"  # Copy the encrypted data bag secret to allow chef-client to run in local mode"},{"line_number":217,"context_line":"  sh %(sudo mkdir -p /etc/chef \u0026\u0026 sudo cp .chef/encrypted_data_bag_secret /etc/chef/openstack_data_bag_secret)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3a1ff146_94ff77a9","line":214,"updated":"2017-03-16 11:16:11.000000000","message":"This look mostly like a copy of the integration tasks, makes me wonder how one could reduce the code duplication.\n\nMaybe a common function called by both tasks called with ROLE and CHEF_ENV as parameters.\n\nAlso I\u0027m thinking whether we need ordering of tasks. Setting up a compute node will likely fail unless installing the controller has finished.","commit_id":"fb90291d4864555161c758faab8ec266a3b3aa65"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"cbb60c7394ef3031f53b1dbdaa04ca8e86f04602","unresolved":false,"context_lines":[{"line_number":211,"context_line":"end"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"desc \"Multi-node integration test on Infra\""},{"line_number":214,"context_line":"task :int_multi \u003d\u003e [:create_key, :berks_vendor] do"},{"line_number":215,"context_line":"  log_dir \u003d ENV[\u0027WORKSPACE\u0027]+\u0027/logs\u0027"},{"line_number":216,"context_line":"  # Copy the encrypted data bag secret to allow chef-client to run in local mode"},{"line_number":217,"context_line":"  sh %(sudo mkdir -p /etc/chef \u0026\u0026 sudo cp .chef/encrypted_data_bag_secret /etc/chef/openstack_data_bag_secret)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a1ced50_29da4979","line":214,"in_reply_to":"3a1ff146_94ff77a9","updated":"2017-03-16 17:06:23.000000000","message":"It was mostly a copypasta of the integration task below, a representation of how it may function. This may need to be done in bootstrap.sh, possibly hinging off of one of the ENV there.\n\nI\u0027m working on something for a future patchset to DRY this up.","commit_id":"fb90291d4864555161c758faab8ec266a3b3aa65"}]}