)]}'
{"specs/kilo/network/enable-dvr-in-chef-cookbook.rst":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d4709513867432586cf8830975429abbe8811472","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Enable dvr in chef cookbook"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Include the URL of your launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_cdbb7ee3","line":2,"updated":"2014-12-19 07:35:38.000000000","message":"Should be Distributed Virtual Router(DVR) the first time and DVR for the rest. Apply to commit message too.","commit_id":"fa5dcd9e9e51a766ca545ce5474d4569124d0012"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d4709513867432586cf8830975429abbe8811472","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently dvr is unable by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user have to manually do some additional config to enable dvr."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_2db7a2f6","line":12,"updated":"2014-12-19 07:35:38.000000000","message":"not enabled.","commit_id":"fa5dcd9e9e51a766ca545ce5474d4569124d0012"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d4709513867432586cf8830975429abbe8811472","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The following template files in cookbook-openstack-network may be modified:"},{"line_number":20,"context_line":"* neutron.conf.erb"},{"line_number":21,"context_line":"* l3_agent.ini.erb"},{"line_number":22,"context_line":"* ovs_neutron_plugin.ini.erb"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The attribute \u0027mechanism_drivers\u0027 which one is need be modified and known by"},{"line_number":25,"context_line":"neutorn-openvswitch-agent, is in ml2_conf.ini, but neutron-openvswitch-agent"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_8d73364d","line":22,"updated":"2014-12-19 07:35:38.000000000","message":"What about the attributed attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed]\u0027 \u003d \u0027True\u0027? should that be included as a proposed change?","commit_id":"fa5dcd9e9e51a766ca545ce5474d4569124d0012"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d4709513867432586cf8830975429abbe8811472","unresolved":false,"context_lines":[{"line_number":21,"context_line":"* l3_agent.ini.erb"},{"line_number":22,"context_line":"* ovs_neutron_plugin.ini.erb"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The attribute \u0027mechanism_drivers\u0027 which one is need be modified and known by"},{"line_number":25,"context_line":"neutorn-openvswitch-agent, is in ml2_conf.ini, but neutron-openvswitch-agent"},{"line_number":26,"context_line":"use ovs_neutron_plugin.ini as config file by default, so maybe we could add"},{"line_number":27,"context_line":"this change in ovs_neutron_plugin.ini.erb."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_cd90de45","line":24,"updated":"2014-12-19 07:35:38.000000000","message":"which one is need -\u003e which needs to be","commit_id":"fa5dcd9e9e51a766ca545ce5474d4569124d0012"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d4709513867432586cf8830975429abbe8811472","unresolved":false,"context_lines":[{"line_number":36,"context_line":"like iproute are installed on compute node."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"If necessary we also need methods to make sure necessary network resource"},{"line_number":39,"context_line":"like tunnel network bridge are created on compute node."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_ed8e7a2d","line":39,"updated":"2014-12-19 07:35:38.000000000","message":"We should check if current network type is tunnel (VXLAN or GRE) since VLAN is not supported yet. \nhttps://review.openstack.org/#/c/129884/\n\nIf it\u0027s not tunnel, we should stop the configuration of DVR.","commit_id":"fa5dcd9e9e51a766ca545ce5474d4569124d0012"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"d4709513867432586cf8830975429abbe8811472","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Dependencies"},{"line_number":67,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"\u003chttps://github.com/stackforge/cookbook-openstack-network\u003e"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Testing"},{"line_number":72,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_6da1aa93","line":69,"updated":"2014-12-19 07:35:38.000000000","message":"I don\u0027t think this is a dependency.","commit_id":"fa5dcd9e9e51a766ca545ce5474d4569124d0012"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8b01546af6e1c1d70746fa152e38a8468ad31ed4","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"https://blueprints.launchpad.net/openstack-chef/+sepc/enable-dvr-chef-cookbook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_f4055e7a","line":7,"updated":"2014-12-19 10:43:46.000000000","message":"Typo: sepc instead of spec","commit_id":"85a844b004da53abebe806b514b041410b59259f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8b01546af6e1c1d70746fa152e38a8468ad31ed4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Proposed change"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The following attribute files in cookbook-openstack-network may be mofified:"},{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We should add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it,"},{"line_number":22,"context_line":"but consider not all network types support DVR, so default value false would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_3458c689","line":19,"updated":"2014-12-19 10:43:46.000000000","message":"I think you should be more decisive here and in the following text, so use \"will\" instead of \"may\" or \"should\" when you propose something to be changed.","commit_id":"85a844b004da53abebe806b514b041410b59259f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8b01546af6e1c1d70746fa152e38a8468ad31ed4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We should add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it,"},{"line_number":22,"context_line":"but consider not all network types support DVR, so default value false would"},{"line_number":23,"context_line":"make sence."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The following template files in cookbook-openstack-network may be modified:"},{"line_number":26,"context_line":"* neutron.conf.erb"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_b4ef56b0","line":23,"updated":"2014-12-19 10:43:46.000000000","message":"sense","commit_id":"85a844b004da53abebe806b514b041410b59259f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8b01546af6e1c1d70746fa152e38a8468ad31ed4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"or network node when DVR is enable."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If necessary we also need methods to make sure necessary packages"},{"line_number":42,"context_line":"like iproute are installed on compute node."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":45,"context_line":"we need also need methods to make sure current network type is either GRE"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_34e606b1","line":42,"updated":"2014-12-19 10:43:46.000000000","message":"Wouldn\u0027t you also have to change the role definition for the compute node in order to have the l3_agent recipe executed there?","commit_id":"85a844b004da53abebe806b514b041410b59259f"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b711d4be2f7aba67fe6942e73fc224846155ded3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* l3_agent.ini.erb"},{"line_number":28,"context_line":"* ovs_neutron_plugin.ini.erb"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The attribute \u0027mechanism_drivers\u0027 which needs to be modified and known by"},{"line_number":31,"context_line":"neutorn-openvswitch-agent, is in ml2_conf.ini, but neutron-openvswitch-agent"},{"line_number":32,"context_line":"use ovs_neutron_plugin.ini as config file by default, so maybe we could add"},{"line_number":33,"context_line":"this change in ovs_neutron_plugin.ini.erb."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_5b0001ab","line":30,"updated":"2014-12-22 00:23:11.000000000","message":"Can you clarify why you need to modify mechanism_drivers by openvswitch agent?","commit_id":"0824e1c6ae1ae658991e3e8e7282589aa1f3d2c1"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"63ddbfcd7db33e796116a50740a8e410b48b54bb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* l3_agent.ini.erb"},{"line_number":28,"context_line":"* ovs_neutron_plugin.ini.erb"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The attribute \u0027mechanism_drivers\u0027 which needs to be modified and known by"},{"line_number":31,"context_line":"neutorn-openvswitch-agent, is in ml2_conf.ini, but neutron-openvswitch-agent"},{"line_number":32,"context_line":"use ovs_neutron_plugin.ini as config file by default, so maybe we could add"},{"line_number":33,"context_line":"this change in ovs_neutron_plugin.ini.erb."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_066fe4fc","line":30,"in_reply_to":"3a961159_5b0001ab","updated":"2014-12-23 03:35:00.000000000","message":"I\u0027ve removed this.\nThe DVR HowTo wiki is not clear on L2 Agent config modification.\nI found attribute like l2_population in ovs_neutron_plugin.ini, which is openvswitch agent config file. So I suppose maybe I can add mechanism_drivers in ovs_neutron_plugin.ini and modify it.\nI did test, that attribute should be modified by openvswitch agent.","commit_id":"0824e1c6ae1ae658991e3e8e7282589aa1f3d2c1"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"2c7dd5ceae100dc085c36da8064c595641651121","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* l3_agent.ini.erb"},{"line_number":28,"context_line":"* ovs_neutron_plugin.ini.erb"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The attribute \u0027mechanism_drivers\u0027 which needs to be modified and known by"},{"line_number":31,"context_line":"neutorn-openvswitch-agent, is in ml2_conf.ini, but neutron-openvswitch-agent"},{"line_number":32,"context_line":"use ovs_neutron_plugin.ini as config file by default, so maybe we could add"},{"line_number":33,"context_line":"this change in ovs_neutron_plugin.ini.erb."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_76a80421","line":30,"in_reply_to":"3a961159_5b0001ab","updated":"2014-12-29 05:24:33.000000000","message":"Sorry for my comment in Dec 23, some points in it is not clear.\n#1, which in openvswitch agent config file.\n#2, I didi test, that attribute(mechanism_drivers) should not be modified by openvswitch agent.","commit_id":"0824e1c6ae1ae658991e3e8e7282589aa1f3d2c1"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"b711d4be2f7aba67fe6942e73fc224846155ded3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":36,"context_line":"* l3_agent.rb"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"l3_agent.ini.erb need a variable to know current node is compute node"},{"line_number":39,"context_line":"or network node when DVR is enable."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If necessary we also need methods to make sure necessary packages"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_9b2d0949","line":38,"updated":"2014-12-22 00:23:11.000000000","message":"I don\u0027t think this is required as long as you can know this from the role or attributes.","commit_id":"0824e1c6ae1ae658991e3e8e7282589aa1f3d2c1"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"63ddbfcd7db33e796116a50740a8e410b48b54bb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":36,"context_line":"* l3_agent.rb"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"l3_agent.ini.erb need a variable to know current node is compute node"},{"line_number":39,"context_line":"or network node when DVR is enable."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If necessary we also need methods to make sure necessary packages"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_e7a10e47","line":38,"in_reply_to":"3a961159_9b2d0949","updated":"2014-12-23 03:35:00.000000000","message":"Chef can get runlist for node, which contains roles and recipes, I consider it\u0027s not a clear way to get node type from roles.\nYes, we can use attributes, but I didn\u0027t find any existing attribute that I can get current node type directly.\nIf you mean add a new attribute, I think we can also pass a variable from l3_agent.rb to l3_agent.ini.erb, if dvr is enabled but user forget to set node type attribute.","commit_id":"0824e1c6ae1ae658991e3e8e7282589aa1f3d2c1"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"fdc1c910984b09c9a4769b77a77c4bc4296737d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"https://blueprints.launchpad.net/openstack-chef/+spec/enable-dvr-chef-cookbook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enable by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user have to manually do some additional config to enable DVR."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_99a4caba","line":10,"updated":"2014-12-27 16:37:46.000000000","message":"Does DVR have any platform differences that should be noted in here?    redhat vs centos vs ubuntu vs suse?  \n\nAnd what about supported platform versions?  I see the netns is used, so I assume that network namespace is required is which is only supported on later version of the platforms, need to make note of those details.","commit_id":"44e1a42d249e95e7b100c88195078e941528cc4e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d6f525a9abcd3a655a208cb2fa2f16f0683e731a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"https://blueprints.launchpad.net/openstack-chef/+spec/enable-dvr-chef-cookbook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enable by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user have to manually do some additional config to enable DVR."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_0b487286","line":10,"in_reply_to":"3a961159_769d6466","updated":"2014-12-29 16:43:51.000000000","message":"I would say that redhat and  ubuntu are ok for now. \nFor the network namespace, I believe for redhat 6.5, that is only available with the RDO distro and not with the base OS, so that may still be an issue.  I think it\u0027s finally in the base redhat 7 OS kernel.","commit_id":"44e1a42d249e95e7b100c88195078e941528cc4e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"d781c5896c29a1061e34b8d14ab13a29067bda3f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"https://blueprints.launchpad.net/openstack-chef/+spec/enable-dvr-chef-cookbook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enable by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user have to manually do some additional config to enable DVR."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_769d6466","line":10,"in_reply_to":"3a961159_99a4caba","updated":"2014-12-29 05:30:05.000000000","message":"I did not notice platform differences in my previous investigation about DVR, I will go check for this.\nI\u0027ve enabled DVR in redhat 6.5 and my colleague enabled it on ubuntu 14.04. Only difference we found is that rh 6.5 need upgrade iproute. Maybe I should do more test, or for now, I can add information like\"redhat and ubuntu have been test, centos and suse will be test later\", is this can be acceptable for this blueprint?\n\nLinux 2.6.24 add basic support for network namespaces. And your can check it here, http://kernelnewbies.org/Linux_2_6_24#head-352920fc4eb155082ec03c19d30e94d6a4cacce2, and it\u0027s released on 24 January 2008. So I suppose this may not affect too much, but it\u0027s a good idea to note some details here.","commit_id":"44e1a42d249e95e7b100c88195078e941528cc4e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"fdc1c910984b09c9a4769b77a77c4bc4296737d1","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":94,"context_line":"interfaces, before boot any instances, we should see nothing after run"},{"line_number":95,"context_line":"\"ip netns\" on compute node. Boot instances on N1 and N2 on different"},{"line_number":96,"context_line":"compute nodes, we should see network namespace on those compute nodes"},{"line_number":97,"context_line":"by run \"ip netns\"."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_59c34257","line":95,"updated":"2014-12-27 16:37:46.000000000","message":"maybe briefly explain what netns command is and what it does?","commit_id":"44e1a42d249e95e7b100c88195078e941528cc4e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"d781c5896c29a1061e34b8d14ab13a29067bda3f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":94,"context_line":"interfaces, before boot any instances, we should see nothing after run"},{"line_number":95,"context_line":"\"ip netns\" on compute node. Boot instances on N1 and N2 on different"},{"line_number":96,"context_line":"compute nodes, we should see network namespace on those compute nodes"},{"line_number":97,"context_line":"by run \"ip netns\"."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_16ec208f","line":95,"in_reply_to":"3a961159_59c34257","updated":"2014-12-29 05:30:05.000000000","message":"Yeah, good idea, I will add some info for that.","commit_id":"44e1a42d249e95e7b100c88195078e941528cc4e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"80c1a2731e8566fa68fce48bbe2a6775ac0a346d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The following attribute files in cookbook-openstack-network will be mofified:"},{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it,"},{"line_number":22,"context_line":"but consider not all network types support DVR yet, so default value false"},{"line_number":23,"context_line":"would make sense."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The following template files in cookbook-openstack-network will be modified:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_36aff8e4","line":22,"updated":"2015-01-05 21:36:05.000000000","message":"Would it make more sense to tie the enablement of DVR to the network type and/or by default auto enable it for GRE and VXLAN?\n\nMaybe a better question is why would someone want gre or vxlan without dvr enabled?","commit_id":"00e3c14ccff09f8081fa97b3e701d35035d9e3e9"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e8d5ccd60dd0358af7be5570f80429495e5a79f7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The following attribute files in cookbook-openstack-network will be mofified:"},{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it,"},{"line_number":22,"context_line":"but consider not all network types support DVR yet, so default value false"},{"line_number":23,"context_line":"would make sense."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The following template files in cookbook-openstack-network will be modified:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_e8a668c0","line":22,"in_reply_to":"3a961159_36aff8e4","updated":"2015-01-06 02:40:21.000000000","message":"I didn\u0027t make DVR auto enabled for GER and VXLAN by default, because I\u0027m not sure if anybody want GRE of VXLAN but not DVR.\nBut your question here shows me some message like, enable DVR will be a tendency. So as you say, by default, DVR is enabled autolly for GRE and VXLAN will be more sense, and if user knows what she/he wants, we should give her/him a choice to disable DVR.\nSo, I consider this would be better:\n#1 [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] will be true by default when network type is GRE or VXLAN.\n#2 if user do not want DVR enabled with GRE or VXLAN, she/he can set [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] false to do that.\n#3 if network type is VLAN, DVR will be disabled even [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] is true.","commit_id":"00e3c14ccff09f8081fa97b3e701d35035d9e3e9"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"bfb36e75ba4eff752b6e742d9a503ae82424dc85","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The following attribute files in cookbook-openstack-network will be mofified:"},{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it,"},{"line_number":22,"context_line":"but consider not all network types support DVR yet, so default value false"},{"line_number":23,"context_line":"would make sense."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The following template files in cookbook-openstack-network will be modified:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_6e41a138","line":22,"in_reply_to":"3a961159_e8a668c0","updated":"2015-01-06 03:03:09.000000000","message":"I would prefer that DVR is not enabled by default when network type is tunnel since floating IP on each compute host requires external network connection. This may not be the situation that every deployer can satisfy. BTW, considering upgrade, DVR should be disable for backward compatibility.","commit_id":"00e3c14ccff09f8081fa97b3e701d35035d9e3e9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"80c1a2731e8566fa68fce48bbe2a6775ac0a346d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"like iproute are installed on compute node."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":44,"context_line":"we need also need methods to make sure current network type is either GRE"},{"line_number":45,"context_line":"or VXLAN, which means tunnel_type in ovs_neutron_plugin.ini should be gre"},{"line_number":46,"context_line":"or vxlan. If current network type is VLAN, we should stop the configuration"},{"line_number":47,"context_line":"of DVR. And we also need methods to make sure necessary network resource"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_8b8c09d9","line":44,"updated":"2015-01-05 21:36:05.000000000","message":"typo,   \u0027...we also need a method to make sure...\"","commit_id":"00e3c14ccff09f8081fa97b3e701d35035d9e3e9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d337507a745e2f7f8eab813a7783e1a38fb95dec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it."},{"line_number":22,"context_line":"User can set this attribute to \u0027auto\u0027, true and false. When this attribute is"},{"line_number":23,"context_line":"set to \u0027auto\u0027, DVR will be enabled or disabled based on network type autolly."},{"line_number":24,"context_line":"And consider only GRE and VXLAN network type support DVR, router_distributed\u0027s"},{"line_number":25,"context_line":"true and false setting will only work in the two network types. To VLAN"},{"line_number":26,"context_line":"network type, DVR will be disabled by default even router_distributed is set"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_9dbb2f0e","line":23,"updated":"2015-01-07 16:25:44.000000000","message":"autolly -\u003e automatically","commit_id":"9d3217987c7a6c5fd58f7e27b9b77fabefd63808"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d337507a745e2f7f8eab813a7783e1a38fb95dec","unresolved":false,"context_lines":[{"line_number":21,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it."},{"line_number":22,"context_line":"User can set this attribute to \u0027auto\u0027, true and false. When this attribute is"},{"line_number":23,"context_line":"set to \u0027auto\u0027, DVR will be enabled or disabled based on network type autolly."},{"line_number":24,"context_line":"And consider only GRE and VXLAN network type support DVR, router_distributed\u0027s"},{"line_number":25,"context_line":"true and false setting will only work in the two network types. To VLAN"},{"line_number":26,"context_line":"network type, DVR will be disabled by default even router_distributed is set"},{"line_number":27,"context_line":"to true."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_1d565fce","line":24,"updated":"2015-01-07 16:25:44.000000000","message":"consider -\u003e considering\n\ntype -\u003e types","commit_id":"9d3217987c7a6c5fd58f7e27b9b77fabefd63808"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d337507a745e2f7f8eab813a7783e1a38fb95dec","unresolved":false,"context_lines":[{"line_number":23,"context_line":"set to \u0027auto\u0027, DVR will be enabled or disabled based on network type autolly."},{"line_number":24,"context_line":"And consider only GRE and VXLAN network type support DVR, router_distributed\u0027s"},{"line_number":25,"context_line":"true and false setting will only work in the two network types. To VLAN"},{"line_number":26,"context_line":"network type, DVR will be disabled by default even router_distributed is set"},{"line_number":27,"context_line":"to true."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The following template files in cookbook-openstack-network will be modified:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_3d279b64","line":26,"updated":"2015-01-07 16:25:44.000000000","message":"I would go one step further and add in that the cookbook will generate a warning log message in this case.","commit_id":"9d3217987c7a6c5fd58f7e27b9b77fabefd63808"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d337507a745e2f7f8eab813a7783e1a38fb95dec","unresolved":false,"context_lines":[{"line_number":35,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":36,"context_line":"* l3_agent.rb"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":39,"context_line":"when DVR is enable. If any existing attributes can support this, we will not"},{"line_number":40,"context_line":"modify l3_agent.rb, otherwise, l3_agent.rb will be modified to check out"},{"line_number":41,"context_line":"current node type, and send \u0027dvr\u0027 or \u0027dvr_snat\u0027 as variable value to"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_e81393b5","line":38,"updated":"2015-01-07 16:25:44.000000000","message":"Technically a node could be both, in all-in-one case, explain how that would be handled.\nI think this type of logic would work:\n\nrecipe_name \u003d \u0027cookbook-openstack-compute::compute\u0027\n\nonly_if node.recipe.include?(recipe_name)","commit_id":"9d3217987c7a6c5fd58f7e27b9b77fabefd63808"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fab29f8d455d8e7280b3e4ae2f439b01a434c777","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Enable Distributed Virtual Router(DVR) in chef cookbook"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Include the URL of your launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a961159_c46db033","line":2,"updated":"2015-01-09 02:31:37.000000000","message":"I think you should add a DVR wiki link at the References section.","commit_id":"9e106c3d10f01dc886e5dda124d05963eabd127e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fab29f8d455d8e7280b3e4ae2f439b01a434c777","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enable by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user have to manually do some additional config to enable DVR."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a961159_e4f38c9c","line":12,"updated":"2015-01-09 02:31:37.000000000","message":"change \"enable\" to \"enabled\"","commit_id":"9e106c3d10f01dc886e5dda124d05963eabd127e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fab29f8d455d8e7280b3e4ae2f439b01a434c777","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enable by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user have to manually do some additional config to enable DVR."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a961159_442c6002","line":13,"updated":"2015-01-09 02:31:37.000000000","message":"change to \"has\"","commit_id":"9e106c3d10f01dc886e5dda124d05963eabd127e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fab29f8d455d8e7280b3e4ae2f439b01a434c777","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Proposed change"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The following attribute files in cookbook-openstack-network will be mofified:"},{"line_number":20,"context_line":"* default.rb"},{"line_number":21,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it."},{"line_number":22,"context_line":"User can set this attribute to \u0027auto\u0027, true and false. When this attribute is"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a961159_e43aac32","line":19,"updated":"2015-01-09 02:31:37.000000000","message":"should \"file\"","commit_id":"9e106c3d10f01dc886e5dda124d05963eabd127e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"fab29f8d455d8e7280b3e4ae2f439b01a434c777","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Another option to case that DVR is enable while tunnel_type is vlan,"},{"line_number":68,"context_line":"is that we can cover that value by gre or vxlan for tunnel_type in"},{"line_number":69,"context_line":"ovs_neutron_plugin.ini. Consider that if user decide to enable DVR,"},{"line_number":70,"context_line":"user can accept the changing in openvswitch agent config file."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a961159_447aa0f1","line":67,"updated":"2015-01-09 02:31:37.000000000","message":"enabled","commit_id":"9e106c3d10f01dc886e5dda124d05963eabd127e"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enabled by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user has to manually do some additional config to enable DVR."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_fbf5db51","line":12,"updated":"2015-01-09 17:12:45.000000000","message":"DVR is not enabled by default in Neutron properties either:\n\n   https://github.com/openstack/neutron/blob/master/etc/l3_agent.ini#L98\n\nIn the Juno release notes, DVR was listed as still experimental and that it should not be used in production until Kilo. I\u0027m not sure if if will be enabled by default then.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is not enabled by default in neutron in chef cookbook."},{"line_number":13,"context_line":"After deployed, user has to manually do some additional config to enable DVR."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_b9e346d7","line":12,"in_reply_to":"3a961159_fbf5db51","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"router_distributed\u0027s true and false setting will only work in the two network"},{"line_number":26,"context_line":"types. To VLAN network type, DVR will be disabled by default even"},{"line_number":27,"context_line":"router_distributed is set to true, warning messages will be given to user to"},{"line_number":28,"context_line":"notify why DVR config doesn\u0027t work."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The following template files in cookbook-openstack-network will be modified:"},{"line_number":31,"context_line":"* neutron.conf.erb"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_bba99327","line":28,"updated":"2015-01-09 17:12:45.000000000","message":"DVR also requires OVS.  If the OVS ML2 extension is not being used, DVR should not be enabled.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"router_distributed\u0027s true and false setting will only work in the two network"},{"line_number":26,"context_line":"types. To VLAN network type, DVR will be disabled by default even"},{"line_number":27,"context_line":"router_distributed is set to true, warning messages will be given to user to"},{"line_number":28,"context_line":"notify why DVR config doesn\u0027t work."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The following template files in cookbook-openstack-network will be modified:"},{"line_number":31,"context_line":"* neutron.conf.erb"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_198e1a33","line":28,"in_reply_to":"3a961159_bba99327","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"router_distributed is set to true, warning messages will be given to user to"},{"line_number":28,"context_line":"notify why DVR config doesn\u0027t work."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The following template files in cookbook-openstack-network will be modified:"},{"line_number":31,"context_line":"* neutron.conf.erb"},{"line_number":32,"context_line":"* l3_agent.ini.erb"},{"line_number":33,"context_line":"* ovs_neutron_plugin.ini.erb"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_0617ae46","line":30,"updated":"2015-01-09 17:12:45.000000000","message":"Maybe I missed this from earlier comments, but why does the ovs and ml2  template files need to be modified ?    I don\u0027t recall seeing any DVR settings in those files.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"router_distributed is set to true, warning messages will be given to user to"},{"line_number":28,"context_line":"notify why DVR config doesn\u0027t work."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The following template files in cookbook-openstack-network will be modified:"},{"line_number":31,"context_line":"* neutron.conf.erb"},{"line_number":32,"context_line":"* l3_agent.ini.erb"},{"line_number":33,"context_line":"* ovs_neutron_plugin.ini.erb"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_79847e0e","line":30,"in_reply_to":"3a961159_0617ae46","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"9c09192268a05e5b90d544c192cb23ec5f37fb43","unresolved":false,"context_lines":[{"line_number":27,"context_line":"router_distributed is set to true, warning messages will be given to user to"},{"line_number":28,"context_line":"notify why DVR config doesn\u0027t work."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The following template files in cookbook-openstack-network will be modified:"},{"line_number":31,"context_line":"* neutron.conf.erb"},{"line_number":32,"context_line":"* l3_agent.ini.erb"},{"line_number":33,"context_line":"* ovs_neutron_plugin.ini.erb"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_c6d4c6bd","line":30,"in_reply_to":"3a961159_0617ae46","updated":"2015-01-09 17:17:01.000000000","message":"Ok, I found \"enable_distributed_routing\" in ovs_neutron_plugin.ini, but I don\u0027t see any DVR settings in ml2_conf.ini.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"router_distributed is set to true, warning messages will be given to user to"},{"line_number":28,"context_line":"notify why DVR config doesn\u0027t work."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The following template files in cookbook-openstack-network will be modified:"},{"line_number":31,"context_line":"* neutron.conf.erb"},{"line_number":32,"context_line":"* l3_agent.ini.erb"},{"line_number":33,"context_line":"* ovs_neutron_plugin.ini.erb"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_f9778e3a","line":30,"in_reply_to":"3a961159_c6d4c6bd","updated":"2015-01-20 02:10:37.000000000","message":"l2_population attribute in ovs_neutron_plugin.ini need be supported in ml2_conf.ini in mechanism_drivers.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* l3_agent.rb"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":40,"context_line":"when DVR is enabled. If any existing attributes can support this, we will not"},{"line_number":41,"context_line":"modify l3_agent.rb, otherwise, l3_agent.rb will be modified to check out"},{"line_number":42,"context_line":"current node type, and send \u0027dvr\u0027 or \u0027dvr_snat\u0027 as variable value to"},{"line_number":43,"context_line":"l3_agent.ini.erb. In common case, 1+N environment and all-in-one environment,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_66a232fe","line":40,"updated":"2015-01-09 17:12:45.000000000","message":"There are other types of nodes besides just compute and network.  For example: all-in-one node, controller/server node, or a dedicated database node.  There could be other dedicated OpenStack service nodes as well.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"f4baa2caaaf771415c5e4cf89ef8503645a401ce","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* l3_agent.rb"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":40,"context_line":"when DVR is enabled. If any existing attributes can support this, we will not"},{"line_number":41,"context_line":"modify l3_agent.rb, otherwise, l3_agent.rb will be modified to check out"},{"line_number":42,"context_line":"current node type, and send \u0027dvr\u0027 or \u0027dvr_snat\u0027 as variable value to"},{"line_number":43,"context_line":"l3_agent.ini.erb. In common case, 1+N environment and all-in-one environment,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_d37446d2","line":40,"in_reply_to":"3a961159_66a232fe","updated":"2015-01-13 04:17:29.000000000","message":"I think we could only consider the two node types. DVR try to give a new data path for vms, like East-West Communication, give compute nodes external IPs to make vms can get floating IPs not only from network nodes.\nDVR will only work on nodes which has L3 agent and OVS agent,\nand these will installed for network node role and compute node role, so what we should really considered what roles the node has.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"of DVR. And we also need methods to make sure necessary network resource"},{"line_number":56,"context_line":"like tunnel network bridge are created on compute node."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If necessary we will change the role definition for compute node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"We did test and enabled DVR on Redhat and Ubuntu, but not all versions have"},{"line_number":61,"context_line":"been tested. So in cookbook, we will deal with details from different"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_4639b6a2","line":58,"updated":"2015-01-09 17:12:45.000000000","message":"If necessary ?    I don\u0027t believe the L3 agent is in the role definition for a compute node, so yes... I believe it will be required.  If customers are not running DVR, they probabaly don\u0027t want L3 agent on compute nodes at all ... so there may need to be some logic to conditionally added L3 to the runlist of compute nodes.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"of DVR. And we also need methods to make sure necessary network resource"},{"line_number":56,"context_line":"like tunnel network bridge are created on compute node."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If necessary we will change the role definition for compute node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"We did test and enabled DVR on Redhat and Ubuntu, but not all versions have"},{"line_number":61,"context_line":"been tested. So in cookbook, we will deal with details from different"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_596fc260","line":58,"in_reply_to":"3a961159_4639b6a2","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":102,"context_line":"then deploy a 1+N environment. Check if config files are modified list"},{"line_number":103,"context_line":"in wiki Neutron DVR HowTo page."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_06a7aea8","line":102,"updated":"2015-01-09 17:12:45.000000000","message":"Are we only considering single controller node in this spec?\nShouldn\u0027t we also consider a dedicated network node ?   \nOr multiple network nodes ...   or ...","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":102,"context_line":"then deploy a 1+N environment. Check if config files are modified list"},{"line_number":103,"context_line":"in wiki Neutron DVR HowTo page."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_19c37a3a","line":102,"in_reply_to":"3a961159_06a7aea8","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":102,"context_line":"then deploy a 1+N environment. Check if config files are modified list"},{"line_number":103,"context_line":"in wiki Neutron DVR HowTo page."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":106,"context_line":"interfaces, before boot any instances, we should see nothing after run"},{"line_number":107,"context_line":"\"ip netns\" on compute node. Boot instances on N1 and N2 on different"},{"line_number":108,"context_line":"compute nodes, we should see network namespace on those compute nodes"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_26b74afa","line":105,"updated":"2015-01-09 17:12:45.000000000","message":"I think additional testing needs to be done to verify outbound traffic from compute nodes is not being NATed through the network node when DVR is enabled on the compute nodes.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"then deploy a 1+N environment. Check if config files are modified list"},{"line_number":103,"context_line":"in wiki Neutron DVR HowTo page."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":106,"context_line":"interfaces, before boot any instances, we should see nothing after run"},{"line_number":107,"context_line":"\"ip netns\" on compute node. Boot instances on N1 and N2 on different"},{"line_number":108,"context_line":"compute nodes, we should see network namespace on those compute nodes"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_39a9167d","line":105,"in_reply_to":"3a961159_26b74afa","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"43f1916b1d83ab29befacc1e20d42256f25a0afc","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Documentation Impact"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* DVR will be enabled by default when network type is GRE or VXLAN,"},{"line_number":120,"context_line":"  user can set [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed]\u0027 \u003d \u0027False\u0027"},{"line_number":121,"context_line":"  in override_attributes to disable it."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_66fb127c","line":119,"updated":"2015-01-09 17:12:45.000000000","message":"DVR also requires ML2 + OVS.  Customer may be using diff plugin or a diff ML2 mechanism driver.","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"27de298fd1974bda849f220d8c67717ba845578b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Documentation Impact"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* DVR will be enabled by default when network type is GRE or VXLAN,"},{"line_number":120,"context_line":"  user can set [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed]\u0027 \u003d \u0027False\u0027"},{"line_number":121,"context_line":"  in override_attributes to disable it."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_59a6e2ac","line":119,"in_reply_to":"3a961159_66fb127c","updated":"2015-01-20 02:10:37.000000000","message":"Done","commit_id":"aaa9dd949c5ad226479ed374156c8eadf1cac071"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"a6d637baba8829aa3bc95eb79b1334ca36344411","unresolved":false,"context_lines":[{"line_number":22,"context_line":"We will add attribute [\u0027openstack\u0027][\u0027network\u0027][\u0027router_distributed\u0027] in it."},{"line_number":23,"context_line":"User can set this attribute to \u0027auto\u0027, true and false. When this attribute is"},{"line_number":24,"context_line":"set to \u0027auto\u0027, chef cookbook will do enough check, like network type and ML2"},{"line_number":25,"context_line":"extensions, to decide enable DVR or not, if DVR cound not be enabled,"},{"line_number":26,"context_line":"chef cookbook will output logs to tell user what happened. And considering"},{"line_number":27,"context_line":"only GRE and VXLAN network types support DVR, router_distributed\u0027s true and"},{"line_number":28,"context_line":"false setting will only work in the two network types. To VLAN network type,"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a961159_c16882f6","line":25,"updated":"2015-01-15 17:19:42.000000000","message":"cound \u003d could","commit_id":"cbd076667b5e061fad8a99ce5834c71dc5c99371"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"a6d637baba8829aa3bc95eb79b1334ca36344411","unresolved":false,"context_lines":[{"line_number":24,"context_line":"set to \u0027auto\u0027, chef cookbook will do enough check, like network type and ML2"},{"line_number":25,"context_line":"extensions, to decide enable DVR or not, if DVR cound not be enabled,"},{"line_number":26,"context_line":"chef cookbook will output logs to tell user what happened. And considering"},{"line_number":27,"context_line":"only GRE and VXLAN network types support DVR, router_distributed\u0027s true and"},{"line_number":28,"context_line":"false setting will only work in the two network types. To VLAN network type,"},{"line_number":29,"context_line":"DVR will be disabled by default even router_distributed is set to true,"},{"line_number":30,"context_line":"warning messages will be given to user to notify why DVR config doesn\u0027t work."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a961159_212146b4","line":27,"updated":"2015-01-15 17:19:42.000000000","message":"DVR is only supported if OVS is enabled.  That needs to be checked too.  Not everyone uses OVS.","commit_id":"cbd076667b5e061fad8a99ce5834c71dc5c99371"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"a6d637baba8829aa3bc95eb79b1334ca36344411","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":57,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":58,"context_line":"or VXLAN, which means tunnel_type in ovs_neutron_plugin.ini should be gre"},{"line_number":59,"context_line":"or vxlan. If current network type is VLAN, we should stop the configuration"},{"line_number":60,"context_line":"of DVR. And we also need methods to make sure necessary network resource"},{"line_number":61,"context_line":"like tunnel network bridge are created on compute node."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a961159_878e8a25","line":58,"updated":"2015-01-15 17:19:42.000000000","message":"The tunnel type property in ovs_neutron_plugin.ini  is actually tunnel_types.  Both vxlan AND GRE can be listed.","commit_id":"cbd076667b5e061fad8a99ce5834c71dc5c99371"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"a6d637baba8829aa3bc95eb79b1334ca36344411","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":107,"context_line":"then deploy a 1+N environment or a multiple network nodes.(All-in-one case"},{"line_number":108,"context_line":"is unnecessary) Check if config files are modified list in wiki Neutron DVR"},{"line_number":109,"context_line":"HowTo page."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a961159_e7358e45","line":107,"updated":"2015-01-15 17:19:42.000000000","message":"I think the All-in-one case should be tested.  Should verify that DVR not enabled (or a warning message is given) when only deploying a all-in-one node.   Perhaps not enabled if router_distributed \u003d auto, and deploy failure or at least a warning if router_distributed \u003d true.","commit_id":"cbd076667b5e061fad8a99ce5834c71dc5c99371"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"b8d54af4046c98836e68c705905d75c81c5e4e24","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":107,"context_line":"then deploy a 1+N environment or a multiple network nodes.(All-in-one case"},{"line_number":108,"context_line":"is unnecessary) Check if config files are modified list in wiki Neutron DVR"},{"line_number":109,"context_line":"HowTo page."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a961159_0f61be38","line":107,"in_reply_to":"3a961159_e7358e45","updated":"2015-01-16 06:59:04.000000000","message":"All-in-one case, the node will have both network node role and compute node role, it will be similar to the control node in 1+N case. So I consider that, user can still set DVR related attributes, but anything should be affected.","commit_id":"cbd076667b5e061fad8a99ce5834c71dc5c99371"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"a6d637baba8829aa3bc95eb79b1334ca36344411","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  [\u0027openstack\u0027][\u0027network\u0027][\u0027ml2\u0027][\u0027mechanism_drivers\u0027 has value"},{"line_number":140,"context_line":"  \u0027openvswitch\u0027."},{"line_number":141,"context_line":"* User need ensure [\u0027openstack\u0027][\u0027compute\u0027][\u0027network\u0027][\u0027plugins\u0027] has"},{"line_number":142,"context_line":"  value \u0027openvswitch\u0027 to support DVR."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"References"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a961159_c755f252","line":142,"updated":"2015-01-15 17:19:42.000000000","message":"Both of the above \"user\" checks should be done in \"auto\" mode.","commit_id":"cbd076667b5e061fad8a99ce5834c71dc5c99371"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is disabled by default in neutron in chef cookbook and config"},{"line_number":13,"context_line":"files. After deployed, user has to manually do some additional config to"},{"line_number":14,"context_line":"enable DVR."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_52c99777","line":11,"updated":"2015-01-16 17:31:22.000000000","message":"Currently DVR is disabled by default in Neutron and not allowed to be configured in the Network cookbook.  After deployment, the user has to manually modify the Neutron configuration files to enable DVR.","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem description"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently DVR is disabled by default in neutron in chef cookbook and config"},{"line_number":13,"context_line":"files. After deployed, user has to manually do some additional config to"},{"line_number":14,"context_line":"enable DVR."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_a7950389","line":11,"in_reply_to":"3a961159_52c99777","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Modify attribute \u0027router_distributed\u0027 in neutron.conf.erb, \u0027agent_mode\u0027 in"},{"line_number":39,"context_line":"l3_agent.ini.erb, \u0027enable_distributed_routing\u0027 and \u0027l2_population\u0027 in"},{"line_number":40,"context_line":"ovs_neutron_plugin.ini.erb, \u0027mechanism_drivers\u0027 in ml2_conf.ini.erb. These"},{"line_number":41,"context_line":"attributes can be found in the howto link in following References section."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":44,"context_line":"* l3_agent.rb"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_1299cf6c","line":41,"updated":"2015-01-16 17:31:22.000000000","message":"in following -\u003e  in the","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Modify attribute \u0027router_distributed\u0027 in neutron.conf.erb, \u0027agent_mode\u0027 in"},{"line_number":39,"context_line":"l3_agent.ini.erb, \u0027enable_distributed_routing\u0027 and \u0027l2_population\u0027 in"},{"line_number":40,"context_line":"ovs_neutron_plugin.ini.erb, \u0027mechanism_drivers\u0027 in ml2_conf.ini.erb. These"},{"line_number":41,"context_line":"attributes can be found in the howto link in following References section."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":44,"context_line":"* l3_agent.rb"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_67ef9b1d","line":41,"in_reply_to":"3a961159_1299cf6c","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":44,"context_line":"* l3_agent.rb"},{"line_number":45,"context_line":"DVR try to give a new data path for vms, like East-West Communication, give"},{"line_number":46,"context_line":"compute nodes external IPs to make vms can get floating IPs not only from"},{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_d2b907cc","line":45,"updated":"2015-01-16 17:31:22.000000000","message":"DVR try to give a new data path for vms -\u003e  DVR gives a new data path for vm\u0027s,\n\nCommunication -\u003e communication","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The following recipe files in cookbook-openstack-network may be modified:"},{"line_number":44,"context_line":"* l3_agent.rb"},{"line_number":45,"context_line":"DVR try to give a new data path for vms, like East-West Communication, give"},{"line_number":46,"context_line":"compute nodes external IPs to make vms can get floating IPs not only from"},{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_87f2c702","line":45,"in_reply_to":"3a961159_d2b907cc","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"DVR try to give a new data path for vms, like East-West Communication, give"},{"line_number":46,"context_line":"compute nodes external IPs to make vms can get floating IPs not only from"},{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."},{"line_number":49,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":50,"context_line":"when DVR is enabled. We need find any existing attributes can support this,"},{"line_number":51,"context_line":"or add a new attribute to support this, or add some methods in l3_agent.rb"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_32db2bee","line":48,"updated":"2015-01-16 17:31:22.000000000","message":"See https://review.openstack.org/#/c/145724/4/attributes/default.rb\nthere is an existing os-network-server role that can be used for this.\nhttps://github.com/stackforge/openstack-chef-repo/blob/master/roles/os-network-server.json\n\nAnd existing compute node role:\nhttps://github.com/stackforge/openstack-chef-repo/blob/master/roles/os-compute-worker.json","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":45,"context_line":"DVR try to give a new data path for vms, like East-West Communication, give"},{"line_number":46,"context_line":"compute nodes external IPs to make vms can get floating IPs not only from"},{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."},{"line_number":49,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":50,"context_line":"when DVR is enabled. We need find any existing attributes can support this,"},{"line_number":51,"context_line":"or add a new attribute to support this, or add some methods in l3_agent.rb"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_e750ebd6","line":48,"in_reply_to":"3a961159_32db2bee","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"compute nodes external IPs to make vms can get floating IPs not only from"},{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."},{"line_number":49,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":50,"context_line":"when DVR is enabled. We need find any existing attributes can support this,"},{"line_number":51,"context_line":"or add a new attribute to support this, or add some methods in l3_agent.rb"},{"line_number":52,"context_line":"to do this."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_92e93fad","line":49,"updated":"2015-01-16 17:31:22.000000000","message":"need to know current -\u003e  will need to query the current","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":46,"context_line":"compute nodes external IPs to make vms can get floating IPs not only from"},{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."},{"line_number":49,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":50,"context_line":"when DVR is enabled. We need find any existing attributes can support this,"},{"line_number":51,"context_line":"or add a new attribute to support this, or add some methods in l3_agent.rb"},{"line_number":52,"context_line":"to do this."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_473a9f98","line":49,"in_reply_to":"3a961159_92e93fad","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."},{"line_number":49,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":50,"context_line":"when DVR is enabled. We need find any existing attributes can support this,"},{"line_number":51,"context_line":"or add a new attribute to support this, or add some methods in l3_agent.rb"},{"line_number":52,"context_line":"to do this."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_978a11ba","line":50,"updated":"2015-01-16 17:31:22.000000000","message":"need -\u003e \"need to\"","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":47,"context_line":"network nodes. And DVR will only work on nodes which has L3 agent and OVS"},{"line_number":48,"context_line":"agent, and these will installed for network node role and compute node role."},{"line_number":49,"context_line":"l3_agent.ini.erb need to know current node is compute node or network node"},{"line_number":50,"context_line":"when DVR is enabled. We need find any existing attributes can support this,"},{"line_number":51,"context_line":"or add a new attribute to support this, or add some methods in l3_agent.rb"},{"line_number":52,"context_line":"to do this."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_87400707","line":50,"in_reply_to":"3a961159_978a11ba","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"If necessary we also need methods to make sure necessary packages"},{"line_number":55,"context_line":"like iproute are installed on compute node."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_12e8ef79","line":57,"updated":"2015-01-16 17:31:22.000000000","message":"For DVR is  -\u003e  DVR is","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":54,"context_line":"If necessary we also need methods to make sure necessary packages"},{"line_number":55,"context_line":"like iproute are installed on compute node."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_c745af15","line":57,"in_reply_to":"3a961159_12e8ef79","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"like iproute are installed on compute node."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"},{"line_number":61,"context_line":"stop the configuration of DVR. And we also need methods to make sure necessary"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_528437b0","line":58,"updated":"2015-01-16 17:31:22.000000000","message":"we need also need a method to make sure current -\u003e we also need a method to make sure the current","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":55,"context_line":"like iproute are installed on compute node."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"},{"line_number":61,"context_line":"stop the configuration of DVR. And we also need methods to make sure necessary"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_a7718378","line":58,"in_reply_to":"3a961159_528437b0","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"},{"line_number":61,"context_line":"stop the configuration of DVR. And we also need methods to make sure necessary"},{"line_number":62,"context_line":"network resource like tunnel network bridge are created on compute node."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_f2b28394","line":59,"updated":"2015-01-16 17:31:22.000000000","message":"which means tunnel_types in ovs_neutron_plugin.ini should be gre -\u003e  . The network type maps to key name tunnel_types in ovs_neutron_plugin.ini with values of gre","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"},{"line_number":61,"context_line":"stop the configuration of DVR. And we also need methods to make sure necessary"},{"line_number":62,"context_line":"network resource like tunnel network bridge are created on compute node."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_c76ccf9f","line":59,"in_reply_to":"3a961159_f2b28394","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"},{"line_number":61,"context_line":"stop the configuration of DVR. And we also need methods to make sure necessary"},{"line_number":62,"context_line":"network resource like tunnel network bridge are created on compute node."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_5207d71c","line":60,"updated":"2015-01-16 17:31:22.000000000","message":"or both the two types -\u003e \u003cremove this text\u003e","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":57,"context_line":"For DVR is supported by network type GRE and VXLAN, but not VLAN yet, so"},{"line_number":58,"context_line":"we need also need a method to make sure current network type is either GRE"},{"line_number":59,"context_line":"or VXLAN, which means tunnel_types in ovs_neutron_plugin.ini should be gre"},{"line_number":60,"context_line":"or vxlan, or both the two types. If current network type is VLAN, we should"},{"line_number":61,"context_line":"stop the configuration of DVR. And we also need methods to make sure necessary"},{"line_number":62,"context_line":"network resource like tunnel network bridge are created on compute node."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_ac3963d1","line":60,"in_reply_to":"3a961159_5207d71c","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"If necessary we will change the role definition for compute node."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We did test and enabled DVR on Redhat and Ubuntu, but not all versions have"},{"line_number":67,"context_line":"been tested. So in cookbook, we will deal with details from different"},{"line_number":68,"context_line":"platforms and release version affect."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_582b797b","line":67,"updated":"2015-01-16 17:31:22.000000000","message":"I would think that with kilo, only redhat 7 and ubuntu 14 would need to be supported in the cookbook.  Just need to state that fact here.  If someone wants to back port this to stable/juno (after kilo branch work is note), they will have to deal with the redhat 6.5 and ubuntu 12 issues.","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":64,"context_line":"If necessary we will change the role definition for compute node."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We did test and enabled DVR on Redhat and Ubuntu, but not all versions have"},{"line_number":67,"context_line":"been tested. So in cookbook, we will deal with details from different"},{"line_number":68,"context_line":"platforms and release version affect."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_3634dff9","line":67,"in_reply_to":"3a961159_582b797b","updated":"2015-01-19 09:39:18.000000000","message":"I think we could output warning messages and logs to systems which we don\u0027t support.","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We did test and enabled DVR on Redhat and Ubuntu, but not all versions have"},{"line_number":67,"context_line":"been tested. So in cookbook, we will deal with details from different"},{"line_number":68,"context_line":"platforms and release version affect."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_789bd5c8","line":68,"updated":"2015-01-16 17:31:22.000000000","message":"platforms and release version affect.    -\u003e platforms and releases affected.","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We did test and enabled DVR on Redhat and Ubuntu, but not all versions have"},{"line_number":67,"context_line":"been tested. So in cookbook, we will deal with details from different"},{"line_number":68,"context_line":"platforms and release version affect."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_5637abfd","line":68,"in_reply_to":"3a961159_789bd5c8","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Another option to case that DVR is enabled while tunnel_types is vlan,"},{"line_number":74,"context_line":"is that we can cover that value by gre or vxlan for tunnel_type in"},{"line_number":75,"context_line":"ovs_neutron_plugin.ini. Consider that if user decide to enable DVR,"},{"line_number":76,"context_line":"user can accept the changing in openvswitch agent config file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_b74aad80","line":75,"updated":"2015-01-16 17:31:22.000000000","message":"user decide  -\u003e user decides","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Another option to case that DVR is enabled while tunnel_types is vlan,"},{"line_number":74,"context_line":"is that we can cover that value by gre or vxlan for tunnel_type in"},{"line_number":75,"context_line":"ovs_neutron_plugin.ini. Consider that if user decide to enable DVR,"},{"line_number":76,"context_line":"user can accept the changing in openvswitch agent config file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_9624b3c6","line":75,"in_reply_to":"3a961159_b74aad80","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Another option to case that DVR is enabled while tunnel_types is vlan,"},{"line_number":74,"context_line":"is that we can cover that value by gre or vxlan for tunnel_type in"},{"line_number":75,"context_line":"ovs_neutron_plugin.ini. Consider that if user decide to enable DVR,"},{"line_number":76,"context_line":"user can accept the changing in openvswitch agent config file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Data model impact"},{"line_number":79,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_57598959","line":76,"updated":"2015-01-16 17:31:22.000000000","message":"accept the changing in openvswitch -\u003e  accept changing the openvswitch","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Another option to case that DVR is enabled while tunnel_types is vlan,"},{"line_number":74,"context_line":"is that we can cover that value by gre or vxlan for tunnel_type in"},{"line_number":75,"context_line":"ovs_neutron_plugin.ini. Consider that if user decide to enable DVR,"},{"line_number":76,"context_line":"user can accept the changing in openvswitch agent config file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Data model impact"},{"line_number":79,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_b61fef6e","line":76,"in_reply_to":"3a961159_57598959","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":108,"context_line":"then deploy a 1+N environment or a multiple network nodes environment."},{"line_number":109,"context_line":"(All-in-one case is unnecessary, we can consider it is come kind of 1+0 case)"},{"line_number":110,"context_line":"Check if config files are modified list in wiki Neutron DVR HowTo page."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_972691c9","line":109,"updated":"2015-01-16 17:31:22.000000000","message":"we can consider it is come kind of 1+0 case -\u003e we can consider it similar to 1+0 case","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":108,"context_line":"then deploy a 1+N environment or a multiple network nodes environment."},{"line_number":109,"context_line":"(All-in-one case is unnecessary, we can consider it is come kind of 1+0 case)"},{"line_number":110,"context_line":"Check if config files are modified list in wiki Neutron DVR HowTo page."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_270593c1","line":109,"in_reply_to":"3a961159_972691c9","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":108,"context_line":"then deploy a 1+N environment or a multiple network nodes environment."},{"line_number":109,"context_line":"(All-in-one case is unnecessary, we can consider it is come kind of 1+0 case)"},{"line_number":110,"context_line":"Check if config files are modified list in wiki Neutron DVR HowTo page."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":113,"context_line":"interfaces, before boot any instances, we should see nothing after running"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_72193379","line":110,"updated":"2015-01-16 17:31:22.000000000","message":"Check if config files are modified list in -\u003e Check if config files are modified according to the list in the","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Add attribute \u0027router_distributed\u0027 \u003d\u003e \u0027true\u0027 in environment file,"},{"line_number":108,"context_line":"then deploy a 1+N environment or a multiple network nodes environment."},{"line_number":109,"context_line":"(All-in-one case is unnecessary, we can consider it is come kind of 1+0 case)"},{"line_number":110,"context_line":"Check if config files are modified list in wiki Neutron DVR HowTo page."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":113,"context_line":"interfaces, before boot any instances, we should see nothing after running"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_076337ab","line":110,"in_reply_to":"3a961159_72193379","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Check if config files are modified list in wiki Neutron DVR HowTo page."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":113,"context_line":"interfaces, before boot any instances, we should see nothing after running"},{"line_number":114,"context_line":"\"ip netns\" on compute nodes. Boot instances on N1 and N2 on different"},{"line_number":115,"context_line":"compute nodes, we should see network namespace on those compute nodes"},{"line_number":116,"context_line":"by running \"ip netns\"."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_323a4bcd","line":113,"updated":"2015-01-16 17:31:22.000000000","message":"before boot any  -\u003e  before booting any\n\nwe should see nothing after running -\u003e we should see nothing listed in the output when running","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Check if config files are modified list in wiki Neutron DVR HowTo page."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":113,"context_line":"interfaces, before boot any instances, we should see nothing after running"},{"line_number":114,"context_line":"\"ip netns\" on compute nodes. Boot instances on N1 and N2 on different"},{"line_number":115,"context_line":"compute nodes, we should see network namespace on those compute nodes"},{"line_number":116,"context_line":"by running \"ip netns\"."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_e7670bb6","line":113,"in_reply_to":"3a961159_323a4bcd","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9f4b2b0766e109b5737cb416497f5e7393fec8cb","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":113,"context_line":"interfaces, before boot any instances, we should see nothing after running"},{"line_number":114,"context_line":"\"ip netns\" on compute nodes. Boot instances on N1 and N2 on different"},{"line_number":115,"context_line":"compute nodes, we should see network namespace on those compute nodes"},{"line_number":116,"context_line":"by running \"ip netns\"."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_f2536313","line":114,"updated":"2015-01-16 17:31:22.000000000","message":"on compute -\u003e on the compute","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"cdcf862765746fb5274e69061839bfb86a30ac87","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Build network N1 and N2, router R1, add subnets of N1 and N2 to R1 as"},{"line_number":113,"context_line":"interfaces, before boot any instances, we should see nothing after running"},{"line_number":114,"context_line":"\"ip netns\" on compute nodes. Boot instances on N1 and N2 on different"},{"line_number":115,"context_line":"compute nodes, we should see network namespace on those compute nodes"},{"line_number":116,"context_line":"by running \"ip netns\"."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_4708dfd8","line":114,"in_reply_to":"3a961159_f2536313","updated":"2015-01-19 09:39:18.000000000","message":"Done","commit_id":"312a626bfabc5b611178a0c2b655f29f021b1b10"}]}