)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sudheesh \u003cskairali@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-11 10:13:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Final commit on openstack docker rst (removed spaces)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id964affc5cea6f568d48e9222f590b4b2f1737a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_040a1ed2","line":7,"updated":"2015-03-11 13:28:30.000000000","message":"in the world of patches, this is just another one to be reviewed again, so please change commit mg to have title and brief desc about the topic within","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"}],"specs/kilo/openstack-docker/openstack-docker.rst":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  2 years old driver."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* There is no Chef cookbook support to configure ceilometer to monitor"},{"line_number":29,"context_line":"  Docker containers in an openstack echo system. This will be supported in the second version"},{"line_number":30,"context_line":"  of the cookbook"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_e4dc2a1b","line":29,"updated":"2015-03-11 13:28:30.000000000","message":"i would move these future items into their own section, may after Proposed Changes, add a Possible Future Enhancements","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Add a cookbook included recipes and related attributes/unit tests to"},{"line_number":38,"context_line":"configure Openstack services such as nova and glance to use nova-docker"},{"line_number":39,"context_line":"driver. Also include recipes that can configure cadvisor to support"},{"line_number":40,"context_line":"ceilometer montoring on Docker containers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_c4c48661","line":37,"updated":"2015-03-11 13:28:30.000000000","message":"maybe reword this, does not read right.","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This cookbook will configure"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* [NOVA_DOCKER_DRIVER]_ .  We will soon support binary installation of nova docker driver as well"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"We will also need to introduce a new role os-docker-compute-single-controller  which will have"},{"line_number":47,"context_line":"all the docker recipes in the order explained in the blueprint."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_443a5637","line":44,"updated":"2015-03-11 13:28:30.000000000","message":"add binary install to new Possible Future Enhancements as suggested above","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* [NOVA_DOCKER_DRIVER]_ .  We will soon support binary installation of nova docker driver as well"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"We will also need to introduce a new role os-docker-compute-single-controller  which will have"},{"line_number":47,"context_line":"all the docker recipes in the order explained in the blueprint."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_0f8dd731","line":46,"updated":"2015-03-11 13:28:30.000000000","message":"remove extra space between controller and which\n\nI don\u0027t see a place in there where the order of recipes is explained, so either add that somewhere or change this description.\n\nI think other roles are needed here.  Since this is tied to compute and image, I think we need a 2 new roles for each of those, like\nos-compute-docker  os-image-docker.  Then each of these can be included in the existing os-compute-single-controller and os-compute-single-contoller-no-nework.  And they can then be included separately for other custom controller configurations  (like just compute controller or just image controller).\n\n\nTo make it easier to understand, I would give examples of a couple of those type of scenarios (all in one,  controller and worker nodes, and multi controller and worker nodes)","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  TESTING.md"},{"line_number":122,"context_line":"  /spec/spec_helper.rb"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Add the default attribute file to determine various docker related configurations"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Add the recipe files to configure openstack services with docker support"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_4f88afe7","line":124,"updated":"2015-03-11 13:28:30.000000000","message":"I think we should consider an Enable/Disable switch for this support.  That would allow these roles to be included in the base roles, but not really do anything unless enabled by a specific docker attribute.","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Add the default attribute file to determine various docker related configurations"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Add the recipe files to configure openstack services with docker support"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Add the template files to configure openstack services with docker support"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_6f53b36c","line":126,"updated":"2015-03-11 13:28:30.000000000","message":"Maybe brief desc here about each recipe","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0e7c57353785053d1fd44b81f63785226886b100","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Add the recipe files to configure openstack services with docker support"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Add the template files to configure openstack services with docker support"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Add the unit tests."},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_2fe8db7b","line":128,"updated":"2015-03-11 13:28:30.000000000","message":"Hopefully the templates within the compute and image cookbook already have everything you need to configure them via attributes, if not spell that out here that you will need to make updates to those as a dependency for this support.","commit_id":"35491055299d09cd3752b9fdaab7b5515b0faee8"}]}