)]}'
{"specs/liberty/network/.gitignore":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1aca2d91_7abebb00","line":1,"updated":"2015-05-06 13:21:20.000000000","message":"What happened with this file?  it\u0027s usually in the base dir, right?","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"85896eaaafaa05b4c626877f04039d2abd385fb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1aca2d91_7a3bfa9c","line":1,"updated":"2015-05-08 14:57:25.000000000","message":"What happened with this file? it\u0027s usually in the base dir, right?","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"}],"specs/liberty/network/ip-address-movement-for-ovs-bridges.rst":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Add recipes to move IP address from NIC to bridge. To make sure those IP addresses"},{"line_number":23,"context_line":"can also be accessed after finish the bridge creation."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Two attributes will be added, including:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_da870fd6","line":22,"updated":"2015-05-06 13:21:20.000000000","message":"Remove  \"To\" make sure.    just \"Make sure...\"","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Add recipes to move IP address from NIC to bridge. To make sure those IP addresses"},{"line_number":23,"context_line":"can also be accessed after finish the bridge creation."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Two attributes will be added, including:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_3d494132","line":22,"in_reply_to":"1aca2d91_da870fd6","updated":"2015-05-07 03:07:22.000000000","message":"Done","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Two attributes will be added, including:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip_movement\u0027][\u0027enable\u0027]: Boolean attribute to decide"},{"line_number":28,"context_line":"  whether IP movement should be enabled or not."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027timeout\u0027]: Integer attribute to decide"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_1a9a2715","line":27,"updated":"2015-05-06 13:21:20.000000000","message":"Default will be true?","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Two attributes will be added, including:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip_movement\u0027][\u0027enable\u0027]: Boolean attribute to decide"},{"line_number":28,"context_line":"  whether IP movement should be enabled or not."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027timeout\u0027]: Integer attribute to decide"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_1d5685d2","line":27,"in_reply_to":"1aca2d91_1a9a2715","updated":"2015-05-07 03:07:22.000000000","message":"Yeah.","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip_movement\u0027][\u0027enable\u0027]: Boolean attribute to decide"},{"line_number":28,"context_line":"  whether IP movement should be enabled or not."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027timeout\u0027]: Integer attribute to decide"},{"line_number":31,"context_line":"  the timeout of IP movement."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Three recipes will be added, including:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_ba02133d","line":30,"updated":"2015-05-06 13:21:20.000000000","message":"Maybe explain why this timeout is needed.  What would be the default?","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip_movement\u0027][\u0027enable\u0027]: Boolean attribute to decide"},{"line_number":28,"context_line":"  whether IP movement should be enabled or not."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027timeout\u0027]: Integer attribute to decide"},{"line_number":31,"context_line":"  the timeout of IP movement."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Three recipes will be added, including:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_bd6311b1","line":30,"in_reply_to":"1aca2d91_ba02133d","updated":"2015-05-07 03:07:22.000000000","message":"OK","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Work Items"},{"line_number":99,"context_line":"----------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Add new attribute to openstack-network."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Add ip-movement recipe to handle common IP movement configurations."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_fa0beb7b","line":101,"updated":"2015-05-06 13:21:20.000000000","message":"attributes?","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Work Items"},{"line_number":99,"context_line":"----------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Add new attribute to openstack-network."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Add ip-movement recipe to handle common IP movement configurations."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_bda671bf","line":101,"in_reply_to":"1aca2d91_fa0beb7b","updated":"2015-05-07 03:07:22.000000000","message":"Done","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* IP movement use \u0027service network restart\u0027 to let network configurations take"},{"line_number":116,"context_line":"  effect. Therefore user should make sure this command can be executed successfully"},{"line_number":117,"context_line":"  in host."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_9a74f7cf","line":115,"updated":"2015-05-06 13:21:20.000000000","message":"Are they base os packages that should be installed to make sure this exists?  It\u0027s always better to make sure the package is installed before using the command.","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* IP movement use \u0027service network restart\u0027 to let network configurations take"},{"line_number":116,"context_line":"  effect. Therefore user should make sure this command can be executed successfully"},{"line_number":117,"context_line":"  in host."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_fd03c90d","line":115,"in_reply_to":"1aca2d91_9a74f7cf","updated":"2015-05-07 03:07:22.000000000","message":"[huwei@workstation sysconfig]$ rpm -qf /etc/init.d/network \ninitscripts-9.03.40-2.el6_5.3.x86_64\n\nYes, initscripts should be installed.","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  effect. Therefore user should make sure this command can be executed successfully"},{"line_number":117,"context_line":"  in host."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* At the end of IP movement, IP movement will ping gateway to check whether its"},{"line_number":120,"context_line":"  movement is succeed or not. So the kernel route table must include a default"},{"line_number":121,"context_line":"  gateway."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_5a553f1b","line":119,"updated":"2015-05-06 13:21:20.000000000","message":"What will ensure a default gateway is configured properly?  This should be something that the recipe can check and auto-fix?","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  effect. Therefore user should make sure this command can be executed successfully"},{"line_number":117,"context_line":"  in host."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* At the end of IP movement, IP movement will ping gateway to check whether its"},{"line_number":120,"context_line":"  movement is succeed or not. So the kernel route table must include a default"},{"line_number":121,"context_line":"  gateway."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_1d77a53b","line":119,"in_reply_to":"1aca2d91_5a553f1b","updated":"2015-05-07 03:07:22.000000000","message":"Recipe can check whether it has a default gw, and check the connection to it. But can not auto fix. Because recipe can not set an arbitrary default gateway for it.","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"3f1234a939c54d55d36684b3fa962c6d52ad2ca8","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Add unit tests for the new recipes."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* For function tests and CI integration tests, at least an all-in-one openstack"},{"line_number":130,"context_line":"  configured with neutron openvswitch plugin and enabled l3 service is needed."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_fa11ab5e","line":129,"updated":"2015-05-06 13:21:20.000000000","message":"So, are you suggesting that the existing aio_neutron test is going to be modified to handle this?  Or are you going to add a new test?   \n\nAlso, I would highly encourage you to help make this work for the multi-nuetron test as well.","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"7078939b9c2846d6ebde342e207bf77d97289191","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Add unit tests for the new recipes."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* For function tests and CI integration tests, at least an all-in-one openstack"},{"line_number":130,"context_line":"  configured with neutron openvswitch plugin and enabled l3 service is needed."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_583bebd1","line":129,"in_reply_to":"1aca2d91_fa11ab5e","updated":"2015-05-07 03:07:22.000000000","message":"I\u0027m not sure the existing CI test env already enable l3 service. If it does, no need to change, just check after finish the deploy the ip address in interface are moved to the corresponding bridge. Also it support multi-neutron test and I glad if I can help to make this work for multi-neutron test.","commit_id":"b53fd0c188d16857ac630401ff41547229e153d8"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"85896eaaafaa05b4c626877f04039d2abd385fb9","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three recipes will be added, including:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* ip-movement: This recipe includes some common IP movement configurations."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* fedora: This recipe includes the fedora platform IP movement configurations."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aca2d91_daf20ed2","line":38,"updated":"2015-05-08 14:57:25.000000000","message":"I\u0027m curious with all this work being done in recipes.  Is there any of this logic that could be netted out into a LWRP for a network resource, such that it could be used in a more generic and flexible way to cover more types of environments?\n\nLike maybe a bridge resource that has actions for \"create, assign/move ip, delete, ...\"\n\nThis would hide all the ugly ovs commands done under the LWRP resource and not expose that uglyness in the receipes for this.\n\nWe are in GREAT need for more networking resources like this.","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"727f7aacefc0791ea2355b10ebe0a9f3a20dc46d","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three recipes will be added, including:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* ip-movement: This recipe includes some common IP movement configurations."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* fedora: This recipe includes the fedora platform IP movement configurations."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9af37de9_42a7b74f","line":38,"in_reply_to":"1aca2d91_daf20ed2","updated":"2015-05-11 06:56:03.000000000","message":"I did not use those chef features before. But it does a good chef cookbook design idea.\nTherefore, we can put the ip address movement ifaces and bridges check in resource.","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"85896eaaafaa05b4c626877f04039d2abd385fb9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* ip-movement: This recipe includes some common IP movement configurations."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* fedora: This recipe includes the fedora platform IP movement configurations."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* ubuntu: This recipe includes the ubuntu platform IP movement configurations."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aca2d91_5a103e01","line":40,"updated":"2015-05-08 14:57:25.000000000","message":"more appropriate with\n   ip-movement-fedora and ip-movement-ubuntu for names?","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"727f7aacefc0791ea2355b10ebe0a9f3a20dc46d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* ip-movement: This recipe includes some common IP movement configurations."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* fedora: This recipe includes the fedora platform IP movement configurations."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* ubuntu: This recipe includes the ubuntu platform IP movement configurations."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9af37de9_826fdf91","line":40,"in_reply_to":"1aca2d91_5a103e01","updated":"2015-05-11 06:56:03.000000000","message":"Good idea.","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"85896eaaafaa05b4c626877f04039d2abd385fb9","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* IP movement use \u0027service network restart\u0027 , \u0027ifdown\u0027 and \u0027ifup\u0027 to let network"},{"line_number":119,"context_line":"  configurations take effect. Those scripts are contained in initscripts packege."},{"line_number":120,"context_line":"  Therefore this package should be installed. And user should make sure those"},{"line_number":121,"context_line":"  command can be executed successfully in host."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* At the end of IP movement, IP movement will ping gateway to check whether its"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aca2d91_3aeb42b2","line":120,"updated":"2015-05-08 14:57:25.000000000","message":"If these packages are required, we should simply add a list of packages to install and then use the package resource to install them, we want the cookbooks to be self-contained as much as possible.  If there are platform diffs between the packages names, fine just add to existing package platform attributes.","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"727f7aacefc0791ea2355b10ebe0a9f3a20dc46d","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* IP movement use \u0027service network restart\u0027 , \u0027ifdown\u0027 and \u0027ifup\u0027 to let network"},{"line_number":119,"context_line":"  configurations take effect. Those scripts are contained in initscripts packege."},{"line_number":120,"context_line":"  Therefore this package should be installed. And user should make sure those"},{"line_number":121,"context_line":"  command can be executed successfully in host."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* At the end of IP movement, IP movement will ping gateway to check whether its"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9af37de9_2231530c","line":120,"in_reply_to":"1aca2d91_3aeb42b2","updated":"2015-05-11 06:56:03.000000000","message":"OK.","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"85896eaaafaa05b4c626877f04039d2abd385fb9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  Therefore this package should be installed. And user should make sure those"},{"line_number":121,"context_line":"  command can be executed successfully in host."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* At the end of IP movement, IP movement will ping gateway to check whether its"},{"line_number":124,"context_line":"  movement is succeed or not. So the kernel route table must include a default"},{"line_number":125,"context_line":"  gateway before deployment."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aca2d91_1a41a6a9","line":123,"updated":"2015-05-08 14:57:25.000000000","message":"Maybe this should be an optional action controlled by a resource?  And it should be smart enough not to try it if the gateway is not setup?","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"727f7aacefc0791ea2355b10ebe0a9f3a20dc46d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  Therefore this package should be installed. And user should make sure those"},{"line_number":121,"context_line":"  command can be executed successfully in host."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* At the end of IP movement, IP movement will ping gateway to check whether its"},{"line_number":124,"context_line":"  movement is succeed or not. So the kernel route table must include a default"},{"line_number":125,"context_line":"  gateway before deployment."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9af37de9_62063b22","line":123,"in_reply_to":"1aca2d91_1a41a6a9","updated":"2015-05-11 06:56:03.000000000","message":"Yeah, you opinion is great, this could be an optional value. So that user can provider another pingable ip address instead of gateway.\n\nBut I don\u0027t think we should not to try it if the gateway is not setup. Because IP movement need a check in the of its operations to make sure its move is succeed. Otherwise, user network environment can be destroyed by it.","commit_id":"1af0be4b55046760450d696503b6d054ce03657d"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"759fb38bc5f1b2aff4324e336a1da9d9818158bb","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"One resources will be added, including:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* ip-movement: this resource includes some check for ovs bridges and corresponding interfaces,"},{"line_number":51,"context_line":"  and get the final ip movement interfaces and bridges."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9af37de9_a3e77b3f","line":50,"updated":"2015-05-11 13:52:40.000000000","message":"this resource(s) would be something like \"network-bridge\" ad \n\"network-interface\" or some other network entities being touched here.  The whole point is that the recipe should try to NOT have any CLI commands within it, they should all be behind a lwrp if possible to make this clean and flexible (in a perfect world).","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"40048d92cc338ed766585578fb00ff0d32bc50c1","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"One resources will be added, including:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* ip-movement: this resource includes some check for ovs bridges and corresponding interfaces,"},{"line_number":51,"context_line":"  and get the final ip movement interfaces and bridges."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_a1af9293","line":50,"in_reply_to":"9af37de9_a3e77b3f","updated":"2015-05-12 06:34:07.000000000","message":"OK","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"759fb38bc5f1b2aff4324e336a1da9d9818158bb","unresolved":false,"context_lines":[{"line_number":119,"context_line":"* Add ubuntu recipe to configure ubuntu platform IP movement configurations."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Add the unit tests."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Dependencies"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9af37de9_03cf67b1","line":122,"updated":"2015-05-11 13:52:40.000000000","message":"Add any network lwrps that might make this cleaner.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"40048d92cc338ed766585578fb00ff0d32bc50c1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"* Add ubuntu recipe to configure ubuntu platform IP movement configurations."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Add the unit tests."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Dependencies"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_a15c32ee","line":122,"in_reply_to":"9af37de9_03cf67b1","updated":"2015-05-12 06:34:07.000000000","message":"Done","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"759fb38bc5f1b2aff4324e336a1da9d9818158bb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Dependencies"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* IP movement use \u0027service network restart\u0027 , \u0027ifdown\u0027 and \u0027ifup\u0027 to let network"},{"line_number":128,"context_line":"  configurations take effect. Those scripts are contained in initscripts packege."},{"line_number":129,"context_line":"  This cookbook will try to install it."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9af37de9_23582bfa","line":127,"updated":"2015-05-11 13:52:40.000000000","message":"Great example of two CLIs that should be behind an \"network- interfaces\" resource.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"40048d92cc338ed766585578fb00ff0d32bc50c1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Dependencies"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* IP movement use \u0027service network restart\u0027 , \u0027ifdown\u0027 and \u0027ifup\u0027 to let network"},{"line_number":128,"context_line":"  configurations take effect. Those scripts are contained in initscripts packege."},{"line_number":129,"context_line":"  This cookbook will try to install it."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_411a1619","line":127,"in_reply_to":"9af37de9_23582bfa","updated":"2015-05-12 06:34:07.000000000","message":"OK, I think I know what you said now.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"759fb38bc5f1b2aff4324e336a1da9d9818158bb","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* IP movement use \u0027service network restart\u0027 , \u0027ifdown\u0027 and \u0027ifup\u0027 to let network"},{"line_number":128,"context_line":"  configurations take effect. Those scripts are contained in initscripts packege."},{"line_number":129,"context_line":"  This cookbook will try to install it."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9af37de9_e34b432a","line":129,"updated":"2015-05-11 13:52:40.000000000","message":"remove  \"try to\", installing packages should be finite.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"40048d92cc338ed766585578fb00ff0d32bc50c1","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* IP movement use \u0027service network restart\u0027 , \u0027ifdown\u0027 and \u0027ifup\u0027 to let network"},{"line_number":128,"context_line":"  configurations take effect. Those scripts are contained in initscripts packege."},{"line_number":129,"context_line":"  This cookbook will try to install it."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_611d1a0f","line":129,"in_reply_to":"9af37de9_e34b432a","updated":"2015-05-12 06:34:07.000000000","message":"Yep. haha","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"759fb38bc5f1b2aff4324e336a1da9d9818158bb","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  of IP movement. This value depends on how long the host network will ready after"},{"line_number":149,"context_line":"  execute \u0027service network restart\u0027 command."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* IP movement default to use default gateway to check its network connections in the"},{"line_number":152,"context_line":"  end of its operations. Assign an ip address to [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027]"},{"line_number":153,"context_line":"  [\u0027validate-ip\u0027] attribute to use another ip address instead."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9af37de9_430a0fd4","line":151,"updated":"2015-05-11 13:52:40.000000000","message":"yup I like this approach, maybe if the value is set to nil, this check is skipped and it\u0027s assumed that the user will check this in his own way.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"8964595e47a7525acc175cb907f404f96554b535","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  of IP movement. This value depends on how long the host network will ready after"},{"line_number":149,"context_line":"  execute \u0027service network restart\u0027 command."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* IP movement default to use default gateway to check its network connections in the"},{"line_number":152,"context_line":"  end of its operations. Assign an ip address to [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027]"},{"line_number":153,"context_line":"  [\u0027validate-ip\u0027] attribute to use another ip address instead."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_f6489789","line":151,"in_reply_to":"9a0c5dc1_816dae34","updated":"2015-05-12 14:58:07.000000000","message":"Wow, great reply, please add this to the doc, it will help others understand why this check is important.  Also, might help to better explain somewhere in here about your basic design for \"rollback\" logic and why that in important with 1 nic, and what happens with 2 nics.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"40048d92cc338ed766585578fb00ff0d32bc50c1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  of IP movement. This value depends on how long the host network will ready after"},{"line_number":149,"context_line":"  execute \u0027service network restart\u0027 command."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* IP movement default to use default gateway to check its network connections in the"},{"line_number":152,"context_line":"  end of its operations. Assign an ip address to [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027]"},{"line_number":153,"context_line":"  [\u0027validate-ip\u0027] attribute to use another ip address instead."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_816dae34","line":151,"in_reply_to":"9af37de9_430a0fd4","updated":"2015-05-12 06:34:07.000000000","message":"I think we should never give up to check the network connectivity after ip movemen.Because ip movement rollback logic depend on its check status. If we do not check status, means we give up rollback logic. which is very dangerous if user have only one nic.","commit_id":"5129687d3f9999fea82132eb9e50da597dfc36a9"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"187b015b57a03f56c4531c7f6e439c5eb2c081d1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Add recipes to move IP address from NIC to bridge. Make sure those IP addresses"},{"line_number":23,"context_line":"can also be accessed after finish the bridge creation."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Two attributes will be added, including:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip_movement\u0027][\u0027enable\u0027]: Boolean attribute to decide"},{"line_number":28,"context_line":"  whether IP movement should be enabled or not. Default to true."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_eb6721e7","line":25,"updated":"2015-05-19 09:41:02.000000000","message":"Three attributes.","commit_id":"e0bd8d4b321892af713008e2506128d362bf556c"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"5794c6b7944022a705875f30d209985b2d43e7d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Add recipes to move IP address from NIC to bridge. Make sure those IP addresses"},{"line_number":23,"context_line":"can also be accessed after finish the bridge creation."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Two attributes will be added, including:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip_movement\u0027][\u0027enable\u0027]: Boolean attribute to decide"},{"line_number":28,"context_line":"  whether IP movement should be enabled or not. Default to true."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_24bd5502","line":25,"in_reply_to":"7a016987_eb6721e7","updated":"2015-05-20 01:57:21.000000000","message":"Done","commit_id":"e0bd8d4b321892af713008e2506128d362bf556c"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"d3ff38ed5be95f19092d339fe2b2fc22ffc8933b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* ip-movement: This recipe includes some common IP movement configurations."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ip-movement-fedora: This recipe includes the fedora platform IP movement configurations."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* ip-movement-ubuntu: This recipe includes the ubuntu platform IP movement configurations."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_abfec9ab","line":44,"updated":"2015-05-19 09:47:25.000000000","message":"If this recipe just includes configures, maybe we could put those configures into attributes/default.rb, like https://github.com/stackforge/cookbook-openstack-network/blob/master/attributes/default.rb#L1074 ?","commit_id":"e0bd8d4b321892af713008e2506128d362bf556c"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"5794c6b7944022a705875f30d209985b2d43e7d7","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* ip-movement: This recipe includes some common IP movement configurations."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ip-movement-fedora: This recipe includes the fedora platform IP movement configurations."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* ip-movement-ubuntu: This recipe includes the ubuntu platform IP movement configurations."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_845be9f5","line":44,"in_reply_to":"7a016987_abfec9ab","updated":"2015-05-20 01:57:21.000000000","message":"I don\u0027t think so. This configuration is not only install some pkgs, it the network configurations. OVS configurations in fedora and ubuntu are different.\nYou can reference how to configure ovs bridge in ubuntu and fedora to check the difference between them.","commit_id":"e0bd8d4b321892af713008e2506128d362bf556c"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"187b015b57a03f56c4531c7f6e439c5eb2c081d1","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Add unit tests for the new recipes."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* For function tests and CI integration tests, at least an all-in-one openstack"},{"line_number":141,"context_line":"  configured with neutron openvswitch plugin and enabled l3 service is needed."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_cb8ea578","line":140,"updated":"2015-05-19 09:41:02.000000000","message":"Shall we not test compute node in 1+N case?","commit_id":"e0bd8d4b321892af713008e2506128d362bf556c"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"5794c6b7944022a705875f30d209985b2d43e7d7","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Add unit tests for the new recipes."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* For function tests and CI integration tests, at least an all-in-one openstack"},{"line_number":141,"context_line":"  configured with neutron openvswitch plugin and enabled l3 service is needed."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_a40dc5e9","line":140,"in_reply_to":"7a016987_cb8ea578","updated":"2015-05-20 01:57:21.000000000","message":"I not said we should not test multiple node topology. My word is \"AT LEAST all-in-one\". Not \"ONLY all-in-one\". \n:)","commit_id":"e0bd8d4b321892af713008e2506128d362bf556c"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"4ae0cda343446a9fcce2bdf1e4d74aa4504103ef","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  the timeout of IP movement. IP movement uses \u0027service network restart\u0027 (for fedora"},{"line_number":32,"context_line":"  platform) and \u0027ifdown\u0027, \u0027ifup\u0027 (for ubuntu platform)  commands to let network"},{"line_number":33,"context_line":"  configurations take effect. This attribute decide how long the node network can"},{"line_number":34,"context_line":"  back to work after execute those commands. The default one is 180s."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027validate-ip\u0027]: String of IP address pinged"},{"line_number":37,"context_line":"  by ip movement in the of its operations to check whether the ip movement is succeed."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a016987_42e76c40","line":34,"updated":"2015-05-27 16:11:20.000000000","message":"The 2nd to last sentence, perhaps should say:\n\n  \"This attribute decides how long the node should wait for the network to become operational again after executing the previous commands.\"","commit_id":"9a1b346bc1411a0fdae9e8cabab84d9baf64f2bc"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"f442ce81bfe6686dfd9c03ac868c77fda1ee53bc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  the timeout of IP movement. IP movement uses \u0027service network restart\u0027 (for fedora"},{"line_number":32,"context_line":"  platform) and \u0027ifdown\u0027, \u0027ifup\u0027 (for ubuntu platform)  commands to let network"},{"line_number":33,"context_line":"  configurations take effect. This attribute decide how long the node network can"},{"line_number":34,"context_line":"  back to work after execute those commands. The default one is 180s."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027validate-ip\u0027]: String of IP address pinged"},{"line_number":37,"context_line":"  by ip movement in the of its operations to check whether the ip movement is succeed."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a016987_8589eecc","line":34,"in_reply_to":"7a016987_42e76c40","updated":"2015-05-27 16:44:31.000000000","message":"great comment to also put in the timeout attribute comment description.","commit_id":"9a1b346bc1411a0fdae9e8cabab84d9baf64f2bc"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"296028dfa765637595970b7fff588984251aae4a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  the timeout of IP movement. IP movement uses \u0027service network restart\u0027 (for fedora"},{"line_number":32,"context_line":"  platform) and \u0027ifdown\u0027, \u0027ifup\u0027 (for ubuntu platform)  commands to let network"},{"line_number":33,"context_line":"  configurations take effect. This attribute decide how long the node network can"},{"line_number":34,"context_line":"  back to work after execute those commands. The default one is 180s."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* [\u0027openstack\u0027][\u0027network\u0027][\u0027ip-movement\u0027][\u0027validate-ip\u0027]: String of IP address pinged"},{"line_number":37,"context_line":"  by ip movement in the of its operations to check whether the ip movement is succeed."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a016987_beff4200","line":34,"in_reply_to":"7a016987_42e76c40","updated":"2015-05-28 09:04:20.000000000","message":"will do","commit_id":"9a1b346bc1411a0fdae9e8cabab84d9baf64f2bc"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"28f6dbce021f00e3de51d6c85999a7bf4c33fb7a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"One resources will be added, including:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* create_ovs_bridge: This resource will create the ovs bridge and move the ip address to the"},{"line_number":54,"context_line":"  corresponding bridge depend on the resource attributes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a016987_96dfe639","line":54,"updated":"2015-05-27 17:45:28.000000000","message":"Changes will also need to be made to the existing openvswitch and l3_agent recipes.  These existing recipes do the OVS add-port which will cause a loss of network connectivity if the IP movement has not been done first.\n\n   https://github.com/stackforge/cookbook-openstack-network/blob/master/recipes/openvswitch.rb#L168\n   https://github.com/stackforge/cookbook-openstack-network/blob/master/recipes/l3_agent.rb#L127\n\nWill probably need to break the community openvswitch recipe in half so that installation/configuration of OVS is done first, then IP movement, finally the existing bridge creation logic (if necessary).","commit_id":"9a1b346bc1411a0fdae9e8cabab84d9baf64f2bc"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"296028dfa765637595970b7fff588984251aae4a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"One resources will be added, including:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* create_ovs_bridge: This resource will create the ovs bridge and move the ip address to the"},{"line_number":54,"context_line":"  corresponding bridge depend on the resource attributes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a016987_3e3b52d3","line":54,"in_reply_to":"7a016987_96dfe639","updated":"2015-05-28 09:04:20.000000000","message":"Yes.That\u0027s right.","commit_id":"9a1b346bc1411a0fdae9e8cabab84d9baf64f2bc"}]}