)]}'
{"specs/ocata/all/db-migration.rst":[{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add attribute for database migration"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In https://github.com/openstack/cookbook-openstack-common/blob/master/attributes/database.rb "},{"line_number":12,"context_line":"exists only attributes for database migration for the services dashboard, identity and image."},{"line_number":13,"context_line":"The attribute for e.g .network is missing. The file should include the DB migration attributes for all services."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_b4491f8c","line":11,"updated":"2017-05-10 20:41:39.000000000","message":"trailing whitespace","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In https://github.com/openstack/cookbook-openstack-common/blob/master/attributes/database.rb "},{"line_number":12,"context_line":"exists only attributes for database migration for the services dashboard, identity and image."},{"line_number":13,"context_line":"The attribute for e.g .network is missing. The file should include the DB migration attributes for all services."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additional the migration process in the service cookbooks have to use the attribute."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_edcea32b","line":12,"updated":"2017-05-10 20:41:39.000000000","message":"\"...there exist only attributes for database migration for the identity, image and dashboard services\" has a better flow for readability.","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":12,"context_line":"exists only attributes for database migration for the services dashboard, identity and image."},{"line_number":13,"context_line":"The attribute for e.g .network is missing. The file should include the DB migration attributes for all services."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additional the migration process in the service cookbooks have to use the attribute."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_cdd3e7d4","line":15,"updated":"2017-05-10 20:41:39.000000000","message":"Additionally","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"If your deployment has more than one networkcontroller:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Endpoint Registration:"},{"line_number":23,"context_line":"It is not necessary to register each network controller in endpoints!"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_94606303","line":20,"updated":"2017-05-10 20:41:39.000000000","message":"needs a space between network and controller","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":24,"context_line":"It will be helpful if an attribute exists which defines if the recipe \u0027openstack-network::identity_registration\u0027 will be called."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DB-Migration:"},{"line_number":27,"context_line":"It is not necessary to migrate the DB on each networkcontroller. It raises an error while multiple migrations at the same time."},{"line_number":28,"context_line":"An parallel DB-migration on one Database raises errors! In cookbook-openstack-common/attribures/database.rb are attributes which defines if an DB-migration for the service will be called! This attribute does not exists for the network service! It needs to be created for usage in cookbook-openstack-network."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_745b9753","line":27,"updated":"2017-05-10 20:41:39.000000000","message":"networkcontroller \u003d\u003e network controller\n\n\"...with multiple migrations at the same time\"","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DB-Migration:"},{"line_number":27,"context_line":"It is not necessary to migrate the DB on each networkcontroller. It raises an error while multiple migrations at the same time."},{"line_number":28,"context_line":"An parallel DB-migration on one Database raises errors! In cookbook-openstack-common/attribures/database.rb are attributes which defines if an DB-migration for the service will be called! This attribute does not exists for the network service! It needs to be created for usage in cookbook-openstack-network."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_ad053b48","line":28,"updated":"2017-05-10 20:41:39.000000000","message":"An \u003d\u003e A","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- Add DB migration attributes for all services"},{"line_number":34,"context_line":"- The migration process in the service cookbooks have to use the attribute"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Alternatives"},{"line_number":37,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_4df8f747","line":34,"updated":"2017-05-10 20:41:39.000000000","message":"this could be reworded to read better:\n\ne.g. \"All service cookbooks must use the attribute\"","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Performance Impact"},{"line_number":67,"context_line":"------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The database don\u0027t need megrated multiple times."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other deployer impact"},{"line_number":72,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_742037b1","line":69,"updated":"2017-05-10 20:41:39.000000000","message":"better wording: The MySQL database does not need to be migrated multiple times.","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"f0853c817e921786c87c6ce07444200de6fc3188","unresolved":false,"context_lines":[{"line_number":89,"context_line":"----------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- Add DB migration attributes for all services"},{"line_number":92,"context_line":"- The migration process in the service cookbooks have to use the attribute"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_8db03f8c","line":92,"updated":"2017-05-10 20:41:39.000000000","message":"ditto from above","commit_id":"4bf646e36669d3bd9843b840a5e6399ab859b35c"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d7b32227cddfd7c02f7286c29a92761ea68c374f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In https://github.com/openstack/cookbook-openstack-common/blob/master/attributes/database.rb"},{"line_number":12,"context_line":"there exist only attributes for database migration for the identity, image and dashboard services."},{"line_number":13,"context_line":"The attribute for e.g .network is missing. The file should include the DB migration attributes for all services."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additionally the migration process in the service cookbooks have to use the attribute."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff0f0b1f_5072d47c","line":13,"updated":"2017-05-22 12:05:33.000000000","message":"Maybe we should move this attribute to the cookbooks themselves to make the connection a bit simpler and easier to find. In addition to that, we can also move all db migration related resources into a specific \"_db_migrate.rb\" recipe in each cookbook, that is included if the attribute is set to true.","commit_id":"31ad29985bf999084317c0c15fd1b752ae391dfa"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d7b32227cddfd7c02f7286c29a92761ea68c374f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Endpoint Registration:"},{"line_number":23,"context_line":"It is not necessary to register each network controller in endpoints!"},{"line_number":24,"context_line":"It will be helpful if an attribute exists which defines if the recipe \u0027openstack-network::identity_registration\u0027 will be called."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DB-Migration:"},{"line_number":27,"context_line":"It is not necessary to migrate the DB on each network controller. It raises an error with multiple migrations at the same time."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff0f0b1f_10fd7cb0","line":24,"updated":"2017-05-22 12:05:33.000000000","message":"I would like to align that with the way we choose to solve the \"db migrate\". IMHO we should have both tasks in seperate recipes that are triggered from attributes that reside in the specific service cookbook and not the common one.","commit_id":"31ad29985bf999084317c0c15fd1b752ae391dfa"}]}