)]}'
{"id":"openstack%2Fopenstack-chef~2678","triplet_id":"openstack%2Fopenstack-chef~master~Iaed348a3789c5e96c408238ddd11be7dd1f821e2","project":"openstack/openstack-chef","branch":"master","topic":"glance-redirect-not-pipe","hashtags":[],"change_id":"Iaed348a3789c5e96c408238ddd11be7dd1f821e2","subject":"Update load_images recipe to load image via redirection and not pipe.","status":"MERGED","created":"2011-12-29 18:37:52.000000000","updated":"2012-01-13 17:00:48.000000000","submitted":"2012-01-13 17:00:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"18fbe47dbd3408b2a9826f06624e2ec681d20efc","_number":2678,"virtual_id_number":2678,"owner":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":1,"date":"2012-01-13 17:00:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"all":[{"value":2,"date":"2012-01-13 17:00:39.000000000","_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"date":"2012-01-13 17:00:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2011-12-29 18:43:33.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":1,"date":"2011-12-30 21:13:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"all":[{"value":1,"date":"2012-01-13 17:00:39.000000000","_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"date":"2011-12-30 21:13:41.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-29 18:43:33.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2011-12-30 21:13:41.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2012-01-13 17:00:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8778e02edcb861e03f23283cf1413a33f68bf6af","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-12-29 18:43:33.000000000","message":"Patch Set 1:\n\nWhy do you hate on pipe?  It saves disk I/O!  Just curious what the problem is with the old way.","accounts_in_message":[],"_revision_number":1},{"id":"045bb06034e58786ed061fa51a165f94d47fd030","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2011-12-29 18:48:14.000000000","message":"Patch Set 1:\n\nYeah, I\u0027m not fully sure I understand why I did it either... as per Jay\u0027s suggestion here (https://review.openstack.org/#change,2569)\n\n\"\"\"\nFYI, this really is not the way that images should be uploaded to Glance. The image file should be redirected to glance add, not piped in. The difference between piping and redirection is that in the latter case, an fseek(SEEK_END) will work, while it will not on the former, leading to problems with unknown content lengths.\n\"\"\"\n\nWe haven\u0027t seen issues with unknown content lengths (that I know of) so any ideas? Maybe we should leave it like it is?","accounts_in_message":[],"_revision_number":1},{"id":"68591b012bb3cc589f1104ceb5df449831f6f5ae","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-12-29 19:00:17.000000000","message":"Patch Set 1:\n\nAh, interesting.  Well, what he says is true.  However, figuring out content length by seeking to the end seems not quite right to me.  I\u0027d figure you\u0027d read in the full data and set content length based on number of bytes read.","accounts_in_message":[],"_revision_number":1},{"id":"4914c22d2b68f87456a1c9c9d3756e255ead424f","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-12-30 21:13:41.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm, thx Brian.\n\nChris, for some background on why we need to calculate the size of the image file *before* we start communicating with Glance, see here:\n\nhttps://bugs.launchpad.net/glance/+bug/794718\n\nCheerio :)\n-jay","accounts_in_message":[],"_revision_number":1},{"id":"2e679478cee6c00e08bc3337fc5ec7695bccfce4","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2012-01-13 17:00:39.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a5dd8d445603edfc754a36c452517616ed94d599","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-13 17:00:48.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/openstack-chef/51/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"be0df5a5ef6ad55e034b950d0a36b939fe143205","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-13 17:00:48.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ce8ebfeba98b5371f32b46974387b6e27331b100","revisions":{"ce8ebfeba98b5371f32b46974387b6e27331b100":{"kind":"REWORK","_number":1,"created":"2011-12-29 18:37:52.000000000","uploader":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"ref":"refs/changes/78/2678/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-chef","ref":"refs/changes/78/2678/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-chef refs/changes/78/2678/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-chef refs/changes/78/2678/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-chef refs/changes/78/2678/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-chef refs/changes/78/2678/1"}}},"commit":{"parents":[{"commit":"e716ba4bde812e69f1b9b5166d19aa1069278e58","subject":"Add config options for firewall_driver.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-chef/commit/e716ba4bde812e69f1b9b5166d19aa1069278e58"}]}],"author":{"name":"Brian Lamar","email":"brian.lamar@rackspace.com","date":"2011-12-29 17:48:30.000000000","tz":-300},"committer":{"name":"Brian Lamar","email":"brian.lamar@rackspace.com","date":"2011-12-29 17:48:30.000000000","tz":-300},"subject":"Update load_images recipe to load image via redirection and not pipe.","message":"Update load_images recipe to load image via redirection and not pipe.\n\nChange-Id: Iaed348a3789c5e96c408238ddd11be7dd1f821e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-chef/commit/ce8ebfeba98b5371f32b46974387b6e27331b100"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-chef/commit/ce8ebfeba98b5371f32b46974387b6e27331b100"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}