)]}'
{"os_doc_tools/commands.py":[{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"398349d573c3171935dfbe09a433043f668eab4d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return line"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def output_heading(os_command, api_name, title, os_file):"},{"line_number":53,"context_line":"    \"\"\"Write DocBook file header."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    :param os_command: client command to document"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_4095e43d","line":52,"updated":"2015-09-10 08:18:48.000000000","message":"any need to change these method names? ditto line 281.","commit_id":"ef4cd560cce550ecadf274becfbbab304798edb0"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"96cd39951b03236125c9e8f9a89fd0b0bb0a0f9e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return line"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def output_heading(os_command, api_name, title, os_file):"},{"line_number":53,"context_line":"    \"\"\"Write DocBook file header."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    :param os_command: client command to document"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_ea0c4c44","line":52,"in_reply_to":"da20952f_4095e43d","updated":"2015-09-14 17:30:57.000000000","message":"I agree. Please separate functional and cleanup changes.","commit_id":"ef4cd560cce550ecadf274becfbbab304798edb0"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"caa8d604503faedb84237ecec043d582a7f40b43","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return line"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def output_heading(os_command, api_name, title, os_file):"},{"line_number":53,"context_line":"    \"\"\"Write DocBook file header."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    :param os_command: client command to document"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_cc1c7668","line":52,"in_reply_to":"da20952f_4095e43d","updated":"2015-09-24 07:42:22.000000000","message":"Previously, the term \"generate\" was used for both discovering the subcommands available for a given openstack client as well as for outputting it. My fix required me to separate the discovery aspect from the output aspect. I thought I would rename other methods in the file also to be consistent.\n\nBut in the new patch I kept the renaming to minimum while still achieving the separation that I needed.","commit_id":"ef4cd560cce550ecadf274becfbbab304798edb0"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"398349d573c3171935dfbe09a433043f668eab4d","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            args.append(\u0027bash-completion\u0027)"},{"line_number":529,"context_line":"            subcommands \u003d subprocess.check_output("},{"line_number":530,"context_line":"                args,"},{"line_number":531,"context_line":"                universal_newlines\u003dTrue).strip().split()"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    subcommands \u003d sorted([o for o in subcommands if not (o.startswith(\u0027-\u0027) or"},{"line_number":534,"context_line":"                                                         o in blacklist)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e0bc38dd","line":531,"updated":"2015-09-10 08:18:48.000000000","message":"nice clean up ... any chance it might miss some intended case?","commit_id":"ef4cd560cce550ecadf274becfbbab304798edb0"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"caa8d604503faedb84237ecec043d582a7f40b43","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            args.append(\u0027bash-completion\u0027)"},{"line_number":529,"context_line":"            subcommands \u003d subprocess.check_output("},{"line_number":530,"context_line":"                args,"},{"line_number":531,"context_line":"                universal_newlines\u003dTrue).strip().split()"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    subcommands \u003d sorted([o for o in subcommands if not (o.startswith(\u0027-\u0027) or"},{"line_number":534,"context_line":"                                                         o in blacklist)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_ec6ffac1","line":531,"in_reply_to":"da20952f_e0bc38dd","updated":"2015-09-24 07:42:22.000000000","message":"This was not my cleanup. The base on which I worked for patch 1 was out-of-date. In patch 2, I made sure that I started from the latest version of this file.","commit_id":"ef4cd560cce550ecadf274becfbbab304798edb0"}]}