)]}'
{"id":"openstack%2Fopenstack-doc-tools~229271","triplet_id":"openstack%2Fopenstack-doc-tools~master~I4f46d275a15685dc76e42b24b21b4930a94bc184","project":"openstack/openstack-doc-tools","branch":"master","topic":"fix-patch-221559","hashtags":[],"change_id":"I4f46d275a15685dc76e42b24b21b4930a94bc184","subject":"Fix oversight in patch 221559","status":"MERGED","created":"2015-09-30 07:32:20.000000000","updated":"2015-10-01 11:24:09.000000000","submitted":"2015-10-01 11:24:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2658bc90c74e4b9b081df4214dc14c3dafd0f6e9","_number":229271,"virtual_id_number":229271,"owner":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2015-10-01 11:24:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},{"value":0,"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":2,"date":"2015-09-30 09:37:17.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":1,"date":"2015-10-01 11:21:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},{"value":0,"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":1,"date":"2015-10-01 11:21:54.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},{"value":0,"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},{"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-30 07:33:23.000000000","updated_by":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"reviewer":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"state":"REVIEWER"},{"updated":"2015-10-01 11:21:10.000000000","updated_by":{"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},"reviewer":{"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},"state":"REVIEWER"},{"updated":"2015-10-01 11:21:54.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2015-10-01 11:24:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b4e5fa45f5e71f80de3c140221e8c98dc5d2ef4b","author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"date":"2015-09-30 07:32:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f5a7732433b0649fe6038ecd73bd99535e7205f","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-09-30 07:34:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"92d6090c076c4a34500dd2b76be8a4ab64cb17e2","author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"date":"2015-09-30 07:34:56.000000000","message":"Patch Set 1:\n\nAnne and Andreas, I tested the original patch 221559 by:\n1) ./doc-tools-update-cli-reference openstack (openstack-doc-tools/bin)\n2) mvn clean generate-sources (in openstack-doc-tools/bin/openstack-manuals/doc/cli-reference)\nand verifying that the generated openstack-doc-tools/bin/openstack-manuals/doc/cli-reference/target/docbkx/webhelp/cli-reference/cli-reference.pdf:\n1) Includes the additions due to my changes by manually inspecting\n2) Did not mess up other commands by counting number of pages\n\n\"./doc-tools-update-cli-reference openstack\" only updates the section on openstackclient. It does not touch the other commands.\nUnfortunately, there was no way to pass \"all projects\" to doc-tools-update-cli-reference. That is why this oversight was not\ndiscovered until after the patch got merged. I am also surprised that the gating tests did not catch it (the mistake causes\nthe documentation for other commands such as cinder to FAIL to be generated). I detected it while casually re-reviewing the merged patch.\n\nIn any case, this time I passed \"cinder\", \"nova\", etc commands to doc-tools-update-cli-reference and made sure things are fine.","accounts_in_message":[],"_revision_number":1},{"id":"f49d5aff2bdbca1fa6812cfa6fdda8868cb77d80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-30 07:36:20.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/71/229271/1/check/gate-openstack-doc-tools-pep8/5f0493a/ : FAILURE in 2m 03s","accounts_in_message":[],"_revision_number":1},{"id":"45172e5fb213c2cfc5ab77021d8f07ea168a7912","author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"date":"2015-09-30 07:42:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"45aac361ebc9734ddf0697f2fc3208deed357e40","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-30 07:48:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/71/229271/2/check/gate-openstack-doc-tools-pep8/65ec593/ : SUCCESS in 1m 21s","accounts_in_message":[],"_revision_number":2},{"id":"1d84d21fc80641b64b4f76129aa3e6aa52e09ca0","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-09-30 09:37:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d74bc19fe7cc6d53c29c343e0882d019ca783503","author":{"_account_id":17207,"name":"Atsushi SAKAI","email":"sakaia@jp.fujitsu.com","username":"sakaia"},"date":"2015-10-01 11:21:10.000000000","message":"Patch Set 2: Code-Review+1\n\nIt works fine for me.","accounts_in_message":[],"_revision_number":2},{"id":"3d8e534458482d8ace9b5087760215be75b61281","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-10-01 11:21:54.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8bb26c0771745e2135e945d574e42b3672c616ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 11:22:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"69154ef8eb37b73569063494abdd8543f68d959b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 11:24:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/71/229271/2/gate/gate-openstack-doc-tools-pep8/6d52db6/ : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":2},{"id":"7b8a1dcaea94822aef3673cd9bf18b8909299998","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 11:24:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1623a2ab0947215e80f86f69fa13a45e17fe6c4e","revisions":{"0a9fb25d5d85fcc9192a29dca984c8dbc07df931":{"kind":"REWORK","_number":1,"created":"2015-09-30 07:32:20.000000000","uploader":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"ref":"refs/changes/71/229271/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/71/229271/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/1"}}},"commit":{"parents":[{"commit":"f515a6fd7e1a694fc82e340a75adc66e5fd50c72","subject":"Merge \"Generate openstackclient subcommands from setting identity API to v3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/f515a6fd7e1a694fc82e340a75adc66e5fd50c72"}]}],"author":{"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","date":"2015-09-30 07:31:22.000000000","tz":-420},"committer":{"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","date":"2015-09-30 07:32:19.000000000","tz":-420},"subject":"Fix oversight in patch 221559","message":"Fix oversight in patch 221559\n\nIn patch 221559 with change id Ic3fc9ed5f3644497e4dd25a92ded01ee0224cdef,\na couple of calls to generate_subcommands() were not replaced with the\nnew method discover_and_generate_subcommands(). Fixing it in this patch.\n\nChange-Id: I4f46d275a15685dc76e42b24b21b4930a94bc184\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/0a9fb25d5d85fcc9192a29dca984c8dbc07df931"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/0a9fb25d5d85fcc9192a29dca984c8dbc07df931"}]},"branch":"refs/heads/master"},"1623a2ab0947215e80f86f69fa13a45e17fe6c4e":{"kind":"REWORK","_number":2,"created":"2015-09-30 07:42:58.000000000","uploader":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"ref":"refs/changes/71/229271/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/71/229271/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/71/229271/2"}}},"commit":{"parents":[{"commit":"f515a6fd7e1a694fc82e340a75adc66e5fd50c72","subject":"Merge \"Generate openstackclient subcommands from setting identity API to v3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/f515a6fd7e1a694fc82e340a75adc66e5fd50c72"}]}],"author":{"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","date":"2015-09-30 07:31:22.000000000","tz":-420},"committer":{"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","date":"2015-09-30 07:42:26.000000000","tz":-420},"subject":"Fix oversight in patch 221559","message":"Fix oversight in patch 221559\n\nIn patch 221559 with change id Ic3fc9ed5f3644497e4dd25a92ded01ee0224cdef,\na couple of calls to generate_subcommands() were not replaced with the\nnew method discover_and_generate_subcommands(). Fixing it in this patch.\n\nChange-Id: I4f46d275a15685dc76e42b24b21b4930a94bc184\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/1623a2ab0947215e80f86f69fa13a45e17fe6c4e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/1623a2ab0947215e80f86f69fa13a45e17fe6c4e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
