)]}'
{"id":"openstack%2Fopenstack-doc-tools~242956","triplet_id":"openstack%2Fopenstack-doc-tools~master~Ic067c7dcef875dcc6143be047c1a96bcb96deda9","project":"openstack/openstack-doc-tools","branch":"master","topic":"pythonic","hashtags":[],"change_id":"Ic067c7dcef875dcc6143be047c1a96bcb96deda9","subject":"Use a more pythonic syntax","status":"MERGED","created":"2015-11-09 06:59:22.000000000","updated":"2015-11-10 16:15:38.000000000","submitted":"2015-11-10 16:15:36.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c115998e74aa7b64d6066c49fb106bd7302586c7","_number":242956,"virtual_id_number":242956,"owner":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-11-10 16:15:36.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"date":"2015-11-09 07:22:48.000000000","_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"value":0,"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-11-09 07:38:51.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"value":2,"date":"2015-11-10 16:12:01.000000000","_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":1,"date":"2015-11-09 07:33:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"value":1,"date":"2015-11-10 16:12:01.000000000","_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-09 07:33:25.000000000","updated_by":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"reviewer":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"state":"REVIEWER"},{"updated":"2015-11-09 07:38:51.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2015-11-10 16:12:01.000000000","updated_by":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"reviewer":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"state":"REVIEWER"},{"updated":"2015-11-10 16:15:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"27ae989753288724d26215b8609673921ee0198c","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2015-11-09 06:59:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0ee477f714e1dc44908f6d6aef9cd96b6c410b9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-09 07:03:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/56/242956/1/check/gate-openstack-doc-tools-pep8/7f5699e/ : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":1},{"id":"38f643a0a99083da9a88d336a3ba0d04d623c1c6","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-11-09 07:07:48.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m not sure about the DEVNULL redirect, I think this should stay in - see change I14c9479ef7ded7b7c62b0d976706e3d7e26a6cd6.\n\nLet\u0027s split this one out and discuss separately.","accounts_in_message":[],"_revision_number":1},{"id":"cc28475dd199d93c3e2818ae92b700b672ce74e1","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2015-11-09 07:11:05.000000000","message":"Patch Set 1:\n\nOh I see why it\u0027s used now. I think that we could use subprocess.PIPE for stderr redirection instead of defining DEVNULL. I\u0027ll test.","accounts_in_message":[],"_revision_number":1},{"id":"0f5b995dea4ecad9796ec85427c1325afdd172a5","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2015-11-09 07:21:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d98d616732f90c8b74d36d54d05ec2569dee5025","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2015-11-09 07:22:48.000000000","message":"Patch Set 2:\n\nOnly the len() calls are updated in this patchset, DEVNULL usage has been kept unchanged.","accounts_in_message":[],"_revision_number":2},{"id":"fc9c6d608ce4c27b6622195623d7d0261b478d68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-09 07:26:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/56/242956/2/check/gate-openstack-doc-tools-pep8/e42c83c/ : SUCCESS in 2m 07s","accounts_in_message":[],"_revision_number":2},{"id":"522b2ba5af671f981e3ee0ed0f8b89e65b019b70","author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"date":"2015-11-09 07:33:25.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks Good","accounts_in_message":[],"_revision_number":2},{"id":"3244aba47c780a16d2aace1262c83a03c1f3f16f","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-11-09 07:38:51.000000000","message":"Patch Set 2: Code-Review+2\n\nthanks","accounts_in_message":[],"_revision_number":2},{"id":"352d27161f8a235a85c1fc9752d856dac2a4cc18","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-11-10 16:12:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9621614d9bcf11d2e9aa04f8d60f00cdc22db183","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 16:12:46.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"980455e0a9630d0541495236ee2cab02ba5044a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 16:15:36.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/56/242956/2/gate/gate-openstack-doc-tools-pep8/d6f5f4b/ : SUCCESS in 2m 32s","accounts_in_message":[],"_revision_number":2},{"id":"5b7638002d12f47b18499f76f5f8e7333f4353c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 16:15:38.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5dea03b26f8897919cd01cc0be4ba09a002b22b4","revisions":{"0f670e3217135b124846b702803deb43fd7424d6":{"kind":"REWORK","_number":1,"created":"2015-11-09 06:59:22.000000000","uploader":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"ref":"refs/changes/56/242956/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/56/242956/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/1"}}},"commit":{"parents":[{"commit":"9925ca9cf8018927b8ab3adbc40835d13590c80b","subject":"Merge \"Add reno for release-notes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/9925ca9cf8018927b8ab3adbc40835d13590c80b"}]}],"author":{"name":"Gauvain Pocentek","email":"gauvain.pocentek@objectif-libre.com","date":"2015-11-09 06:57:52.000000000","tz":60},"committer":{"name":"Gauvain Pocentek","email":"gauvain.pocentek@objectif-libre.com","date":"2015-11-09 06:58:39.000000000","tz":60},"subject":"Use a more pythonic syntax","message":"Use a more pythonic syntax\n\n* Don\u0027t use len(var) when not needed\n* Don\u0027t redirect stderr to /dev/null for check_output\n\nChange-Id: Ic067c7dcef875dcc6143be047c1a96bcb96deda9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/0f670e3217135b124846b702803deb43fd7424d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/0f670e3217135b124846b702803deb43fd7424d6"}]},"branch":"refs/heads/master"},"5dea03b26f8897919cd01cc0be4ba09a002b22b4":{"kind":"REWORK","_number":2,"created":"2015-11-09 07:21:50.000000000","uploader":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"ref":"refs/changes/56/242956/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/56/242956/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/56/242956/2"}}},"commit":{"parents":[{"commit":"9925ca9cf8018927b8ab3adbc40835d13590c80b","subject":"Merge \"Add reno for release-notes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/9925ca9cf8018927b8ab3adbc40835d13590c80b"}]}],"author":{"name":"Gauvain Pocentek","email":"gauvain.pocentek@objectif-libre.com","date":"2015-11-09 06:57:52.000000000","tz":60},"committer":{"name":"Gauvain Pocentek","email":"gauvain.pocentek@objectif-libre.com","date":"2015-11-09 07:21:22.000000000","tz":60},"subject":"Use a more pythonic syntax","message":"Use a more pythonic syntax\n\nDon\u0027t use len(var) when not needed.\n\nChange-Id: Ic067c7dcef875dcc6143be047c1a96bcb96deda9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/5dea03b26f8897919cd01cc0be4ba09a002b22b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/5dea03b26f8897919cd01cc0be4ba09a002b22b4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
