)]}'
{"id":"openstack%2Fopenstack-doc-tools~263879","triplet_id":"openstack%2Fopenstack-doc-tools~master~I49dc213d0389d8d8dc490d4a63c015a6d861d780","project":"openstack/openstack-doc-tools","branch":"master","topic":"add_zaqar_config_hook","hashtags":[],"change_id":"I49dc213d0389d8d8dc490d4a63c015a6d861d780","subject":"Add Zaqar configuration options hook","status":"MERGED","created":"2016-01-05 19:56:16.000000000","updated":"2016-01-08 07:35:34.000000000","submitted":"2016-01-08 07:35:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"716477151502b0f73866e9897976a611868208a1","_number":263879,"virtual_id_number":263879,"owner":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"value":2,"date":"2016-01-08 07:35:34.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"all":[{"value":2,"date":"2016-01-08 07:30:23.000000000","_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-08 05:23:24.000000000","_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"all":[{"value":1,"date":"2016-01-08 07:30:23.000000000","_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"},{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-08 05:23:24.000000000","updated_by":{"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"},"reviewer":{"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"},"state":"REVIEWER"},{"updated":"2016-01-08 07:30:23.000000000","updated_by":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"reviewer":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"state":"REVIEWER"},{"updated":"2016-01-08 07:35:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6c6df919ff24ae23524ca82ccd3c547db67f8a97","author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"date":"2016-01-05 19:56:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3b757a79cb47054ee43ca1d3bf464753d0f5b87","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2016-01-05 19:59:20.000000000","message":"Patch Set 1:\n\nLGTM, just waiting on jenkins before +2","accounts_in_message":[],"_revision_number":1},{"id":"c58161ddb9541956564bac86c4d2e37ffe43acfe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-05 20:07:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/79/263879/1/check/gate-openstack-doc-tools-pep8/b6d4650/ : SUCCESS in 2m 19s","accounts_in_message":[],"_revision_number":1},{"id":"1c837c9760330c264e3eee27489a3a8d271392ee","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2016-01-05 20:11:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"43f04b145755929574e0be3f4e96202f5e920441","author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"date":"2016-01-07 19:54:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a6ac27fd697afd067b0b84ed6edd9f6d3783350f","author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"date":"2016-01-07 20:00:52.000000000","message":"Patch Set 2:\n\nThe previous patch set was bad because of hard-coded names of modules where Zaqar configuration options were stored.","accounts_in_message":[],"_revision_number":2},{"id":"74f5ebfced4400306c0e1acfd14f9aa2aefa3818","author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"date":"2016-01-07 20:04:41.000000000","message":"Patch Set 2:\n\nSorry. In my previous comment replace:\ns/were stored/are stored","accounts_in_message":[],"_revision_number":2},{"id":"0c496eb81270ed098c2ca624dfafe1c13c65eb91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 20:05:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/79/263879/2/check/gate-openstack-doc-tools-pep8/fea9544/ : SUCCESS in 2m 46s","accounts_in_message":[],"_revision_number":2},{"id":"4d2cc6984bef2afd3629bd5daf5f556d363257dd","author":{"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"},"date":"2016-01-08 05:23:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1505b339450cd2281c0b9d479b90f9b5558c8ba9","author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"date":"2016-01-08 05:34:08.000000000","message":"Patch Set 2:\n\nWhen I ran the command \"./autohelp-wrapper update zaqar\", got the error:\n\n File \"/home/ubuntu/zaqar/openstack-doc-tools/autogenerate_config_docs/autohelp.py\", line 481, in update_flagmappings\n   with open(package_name + \u0027.flagmappings\u0027) as f:\n IOError: [Errno 2] No such file or directory: \u0027zaqar.flagmappings\u0027\n\nI guess it affects the situation that zaqar is an only project that doesn\u0027t have any flagmappings.","accounts_in_message":[],"_revision_number":2},{"id":"3c3f0e0da7adb371a3e33a1822c8e89c8a98fd13","author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"date":"2016-01-08 07:05:57.000000000","message":"Patch Set 2:\n\n\u003e When I ran the command \"./autohelp-wrapper update zaqar\", got the\n \u003e error:\n \u003e \n \u003e File \"/home/ubuntu/zaqar/openstack-doc-tools/autogenerate_config_docs/autohelp.py\",\n \u003e line 481, in update_flagmappings\n \u003e with open(package_name + \u0027.flagmappings\u0027) as f:\n \u003e IOError: [Errno 2] No such file or directory: \u0027zaqar.flagmappings\u0027\n \u003e \n \u003e I guess it affects the situation that zaqar is an only project that\n \u003e doesn\u0027t have any flagmappings.\n\nYes, Zaqar doesn\u0027t have flagmappings now. Execute command \"./autohelp-wrapper create zaqar\". This command will create initial flagmappings file and after it\u0027s execution \"./autohelp-wrapper update zaqar\" command should work. ;)","accounts_in_message":[],"_revision_number":2},{"id":"c2c87845415fc1b040bf05e3ce3810a9e0113a50","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2016-01-08 07:30:23.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLooks good. Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"3d629f59f2d4b9892dd3f3345edc65a39953ee7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 07:30:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b9570e480a8e86e64a5d0634fdf86b6b9b4e10e6","date":"2016-01-08 07:35:34.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"3d70a0ed03ed0a608e501ad81f7c192207258245","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 07:35:34.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-doc-tools-pep8 http://logs.openstack.org/79/263879/2/gate/gate-openstack-doc-tools-pep8/3fa4672/ : SUCCESS in 2m 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d0b4e74fae0b5184cbba27f26f67d6d36eb44364","revisions":{"85f557355d8e9152d666ed051aa722ae2771fabd":{"kind":"REWORK","_number":1,"created":"2016-01-05 19:56:16.000000000","uploader":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"ref":"refs/changes/79/263879/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/79/263879/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/1"}}},"commit":{"parents":[{"commit":"69c7c929c7ab0307da013f82db4601970f4e7b2e","subject":"autohelp-wrapper: remove leftover \"fi\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/69c7c929c7ab0307da013f82db4601970f4e7b2e"}]}],"author":{"name":"Eva Balycheva","email":"ubershy@gmail.com","date":"2016-01-05 16:55:53.000000000","tz":180},"committer":{"name":"Eva Balycheva","email":"ubershy@gmail.com","date":"2016-01-05 17:12:36.000000000","tz":180},"subject":"Add Zaqar configuration options hook","message":"Add Zaqar configuration options hook\n\nCurrently configuration tables from Zaqar cannot be automatically\ngenerated.\n\nZaqar registers most of it\u0027s options in lazy way, so these options do\nnot appear in flagmappings file.\nAlso the options from the embedded zaqar-bench tool end up in\nflagmappings file which is wrong.\n\nThis patch adds hook for Zaqar which manually registers lazy options and\nalso unregisters options from embedded zaqar-bench tool. This will make\nautomated generation of configuration tables possible.\n\nChange-Id: I49dc213d0389d8d8dc490d4a63c015a6d861d780\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/85f557355d8e9152d666ed051aa722ae2771fabd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/85f557355d8e9152d666ed051aa722ae2771fabd"}]},"branch":"refs/heads/master"},"d0b4e74fae0b5184cbba27f26f67d6d36eb44364":{"kind":"REWORK","_number":2,"created":"2016-01-07 19:54:33.000000000","uploader":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"ref":"refs/changes/79/263879/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/79/263879/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/79/263879/2"}}},"commit":{"parents":[{"commit":"69c7c929c7ab0307da013f82db4601970f4e7b2e","subject":"autohelp-wrapper: remove leftover \"fi\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/69c7c929c7ab0307da013f82db4601970f4e7b2e"}]}],"author":{"name":"Eva Balycheva","email":"ubershy@gmail.com","date":"2016-01-05 16:55:53.000000000","tz":180},"committer":{"name":"Eva Balycheva","email":"ubershy@gmail.com","date":"2016-01-07 19:47:37.000000000","tz":180},"subject":"Add Zaqar configuration options hook","message":"Add Zaqar configuration options hook\n\nCurrently configuration tables from Zaqar cannot be automatically\ngenerated.\n\nZaqar registers most of it\u0027s options in lazy way, so these options do\nnot appear in flagmappings file.\nAlso the options from the embedded zaqar-bench tool end up in\nflagmappings file which is wrong.\n\nThis patch adds hook for Zaqar which manually registers lazy options and\nalso unregisters options from embedded zaqar-bench tool. To find all\noptions hook iterates through all registered entry points under\n\u0027oslo.config.opts\u0027 group and choses ones which names start from \u0027zaqar\u0027.\n\nThis will make automated generation of configuration tables possible.\n\nChange-Id: I49dc213d0389d8d8dc490d4a63c015a6d861d780\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/d0b4e74fae0b5184cbba27f26f67d6d36eb44364"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/d0b4e74fae0b5184cbba27f26f67d6d36eb44364"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
