)]}'
{"id":"openstack%2Fopenstack-doc-tools~380000","triplet_id":"openstack%2Fopenstack-doc-tools~master~Ib8dec9d44ce66b1b7ff1486a234fae73d29f23ff","project":"openstack/openstack-doc-tools","branch":"master","topic":"assertTrue","hashtags":[],"change_id":"Ib8dec9d44ce66b1b7ff1486a234fae73d29f23ff","subject":"Change assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2016-09-30 08:19:20.000000000","updated":"2016-09-30 11:33:39.000000000","submitted":"2016-09-30 11:33:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a68fb580e61aff15c22fe9c347504070792a43c1","_number":380000,"virtual_id_number":380000,"owner":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2016-09-30 11:33:39.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"all":[{"value":2,"date":"2016-09-30 11:30:27.000000000","_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},{"value":2,"date":"2016-09-30 08:24:28.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"all":[{"value":1,"date":"2016-09-30 11:30:27.000000000","_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-30 08:24:28.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2016-09-30 11:30:27.000000000","updated_by":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"reviewer":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"state":"REVIEWER"},{"updated":"2016-09-30 11:33:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"617e8ebc1c77036281a09ecb92199c90913bdd3d","author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"date":"2016-09-30 08:19:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d66e07be5a2f418c198044e62282e26b2ad924a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 08:23:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-doc-tools-python35-nv http://logs.openstack.org/00/380000/1/check/gate-openstack-doc-tools-python35-nv/f8b08ec/ : SUCCESS in 2m 13s (non-voting)\n- gate-openstack-doc-tools-pep8-ubuntu-xenial http://logs.openstack.org/00/380000/1/check/gate-openstack-doc-tools-pep8-ubuntu-xenial/20bf070/ : SUCCESS in 1m 57s\n- gate-openstack-doc-tools-python27-ubuntu-xenial http://logs.openstack.org/00/380000/1/check/gate-openstack-doc-tools-python27-ubuntu-xenial/1ddb375/ : SUCCESS in 2m 14s","accounts_in_message":[],"_revision_number":1},{"id":"962f2214735bb5ae96497900acca4d300254d742","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-09-30 08:24:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"aa4d5219a7ecc90c1adc45e7e9743a9ffcb5bb01","author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"date":"2016-09-30 11:30:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"306528d5e5505e38f601138d3bb4671d0ce9ddc1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 11:30:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3d35f2d5a003cfe62cc0bafcd5f81aec875fbd37","date":"2016-09-30 11:33:39.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"756f0a27d0b8aa5d361a75f330894af7a4bb8400","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 11:33:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-doc-tools-pep8-ubuntu-xenial http://logs.openstack.org/00/380000/1/gate/gate-openstack-doc-tools-pep8-ubuntu-xenial/13d1187/ : SUCCESS in 2m 58s\n- gate-openstack-doc-tools-python27-ubuntu-xenial http://logs.openstack.org/00/380000/1/gate/gate-openstack-doc-tools-python27-ubuntu-xenial/5e6e1dd/ : SUCCESS in 2m 14s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"52d9c5272363c0cc9c8930d02dfd71d138c12650","revisions":{"52d9c5272363c0cc9c8930d02dfd71d138c12650":{"kind":"REWORK","_number":1,"created":"2016-09-30 08:19:20.000000000","uploader":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"ref":"refs/changes/00/380000/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-doc-tools","ref":"refs/changes/00/380000/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/00/380000/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/00/380000/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-doc-tools refs/changes/00/380000/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-doc-tools refs/changes/00/380000/1"}}},"commit":{"parents":[{"commit":"ff558eb3b14da4b504b1548acfd2d0407da93f5c","subject":"Move release notes to be handled by reno","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/ff558eb3b14da4b504b1548acfd2d0407da93f5c"}]}],"author":{"name":"gecong1973","email":"ge.cong@zte.com.cn","date":"2016-09-30 08:30:29.000000000","tz":480},"committer":{"name":"gecong1973","email":"ge.cong@zte.com.cn","date":"2016-09-30 08:30:29.000000000","tz":480},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nSome of tests use different method of\nassertTrue(isinstance(A, B)) or assertEqual(type(A), B).\nThe correct way is to use assertIsInstance(A, B) provided\nby testtools\n\nChange-Id: Ib8dec9d44ce66b1b7ff1486a234fae73d29f23ff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/52d9c5272363c0cc9c8930d02dfd71d138c12650"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-doc-tools/commit/52d9c5272363c0cc9c8930d02dfd71d138c12650"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}