)]}'
{"app/js/constants.js":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cdd878b1f95e1f30efb6452432818830b8002ac7","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"var AppSettings \u003d {"},{"line_number":4,"context_line":"  appTitle: \u0027OpenStack Health\u0027,"},{"line_number":5,"context_line":"  apiUrl: \u0027http://localhost:5000\u0027"},{"line_number":6,"context_line":"};"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"module.exports \u003d AppSettings;"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a2fa921_acf3a909","line":5,"updated":"2015-10-07 03:03:34.000000000","message":"One question I had here after doing some more reading on how all of this js gorp is supposed to be working is: shouldn\u0027t we change the gulp production or deploy tasks or something to handle setting this variable for real when we deploy this.\n\nMy understanding of how this will work in production is that in the puppet side we\u0027ll check out the repo run gulp production (or something similar) and dump all of the js and html into a dir for a vhost on apache. Part of that will be having gulp modify this value to point to the right address for where ever the rest api ends up getting deployed.\n\nWe should follow up on irc about this, because I\u0027m still grasping at straws a bit on how the js side of this is supposed to work.\n\nEither way this isn\u0027t a real review comment, and this is fine to land as is, it\u0027s more a discussion for a follow up patch that may or may not be needed.","commit_id":"feeedb829bed70e05cbe4419d98e57b13049364e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1de012c5299e67b55b8854114f216897e2878b46","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"var AppSettings \u003d {"},{"line_number":4,"context_line":"  appTitle: \u0027OpenStack Health\u0027,"},{"line_number":5,"context_line":"  apiUrl: \u0027http://localhost:5000\u0027"},{"line_number":6,"context_line":"};"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"module.exports \u003d AppSettings;"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a2fa921_786e9202","line":5,"in_reply_to":"7a2fa921_acf3a909","updated":"2015-10-07 15:49:49.000000000","message":"5000 conflicts with keystone, I\u0027d prefer another port. Yes they won\u0027t run on the same production machine, but my apache on my dev box is running keystone on 5000","commit_id":"feeedb829bed70e05cbe4419d98e57b13049364e"}],"app/js/services/health-api.js":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"55f593800880b37dc13583cf91b6be3ef4c07311","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"function HealthService($http, AppSettings) {"},{"line_number":8,"context_line":"  var base \u003d AppSettings.apiUrl;"},{"line_number":9,"context_line":"  "},{"line_number":10,"context_line":"  var service \u003d {};"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  service.getRunsFromBuildName \u003d function(buildName) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"7a2fa921_2c683cf5","line":9,"updated":"2015-10-05 19:12:15.000000000","message":"Whitespace...","commit_id":"c60dc397ca526294baaaad1882f50e2c8df1ceb0"}]}