)]}'
{"openstack_health/api.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b69594c115e75a9a2d214092b1fa56cedea5e36b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from sqlalchemy.orm import sessionmaker"},{"line_number":28,"context_line":"from subunit2sql.db import api"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"app \u003d flask.Flask(__name__)"},{"line_number":32,"context_line":"engine \u003d None"},{"line_number":33,"context_line":"Session \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_0e13df5d","side":"PARENT","line":30,"updated":"2015-10-12 18:55:24.000000000","message":"unrelated whitespace :)","commit_id":"28a798323422cb0a84b0f9034a0d8305128b2e8a"},{"author":{"_account_id":17995,"name":"Glauco Oliveira","email":"gvinici@thoughtworks.com","username":"glauco"},"change_message_id":"24372f4db6ea97ab0200e348e49d3920e2d15ac3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from sqlalchemy.orm import sessionmaker"},{"line_number":28,"context_line":"from subunit2sql.db import api"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"app \u003d flask.Flask(__name__)"},{"line_number":32,"context_line":"engine \u003d None"},{"line_number":33,"context_line":"Session \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_ee1c63c3","side":"PARENT","line":30,"in_reply_to":"7a2fa921_0e13df5d","updated":"2015-10-12 19:13:59.000000000","message":"Done","commit_id":"28a798323422cb0a84b0f9034a0d8305128b2e8a"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b69594c115e75a9a2d214092b1fa56cedea5e36b","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"@app.route(\u0027/status\u0027, methods\u003d[\u0027GET\u0027])"},{"line_number":278,"context_line":"def get_status():"},{"line_number":279,"context_line":"    is_db_connection_ok \u003d _check_db_connection()"},{"line_number":280,"context_line":"    if not is_db_connection_ok:"},{"line_number":281,"context_line":"        response \u003d jsonify({\u0027status\u0027: {\u0027database connection\u0027: \u0027failure!\u0027}})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_8efe0f04","line":278,"updated":"2015-10-12 18:55:24.000000000","message":"So we need a unit test for this  new api endpoint","commit_id":"1edd99a2bbe6dc01b13b9bad75f08390fc605905"},{"author":{"_account_id":17995,"name":"Glauco Oliveira","email":"gvinici@thoughtworks.com","username":"glauco"},"change_message_id":"24372f4db6ea97ab0200e348e49d3920e2d15ac3","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"@app.route(\u0027/status\u0027, methods\u003d[\u0027GET\u0027])"},{"line_number":278,"context_line":"def get_status():"},{"line_number":279,"context_line":"    is_db_connection_ok \u003d _check_db_connection()"},{"line_number":280,"context_line":"    if not is_db_connection_ok:"},{"line_number":281,"context_line":"        response \u003d jsonify({\u0027status\u0027: {\u0027database connection\u0027: \u0027failure!\u0027}})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_8e784ffa","line":278,"in_reply_to":"7a2fa921_8efe0f04","updated":"2015-10-12 19:13:59.000000000","message":"Done","commit_id":"1edd99a2bbe6dc01b13b9bad75f08390fc605905"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"32c5012ced55a53991869464b72714872f42b226","unresolved":false,"context_lines":[{"line_number":279,"context_line":"def get_status():"},{"line_number":280,"context_line":"    is_db_connection_ok \u003d _check_db_connection()"},{"line_number":281,"context_line":"    if not is_db_connection_ok:"},{"line_number":282,"context_line":"        response \u003d jsonify({\u0027status\u0027: {\u0027database connection\u0027: \u0027failure!\u0027}})"},{"line_number":283,"context_line":"        response.status_code \u003d 500"},{"line_number":284,"context_line":"        return response"},{"line_number":285,"context_line":"    return jsonify({\u0027status\u0027: {\u0027database connection\u0027: \u0027success!\u0027}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_eef8e34b","line":282,"updated":"2015-10-12 19:19:27.000000000","message":"So this is a dict, I think we can do without the exclamation mark. If it were just a log string or something I\u0027d be fine with it, but I don\u0027t think it adds anything to a json object payload. I\u0027m almost tempted to say we should treat this a boolean, but that might be too hard to figure out, so I\u0027m fine with a string.\n\nAlso, I\u0027m tempted to say drop the space from the key \u0027database connection\u0027 here too, but I guess that\u0027s fine.","commit_id":"e70e339e57342db31f85cefd1e94a3731fee7fb9"},{"author":{"_account_id":17995,"name":"Glauco Oliveira","email":"gvinici@thoughtworks.com","username":"glauco"},"change_message_id":"7fced60984b0f154e593b0575d215779e48c5c55","unresolved":false,"context_lines":[{"line_number":279,"context_line":"def get_status():"},{"line_number":280,"context_line":"    is_db_connection_ok \u003d _check_db_connection()"},{"line_number":281,"context_line":"    if not is_db_connection_ok:"},{"line_number":282,"context_line":"        response \u003d jsonify({\u0027status\u0027: {\u0027database connection\u0027: \u0027failure!\u0027}})"},{"line_number":283,"context_line":"        response.status_code \u003d 500"},{"line_number":284,"context_line":"        return response"},{"line_number":285,"context_line":"    return jsonify({\u0027status\u0027: {\u0027database connection\u0027: \u0027success!\u0027}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_6f136d0e","line":282,"in_reply_to":"7a2fa921_eef8e34b","updated":"2015-10-12 20:20:36.000000000","message":"Changed it to be:\n{\n  \"status\": {\n    \"availability\": {\n      \"database\": true\n    }\n  }\n}","commit_id":"e70e339e57342db31f85cefd1e94a3731fee7fb9"}]}