)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18001,"name":"Caio Carrara","email":"ccarrara@thoughtworks.com","username":"caiocarrara"},"change_message_id":"3cc43e4e1ebb387256d41924b6755083894e4a3c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add x and y axis tick formats"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows us using d3 formats on our charts, simplifying our"},{"line_number":10,"context_line":"controllers. This will help us avoiding adding formatting lagic inside"},{"line_number":11,"context_line":"our controller (i.e. multiplying percentages by 100)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia42fc20cc5e01433b899b2008088f1dcdc6646c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a26ad4f_39b05ef4","line":10,"updated":"2015-10-28 12:06:50.000000000","message":"(nit) just fix the typo \"lagic\" :)","commit_id":"6a973c516f845ac7d18198f1f2ece2a39d3df839"},{"author":{"_account_id":17995,"name":"Glauco Oliveira","email":"gvinici@thoughtworks.com","username":"glauco"},"change_message_id":"69caea4027bda85014f98ad52c0bfd03dc848f3d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add x and y axis tick formats"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows us using d3 formats on our charts, simplifying our"},{"line_number":10,"context_line":"controllers. This will help us avoiding adding formatting lagic inside"},{"line_number":11,"context_line":"our controller (i.e. multiplying percentages by 100)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia42fc20cc5e01433b899b2008088f1dcdc6646c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a26ad4f_46c20987","line":10,"in_reply_to":"1a26ad4f_39b05ef4","updated":"2015-10-28 22:24:38.000000000","message":"Done","commit_id":"6a973c516f845ac7d18198f1f2ece2a39d3df839"}],"app/js/directives/chart-line.js":[{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"bbc0ae7c4e864eca47604a1547eff8f6419da579","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      if (attrs.forcey) {"},{"line_number":33,"context_line":"        chart.forceY(angular.fromJson(attrs.forcey));"},{"line_number":34,"context_line":"      }"},{"line_number":35,"context_line":"      if (attrs.xtickformat) {"},{"line_number":36,"context_line":"        chart.yAxis.tickFormat(d3.format(attrs.xtickformat));"},{"line_number":37,"context_line":"      }"},{"line_number":38,"context_line":"      if (attrs.ytickformat) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"1a26ad4f_0bef3ae9","line":35,"updated":"2015-10-28 21:49:10.000000000","message":"Angular mutates attribute names between the view and controller, which is why the case is different here than it is in the view. We should probably stick to their naming conventions so things get mutated correctly and hopefully avoid future confusion.\n\nI\u0027d recommend using tick-format-x\u003d\"...\" in the views, then referencing it here with attrs.tickFormatX. (x-tick-format will remove the x- prefix unfortunately)","commit_id":"6a973c516f845ac7d18198f1f2ece2a39d3df839"},{"author":{"_account_id":17995,"name":"Glauco Oliveira","email":"gvinici@thoughtworks.com","username":"glauco"},"change_message_id":"69caea4027bda85014f98ad52c0bfd03dc848f3d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      if (attrs.forcey) {"},{"line_number":33,"context_line":"        chart.forceY(angular.fromJson(attrs.forcey));"},{"line_number":34,"context_line":"      }"},{"line_number":35,"context_line":"      if (attrs.xtickformat) {"},{"line_number":36,"context_line":"        chart.yAxis.tickFormat(d3.format(attrs.xtickformat));"},{"line_number":37,"context_line":"      }"},{"line_number":38,"context_line":"      if (attrs.ytickformat) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"1a26ad4f_869ee154","line":35,"in_reply_to":"1a26ad4f_0bef3ae9","updated":"2015-10-28 22:24:38.000000000","message":"Great to know that! If you don\u0027t mind, I will also change the other properties as well to fix this problem.","commit_id":"6a973c516f845ac7d18198f1f2ece2a39d3df839"}],"app/views/home.html":[{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"bbc0ae7c4e864eca47604a1547eff8f6419da579","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                    \u003ch3 class\u003d\"panel-title\"\u003eJob Failure Rate\u003c/h3\u003e"},{"line_number":21,"context_line":"                \u003c/div\u003e"},{"line_number":22,"context_line":"                \u003cdiv class\u003d\"panel-body\"\u003e"},{"line_number":23,"context_line":"                    \u003cchart-line data\u003d\"home.chartDataRate\" width\u003d\"100%\" height\u003d\"250\" \"[0,1]\" xTickFormat\u003d\"%\"\u003e\u003c/chart-line\u003e"},{"line_number":24,"context_line":"                \u003c/div\u003e"},{"line_number":25,"context_line":"            \u003c/div\u003e"},{"line_number":26,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"1a26ad4f_abe9661c","line":23,"updated":"2015-10-28 21:49:10.000000000","message":"Looks like there\u0027s a stray value here (\"[0,1]\").\n\nAs per comments in chart-line.js, we probably want to change xTickFormat to tick-format-x so Angular converts the attribute name correctly.","commit_id":"6a973c516f845ac7d18198f1f2ece2a39d3df839"},{"author":{"_account_id":17995,"name":"Glauco Oliveira","email":"gvinici@thoughtworks.com","username":"glauco"},"change_message_id":"69caea4027bda85014f98ad52c0bfd03dc848f3d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                    \u003ch3 class\u003d\"panel-title\"\u003eJob Failure Rate\u003c/h3\u003e"},{"line_number":21,"context_line":"                \u003c/div\u003e"},{"line_number":22,"context_line":"                \u003cdiv class\u003d\"panel-body\"\u003e"},{"line_number":23,"context_line":"                    \u003cchart-line data\u003d\"home.chartDataRate\" width\u003d\"100%\" height\u003d\"250\" \"[0,1]\" xTickFormat\u003d\"%\"\u003e\u003c/chart-line\u003e"},{"line_number":24,"context_line":"                \u003c/div\u003e"},{"line_number":25,"context_line":"            \u003c/div\u003e"},{"line_number":26,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"1a26ad4f_467a0926","line":23,"in_reply_to":"1a26ad4f_abe9661c","updated":"2015-10-28 22:24:38.000000000","message":"Done","commit_id":"6a973c516f845ac7d18198f1f2ece2a39d3df839"}]}