)]}'
{"app/js/directives/chart-line.js":[{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"45c92f5ab96620b03ac02bc8e92a3ad7195f560e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    var chart \u003d null;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    var svg \u003d d3.select(el[0]).append(\u0027svg\u0027)"},{"line_number":24,"context_line":"    .attr(\u0027width\u0027, attrs.width)"},{"line_number":25,"context_line":"    .attr(\u0027height\u0027, attrs.height);"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    var update \u003d function(data) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa80f949_2516dd55","line":24,"updated":"2015-11-04 21:22:40.000000000","message":"minor nit: looks like some formatting was lost here","commit_id":"2f63d19c526b660c696698e8b0bd7a648369403d"}],"app/js/directives/loading-indicator.js":[{"author":{"_account_id":9189,"name":"Anderson Mesquita","email":"andersonvom@gmail.com","username":"andersonvom"},"change_message_id":"6d538d2b6af687bb8c4260686f5cca16319308ef","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\"\u003c/div\u003e\","},{"line_number":13,"context_line":"    link : function(scope, element) {"},{"line_number":14,"context_line":"      scope.$on(\"loading-started\", function() {"},{"line_number":15,"context_line":"        element.css({\"display\" : \"\"});"},{"line_number":16,"context_line":"      });"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"      scope.$on(\"loading-complete\", function() {"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa80f949_7177cf3a","line":15,"updated":"2015-11-04 18:55:36.000000000","message":"What if you grabbed the sibling of ``element`` and hid/displayed it from there? then we could get rid of the changes in half those files.","commit_id":"2f63d19c526b660c696698e8b0bd7a648369403d"},{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"45c92f5ab96620b03ac02bc8e92a3ad7195f560e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\"\u003c/div\u003e\","},{"line_number":13,"context_line":"    link : function(scope, element) {"},{"line_number":14,"context_line":"      scope.$on(\"loading-started\", function() {"},{"line_number":15,"context_line":"        element.css({\"display\" : \"\"});"},{"line_number":16,"context_line":"      });"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"      scope.$on(\"loading-complete\", function() {"}],"source_content_type":"text/javascript","patch_set":2,"id":"fa80f949_20024b70","line":15,"in_reply_to":"fa80f949_7177cf3a","updated":"2015-11-04 21:22:40.000000000","message":"The issue there is that the elements we want to hide are not necessarily sibling elements. In this case, `element` will always be contained within its own row div and will not have any siblings at all. I suspect selecting the right set of elements would end up being more complex than baking the hide/show functionality in directly.","commit_id":"2f63d19c526b660c696698e8b0bd7a648369403d"}]}